Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

2008-07-22 Thread Huw Davies
Adam Petaccia wrote: > On Tue, 2008-07-22 at 11:11 +0100, Huw Davies wrote: >>> +} RegionElement; >> It would be better to avoid the mixed upper/lower case names, since >> this makes it look like they're win32 api structures. Something like >> typedef struct region_element region_element is nicer

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

2008-07-22 Thread Adam Petaccia
On Tue, 2008-07-22 at 11:11 +0100, Huw Davies wrote: > Hi Adam, > > Some comments inlined below: Thanks for the review. > > On Tue, Jul 22, 2008 at 01:22:56AM -0400, Adam Petaccia wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > > index e7ca874..9c0246b

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

2008-07-22 Thread Huw Davies
Hi Adam, Some comments inlined below: On Tue, Jul 22, 2008 at 01:22:56AM -0400, Adam Petaccia wrote: > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index e7ca874..9c0246b 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -1