Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

Mike McCormack [EMAIL PROTECTED] wrote: >> +SetLastError(ERROR_CALL_NOT_IMPLEMENTED); >> +return ERROR_CALL_NOT_IMPLEMENTED; >> +} > >You SetLastError or return an error code, not both. This is not always correct. Win32 API has several functions returning an int where the only SDK documen

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

Also, please disable your challenge/response spam "filter". Solving your spam problem by spamming everybody else is not cool. You wrote to us with a patch, you solicited our response, so why are you spamming us back? I'd advise others to not respond to spam from bluebottle.com. Mike

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

"MattK" <[EMAIL PROTECTED]> wrote: +if(fdwReason == DLL_THREAD_ATTACH) +{ +DisableThreadLibraryCalls(hinstDLL); +return TRUE; +} This is not an appropriate place to call DisableThreadLibraryCalls, how did you come with it when there are a lot of examples in the Wine

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll

MattK wrote: +BOOL WINAPI DnsNameCompare_A(LPSTR pName1, LPSTR pName2) +{ +TRACE("(%s %s)\n",pName1, pName2); + +LPSTR name1 = pName1; +LPSTR name2 = pName2; + +RemovePeriods(name1); +RemovePeriods(name2); + +int equal; + +equal = lstrcmpiA(name1,name2); + +retur

[Dnsapi.dll] Implement Dnsapi.dll

> Please submit a seperate patch for the windns.h header file. In order for the patch to compile you need the windns.h header. > Hmmm. The Windows Platform SDK doesn't define this function as WINAPI. In WinDNS.h in the PSDK include directory, it is declared as BOOL WINAPI. > Maybe cdecl instead,

Re: [Dnsapi.dll] Implement Dnsapi.dll

MattK wrote: This is a patch to implement Dnsapi.dll. It contains "bare bones". Please submit a seperate patch for the windns.h header file. @@ -1193,6 +1193,7 @@ AC_CHECK_FUNCS(\ strcasecmp \ strerror \ strncasecmp \ +strsep \ Adding strsep here doesn't gu

[Dnsapi.dll] Implement Dnsapi.dll

This is a patch to implement Dnsapi.dll. It contains "bare bones". This was done mainly to help with Bug 4323 . This patch has the DllMain entry point, a function and a stub, header files, implementation into the tree, and a .spec file. Please tell me ho