Re: [ComCtl32 3/4] Implement Some String Functions

2004-02-17 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > Because this implementation is copied from the SHLWAPI implementation. I > did try to submit a test case to test for DBCS compatibility there, but > as was noted by several people, DBCS depends on the current locale so > the test was wrong. Therefore,

Re: [ComCtl32 3/4] Implement Some String Functions

2004-02-17 Thread Robert Shearman
On Tue, 2004-02-17 at 15:08, Dmitry Timoshkov wrote: > "Robert Shearman" <[EMAIL PROTECTED]> wrote: > > > > While you are at it, perhaps it would be a better idea to use > > > CompareStringA/W with appropriate flags for all those StrCmpNIA/W, > > > StrCmpNA/W, etc. > > > > Like this? > > Not rea

Re: [ComCtl32 3/4] Implement Some String Functions

2004-02-17 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > > While you are at it, perhaps it would be a better idea to use > > CompareStringA/W with appropriate flags for all those StrCmpNIA/W, > > StrCmpNA/W, etc. > > Like this? Not really. Why do you need ugly helpers/wrappers? Why to not use CompareStrin

Re: [ComCtl32 3/4] Implement Some String Functions

2004-02-17 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > Changelog: > Implement some string functions While you are at it, perhaps it would be a better idea to use CompareStringA/W with appropriate flags for all those StrCmpNIA/W, StrCmpNA/W, etc. -- Dmitry.