Re: [Bug 18786] patch

2009-06-17 Thread Guy Albertelli
Hi Juan, On Tue, 2009-06-16 at 08:51 -0700, Juan Lang wrote: > The patch is unfortunately incorrect. Hardcoding 1 as the instance > can't work in general. I don't know what the correct fix is offhand. > I also don't see how it's a partial revert, as the patch looks nothing > like the code before

Re: [Bug 18786] patch

2009-06-16 Thread Juan Lang
Hi Guy, > Could you look at bug 18786 and my suggested patch to get MINITAB > working again. It is a partial revert of one of your patches from > 6/25/08 (see comment #7). > > I have verified that the associated tests (dlls/inetmib1/tests/main.c) > exercise that code both pre and post revert. Howe

[Bug 18786] patch

2009-06-15 Thread Guy Albertelli
Hello Juan, Could you look at bug 18786 and my suggested patch to get MINITAB working again. It is a partial revert of one of your patches from 6/25/08 (see comment #7). I have verified that the associated tests (dlls/inetmib1/tests/main.c) exercise that code both pre and post revert. However the