Re: [AppDb] stuff thats broken

2006-06-25 Thread Chris Morgan
Oh. I had no idea that you had re-enabled makeSafe(). You almost certainly do not want to do that, it was disabled because it was broken. makeSafe() likely will never use addSlashes() since that protection was intended to make variables safe for use with sql. Future implementations of makeSafe

Re: [AppDb] stuff thats broken

2006-06-25 Thread Tony Lambregts
Chris Morgan wrote: 5.) If you add a hyperlink in a note it is broken with makesafe() turned on. I'm not sure this has anything to do with makeSafe(). Right now makeSafe() is effectively disabled and I've carefully reviewed the changes to addAppNode.php but I can't see how any of the changes b

Re: [AppDb] stuff thats broken

2006-06-23 Thread Chris Morgan
> > 5.) If you add a hyperlink in a note it is broken with makesafe() > > turned on. > > I'm not sure this has anything to do with makeSafe(). Right now makeSafe() > is effectively disabled and I've carefully reviewed the changes to > addAppNode.php but I can't see how any of the changes broke no

Re: [AppDb] stuff thats broken

2006-06-23 Thread Chris Morgan
On Friday 23 June 2006 9:12 pm, Tony Lambregts wrote: > So I was testing Chris's "query_parameters" patch and I found the > following things broken with current CVS. This note is mostly to archive > the issues I found than anything else. Most of these are minor problems > but they should be fixed.

[AppDb] stuff thats broken

2006-06-23 Thread Tony Lambregts
So I was testing Chris's "query_parameters" patch and I found the following things broken with current CVS. This note is mostly to archive the issues I found than anything else. Most of these are minor problems but they should be fixed. If you want to have a go at fixing any of the issues feel