Re: [AppDB] big AppDB refactoring

2004-12-19 Thread Jonathan Ernst
Le samedi 18 dÃcembre 2004 Ã 19:31 -0500, Chris Morgan a Ãcrit : > I looked the patch over, you move include/user.php to > include/classes/user.php > but you didn't just move the class, you moved the class AND functions that > call in to the user class. Why bother separating things into functio

Re: [AppDB] big AppDB refactoring

2004-12-18 Thread Chris Morgan
I'd feel bad if this issue hadn't come up a few times in the past. Sending in large patches that do multiple things is silly. Even worse is that these are fundamental changes to where things are located but we haven't even decided there is a problem with how things are now or even whether thin

Re: [AppDB] big AppDB refactoring

2004-12-18 Thread Jonathan Ernst
Hello, I certainly agree that I could have separated apidb->appdb changes from the rest (but replacing it is trivial and is functionnaly equivalent), but I can't seriously make one patch for each file moved as it'll require to patch every dependent files for each move. The files in / import files

Re: [AppDB] big AppDB refactoring

2004-12-18 Thread tony_lambregts
Jonathan Ernst wrote: This patch is a big refactoring of the AppDB. Some files have been moved and renamed, others were simply deleted and many where fixed and improved. No functional differences (apart the fixed global vars). *The configuration (config.inc.php) has to be updated on the live server