Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-12 Thread Paul Vriens
> > One question remains though, what do I do with: > > /* also release reference to the nested stream */ > if (This->pStream != NULL) > IAVIStream_Release(This->pStream); > > should this be done regardless of the value of This->ref ? > Hi Michael, forget the question. I just saw that the

Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-11 Thread Paul Vriens
Hi Michael, > I don't really know what you want to cleanup here, looks very clean to me. The cleanup I'm currently working on is changing This->ref[++|--] and friends into Interlocked * functions for thread safety (see Janitorial page on WineHQ). > > You are right, the release method is buggy. t

Re: [AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-11 Thread Michael Günnewig
Paul Vriens <[EMAIL PROTECTED]> writes: > Hi, > > during my code cleanup I came to acmstream.c and found the following: > > static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) > { > IAVIStreamImpl *This = (IAVIStreamImpl *)iface; > > TRACE("(%p) -> %ld\n", iface, This->ref + 1); > > /*

[AVIFIL32] question about ACMStream_fn[AddRef|Release] in acmstream.c

2005-01-11 Thread Paul Vriens
Hi, during my code cleanup I came to acmstream.c and found the following: static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) { IAVIStreamImpl *This = (IAVIStreamImpl *)iface; TRAC