Re: [8/11] kernel32: Implement the timer queue thread.

2008-07-19 Thread Dan Hipschman
Thanks for these especially good comments, Rob! On Sat, Jul 19, 2008 at 07:08:17PM +0100, Rob Shearman wrote: > 2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>: > > > > This patch implements the timer thread, running callbacks, cleaning up > > timers, and all that good stuff. It should be very effic

Re: [8/11] kernel32: Implement the timer queue thread.

2008-07-19 Thread Rob Shearman
2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>: > > This patch implements the timer thread, running callbacks, cleaning up > timers, and all that good stuff. It should be very efficient, using mostly > atomic operations and one critical section for thread safety. It would be more efficient for queue

Re: [8/11] kernel32: Implement the timer queue thread.

2008-07-19 Thread Hans Leidekker
On Saturday 19 July 2008 02:19:11 Dan Hipschman wrote: > It punts on some integer-wrapping issues. If someone runs their wineserver > for 49 days they may run into that issue. I just thought it would distract Have you thought about using GetTickCount64 instead of GetTickCount? -Hans