> General observation: other tests in Wine explicitly check for specific
> hr values, is there a reason you have used the generic SUCCEEDED here
> instead of that approach?
In general we don't care what the return value on success is.
Applications sometimes sometimes do check for particular failur
2008/10/14 Michael Karcher <[EMAIL PROTECTED]>:
> But there might be Win32 applications that do care about specific return
> values. So the implementation in Wine has to match native in returning
> S_OK or S_FALSE (the two most common success values). What is the point
> in not testing your impleme
2008/10/14 Reece Dunn <[EMAIL PROTECTED]>:
> 2008/10/14 Henri Verbeet <[EMAIL PROTECTED]>:
>> +IShellView2_DestroyViewWindow(shell_view2);
>> +ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr);
>
> You are missing a "hr = " here, otherwise the ok check is not checkin
2008/10/14 Henri Verbeet <[EMAIL PROTECTED]>:
> +IShellView2_DestroyViewWindow(shell_view2);
> +ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr);
You are missing a "hr = " here, otherwise the ok check is not checking
the return value from DestroyViewWindow.
> +
