Re: [5/5] gdiplus: Add some tests for GdipBitmapLockBits/GdipBitmapUnlockBits.

2012-07-11 Thread Dmitry Timoshkov
Vincent Povirk wrote: > Shouldn't your second LockBits in this loop always use > PixelFormat24bppRGB and ImageLockModeRead? As it is, if the > LockBits/UnlockBits is writing but not reading, you won't be able to > tell. Probably that would simplify the test a bit, but I don't see a problem with

Re: [5/5] gdiplus: Add some tests for GdipBitmapLockBits/GdipBitmapUnlockBits.

2012-07-11 Thread Vincent Povirk
Shouldn't your second LockBits in this loop always use PixelFormat24bppRGB and ImageLockModeRead? As it is, if the LockBits/UnlockBits is writing but not reading, you won't be able to tell. Also, you might want to try flags == 0 in some pixel format other than 24bppRGB. As I understand it, all mod