Vincent Povirk wrote:
> I guess I prefer to keep interfaces as simple as possible even if it
> means writing more code? I'd consider writing a helper function, but
> none of the other methods would use it.
Is there any hurry with CreateBitmapFromMemory implementation, or you
somehow prefer your
On Wed, Jan 2, 2013 at 11:42 PM, Dmitry Timoshkov wrote:
> It's better to actually check return value of IWICBitmapLock_GetDataPointer
> before memecpy(), or if that's not supposed to fail drop 'hr' assignment.
Whoops, good catch. (I don't think it can fail, but I didn't mean to
make that assumpt
Vincent Povirk wrote:
> +hr = IWICBitmap_Lock(bitmap, NULL, WICBitmapLockWrite, &lock);
> +if (SUCCEEDED(hr))
> +{
> +UINT buffersize;
> +BYTE *buffer;
> +
> +hr = IWICBitmapLock_GetDataPointer(lock, &buffersize, &buffer);
> +
> +
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23710
Your paranoid android
