Re: [2/5] setupapi: Changing pointers on SP_DEVINFO_DATA

2008-04-02 Thread Juan Lang
> Should modify DeviceInfoSet and _SP_DEVINFO_DATA structures? Yes. A linked list would be more appropriate than an array. Embarrassingly, this is the second time I've introduced such an error into Wine. Sorry for the mess. --Juan

Re: [2/5] setupapi: Changing pointers on SP_DEVINFO_DATA

2008-04-02 Thread Alexander Morozov
> > SETUPDI_AddDeviceToSet: changing pointers on SP_DEVINFO_DATA after > > allocating new memory block for their array > > We shouldn't have to do that sort of thing. The data structure should be > fixed to store pointers that don't have to be moved around. Should modify DeviceInfoSet and _SP_DEVI

Re: [2/5] setupapi: Changing pointers on SP_DEVINFO_DATA

2008-04-02 Thread Alexandre Julliard
Alexander Morozov <[EMAIL PROTECTED]> writes: > SETUPDI_AddDeviceToSet: changing pointers on SP_DEVINFO_DATA after > allocating new memory block for their array We shouldn't have to do that sort of thing. The data structure should be fixed to store pointers that don't have to be moved around. -