Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Vincent Povirk
Looks like I won't be around when this finishes, but I sent a test to testbot: https://testbot.winehq.org/JobDetails.pl?Key=23638 This should succeed if your implementation is correct (data is referenced, not copied).

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Vincent Povirk
>> I'm pretty sure CreateBitmapFromMemory copies the data rather than >> referencing existing data. > > How do you know that? In any case adding a test case and support for that > behaviour should be pretty trivial once this patch is accepted. I believe it was this stack overflow question that fir

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Dmitry Timoshkov
Vincent Povirk wrote: > I'm pretty sure CreateBitmapFromMemory copies the data rather than > referencing existing data. How do you know that? In any case adding a test case and support for that behaviour should be pretty trivial once this patch is accepted. -- Dmitry.

Re: [2/2] windowscodecs: Implement ComponentFactory_CreateBitmapFromMemory.

2012-12-27 Thread Vincent Povirk
I'm pretty sure CreateBitmapFromMemory copies the data rather than referencing existing data. On Thu, Dec 27, 2012 at 3:29 AM, Dmitry Timoshkov wrote: > --- > dlls/windowscodecs/bitmap.c| 31 +-- > dlls/windowscodecs/imgfactory.c| 18 +++---