Re: [2/2] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr

2009-05-12 Thread Guy Albertelli
On Sat, 2009-05-09 at 09:52 -0600, Vitaliy Margolen wrote: > Few nitpicks about your patch. > > Guy Albertelli wrote: > > > +/* is there space in the return variable ?? */ > > +if ((o1->SymbolicLinkNameLength/sizeof(WCHAR))+2 > size) > > +{ > > +

Re: [2/2] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr

2009-05-09 Thread Vitaliy Margolen
Few nitpicks about your patch. Guy Albertelli wrote: > +if (!(input = HeapAlloc( GetProcessHeap(), 0, i_size ))) > +{ > +SetLastError( ERROR_NOT_ENOUGH_MEMORY ); > +goto err_ret; > +} > +memset( input, 0, i_size ); To zero out allocated memory you should use HEAP_Z