Fwd: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-12 Thread Per Johansson
On Fri, Oct 12, 2012 at 8:48 AM, Alistair Leslie-Hughes wrote: > I will have a look at some sort of hash table. > I'd use wine existing tree implementation, unless there's some specific reason to use a hash table. Hash tables are good in theory but with in practice trees are just as effective in

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-12 Thread Nikolay Sivov
On 10/12/2012 09:48, Alistair Leslie-Hughes wrote: On 9/10/2012 8:54 PM, Henri Verbeet wrote: On 9 October 2012 11:26, Alistair Leslie-Hughes wrote: Changelog: scrrun: Implement IDictionary_Add and Count Actually, does it ever make sense to use a linked list at all to implement a dicti

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-11 Thread Alistair Leslie-Hughes
On 9/10/2012 8:54 PM, Henri Verbeet wrote: On 9 October 2012 11:26, Alistair Leslie-Hughes wrote: Changelog: scrrun: Implement IDictionary_Add and Count Actually, does it ever make sense to use a linked list at all to implement a dictionary? It seems to me that if you only ever have a h

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-09 Thread Henri Verbeet
On 9 October 2012 11:26, Alistair Leslie-Hughes wrote: > Changelog: > scrrun: Implement IDictionary_Add and Count > Actually, does it ever make sense to use a linked list at all to implement a dictionary? It seems to me that if you only ever have a handful of entries a simple array would be b

Re: [1/3] scrrun: Implement IDictionary_Add and Count

2012-10-08 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > static HRESULT WINAPI dictionary_get_Count(IDictionary *iface, LONG *pCount) > { > dictionary *This = impl_from_IDictionary(iface); > > -FIXME("(%p)->(%p)\n", This, pCount); > +TRACE("(%p)->(%p)\n", This, pCount); > > -*pCount = 0; > +*p