Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-13 Thread Nikolay Sivov
On 6/13/2012 17:42, Ulrik Dickow wrote: Here's a new version of the patch that follows all of your 3 requests: Den 12-06-2012 13:11, Nikolay Sivov skrev: [...] Please use something like CLSID array with every available Document CLSID, instead of only testing 2 of them. There's a lot of examples

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-13 Thread Ulrik Dickow
Here's a new version of the patch that follows all of your 3 requests: Den 12-06-2012 13:11, Nikolay Sivov skrev: > [...] > Please use something like CLSID array with every available Document > CLSID, instead of only testing 2 of them. There's a lot of examples for > that in saxreader.c. > [...] >

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-12 Thread Nikolay Sivov
On 6/12/2012 13:33, Ulrik Dickow wrote: Den 12-06-2012 13:11, Nikolay Sivov skrev: On 6/12/2012 11:52, Ulrik Dickow wrote: +/* create on element and try to alter namespace after that */ +doc = (doc_version == 0 ? + create_document(&IID_IXMLDOMDocument) : + create_do

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-12 Thread Ulrik Dickow
Den 12-06-2012 13:11, Nikolay Sivov skrev: > On 6/12/2012 11:52, Ulrik Dickow wrote: >> +/* create on element and try to alter namespace after that */ >> +doc = (doc_version == 0 ? >> + create_document(&IID_IXMLDOMDocument) : >> + create_document_version(60, &IID_IXMLDOM

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-12 Thread Nikolay Sivov
On 6/12/2012 11:52, Ulrik Dickow wrote: Patch 1 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . +static void test_namespaces_change(int doc_version) +{ +IXMLDOMDocument *doc; +IXMLDOMElement *elem; +IXMLDOMNode *node; + +VARIANT var; +HRESULT hr; +BSTR str;