Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-16 Thread Shachar Shemesh
Kuba Ober wrote: I wouldn't be so sure about that. On win98, in "MS-DOS Prompt" I can type edit \\server\myhome\file.txt And it opens it just fine. Similarly, I can type dir "\\server\shared files" I'm sure the DOS utilities just use long file name APIs and those "simply work". It should be the

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-16 Thread Kuba Ober
> >>What's wrong with additional APIs? The browse folder API isn't COM based > >>anyway. > > > >It would be much better to use the API provided to create a namespace for > > the Unix filesystem. The Control Panel and Network Neighborhood are good > > examples of this. Quite a few third party apps c

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-11 Thread Arjen Nienhuis
> > Hmm. For the winecfg use case though we have to pass back a Unix path, > as by definition it might not be mapped to a Windows path. I suspect > most code that uses the browse folder API converts the PIDL straight > into a path that it can use with CreateFileEx and so on so it might > break stu

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-06 Thread Mike Hearn
On Mon, 2004-12-06 at 17:07 +0100, Alexandre Julliard wrote: > Native file pickers are a completely different issue. What I'm talking > about is the standard shell browser thing, except showing Unix paths > instead of Windows drives, so that it's as transparent as possible to > the app. If the app

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-06 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > I don't see how to make this work. Silently replacing the win32 file > pickers with native file pickers (or custom built-for-Unix Wine > pickers) is possible in a few cases but when the app modifies the > dialog with additional controls, we have to use the

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-06 Thread Alexandre Julliard
Robert van Herk <[EMAIL PROTECTED]> writes: > Do you want me to continue on my patch, or are you saying that you > feel that this is not the way to go, so that I would be wasting time > with further polishing it anyway? I'm afraid so yes. We really don't want to define new APIs for that, it needs

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-06 Thread Mike Hearn
Alexandre Julliard wrote: I'm afraid so yes. We really don't want to define new APIs for that, it needs to be integrated properly with the existing code. Ideally a Winelib app should be able to start using Unix dialogs without code changes at all. I don't see how to make this work. Silently replaci

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-06 Thread Robert van Herk
Mike Hearn wrote: Alexandre Julliard wrote: Well, there's an IShellFolder interface, and it should probably be doing something with that. In any case it should definitely be more integrated into the shell way of doing things, there shouldn't be a need for a whole new set of APIs. This needs more th

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-03 Thread Mike Hearn
Alexandre Julliard wrote: Well, there's an IShellFolder interface, and it should probably be doing something with that. In any case it should definitely be more integrated into the shell way of doing things, there shouldn't be a need for a whole new set of APIs. This needs more thought IMO... I hav

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-03 Thread Shachar Shemesh
Steven Edwards wrote: --- Mike Hearn <[EMAIL PROTECTED]> wrote: What's wrong with additional APIs? The browse folder API isn't COM based anyway. It would be much better to use the API provided to create a namespace for the Unix filesystem. The Control Panel and Network Neighborhood are goo

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-02 Thread Steven Edwards
Hi, --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Well, there's an IShellFolder interface, and it should probably be > doing something with that. In any case it should definitely be more > integrated into the shell way of doing things, there shouldn't be a > need for a whole new set of APIs.

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-02 Thread Alexandre Julliard
Mike Hearn <[EMAIL PROTECTED]> writes: > On Thu, 02 Dec 2004 15:19:27 +0900, Mike McCormack wrote: > > How about creating a new object class or interface to an existing object > > that exposes these interfaces? That way you won't need to export any > > extra functions from shell32. > > What's

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-02 Thread Steven Edwards
--- Mike Hearn <[EMAIL PROTECTED]> wrote: > What's wrong with additional APIs? The browse folder API isn't COM based > anyway. It would be much better to use the API provided to create a namespace for the Unix filesystem. The Control Panel and Network Neighborhood are good examples of this. Quit

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-02 Thread Mike Hearn
On Thu, 02 Dec 2004 15:19:27 +0900, Mike McCormack wrote: > How about creating a new object class or interface to an existing object > that exposes these interfaces? That way you won't need to export any > extra functions from shell32. What's wrong with additional APIs? The browse folder API i

Re: <> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-01 Thread Mike McCormack
Robert van Herk wrote: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. How about creatin

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Shachar Shemesh
Robert van Herk wrote: So yes, I could put it all in a structure on the stack and then pass it to the dlgproc, but it will only arrive there on WM_INITDIALOG. However, I will also need the structure when the other messages come in. So where do I save it then, if I cannot put it in a global var?

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Robert van Herk
However I can definitely see your point here but since the functions are all internal to shell32 at this point and can accept any parameters you may like, I would consider it a cleaner solution to allocate a structure on the stack which contains such helper variables together with the pointer to

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Robert van Herk
Rolf Kalbermatter wrote: Robert van Herk wrote: I guess you are right, but the strange thing is that this was already the case in the original code. The hwnd of the tree view and the pointer to the browseinfo structure are copied into a global variable, so at least my code is not worse here :-)

RE: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Rolf Kalbermatter
Robert van Herk wrote: > I guess you are right, but the strange thing is that this was already > the case in the original code. The hwnd of the tree view and the > pointer to the browseinfo structure are copied into a global variable, > so at least my code is not worse here :-). Well, existing c

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Robert van Herk
Rolf Kalbermatter wrote: Robert van Herk wrote: -LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) +static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode aBrowseMode) +{ +INT_PTR ret; + +browseMode = aBrowseMode; ^^

Re: <> Added shell32.dll functions to browse for unix directory;

2004-12-01 Thread Rolf Kalbermatter
Robert van Herk wrote: >-LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) >+static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode >aBrowseMode) >+{ >+INT_PTR ret; >+ >+browseMode = aBrowseMode; ^^ I may miss something he

<> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-01 Thread Robert van Herk
Hi, I had some problems with my mail server, so I send in this patch again. If the previous one did arrive, please ignore this e-mail. Changes: Added functionality to browse for a UNIX folder. This is done by making two new

<> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive

2004-12-01 Thread Robert van Herk
Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed ju