Re: 'PngDecoder_Block_GetCount'

2012-10-05 Thread Max TenEyck Woodbury
On 10/05/2012 05:53 PM, Vincent Povirk wrote: >> Beyond that, I am not sure what you are talking about. The value to be >> returned (at the address specified by the 2nd parameter) is an unsigned >> integer. There is no place to return 'chunks'; only a place to return a >> count. > > Other method

Re: 'PngDecoder_Block_GetCount'

2012-10-05 Thread Vincent Povirk
> Beyond that, I am not sure what you are talking about. The value to be > returned (at the address specified by the 2nd parameter) is an unsigned > integer. There is no place to return 'chunks'; only a place to return a > count. Other methods on that interface allow you to return an IWICMetadat

Re: 'PngDecoder_Block_GetCount'

2012-10-05 Thread Max TenEyck Woodbury
On 10/05/2012 10:58 AM, Vincent Povirk wrote: > You should take a look at the PNG format spec, particularly the part > about chunks: http://www.libpng.org/pub/png/spec/1.2/PNG-Structure.html > > I believe what's needed here is to return all ancillary chunks. > First, thank you for the pointer to

Re: [patch 1/1] dlls/windowscodecs/pngformat.c: implemented 'PngDecoder_Block_GetCount'

2012-10-05 Thread Vincent Povirk
You should take a look at the PNG format spec, particularly the part about chunks: http://www.libpng.org/pub/png/spec/1.2/PNG-Structure.html I believe what's needed here is to return all ancillary chunks.

Re: 'PngDecoder_Block_GetCount'

2012-10-05 Thread Max TenEyck Woodbury
Hmm. I definitely misunderstood what this function was intended to do. As I understand things now, there are two ways to approach processing graphical information: 1) As a stream of information to be processed in the order it arrives. 2) As an aggregate to be processed all at once. The PNG forma

Re: [patch 1/1] dlls/windowscodecs/pngformat.c: implemented 'PngDecoder_Block_GetCount'

2012-10-05 Thread Max TenEyck Woodbury
ecoder_Block_GetContainerFormat(IWICMetadataBlockReade >> static HRESULT WINAPI >> PngDecoder_Block_GetCount(IWICMetadataBlockReader *iface, >> UINT *pcCount) >> { >> -FIXME("%p,%p: stub\n", iface, pcCount); >> -return E_NOTIMPL; >> +

Re: [patch 1/1] dlls/windowscodecs/pngformat.c: implemented 'PngDecoder_Block_GetCount'

2012-10-05 Thread Nikolay Sivov
--- a/dlls/windowscodecs/pngformat.c +++ b/dlls/windowscodecs/pngformat.c @@ -899,8 +899,10 @@ static HRESULT WINAPI PngDecoder_Block_GetContainerFormat(IWICMetadataBlockReade static HRESULT WINAPI PngDecoder_Block_GetCount(IWICMetadataBlockReader *iface, UINT *pcCount) { -FIXME("