Re: Valgrind warning cleanup...

2006-05-14 Thread leslie . polzer
On Sat, May 13, 2006 at 01:36:54PM -0700, Dan Kegel wrote: > There's another valgrind warning that is much more understandable, and > I'm sending an obvious fix for it to wine-patches. (My first patch > missed one instance, so I'm resending.) I'd appreciate it if you could > check that one, too. -

Re: Quiet valgrind warnings in init_current_teb

2006-05-14 Thread leslie . polzer
On Sat, May 13, 2006 at 11:11:50PM +0100, Mike Hearn wrote: > if ((ent->HighWord.Bits.Granularity = (limit >= 0x10))) > > but unless I'm reading it wrong this is not testing ent before > initialization at all, it's testing limit, assigning to ent, then > testing the result of that assignment .

Re: Valgrind warning cleanup...

2006-05-13 Thread leslie . polzer
On Sat, May 13, 2006 at 01:01:34PM -0700, Dan Kegel wrote: > What do folks think - should we just make the allocation a little > bigger to make valgrind happy? I know this kind of errors from working on GNU Parted with Valgrind, and my policy is to leave the code alone when I can't spot why it sho

Re: Tiny patch for dib.c

2006-05-04 Thread leslie . polzer
On Thu, May 04, 2006 at 12:16:10PM +0900, Mike McCormack wrote: > Maybe you can investigate how we can get a DIB with bmBitsPixel <= 8 > and (biClrUsed > 256 or bcBitCount>8) ? I'm not an expert on this, but I supposed the application called it with an off-by-one value of 257? Do you think the p

Re: Newbie question clipboard

2006-05-02 Thread leslie . polzer
On Tue, May 02, 2006 at 09:12:11AM -0700, Thomas Hehl wrote: > 1. On the line: Call user32.GetClipboardData(0001) ret=00439e26, > what does the ret mean? Isn't the return value posted later in the > log? a) "ret" is the return address of the function. b) the return value is posted at the end o