Re: DDRAW: Fix reference counting

2005-09-19 Thread Jakov af Wallby
On Mon, Sep 19, 2005 at 09:27:05AM +0200, Stefan D?singer wrote: > Hi, > > Why do you increase the refcount by 2? Since you add and release them in > > the same functions, it is not really necessary and just adds complexity > > to the code. > Well, Windows does so for some reason, and after what I'

Re: file locking

2005-07-13 Thread jakov
Brian Vincent wrote: >I've been playing around with file locking and Wine, namely the fact >that Wine doesn't have any. > >Is there any way around this, maybe placing the burden on a >filesystem? If I wanted to share files between two different users >(say with something dumb like file permission

Re: [user/tests]: Re: Fix bug that left mouse buttons swapped after tests

2005-06-30 Thread jakov
> Saulius Krasuckas wrote: >>>ChangeLog: Fix bug that left mouse buttons swapped after tests >>> >>>Ivan. >> >> >> I think your patch causes test to fail on Wine, Ivan. My try goes next. > > Maybe that isn't a bad thing, the results from the latest build of > winetest shows this test fails > on wi

Re: Make running tests on a visible desktop a mandatory requirement

2005-03-10 Thread jakov
>> +if (!running_on_visible_desktop ()) { >> +report (R_ERROR, "Tests must be run on a visible desktop"); >> +exit (2); >> +} >> + >> /* initialize the revision information first */ >> extract_rev_infos(); >> > Apart from the fact whether winrash should be 'fixed'

Re: Test suite, todo_wine and different kernels versions

2005-03-10 Thread jakov
> > While removing todo_wine() for this cases silences the output, anybody > running on an older kernel will hit an error. > > How to proceed in that case. Sould he have something like > todo_linux(kernelversion){}? This is interesting! Wine depends on other stuff too (libraries) and similar t

Re: Make running tests on a visible desktop a mandatory requirement

2005-03-08 Thread Jakov af Wallby
On Wed, Mar 09, 2005 at 12:03:01AM +0800, Dmitry Timoshkov wrote: > Hello, > > it appears that new test for a visible desktop works fine, time to make > running tests on a visible desktop a mandatory requirement. Will this not mean no winrash tests any more, only manual ones? I haven't got arou