Hi Hans,
Sorry for the delay, I wanted to test it a bit more before answering.
On 09/23/13 10:50, Hans Leidekker wrote:
> On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote:
>> I was hoping for a test like the attached one, which shows that there is
>> still more work to do. But
ed all those bugs while preparing the
release, but they seem to be caused by MSHTML, not Gecko itself, so the
release won't change behaviour here.
Cheers,
Jacek
separated patch. And you don't need to include changes to generated
files (configure, configure.ac and include/Makefile.in).
Cheers,
Jacek
; InternetOpenRequest_test();
> test_http_cache();
> InternetOpenUrlA_test();
I was hoping for a test like the attached one, which shows that there is
still more work to do. But it's a step in the right direction, so I'm
fine with your patch.
Thanks,
Jacek
commit
On 09/11/13 17:32, Hans Leidekker wrote:
> On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote:
>> Hi Hans,
>>
>> On 09/11/13 13:50, Hans Leidekker wrote:
>>> static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t
>>> *req)
>>
On 9/11/13 7:09 PM, Hans Leidekker wrote:
On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote:
Network traces tell me that native also performs a read on the first call to
InternetQueryDataAvailable.
Are you sure it's not an asynchronous read from a separated thread that
is order
res;
> +
> +if(!chunked_stream->chunk_size || chunked_stream->chunk_size == ~0u) {
> +res = start_next_chunk(chunked_stream, req);
> +if(res != ERROR_SUCCESS)
> +return 0;
> +}
start_next_chunk may block and we don't want chunked_get_avail_data to
block.
Jacek
On 09/11/13 14:22, Michael Stefaniuc wrote:
> On 09/11/2013 02:11 PM, Henri Verbeet wrote:
>> On 11 September 2013 12:09, Jacek Caban wrote:
>>> +typedef enum D3D11_RESOURCE_MISC_FLAG
>>> +{
>>> +D3D11_RESOURCE_MISC_GENERATE_
On 09/05/13 18:53, Juan Lang wrote:
> [+wine-devel]
>
> Hi Jacek,
> I've added the list so the discussion can take place in public.
>
> On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban <mailto:ja...@codeweavers.com>> wrote:
>
> I have a patch for crypt32. I&#x
tSetOptionW(NULL, INTERNET_OPTION_SETTINGS_CHANGED, NULL, 0);
There must be a better way to do that than removing all existing wininet
cached connections to all hosts. Removing INTERNET_FLAG_KEEP_CONNECTION
from HttpOpenRequest call would be a good start...
Jacek
On 09/04/13 15:36, Hans Leidekker wrote:
> On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote:
>> On 09/04/13 15:01, Hans Leidekker wrote:
>>> ---
>>> dlls/rpcrt4/rpc_transport.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>>
On 09/04/13 14:38, Hans Leidekker wrote:
> On Wed, 2013-09-04 at 13:11 +0200, Jacek Caban wrote:
>> On 09/04/13 09:22, Hans Leidekker wrote:
>>> ---
>>> dlls/wininet/http.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>>
that:
ok(!on_async, "Returned zero size in response to request complete\n");
I think we should try harder to have a test reporting zero size data
(this may be tricky to write one for Wine tests, but if we could just
observe such occasional notifications, that would be enough). And this
would need more testing with native IE.
This all means that intention of the patch may be right, but it needs
more work.
Thanks,
Jacek
On 09/03/13 13:51, Qian Hong wrote:
> On Tue, Sep 3, 2013 at 7:42 PM, Jacek Caban wrote:
>> Not really, good catch. We should make them consistent. Honestly, I'm
>> not sure which one is better. Both have their problems. Some functions
>> are forwarded, others are not, s
On 09/03/13 13:28, Qian Hong wrote:
> On Tue, Sep 3, 2013 at 7:27 PM, Qian Hong wrote:
>> Hi Jacek, we already have a debug channel atl100 for atl100.dll, but
>> we currently use atl for both atl.dll and atl80.dll, do you think it
>> is better to use atl for all, or one debug
http://testbot.winehq.org/JobDetails.pl?Key=26726
>
> Your paranoid android
These seem to be caused by different cache handling in IEs. In general,
non-cached download would be more interesting, so we should probably
enforce that.
Jacek
new Gecko.
Anything that uses MSHTML is worth testing. All help with testing is
appreciated!
Cheers,
Jacek
[1] https://sourceforge.net/projects/wine/files/Wine%20Gecko/2.24-beta1/
[2] http://source.winehq.org/patches/data/97881
[3] http://wiki.winehq.org/Gecko
diff --git a/dlls/appwiz.cpl/addon
er ideas?
I'd appreciate opinions.
Thanks,
Jacek
[1] https://sourceforge.net/p/wine/wine-gecko/ci/master/tree/
[2] https://sourceforge.net/p/forge/site-support/4299/
. Patch contains one complete thing. It
> introduces an new switch. I separate this switch out, as it can be
> reviewed absolutely independently to the actual namespace lexer/parser
> thing (which is the first user of this switch).
> Jacek asked me to break things down in small log
Hi Nikolay,
On 07/30/13 12:42, Nikolay Sivov wrote:
> +dst = &This->attr[index];
> +src = &This->attr[index+1];
> +
> +memmove(dst, src, This->length-index-1);
*sizeof(*dst)
Cheers,
Jacek
et_ITextDocument(ReTxtDoc *document)
+{
+ TRACE("(%p)\n", document);
+ return &document->iTextDocumentIface;
+}
Full declaration of ReTxtDoc in a header (so you don't need such helper) would
be cleaner, IMO.
new file mode 100644
index 000..02579b2
--- /dev/null
+++ b/dlls/riched20/txtdoc.h
How about using an existing header?
Thanks,
Jacek
t is that
ITextDocument should be supported, but there is probably a better place
to put this test.
+
+struct tagReTxtDoc {
+ IUnknown *outerObj;
+ ME_TextEditor *editor;
+ ITextDocument iTextDocumentIface;
+};
Do you really need a separated structure for that? Wouldn't adding
ITextDocument implementation to ITextServicesImpl be enough?
Thanks,
Jacek
s indeed a stupid mistake and after fixing
it, the behaviour is more logical. I will send a patch fixing tests.
Fixing todo_wine may wait until after code freeze. Current Wine
behaviour shouldn't cause problems.
Thanks,
Jacek
On 06/30/13 23:14, Thomas Faber wrote:
> On 2013-06-27 13:33, Jacek Caban wrote:
>> That
>> said, if such interfaces are just obscure special case, I would say we
>> shouldn't care. We may easily avoid them (I just sent a patch avoiding
>> it in mshtml).
> Ah, I
uire some more changes in Wine. At least MSHTML already has an
interface identical to IUnknown (nsISupports), which would cause the
error. This should be solvable with some tricks.
Thanks,
Jacek
Hi Zhan,
On 05/17/13 16:53, Zhan Jianyu wrote:
> This patch is built based on Jaceks's newly-submitted patch:
>
> commit 48a862306288d69d3623d5ecdc0f5a5a40addafe
> ( vbscript: Round half to even in to_int)
>
> Thanks, Jacek. :-)
>
> With his patch, CInt could
On 04/26/13 16:18, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> On 04/26/13 14:46, Alexandre Julliard wrote:
>>> Jacek Caban writes:
>>>
>>>> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version.
>>>> Previous version
On 04/26/13 14:46, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version.
>> Previous versions had a separated library that contained forwards from
>> underscored functions to non-underscored, which I bel
On 04/26/13 12:02, Henri Verbeet wrote:
> On 26 April 2013 10:27, Jacek Caban wrote:
>> - round is not portable. As I mentioned you before, Wine needs to be C89
>> compatible. If we need some features that are not part of C89, we need
>> to be careful about that and it often
t that and it often requires things like configure
checks. In case of round, replacing it with floor(x+0.5) does the trick
pretty well.
Cheers,
Jacek
need to
comfortably test the new package. Just apply the patch you the Wine tree
and everything should work. All tests are appreciated.
Thanks,
Jacek
diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c
index 2a47b84..a3bfd0b 100644
--- a/dlls/appwiz.cpl/addons.c
+++ b/dlls/appwiz.cpl
t; ./configure --disable-tests was used to reduce noise
> >
> > Static analyse of the tests is important as well. Over the years
> I found bad tests that didn't test what they were supposed to
> test. And even cases where the Wine code was bad due to that
eant to cast src
to VARIANT_BOOL*.
Cheers,
Jacek
res touching about every part of the
engine, so it's not something for the first patch. It's better to start
with simpler parts, like you already do.
Cheers,
Jacek
(300) = 300, "CInt(300) = " & CInt(300))
> Call ok(CInt(-300) = -300, "CInt(-300) = " & CInt(-300))
> +
> +Call ok(CBool(5) = "True", "CBool(5) = " & CBool(5))
> +Call ok(CBool(0) = "False", "CBool(0) = " & CBool(0))
> +Call ok(CBool(-5) = "True", "CBool(-5) = " & CBool(-5))
...and that's why getVT(...) test would be nice here.
Thanks,
Jacek
ok(CInt(-36.25) = -36, "CInt(-36.25) = " & CInt(-36.25))
Please add some tests using getVT to verify underlying types.
Thanks,
Jacek
as much as a patch. That's a
good start and I think vbscript improvement can be a good GSoC project.
Cheers,
Jacek
andom unrelated failure. Here is a clean run
of the same patch:
https://testbot.winehq.org/JobDetails.pl?Key=25094
I will resend the patch.
Cheers,
Jacek
Hi Ken,
On 04/10/13 16:16, Ken Thomases wrote:
> Hi Jacek,
>
> On Apr 10, 2013, at 4:24 AM, Jacek Caban wrote:
>
>> On 3/28/13 8:31 PM, Ken Thomases wrote:
>>> Mac OS X 10.8 introduced support for TLS 1.1 and 1.2.
>> Can someone with Mac OS X 10.8 test the att
are
listed as supported protocol.
Thanks,
Jacek
commit 78f9768f8d6759af1df99c4b67b8fd6a93369da4
Author: Jacek Caban
Date: Tue Apr 9 12:35:33 2013 +0200
secur32: Added support for TLS 1.1 and TLS 1.2 on Mac.
diff --git a/dlls/secur32/schannel_macosx.c b/dlls/secur32/schannel_macosx.c
On 03/07/13 12:07, Jacek Caban wrote:
> Hi all,
>
> I've uploaded a new Gecko builds to SourceForge [1]. This one is based on
> Firefox 20 beta and, other than usual update of Gecko, it should fix some
> crashes like bug b*ug 32753* <http://bugs.winehq.org/show_bug.cgi?id=
Hi Juan,
On 03/29/13 18:19, Juan Lang wrote:
> Hi Jacek,
>
> thanks for the detailed reply.
>
> On Fri, Mar 29, 2013 at 3:02 AM, Jacek Caban <mailto:ja...@codeweavers.com>> wrote:
>
> Each protocol has two kinds of enable/disable flags: "enabled" and
Hi Juan,
On 03/28/13 21:55, Juan Lang wrote:
> On Thu, Mar 28, 2013 at 12:31 PM, Ken Thomases <mailto:k...@codeweavers.com>> wrote:
>
> On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote:
>
> > --- a/dlls/secur32/schannel_macosx.c
> > +++
Hi Ken,
On 03/28/13 20:31, Ken Thomases wrote:
> On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote:
>
>> --- a/dlls/secur32/schannel_macosx.c
>> +++ b/dlls/secur32/schannel_macosx.c
>> @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef
>&g
ows doesn't allow a "//" to appear after the scheme
> * of a URI, if it's an opaque URI.
> */
> -if(data->scheme && *(data->path) == '/' && *(data->path+1) == '/') {
> +if (is_mailto && *(data->path) == '/' && *(data->path+1) == '/') {
> +if (!*(data->path+2)) uri->path_start = -1;
> +offset += 2;
I think this should be done in parsing phrase, not during canonicalization.
Jacek
on with the attached patch. As
usually, grab the build from SourceForge, put it in the right place [2] and run
patched Wine. All help with testing is appreciated!
Thanks,
Jacek
[1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/2.20-beta1/
[2] http://wiki.winehq.org/Gecko
diff --git a/dlls
rdupW(szDefaultHeader);
> +request->flags |= INTERNET_REQFLAG_NO_HEADERS;
I don't think we want to maintain valid request->flags for that
particular flag. Checking for request->rawHeaders should be enough. If
we avoided setting rawHeaders here, we'd achieve the same behaviour.
Jacek
http://testbot.winehq.org/JobDetails.pl?Key=24441
>
> Your paranoid android.
That's because TestBot still can't update to current Wine version:
http://testbot.winehq.org/JobDetails.pl?Key=24423
Jacek
On 02/18/13 12:49, Francois Gouget wrote:
> On Sat, 16 Feb 2013, Jacek Caban wrote:
>
>> On 2/16/13 1:28 AM, Francois Gouget wrote:
>>> However I think the test should still not fail. So I'm looking for a
>>> volunteer to either get the test to succeed with urlm
ill send a
patch. Thanks for the analyze.
Cheers,
Jacek
sful run:
http://testbot.winehq.org/JobDetails.pl?Key=24400
Cheers,
Jacek
oniker_BindToStorage failed: 800c0005
> url.c:3036: Test failed: unk == NULL
> (...)
These seem to be (random) network failure. I've got it all succeeding
before sending patches:
https://testbot.winehq.org/JobDetails.pl?Key=24358
Jacek
On 01/30/13 20:09, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> ---
>> dlls/Makedll.rules.in | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
> Why do you need this?
My use case is not really valid as is for Wine. I was experimenting with
runni
On 01/22/13 20:21, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> The following patch makes winhttp use schannel instead of OpenSSL for
>> SSL (HTTPS) connections. It is made to be as minimal change as possible
>> (but complete enough to replace all OpenSSL fun
On 01/22/13 17:22, Hans Leidekker wrote:
> On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote:
>> @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn )
>> pSSL_CIPHER_get_bits( cipher, &bits );
>> return bits;
&
1
> +#define DISPID_MATCHCOLLECTION__NEWENUM -4
> +
> +#define DISPID_MATCH_VALUE 0
Please use DISPID_VALUE and DISPID_NEWENUM instead.
Jacek
tter done while constructing the URL
instead of here.
+test_DoVerb(webbrowser);
+test_Navigate2(webbrowser, file_url);
+
+IWebBrowser2_Release(webbrowser);
This is not enough for proper clean up. You may verify that by checking ref
count here. At least setting client site to NULL is needed.
Cheers,
Jacek
u are at this, it may be simplified to:
return token & 0xfffe == 0xfffe;
Cheers,
Jacek
Hi Nikolay,
On 12/20/12 11:29, Nikolay Sivov wrote:
> On 12/19/2012 17:22, Jacek Caban wrote:
>> On 12/19/12 08:24, Nikolay Sivov wrote:
>>> Add custom handling for DISPID_VALUE for node map
>> If this has to be done for all IDispatchEx objects with DISPID_VALUE, it
>
wFlags |= DISPATCH_PROPERTYGET;
before ITypeInfo::Invoke call should do the trick and replace both this
patch and already committed node list patch.
Cheers,
Jacek
s prove that we should relax our verification on
CERT_TRUST_IS_OFFLINE_REVOCATION or something similar. To prove that
revocation checks are not made, a test with truly revoked cert would be
needed.
Jacek
Sure, there you go:
https://testbot.winehq.org/JobDetails.pl?Key=23215
Jacek
27;\' in path */
> +val = strrchrW(name, '\\');
> +keyname = SysAllocStringLen(&name[len], val-&name[len]);
It's better, but now if there is only one backslash, you will have
val-&name[len] == -1.
Thanks,
Jacek
AllocStringLen(NULL, datalen-1);
> +ret = RegGetValueW(root, keyname, &name[val], RRF_RT_ANY, &type,
> V_BSTR(value), &datalen);
> +}
> +else
> +FIXME("type %d not handled\n", type);
This should return an error.
Jacek
On 11/27/12 16:33, Nikolay Sivov wrote:
> On 11/27/2012 17:26, Rosanne DiMesio wrote:
>> On Tue, 27 Nov 2012 13:32:02 +0100
>> Jacek Caban wrote:
>>
>>> The idea is that Wine Gecko version could be just something based on
>>> other versions, that are more in
On 11/27/12 14:53, André Hentschel wrote:
> Am 27.11.2012 13:32, schrieb Jacek Caban:
>> The idea is that Wine Gecko version could be just something based on
>> other versions, that are more informative. It's not really possible to
>> use Wine version, because the first
s a minor version. So the next few release would look like:
- 1.9 (that's already in beta and will be the last release using old scheme)
- 2.20 (assuming the next update will be 3 months from 1.9, which means
Firefox 20)
- 2.22 (assuming another 3 moths for the update).
Any suggestions/comments welcomed.
Cheers,
Jacek
On 11/26/12 22:35, Andrew Talbot wrote:
> Jacek Caban wrote:
>
>> It's probably better to change the macro to require the semicolon.
>>
>> Jacek
> The reason I did it that way was because there are two variants of the
> DEFINE_CXX_DATA macro, surrounded by a
e the semicolon.
Jacek
build from SourceForge, put it in the right place [2] and run patched
Wine. All help with testing is appreciated!
Thanks,
Jacek
[1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.9-beta1/
[2] http://wiki.winehq.org/Gecko
diff --git a/dlls/appwiz.cpl/addons.c b/dlls/appwiz.cpl/addons.c
ind
On 11/20/12 16:00, Ann and Jason Edmeades wrote:
> On 20 November 2012 12:15, Jacek Caban <mailto:ja...@codeweavers.com>> wrote:
>
> On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote:
>
> (I'll make this change in try 2, as I need to fix the broken
>
On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote:
(I'll make this change in try 2, as I need to fix the broken NT4 stuff
from patch 1 anyway)
I think it's time to consider skipping all cmd tests on NT4. Adding
@or_broken@ for NT4 mostly pollutes those tests.
Jacek
ed: expected GetOverridesKeyPath
> webbrowser.c:2601: Test failed: expected Invoke_SETSECURELOCKICON
> webbrowser.c:2602: Test failed: expected Invoke_FILEDOWNLOAD
> webbrowser.c:3015: Test failed: doc_disp == NULL
> webbrowser: unhandled exception c005 at 00402F21
That's TestBot not skipping on platforms that should be skipped.
Jacek
lem is in implementation,
not tests.
Jacek
lt
includes. We probably need some way (command like arg or some tricky
argument in IDL file) to instruct widl to generate pure headers. This
may not be a big deal for Wine (and we ignored it for dwrite.h), but
that's more important for mingw-w64 and they use our d3dx* headers
(among others).
Jacek
;>> of the compilation usually removes both the save and discard operations.
>> Sure, but I don't think it's enough to justify such changes all over the
>> place, in existing code.
>>
> I agree that it is not enough to justify a separate set of patches, but
> as part of another set of changes, I think it is justified. After all,
> how else are examples of bad code going to be removed.
This is not a bad coding. You're changing a lot of my code, which uses
my coding style and this style is to use postfix incrementation. I'm not
saying it's better of worse because it's not, so there is no reason to
change it. Your argument about requirement for temporary storage is an
example of bad way to think about the code.
Jacek
LP* types). It would be nice if you could avoid it
in your patches.
Jacek
On 10/16/12 13:21, Jacek Caban wrote:
>> How exactly? Do you know more details / urls?
>>
>> Does it return -n ... +n values? Like the memcmp optimization that caused
>> mysql security issue?
>> In that case my patch should work.
> From what I know following call
s a leftover after string
representation change. We should use jsstr_t here to avoid allocation
anyway, I will send a patch.
Thanks,
Jacek
On 10/16/12 13:16, Marcus Meissner wrote:
> On Tue, Oct 16, 2012 at 01:12:50PM +0200, Jacek Caban wrote:
>> On 10/16/12 13:08, Marcus Meissner wrote:
>>> On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote:
>>>> ---
>>>> dlls/ntdll/string.c
On 10/16/12 13:08, Marcus Meissner wrote:
> On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote:
>> ---
>> dlls/ntdll/string.c | 12 +++-
>> dlls/ntdll/tests/string.c | 33 +
>> 2 files changed, 44
On 10/11/12 19:12, Charles Davis wrote:
> On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote:
>> This patch alone makes SunSpider 0.9 17x faster.
> Seems to me that something is really wrong with our BSTR implementation if
> replacing it with a home-grown implementation speeds this up
On 10/11/12 12:39, Henri Verbeet wrote:
> On 11 October 2012 12:16, Jacek Caban wrote:
>> +struct _jsstr_t {
>> +unsigned length_flags;
>> +unsigned ref;
>> +WCHAR str[1];
>> +};
> It's probably much too late for jscript, and perhaps Wine i
http://testbot.winehq.org/JobDetails.pl?Key=22013
>
> Your paranoid android.
Can someone please clear TestBot queue? Every time I send a series of
two patches, it tries to test my previous series, which usually (like in
this case) is already in Git.
Jacek
ount)==CSTR_EQUAL)
> + && ((lpString1[cchCount] == 0) || (lpString1[cchCount] ==
> (WCHAR){'\\'})))
> +return TRUE;
> +else
> +return FALSE;
This could be simplified:
len = strlenW(str2);
return !strncmpiW(str1, str2, len) && (!str1[len] || str1[len] == '\\');
Cheers,
Jacek
On 10/03/12 14:57, Marcus Meissner wrote:
> On Tue, Oct 02, 2012 at 01:19:37PM +0200, Jacek Caban wrote:
>> Hi Marcus,
>>
>> On 10/01/12 23:00, Marcus Meissner wrote:
>>> Hi,
>>>
>>> Various coverity issues complain about user-after-free scenar
Hi Nikolay,
On 10/03/12 13:34, Nikolay Sivov wrote:
> Support vb* constants for message box buttons
How about using MB_* constants from winuser.h instead of hardcoding them
here? Other than that, the patch looks good to me.
Jacek
rt 2).
This looks like a hack. It would be better to have always valid list
entry (if this really can't be added to the list earlier, you may always
initialize it by list_init) or make sure to not call ReleaseHelpViewer
before HHInfo is fully initialized.
Jacek
gnalled as an
error). It means that in this case we want to return RPC_S_OK. What is
the exact problem?
Jacek
gt; -return RPC_S_OK;
> +return call_ret; /* The Http* status codes map into the RPC_S
> namespace */
Not really, Http* APIs return BOOL and GetLastError() call is needed to
get error code. AFAIR, when I tested this code, most HTTP-related errors
were translated to RPC_S_SERVER_UNAVAILABLE by rpcrt4. That may be a
better choice here as well.
Jacek
Hi Nikolay,
On 09/30/12 20:36, Nikolay Sivov wrote:
> http://bugs.winehq.org/show_bug.cgi?id=31835
The code may be simple and obvious, but I'd still like to see a test. A
simple call should be enough just to make sure it's executed when I test
new Gecko builds.
Jacek
, puArgErr);
This really should be an interface, not an object. &This->IDistionary_iface or
simply iface would be the right thing to do.
Jacek
Hi Juan,
On 09/17/12 22:42, Juan Lang wrote:
> Hi Jacek,
>
> + * that NaN value representation has 52 (almost) free bytes.
>
> You mean bits, yes?
Yes, of course.
> While you're at it,
> + * jsval_t structure is used to represent JavaScript dynamicaly-typed values.
Please ignore this last patch. It has one more dependency that I didn't
send yet.
On 09/17/12 15:21, Jacek Caban wrote:
> ---
> dlls/jscript/jsutils.c |4 +-
> dlls/jscript/jsval.h | 143
> +--
> 2 files changed, 114 insertions(+), 33 deletions(-)
>
On 09/10/12 12:19, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> ---
>> dlls/mshtml/navigate.c | 42 +++---
>> dlls/mshtml/nsiface.idl | 11 +++
>> 2 files changed, 50 insertions(+), 3 deletions(-)
> It does
On 09/07/12 19:15, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> dlls/mshtml/htmlwindow.c |1 -
>> dlls/mshtml/mshtml_private.h |1 -
>> dlls/mshtml/script.c | 18 ++
>> dlls/mshtml/tests/vbtest.html | 15 +
Hi,
Here is proper run:
https://testbot.winehq.org/JobDetails.pl?Key=21409
Jacek
On 09/03/12 16:13, Alexandre Julliard wrote:
> Jacek Caban writes:
>
>> ---
>> dlls/mshtml/htmlwindow.c | 127
>> ++
>> 1 files changed, 72 insertions(+), 55 deletions(-)
> gcc -m32 -c -I. -I. -I../../inclu
t's not an option, xul.dll alone is over 700MB unstripped.
Jacek
ess and improving my hardware, but that has its
limits. And the time spent on Gecko maintenance (as in pure maintenance,
not real improvements) costs Wine in terms of improvements I could make
in this time.
If someone has a reason to keep debug builds, let me know. Any comments
are welcomed.
Tha
1 - 100 of 864 matches
Mail list logo
