Re: Add Windows Vista option to winecfg

2007-04-12 Thread Felix Nawothnig
Kovács András wrote: This patch is needed, because DirectX 10 is Vindows Vista only feature. Nothing wrong with adding Vista to the list but how is this needed? You don't want to disallow usage of dx10 unless Vista is selected, do you? Felix

Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Felix Nawothnig
Alexandre Julliard wrote: 2. Export LockDIBSection/Unlock to gdi32. Adding more exports is not nice but there really is no way around that, right? No, LockDIBSection is a driver internal detail, gdi32 has no business knowing about this. In my code the call to LockDIBSection serves two p

Re: Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Felix Nawothnig
itmap = handle; dc->flags &= ~DC_DIRTY; SetRectRgn( dc->hVisRgn, 0, 0, bitmap->bitmap.bmWidth, bitmap->bitmap.bmHeight); diff --git a/dlls/gdi32/dibdrv.c b/dlls/gdi32/dibdrv.c new file mode 100644 index 000..e4a216e --- /dev/null +++ b/dlls/gdi32/dibdrv.c @@

Patches / a proposal for the mystic DIB engine

2007-04-11 Thread Felix Nawothnig
Okay, I've spent the last days looking into this matter and I'd like to suggest a way to get it started. So. This is the plan: 1. In winex11.drv: -INT X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL lossy) +HBITMAP X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL force)

Re: notepad: Fix the wrong '&' operator use.

2007-04-05 Thread Felix Nawothnig
Byeong-Sik Jeon wrote: FormatMessage( FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error, 0, -(LPTSTR) &lpMsgBuf, 0, NULL); +lpMsgBuf, 0, NULL); This patch is wrong. When FORMAT_MESSAGE_ALLOCATE_BUFFER is used For

Re: [1/2] wined3d: Downgrade some ERRs to FIXMEs

2007-04-04 Thread Felix Nawothnig
Stefan Dösinger wrote: Some of them should technically be ERRs because we tell the application that we do not support those features, so they should never be used. Application bugs shouldn't trigger ERRs, Wine bugs should. Felix.

Re: Setting debug channels in 20040914 version

2007-04-02 Thread Felix Nawothnig
Bill Medland wrote: Can someone remind me how we used to set the debug channels back in late 2004? wine --debugmsg +relay ... Or maybe it was -debugmsg? Felix

Re: Is Wine a platform for Codeweaver to make money?! Please help me understand.

2007-03-29 Thread Felix Nawothnig
Sasan Iman wrote: I know that if you fiddle around with the stock release long enough you can get MS Office working on Wine as I have on a number of occasions, but shouldn't making this work for everyone be the highest priority for getting Wine to be adopted more widely?! Or is Wine more targeted

Re: gdi32: Add failing metrics test for negative font widths

2007-03-28 Thread Felix Nawothnig
Felix Nawothnig wrote: --- dlls/gdi32/tests/font.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) Anything wrong with this patch?

Re: WineD3D: Make CreateCubeTexture fail when not supported

2007-03-28 Thread Felix Nawothnig
Duane Clark wrote: On a Matrox G550, Win2k, crosscompiled on Linux with MingW: I:\dlls\d3d8\tests>d3d8_crosstest texture texture.c:122:texture caps: 0x41c7 texture.c:110:pool=0 hr=0x8876086c texture.c:110:pool=1 hr=0x8876086c texture.c:110:pool=2 hr=0x8876086c texture.c:110:pool=3 hr=0x0

Re: WineD3D: Make CreateCubeTexture fail when not supported

2007-03-28 Thread Felix Nawothnig
Luke Bratch wrote: Somewhere I have an ancient Matrix MGA G200 AGP card... If this would be of any use, I'll dig it out and run any tests in Wine/Windows that you'd like? Sure, if you're willing to do that just because I'm lazy. :-) I was just hoping someone might be running a box with an MGA

WineD3D: Make CreateCubeTexture fail when not supported

2007-03-28 Thread Felix Nawothnig
Not tested under Windows (does _anyone_ besides me have a Matrox? :) - would be nice if someone with either an MGA or an really ancient GPU could run the test on windows (if the pool=0 trace has an hr!=0 you got one of those ancient cards :). CCing to wine-devel for that reason. --- dlls/d3d8/

Re: x11drv: XDND: Fix file drop to properly support file:/// URIs(debugging problem)

2007-03-22 Thread Felix Nawothnig
Maciej Katafiasz wrote: +if(GetLastError()) +{ + TRACE("Can't convert to WCHAR: %d\n", GetLastError()); + goto clean_wfn; +} This is not an appropriate way of testing for an API failure. What is inappropriate and how should I fix it? Most APIs don't change GLE on success

Re: Supreme Commander Up and running!

2007-03-20 Thread Felix Nawothnig
Stephan Rose wrote: Figure, that'd be as good as a start as any as something for me to implement. Easy to test toojust before I dive into it, anyone potentially already working on it (or is there a good way to check)? Figured I'd ask first before 2 people work on the same thing. Someone

Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-17 Thread Felix Nawothnig
Dimi Paun wrote: Depends. Right now this code does nothing (and I was going to remove it anyway) - the only place where clrTextBk is read from is in prepaint_setup() - but prepaint_setup() is not called for subitems (and the CLR_NONE override is only done for subitems). Well, but that's the poin

Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Felix Nawothnig
(CCing wine-devel again) Dimi Paun wrote: Problem is that DrawText() for the subitems will also use the background color - which is wrong. Why is it wrong? Because the "background color" isn't the background color of the list. And it's definitly not the text bkclr in gdi-context either - I h

Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Felix Nawothnig
Felix Nawothnig wrote: Well - yes. But other controls do this too (statusbar for example) and considering all the stuff we do during refresh this is hardly a bottleneck. And even if it is we should optimize this codepath in gdi32 instead (by caching solid brushs for example). ...looking at

Re: [2/3] comctl32: Never draw item text with OPAQUE.

2007-03-16 Thread Felix Nawothnig
Dimi Paun wrote: But this ends up creating and deleting the brush for each of the cells Well - yes. But other controls do this too (statusbar for example) and considering all the stuff we do during refresh this is hardly a bottleneck. And even if it is we should optimize this codepath in gdi3

Defining COM interfaces without IDL

2007-03-15 Thread Felix Nawothnig
Hi. The PSDK headers sometimes use IDL to define an interface, sometimes it's done by hand (or rather using macros). I don't know if there is any reason for that (someone in the channel said it's just sloppiness by MS) - so, are there any resulting differences regarding source compatibility o

Re: comctl32: register all the controls in DllMain (fixes bug #7641)

2007-03-14 Thread Felix Nawothnig
Mikołaj Zalewski wrote: comctl32 version 5.82 (at least the one that comes with a fully patched Windows XP) and 6.0 register all the controls in DllMain. InitCommonControlsEx is just a dummy function. Could it be that 6.0 only registers those controls listed using window class dependencies i

Re: appdb needs to allow untested applications sometimes

2007-03-10 Thread Felix Nawothnig
Chris Morgan wrote: What would the purpose of having untested applications in the appdb be? Users would search for the app and find that it shows up but then find that it doens't work. At which point the application would qualify as been tested, no? Felix

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS fix

2007-03-10 Thread Felix Nawothnig
Andrew O.Shadoura wrote: +#if 0 static int once; +#endif if (!src || (!dst && dstlen)) { @@ -1774,11 +1783,13 @@ INT WINAPI MultiByteToWideChar( UINT pag if (srclen < 0) srclen = strlen(src) + 1; +#if 0 if (!once && (flags & MB_USEGLYPHCHARS)) { once = 1;

Re: quartz: Check allocation failure and clear memory inDSound Renderer

2007-03-09 Thread Felix Nawothnig
Dmitry Timoshkov wrote: However, note that NULL is not always all binary zero in memory. :) I don't believe it's true since NULL is defined as (void *)0. Actually it may aswell be just 0 in C. Just in C++ it's defined to be (void *)0. But even with just 0 an assignment/compare/whatever will g

Re: quartz: Check allocation failure and clear memory in DSound Renderer

2007-03-09 Thread Felix Nawothnig
Detlef Riekenberg wrote: @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, LPVOID * ppv) pDSoundRender->pClock = NULL; pDSoundRender->init = FALSE; pDSoundRender->started = FALSE; ... there is no need to clear it again. However, note that NULL is not always all

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

2007-03-09 Thread Felix Nawothnig
Jan Zerebecki wrote: cs is never NULL at that point. Where should it be checked for NULL, then? Or what does it prevent to be NULL? cs == lParam. And this code is inside if (lParam != NULL).

Re: user32: avoid NULL pointer access in DefWindowProcA WM_NCCREATE

2007-03-08 Thread Felix Nawothnig
Jan Zerebecki wrote: CREATESTRUCTA *cs = (CREATESTRUCTA *)lParam; /* check for string, as static icons, bitmaps (SS_ICON, SS_BITMAP) * may have child window IDs instead of window name */ -if (HIWORD(cs->lpszName)) +if (cs && HIWORD(c

Re: Work legalities

2007-03-07 Thread Felix Nawothnig
Nathan Williams wrote: What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? The FSF says: http://www.gnu.org/licenses/gpl.html | You should also get your employer (if you work as a programmer) or | your school, if any, to sign a "

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-03-02 Thread Felix Nawothnig
Erich Hoover wrote: I see your point. However, since the function you are implementing is in kernel32 anyway you could abstract it away and make both functions (CopyFile and ReplaceFile) call some internal function. That way you would get rid of the locking completly which is argueably somewhat u

Re: Forum proposal

2007-03-01 Thread Felix Nawothnig
(Score:-1, Flaimbait) Wojciech 'arab' Arabczyk wrote: Well - one could setup a forum<->mailing list gateway. Not easily doable due to the nature of SMTP. Also a forum would be completly useless for anything but wine-users... But let's be honest here: Most people who use webforums are too s

Re: Wine's Wiki Defaced

2007-02-28 Thread Felix Nawothnig
Francois Gouget wrote: Someone has defaced Wine's Wiki frontpage. Also I have either forgotten my password or the user accounts don't work anymore. Could someone look into this? Reverted it (no idea about the accounts, I was still logged in).

Re: Using ex-user32 controls from native comctl32 6

2007-02-28 Thread Felix Nawothnig
Frank Richter wrote: So, any idea how Windows makes comctl32 register the user classes? I think it just re-registered the classes, but I'm not sure. A trace with class registrations (ie +class) might give some hint at what native does. Okay, I was stupid. I removed registration of all the user

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-28 Thread Felix Nawothnig
Erich Hoover wrote: The "right" way would probably to do the copying yourself by read/write.. but I dunno. Except that it would ignore the permissions issues that have already been coded into the copy routines (and any updates that may eventually No, CreateFile (and friends) does the permission

Using ex-user32 controls from native comctl32 6

2007-02-28 Thread Felix Nawothnig
(CC-ing to Frank Richter because I hope he knows the answer :) Hi. I've been trying to make wine use the ex-user32 controls (listbox, scrollbox, etc.) in comctl32 where Microsoft copied them to in version 6 to get message traces of those controls (I know I could use msg spy tools on Windows bu

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-28 Thread Felix Nawothnig
(CC-ing wine-devel again) Erich Hoover wrote: The "right" way would probably to do the copying yourself by read/write.. but I dunno. Except that it would ignore the permissions issues that have already been coded into the copy routines (and any updates that may eventually No, CreateFile (and

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-26 Thread Felix Nawothnig
Erich Hoover wrote: Is the attached more like what you're looking for? I did some investigation and... actually I'm looking for an equivalent to the linux splice syscall. Win32 is the most braindead API ever. Duh. The "right" way would probably to do the copying yourself by read/write.. but

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-26 Thread Felix Nawothnig
Erich Hoover wrote: I assume you're referring to the file existence check and file delete, followed by the actual copy and move. I implemented these checks in this manner in order to provide error codes consistent with the documentation. I am not incredibly familiar with the Wine internals,

Re: kernel32: Implement ReplaceFileA/ReplaceFileW

2007-02-26 Thread Felix Nawothnig
Erich Hoover wrote: Real Name: Erich Hoover Description: Implements the functions ReplaceFileA and ReplaceFileW in kernel32 (Bug #7544). Also provides conformance test code to ensure proper functionality. Changelog: kernel32: Implement ReplaceFileA/ReplaceFileW Your patch seems

Re: Wine and XP Themes

2007-02-26 Thread Felix Nawothnig
Frank Richter wrote: WRT speed: themes usually use alpha-blending extensively; however, the speed of Wine's AlphaBlend() can almost be measured in geological terms; Why is that? Looking at it it seems to be using XRender - since theming doesn't require Aero and stuff what way would there be to

Re: [PATCH] user32: do not call NULL message callback

2007-02-24 Thread Felix Nawothnig
Fabian Bieler wrote: The only way I know of to test this behavior would be to pass a NULL pointer as callback. Naturally this results in a segfault without this patch. Is this okay for a testcase? Use if(0) instead of todo_wine then (and let the second patch, which fixes the bug, remove the i

Re: [PATCH] user32: do not call NULL message callback

2007-02-24 Thread Felix Nawothnig
Fabian Bieler wrote: Windows silently ignores NULL pointers supplied to SendMessageCallback as callback function. A testcase would be nice. Felix

Re: New wintest executable is there (but there are some issues due to introduction of skip)

2007-02-24 Thread Felix Nawothnig
And while we're at it, there seems to be some misconfiguration of the httpd (for quite some time), as the following URL generates an 500 Internal Server Error: http://test.winehq.org/data/200702241000/2003_W2K3-SE-IE7/ntdll:error.txt

Re: test.winehq.com status

2007-02-24 Thread Felix Nawothnig
Hi. A new crossbuild appeared today but the site shows all tests failing. See http://test.winehq.org/data/200702241000/ Felix

Re: [1/2] comctl32: add WM_PAINT message sequence tests

2007-02-23 Thread Felix Nawothnig
James Hawkins wrote: If you're subclassing the header control and checking messages from the header control, then you need to add another message sequence, HEADER_SEQ_INDEX. Problem is I need to test whether the header msgs are sent between the WM_PAINT and WM_NOTIFY of the listview - right no

Message spy log viewer

2007-02-23 Thread Felix Nawothnig
Hi. I just figured I never told anyone (did I?) - a while ago I wrote a Ruby/GTK2 tool to parse +message logs (along with other channels mixed in) and display them in a treeview - makes debugging message related problems much easier. I suppose others wrote similar scripts for their own use - bu

Re: Rediffed patch from Rein Klazes:winex11.drv:Add pointer check in X11DRV_SetDIBits

2007-02-20 Thread Felix Nawothnig
Louis. Lenders wrote: + if( IsBadReadPtr( bits, nrsrcbytes)) return 0; AFAIK you should never use that function since it introduces a race con. Try using an exception handler around the memory access itself. Felix

Re: wineboot: Start items in StartUp folder on boot, includes security measures.

2007-02-14 Thread Felix Nawothnig
[EMAIL PROTECTED] wrote: And I have never advocated for putting this in the registry, my suggestion has always been to store these settings in a file outside the .wine/drive_c jail area that is accessbile via wine's Win32 API. Wine is *not* a sandbox. Any .exe run can make use of native (Linux)

Re: Add RegisterRawInputDevices stub implementation

2007-02-13 Thread Felix Nawothnig
Kovács András wrote: +BOOL WINAPI RegisterRawInputDevices(PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize) +{ +int i; Please keep the indentation style of the original file.

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

2007-02-13 Thread Felix Nawothnig
Andrew Talbot wrote: I've seen this function represented with the first two parameters constified. Is anyone aware of a more const-correct version in the field than the one Felix mentions? Sorry about that, seems they changed the declaration in the new headers - I misinterpreted your comment a

Re: comctl32: move up-down msg seq tests into new 'msg' test

2007-02-13 Thread Felix Nawothnig
James Hawkins wrote: This is not what needs to happen. The generic message sequence testing code needs to be factored into msg.c, but the specific tests need to stay in each control's test file. Guessed so... How about putting it into include/wine/test.h to share the code with user32/msg? Wou

Re: version: Constify a formal parameter of VerQueryValue{A|W}()

2007-02-13 Thread Felix Nawothnig
Andrew Talbot wrote: -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock, +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock, This is wrong - in the PSDK headers it's LPSTR (the first parameter should be const though). Felix

Re: wineboot: Start items in StartUp folder on boot, includes security measures.

2007-02-11 Thread Felix Nawothnig
[EMAIL PROTECTED] wrote: This sounds almost perfect. I think the counterpoint raised by James Hawkins would be adequately addressed by adding a winecfg option as follows: Since we want winecfg to be gone in the long-term a registry key alone would probably do fine. Felix

Re: Comctl32 Status Bar Test

2007-02-10 Thread Felix Nawothnig
Alex Arazi wrote: -ok(rc.top == 2, "Expected 2, got %d\n", rc.top); -ok(rc.bottom == 21, "Expected 21, got %d\n", rc.bottom); -ok(rc.left == 0, "Expected 0, got %d\n", rc.left); -ok(rc.right == 50, "Expected 50, got %d\n", rc.right); I didn't really look at your new tests but th

Re: Some thoughts about the ominous DIB Engine

2007-02-09 Thread Felix Nawothnig
Felix Nawothnig wrote: Pierre could speak to this better than I, but my understanding is that the Quartz driver does not need the DIB engine. Quartz (the Mac's imaging and windowing API) is capable of drawing to offscreen bitmaps directly, at color depths that need not match the disp

Re: Some thoughts about the ominous DIB Engine

2007-02-09 Thread Felix Nawothnig
Ken Thomases wrote: Pierre could speak to this better than I, but my understanding is that the Quartz driver does not need the DIB engine. Quartz (the Mac's imaging and windowing API) is capable of drawing to offscreen bitmaps directly, at color depths that need not match the display's. T

Re: comctl32: tab: update the item mask after a TB_SETITEM (fixes bug #7345)

2007-02-06 Thread Felix Nawothnig
Mikołaj Zalewski wrote: Tab uses a mask to mark which fields are set but it new fields were set by SetItem the mask wasn't updated. Actually all members are always valid (for the internal structure at least). I already sent a patch which removes the mask. Felix

Undoc. comctl32 mem management functions

2007-02-06 Thread Felix Nawothnig
Hi. comctl32 exports (undocumented) Alloc() and friends which call LocalAlloc => GlobalAlloc => HeapAlloc since it's doesn't use any fancy LMEM / GMEM flags... so shouldn't Alloc() call HeapAlloc() directly? If Global/Local* behave different than Heap* on Windows - wouldn't it then be desirabl

Re: msi: InstallPackage check for UI level must not disregard flags (updated)

2007-02-06 Thread Felix Nawothnig
Misha Koshelev wrote: So do you think I should add a define like INSTALLUILEVEL_NOFLAGS somewhere set to 0xf then? Shouldn't that be 0x7? I guess either one would work since the first flag is 0x20. Do I need to change it to 0x7 or leave as is? So would 0x1f or 0xfe1f. Doesn't make it cor

Re: msi: InstallPackage check for UI level must not disregard flags (updated)

2007-02-06 Thread Felix Nawothnig
Koshelev, Misha Vladislavo wrote: So do you think I should add a define like INSTALLUILEVEL_NOFLAGS somewhere set to 0xf then? Shouldn't that be 0x7?

Re: [PATCH] coverity: CID35: fixed wrong condition

2007-02-06 Thread Felix Nawothnig
Marcus Meissner wrote: - if(nRelPos>=0) { /* if this or preceding row */ + if(nRelPos<=0) { /* if this or preceding row */ while(nRelPos<=0) { Shouldn't that become a "do { ... } while()" then? No, since there is a return item; after the while () loop. I meant replacing just the while()

Re: [PATCH] coverity: CID35: fixed wrong condition

2007-02-05 Thread Felix Nawothnig
Marcus Meissner wrote: - if(nRelPos>=0) { /* if this or preceding row */ + if(nRelPos<=0) { /* if this or preceding row */ while(nRelPos<=0) { Shouldn't that become a "do { ... } while()" then?

Re: Getting Fallout 2 to work well

2007-02-02 Thread Felix Nawothnig
Joonas Koivunen wrote: The problem I have is that fallout2.exe takes all the available CPU power, optimizing that might make other old games work better too. I'm interested in the task, though I haven't got much of an idea how GDI or DirectDraw api's work and I'd need some pointers where to sta

test.winehq.com status

2007-01-30 Thread Felix Nawothnig
Hi. Anyone knows what happened to test.winehq.com/data? There has been no new crossbuilds for quite some time now... Felix

Re: dsound/tests: The tests link with dsound.dll so use GetModuleHandle() instead of LoadLibrary().

2007-01-11 Thread Felix Nawothnig
Francois Gouget wrote: This is a NOP, it just seems a bit cleaner to me. -hDsound = LoadLibraryA("dsound.dll"); -if (!hDsound) { -trace("dsound.dll not found\n"); -return; -} - +hDsound = GetModuleHandleA("dsound.dll"); +ok(hDsound != NULL, "dsound.dll not loa

Re: Throwing in an idea (probably it was discussed before though)

2005-08-22 Thread Felix Nawothnig
John Smith wrote: This will just allow developers to hide bugs in wine and slow development even further, I thing it's a bad idea. Ahem. To say it politely - I didn't get an impression that WINE developers are desperately looking for unknown bugs to fix. Because it's a tedious and boring task

Re: excluding kernel32.9[78] from a relay log

2005-08-20 Thread Felix Nawothnig
Saulius Krasuckas wrote: I want to exclude this stuff. Adding "97;98" to "HKEY_CURRENT_USER/Software/Wine/debug/RelayExclude" string value doesn't help me. Adding "_EnterSysLevel;_LeaveSysLevel;97;98" does not help either. Suggestions? Try "kernel32.97;kernel32.98". Felix

Re: winspool.drv: Conformance-Tests

2005-08-18 Thread Felix Nawothnig
Detlef Riekenberg wrote: I wrote a Commandline-Program for testing the Printing-API and found many misterious behaviour. While rewriting the conformance-tests for winspool.drv, how should we handle this bugs / features ? There are several types of undocumented behaviour: a) The documentation

Re: Cursor Disappears and reappears

2005-08-17 Thread Felix Nawothnig
Kevin DeKorte wrote: Using Wine 20050725 and Lotus Notes 6.51 when I move my mouse to the database tabs or over the replication window the mouse disappears while I move over the tab or replicated databases and then reappears when I leave the list. The databases are highlighted, but having the mou

Re: PATCH: GlobalAddAtomA check for invalid ptr

2005-08-14 Thread Felix Nawothnig
Marcus Meissner wrote: Yes, but please don't use the IsBad* functions, use a proper exception handler. Next try, is this what you imagined. The reason for using an exception handler is thread safety - to achieve that you have to put it around the ATOM_AddAtomA call. Felix

Re: Porting Device Drivers to Winehq

2005-08-10 Thread Felix Nawothnig
John Shillinglaw wrote: Thank you all for your help. I was vaguely aware that wine could not use the 95 drivers for my card, and developing pcmcia-cs / alsa drivers was my goal. Finding accurate, recent win 95 decodeing info/ tools on the net was difficult, and I knew that wine developers face th

Re: Inconsistency/bug with GetProcAddress

2005-08-07 Thread Felix Nawothnig
Mike McCormack wrote: Yes it is. NTDLL and KERNEL32 are both mapped to always the same address on >=NT4 (in NT3 only NTDLL was at a fixed address however). KERNEL32 and NTDLL are special cases because they are loaded first when the address space is empty, and since the NT kernel has no address

Re: Inconsistency/bug with GetProcAddress

2005-08-07 Thread Felix Nawothnig
Mike McCormack wrote: Is there are any reason why this is happening? Any ways to fix this? Under Windows 98, you will always get the same address for the same export from a dll, however that's not garanteed under Windows NT (or Wine). Yes it is. NTDLL and KERNEL32 are both mapped to always the

Re: test case demonstrating PeekMessage give up timeslices

2005-08-06 Thread Felix Nawothnig
Oliver Mössinger wrote: We changed our program to avoid the needless polling (only two PeekMessage are needet then). We add also the PM_NOYIELD. This gives back the reaction of the program if some other process consumes process time. But the speed is more reduced than windows. So we actually go

Re: Wine passes WGA test

2005-08-05 Thread Felix Nawothnig
James Courtier-Dutton wrote: IIRC it's checking the location of the old Wine config registry key. This has all moved as part of the config file removal (and as was planned long before WPA came around). No doubt they will update their WPA checks at some point... Would it be wiser to implement a

Re: WRT: Links and Timeout

2005-08-03 Thread Felix Nawothnig
Francois Gouget wrote: On the WRT-Page "http://www.astro.gla.ac.uk/users/paulm/WRT/wrt.php";, the link for "current status of Wine's conformance tests" is dead ("http://fgouget.free.fr/wine/tests-en.shtml";). The list of tests was really a pain to manage by hand and as it has grown a lot since t

Re: DSOUND: prevent assertion in mixer.c

2005-08-02 Thread Felix Nawothnig
Alex Villací­s Lasso wrote: I guess this is preluded by some "length not a multiple of block size" errors? I've been experiencing those errors with the same failed assertion in another game and came up with a similar patch but didn't submit since I think this just hides another bug as it should

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Felix Nawothnig
Uwe Bonnes wrote: Why? When you're debugging 16bit programs, sometimes you only want to see 16bit calls.:) Isn't your proposal similar to the recent "nrelay" proposal, where only calls from native code is logged, but not wine code calling other wine code? Why exactly do we need this (both nrel

Re: Move Win16 relay messages to the relay16 channel

2005-08-02 Thread Felix Nawothnig
Uwe Bonnes wrote: Why? When you're debugging 16bit programs, sometimes you only want to see 16bit calls.:) Isn't your proposal similar to the recent "nrelay" proposal, where only calls from native code is logged, but not wine code calling other wine code? Why exactly do we need this (both nre

Re: DSOUND: prevent assertion in mixer.c

2005-08-02 Thread Felix Nawothnig
Alex Villací­s Lasso wrote: wine-pthread: mixer.c:386: DSOUND_MixInBuffer: Assertion `adjusted_remainder >= 0' failed. wine: Unhandled exception (thread 000a), starting debugger... WineDbg starting on pid 0x8 I guess this is preluded by some "length not a multiple of block size" errors? I've

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
I wrote: since a server call is much more expensive than a Windows system call. Would using shm fix that? No, you don't want to put the message queue in shared memory, that's not reliable. shm + kernel handles for synchronization then? Wait, putting the message queue into shm isn't what I wa

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
Alexandre Julliard wrote: since a server call is much more expensive than a Windows system call. Would using shm fix that? No, you don't want to put the message queue in shared memory, that's not reliable. shm + kernel handles for synchronization then? Felix

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
Alexandre Julliard wrote: So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD specified it yields execution twice (although it shouldn't at all). PeekMessage is going to call the server and wait on the result, there's no way around it. The extra yield is to avoid hammering the

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
I wrote: So, PeekMessage always yields execution (it shouldn't) with PM_NOYIELD specified it yields execution twice (although it shouldn't at all). Err, that should read "and without PM_NOYIELD specified". Felix

Re: test case demonstrating PeekMessage give up timeslices

2005-08-02 Thread Felix Nawothnig
Alexandre Julliard wrote: You can probably fix it by passing PM_NOYIELD in the PeekMessage calls. But if your app needs a lot of CPU, restructuring the code to avoid all the needless polling would give much better results, and probably improve the behavior on Windows too. That's just a workarou

Re: LoadString problems

2005-07-31 Thread Felix Nawothnig
James Hawkins wrote: Maybe that only returns the hinstance of the process calling the module, and not the hinstance of the module itself. Ofcourse it doesn't do that, how should it know from what module the call came from? I didn't think so, so shouldn't GetModuleHandle(NULL) work? It leads me

Re: [usp10] Add stubbed support for ScriptGetFontProperties

2005-07-31 Thread Felix Nawothnig
Oliver Stieber wrote: +HRESULT WINAPI ScriptGetFontProperties(HDC hdc, SCRIPT_CACHE *psc, SCRIPT_FONTPROPERTIES *sfp) { +FIXME("%p,%p,%p\n", hdc, psc, sfp); +/* return something sensible? */ +if (NULL != sfp) { +sfp->cBytes= sizeof(SCRIPT_FONTPROPERTIES); +sfp

Re: LoadString problems

2005-07-30 Thread Felix Nawothnig
James Hawkins wrote: Maybe that only returns the hinstance of the process calling the module, and not the hinstance of the module itself. Ofcourse it doesn't do that, how should it know from what module the call came from? (Yes, there are ways. But they are hackish, wouldn't work always and

Re: Benchmark's on the Wiki

2005-07-30 Thread Felix Nawothnig
Tom Wickline wrote: I'm not finished, but I thought I would ask if this going in the right direction? http://wiki.winehq.org/BenchMark Much better, although Windows should really be on the left side. Why? its Wine against XP ... not XP against Wine. Maybe it's just me (no it's not, someone el

Re: Benchmark's on the Wiki

2005-07-30 Thread Felix Nawothnig
Tom Wickline wrote: I'm not finished, but I thought I would ask if this going in the right direction? http://wiki.winehq.org/BenchMark Much better, although Windows should really be on the left side. Felix

Re: [wined3d] tidy up draw prim and add strided data new to d3d9

2005-07-29 Thread Felix Nawothnig
Oliver Stieber wrote: use ++x instead of x++ since x++ potentially requires a temporary variable. I seriously doubt this will actually have an effect on the resulting assembly code generated by any semi-serious compiler (regardless of the -O level) as for(i = 0; i < x; i++) is a quite common

Re: KERNEL32: Re: Fix thread tests on WinME

2005-07-28 Thread Felix Nawothnig
Saulius Krasuckas wrote: Felix, I have reverted part of your patch and tested this. Reversion is doing fine on WinME -- zero failed tests. Didn't tested on XP or so. Is this acceptable? If so, feel free to submit it under own name. Or correct the code. :-) This is not really correct, Se

Re: winecfg in 640x480

2005-07-28 Thread Felix Nawothnig
Joe Baker wrote: Well, in KDE use the Alt key and the left mouse to click and drag the window from anywhere in the window to move it higher. I think that blackbox supports this style of Window movement as well if you're on a lighter resource computer as your resolution suggests. This doesn't

Re: Const Function Parameters?

2005-07-27 Thread Felix Nawothnig
Andreas Mohr wrote: While I'm not too convinced in this case (1.5% improvement sounds like within statistic noise), it should be a good idea to mark things in Wine const whenever possible (objdump -x helps here), since it improves reliability Huh? He did stuff like... -void foo(int i) +void fo

Re: dlls/winmm/winealsa/midi.c: Bug in MIDI_CMD_BENDER fixed

2005-07-27 Thread Felix Nawothnig
Johannes Koch wrote: No, you don't. The bitwise shifting operator has a higher precedence than the bitwise or does. In case you didn't know... $ man 7 operator is your friend. :-) Felix

Re: Const Function Parameters?

2005-07-26 Thread Felix Nawothnig
Michael Carlson wrote: I've also found that marking a couple of parameters of that function const (that I believe should be marked const anyways), CPU usage in that function drops measurably with oprofile. As far as I know, parameters that aren't modified in a function should be marked const anyw

Re: commctrl: modularize progress drawing

2005-07-26 Thread Felix Nawothnig
Dimi Paun wrote: It has become the norm lately to not have the ALLCAPS_ prefix for internal static functions, but rather have names_with_underscores to easily tell them apart from Win32 APIs. So for the above, I guess get_led_size() would be preferable. I thought the only half-official rule wo

Re: Exception Handling with a "bad" ESP

2005-07-22 Thread Felix Nawothnig
Dimi Paun wrote: Direct memory access can be done using X11 SHM, no? But then you lose network transparency. I'd think that apps directly accessing the surface memory are either games or do some other kind of realtime graphics so network transparency isn't worth anything there (since we'd ha

Re: Exception Handling with a "bad" ESP

2005-07-22 Thread Felix Nawothnig
Dimi Paun wrote: We need to get rid of that seperation - either the DIB should be stored fully on X side (which would require to add some features to X) or fully on Wine side (by implementing a GDI renderer in Wine). You can't have it fully on the X side, since you need direct memory access D

Re: Exception Handling with a "bad" ESP

2005-07-22 Thread Felix Nawothnig
Glenn Wurster wrote: Our current DIB implementation is an ugly hack. We need a real DIB implementation, either as a complete GDI engine in Wine or as an X11 extension. But is it the DIB implementation that is really at fault here or is it the fact that we are adding extra exceptions and can't b

Re: Exception Handling with a "bad" ESP

2005-07-22 Thread Felix Nawothnig
Glenn Wurster wrote: Comments? Suggestions? Our current DIB implementation is an ugly hack. We need a real DIB implementation, either as a complete GDI engine in Wine or as an X11 extension. Some work has been done on a GDI engine in Wine by Transgaming a couple of years ago but it wasn't

Re: [ntdll/tests/info.c] Skip test if needed

2005-07-22 Thread Felix Nawothnig
Paul Vriens wrote: every now and then one of the tests failed. Probably because a process is not longer there. You could spawn a child-process in the test which would be more reliable (or you could query the current process - that's what I do in the psapi tests)... Felix

  1   2   >