GSoC '13 - Hello!

Hello everyone, My name is Eric Zheng, I'm a junior in Computer Engineering at the University of Illinois Urbana-Champaign. I just wanted to introduce myself and state my interest in the "Xinput / Xbox 360 controller compatibility" project. I hope to be able to jump on IRC later

Re: [3/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution

Le 08/04/2013 16:03, Nikolay Sivov a écrit : On Mon, Apr 8, 2013 at 4:47 PM, Hugh McMaster > wrote: From: Nikolay Sivov [mailto:bungleh...@gmail.com ] Sent: Monday, 8 April 2013 11:08 PM To: wine-devel; Hu

Re: Linker error when improving GetLargestConsoleWindowSize

>This won't be able to work. The linker error is telling you, effectively, that you're not importing user32. However, kernel32 can't import user32. Kernel32 is at a lower level than user32. And a console program especially can't rely on user32 being loaded and initialized to satisfy the request

Re: A new demangler test?

Le 24/02/2013 07:07, Max TenEyck Woodbury a écrit : On 02/23/2013 02:54 AM, Eric Pouech wrote: Le 21/02/2013 14:33, Max TenEyck Woodbury a écrit : Would it be appropriate to add a test to the name demangler that: 1) Scans all '.dll' and '.spec' files for mangled names, and

Re: A new demangler test?

Le 21/02/2013 14:33, Max TenEyck Woodbury a écrit : Would it be appropriate to add a test to the name demangler that: 1) Scans all '.dll' and '.spac' files for mangled names, and 2) Tries to decode those names. 3) Prints the mangled and decoded names and where they occur. Success would be tha

Re: dbghelp: Implement rudimentary stack walk for ARM64

Le 21/01/2013 20:26, André Hentschel a écrit : Am 21.01.2013 10:50, schrieb Eric Pouech: +if ((frame->AddrPC.Mode == AddrModeFlat) && +(frame->AddrFrame.Mode != AddrModeFlat)) this looks strange to me. I guess, you want to check that both mode address modes ar

Re: dbghelp: Implement rudimentary stack walk for ARM64

> +if ((frame->AddrPC.Mode == AddrModeFlat) && > +(frame->AddrFrame.Mode != AddrModeFlat)) this looks strange to me. I guess, you want to check that both mode address modes are AddrModeFlat A+ -- Eric Pouech

Re: [PATCH 0/7] Series short description

> Running make test with this series hangs in the hlink.c test, there seems to be a wineconsole process that never terminates. that's because rpcss is started from the hlink test, and is still a child of wineconsole (now) after the test terminated and wineconsole always waits for all its children

Re: Help Splitting Patches

Le 30/12/2012 22:52, Adam Martinson a écrit : Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. I haven't checked whether it's really possible, but one way to go would be to: -

Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)

hmm, that was intended to work (and did work for try#1, even though I didn't retest it in #2) :-( I'll look at it A+ 2012/12/19 Alexandre Julliard > Eric Pouech writes: > > >> Try #2 (changes from previous patch) > > > > > - fix changelog of first

Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)

hanging the old code to make it work in patch#2 and erase it in next patch A+ -- -- Eric Pouech

Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

Le 20/11/2012 13:31, Alexandre Julliard a écrit : Eric Pouech writes: That doesn't look right. There's no guarantee that the handle is for the current process console. in fact, it's guaranted, because we check before (in the function calling this helper) that the handle is r

Re: [PATCH 4/5] [kernel] Support opening of console for read (try 2)

ake it clearer by adding a comment to the helper function saying that those two conditions are met A+ -- Eric Pouech

Re: Any advice please... Console input issue

king to add a helper functions for the writeconsoleinput calls in bare_console_fetch_input. and this helper function would : - try to call writeconsoleinput with the current console input handle - if it fails with status_access_denied, then create the right handle as you did - from your code, please use CreateFileW instead of CreateFileA A+ -- -- Eric Pouech

Re: Any advice please... Console input issue

Le 09/11/2012 22:49, Ann and Jason Edmeades a écrit : Hello, I've been looking at a patch which sorts out NUL and CON handling in a part of the command shell, and have stumbled upon a problem I am not sure how to fix because I really dont understand the underlying console handling, and would

Re: [PATCH] wineboot: detect correct processor name and vendorID, use Intel Pentium 4 as fallback

Le 20/10/2012 12:42, Patrick Rudolph a écrit : This patch need lots of testing, since I can only test it on linux using an Intel CPU. Please tests on other OS and systems, too. please use the ntdll or kernel32 relevant API so that you don't have to copy the same code A+

Re: Have there been any problems with Wine on GCC 4.7?

-g was already the default. Most packagers (to my knowledge) provide a separate debug package, which isn't installed by default. i'm not especially speaking of packagers, but folks who compile wine themselves with something like: ./configure CFLAGS=-O2 and your patch forces -gdwarf2 (whatever

Re: Have there been any problems with Wine on GCC 4.7?

> > > http://source.winehq.org/git/wine.git/commitdiff/3f1dbaf3df0ae8ec2f0e86191eae3879fc422e2d > > -- > -Austin > the trouble with this patch is that it enables debug info whatever the default configuration is... A+ -- Eric Pouech

Re: Have there been any problems with Wine on GCC 4.7?

diff --git a/configure.ac b/configure.ac index 4bd43d1..c80fd8a 100644 --- a/configure.ac +++ b/configure.ac @@ -1746,6 +1746,8 @@ then WINE_TRY_CFLAGS([-Wtype-limits]) WINE_TRY_CFLAGS([-Wunused-but-set-parameter]) WINE_TRY_CFLAGS([-Wwrite-strings]) + WINE_TRY_CFLAGS([-gdwarf-2]) +

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

Le 13/08/2012 09:51, Dmitry Timoshkov a écrit : Eric Pouech wrote: It would look much better without all those 'ret' + 'else' things. well, wine doesn't have coding guidelines... so I don't know what "look much better" means (project wise) For this p

Re: Have there been any problems with Wine on GCC 4.7?

In the meantime, I suppose I could enable the -gdwarf-2 compiler option. yes (but it's a bit more tricky than it sounds) something like this will do A+ diff --git a/configure.ac b/configure.ac index 4bd43d1..2624dc1 100644 --- a/configure.ac +++ b/configure.ac @@ -236,6 +236,12 @@ then AC

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

> It would look much better without all those 'ret' + 'else' things. well, wine doesn't have coding guidelines... so I don't know what "look much better" means (project wise) A+ -- Eric Pouech

Re: Have there been any problems with Wine on GCC 4.7?

Le 24/07/2012 04:06, Scott Ritchie a écrit : Wine is the last remaining package still depending on GCC 4.5 in the current Ubuntu alpha, it would be nice to drop GCC 4.5 and forward port Wine, however 4.6 is known to not work too well. But now we have 4.7 -- have there been any bugs attributed to

Re: Wine's support for reporting calling conventions

*/ > sig_type = symt_new_function_signature(ctx->module, ret_type, > CV_CALL_FAR_C); > > > Thanks > Roger > -- -- Eric Pouech

Re: Error When Using winedbg on 64-bit Ubuntu 12.04

gt; > My source tree is synced to git commit 020a68e1350eaf7293718732c1c920** > 3e460709c6. > > Has anyone had success debugging Windows applications on 64-bit Linux? > > Thanks, > John Edmonds > > > -- -- Eric Pouech

Re: kernel32: Add a test for deleting an opened for reading file. Take 2.

%d\n", GetLastError()); > +ret = DeleteFile(temp_file); > +todo_wine > +ok(!ret, "DeleteFile should fail\n"); > +} > > START_TEST(file) > { > @@ -3257,6 +3282,7 @@ START_TEST(file) > test_CreateFileW(); > test_DeleteFileA(); > test_DeleteFileW(); > +test_delete_file(); > test_MoveFileA(); > test_MoveFileW(); > test_FindFirstFileA(); > -- > 1.7.11 > > > > -- -- Eric Pouech

Re: Wine's support for reporting calling conventions

face to do so). HTH A+ 2012/6/6, Roger Cruz : > Hi Eric, > > Thanks for replying. I saw that in the DWARF spec and I was afraid that > DWARF may not provide detailed Info. But I also read in the spec that the > compilers use a DWARF extension feature to convey additional info such as

Re: msxml3: avoid a dangling else (LLVM/Clang)

ing a code-style flame-war ? A+ -- Eric Pouech

Re: Ubuntu 12.04 (version#2, drop previous mail)

al_error( "cannot get pid from lock (lock isn't locked)\n"); +} +else +fatal_error( "cannot get pid from lock\n"); +close(zfd); +} /* work around Ubuntu's ptrace breakage */ if (server_pid != -1) prctl( 0x59616d61 /* PR_SET_P

Re: Ubuntu 12.04 (version#2, drop previous mail)

the least > Just do the chroot. You will save yourself so much grief and it will > actually work. if the ubuntu folks keep this state of mind, then they'll continue to sink the best solution is then to pick up another distro A+ -- -- Eric Pouech

Re: Fwd: Ubuntu 12.04 (version#2, drop previous mail)

Le 29/04/2012 22:44, Eric Pouech a écrit : for the devels having upgraded their boxes to ubuntu 12.04, here's a couple of stuff I had to do, especially to get 32bit wine compile This could be useful if you want to have a dual x86_64 : i386 setup this is an updated version to what I al

Fwd: Ubuntu 12.04 (version#2, drop previous mail)

, as I didn't note all the :i386 packages I've manually installed) libldap2.so alternatively, if I do a [eric:~]$ dpkg -l | grep i386 | grep -- -dev ii libc6-dev-i386 2.15-0ubuntu10 Embedded GNU C Library: 32-bit development libraries for AMD64 ii libldap2-dev:i386

Re: winedbg and program stdout

kely have to create a new window for the console A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: automate winedbg IDE integration

fix later on... A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: automate winedbg IDE integration

ve a trace of the gdb commands ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: automate winedbg IDE integration

ps. Is there an easier way? Or maybe everyone use plain winedbg without any IDE? it depends on how the interaction with gdb is done... some IDE provide sufficient parametrisation of gdb launching so that you can use directly winedbg --gdb but YMMV which IDE do you have in mind ? A+ --

Re: winedbg: Respect Thumb mode when adjusting PC on ARM

Le 11/03/2012 09:18, Eric Pouech a écrit : Le 10/03/2012 18:26, André Hentschel a écrit : --- programs/winedbg/be_arm.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/programs/winedbg/be_arm.c b/programs/winedbg/be_arm.c index c39043c..6c1cc05 100644 --- a

Re: winedbg: Respect Thumb mode when adjusting PC on ARM

(never being changed), and the current/outgoing one), and that we pass the two contexts in winedbg to do the right thing here A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: wineconsole: Remove the character-width check as we need newer FreeType library.

Le 15/12/2011 17:18, Akihiro Sagawa a écrit : On Wed, 14 Dec 2011 19:35:34 +0100, Eric Pouech wrote: this doesn't solve the printing issue as the always infer that any char has the same size how is this printed on real windows with your character set ? See the attachment, please. It was

Re: wineconsole: Remove the character-width check as we need newer FreeType library.

-- > 1 files changed, 2 insertions(+), 32 deletions(-) > > > > > -- -- Eric Pouech

Re: [PATCH] server: assert on failure to open /dev/null (Coverity)

e stdio fds are open */ > fd = open( "/dev/null", O_RDWR ); > +assert (fd != -1); > while (fd >= 0 && fd <= 2) fd = dup( fd ); > > if (!server_dir) fatal_error( "directory %s cannot be accessed\n", > config_dir ); > -- > 1.7.1 > > > > -- -- Eric Pouech

Re: [PATCH 3/6] [UnInstall]: No longer use unix stdio functions, but the kernel32 equivalent

Le 07/11/2011 14:12, Alexandre Julliard a écrit : Eric Pouech writes: #28185 A+ --- programs/uninstaller/main.c | 65 ++- 1 files changed, 46 insertions(+), 19 deletions(-) I'm not sure that's a good idea. The output of uninstaller i

Re: cmd: Avoid mixing signed and unsigned type in conditional expression

hars = 0; > if (++line_count >= max_height - 1) { > -- > 1.7.7.1 > > > > -- -- Eric Pouech

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

pe (as you added it) to a given number A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

D_HT bits) static inline BOOL is_console_handle(HANDLE h) {return ((DWORD_PTR)h) & 3 == 3;} will test every handle and tell whether it's a console or a regular (file, pipe...) handle A+ > -- > -- > Eric Pouech >

Re: [2/3] cmd: Avoid checking whether we're in console mode for every read (try 2)

, console handles have their 2 lower bit set you could use it to even simplify further the code A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

regarding the 'expect' stuff, you can look at the automaton to test winedbg https://github.com/ericZp/wdtp not sure it fully matches what you want to do, but it can help A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the inge

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

Le 09/09/2011 13:02, Frédéric Delanoy a écrit : 2011/9/9 Eric Pouech: WineDbg> set ! symbol_picker scoped will do what you want unfortunately, there's no way to store it as a default command (you can always use --command or --file on command line to help) Thanks for that quick respo

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

this won't work if a .bat file calls another .bat file the cache must be stored inside the context structure... A+ -- Eric Pouech

Re: kernel32: Fix writing to a pipe in WriteConsoleW().

Le 01/09/2011 16:22, Francois Gouget a écrit : On Wed, 24 Aug 2011, Eric Pouech wrote: [...] you can safely provide the patches with protecting WriteConsole and friends with a if (!is_console_handle(???)) return FALSE; line Would something like the attached patch be ok? As far as I can see all

Re: Where is the best place to report a fscanf bug found under wine-1.3.27?

somewhere in the code path A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: kernel32: Fix writing to a pipe in WriteConsoleW().

sole net.exe - C3 when running wine net.exe note that we're playing with handles, and hidding behind console handles (with lower bit sets) handles to other objects... (in fact, from your first post, there is no infinite loop as the calls are made on different objects) you can safely provide the pa

Re: kernel32: Fix writing to a pipe in WriteConsoleW().

t) is FALSE ? (similar functions as WriteConsoleA, ReadConsoleA/W should be protected the same way) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Winhelp crash in assertion(0) if .hlp file is not found

I've just sent a patch that should fix it. A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Winhelp crash in assertion(0) if .hlp file is not found

name when opening a file) can you send me (in private) the relevant .hlp files (main one and glossary.hlp) I'll have a deeper look -- Eric Pouech

Re: app freezes during WM_KILLFOCUS

On 6/16/2011 10:49 AM, Ken Thomases wrote: On Jun 16, 2011, at 9:09 AM, Eric Frias wrote: I've been chasing a bug for a few days, and finally have a good idea of what is going on. When a program brings up a modal dialog box in response to a WM_KILLFOCUS message, the program will f

app freezes during WM_KILLFOCUS

troducing any obvious errors, but I'm sure that check was in there for a reason. It's probably better to keep the application code from being executed from inside the event handler, if that's possible. Eric // winetest.cpp : Defines the entry point for t

Re: dbghelp: Implement SymEnumSourceFilesW.

unfortunately, glib doesn't provide this (yet) so, shall we ?: - embed a (simple) unicode regex lib in dbghelp - or make generic in libwine (so that the day that glib provides the right interface we can use it) - or ... libTRE seems a good choice here, with compatible license A+ -- Eric Pouech

Re: no line numbers in backtraces on Mac OS X?

umbers help > a lot in locating bogus code. > > Thank for your help, >Jörg Höhle. > > > -- -- Eric Pouech

Re: tests/msvcrt: add test for _splitpath function

uot;\\", "", ""}, > +{"\\directory\\test.txt", "", "\\directory\\", "test", > ".txt"}, > +{"\\directory\\test", "", "\\directory\\", "test", ""}, > +{"\\directory\\.txt", "", "\\directory\\", "", ".txt"}, > +{"\\directory\\", "", "\\directory\\", "", ""}, > +{"\\test.txt", "", "\\", "test", ".txt"}, > +{"\\test", "", "\\", "test", ""}, > +{"\\.txt", "", "\\", "", ".txt"}, > +{"\\", "", "\\", "", ""}, > +{"test.txt", "", "", "test", ".txt"}, > +{"test", "", "", "test", ""}, > +{".txt", "", "", "", ".txt"}, > +{"", "", "", "", ""}}; > -- > Eric Pouech >

Re: msvcrt: Don't pass NULL as __ms_va_list in printf implementation

> > You could va_copy() it to a second va_list if you need to do it twice. > va_copy is C99. Are we ready to say that is now dependant to C89 ?. A+ -- Eric Pouech

Re: gecko and native msvcrt

Le 30/04/2011 12:15, Jacek Caban a écrit : On 4/29/11 11:58 PM, Eric Pouech wrote: Le 29/04/2011 23:07, Dan Kegel a écrit : While testing a game with current gecko, I saw the error wine: Call from 0x7bc4ad90 to unimplemented function msvcrt.dll._snwprintf_s, aborting The game needed a

Re: gecko and native msvcrt

link gecko against msvcr80 or msvcr90 instead of msvcrt A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Missing backtrace when debugging a game

) you need the debug info associated with that program to go further. do you have it ? or does the exec contain FPO information (winedump could be handy here) "reading" the stack shows that calling function is at 0x3670f9 so disas 0x3670f9 might give you better info A+ -- Eric Pouech &q

Re: debugging wine itself with GDB

;s internal (shared lib vs DLL) method 1/ allows you to get access to some of the wine internals (see docs) from gdb A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: dbghelp: get rid of a couple unused variables (try 2)

Le 11/04/2011 19:07, Austin English a écrit : IMO, you should keep the variable names in comment so that we know what we're talking about: /* version = */ dwarf2_parse_u2(&ctx); or dwarf2_parse_u2(&ctx); /* version */ A+ -- Eric Pouech "The problem with designing so

Re: [PATCH2/2] winmm: PlaySound concurrency cleanup.

teEvent fails because memory is tight? > What happens in the app when waveOutClose's CreateEvent fails? > It's always tough to reason about the many error paths. > > Regards, >Jörg Höhle > > > > -- -- Eric Pouech

Re: Wine and Summer of Code 2011

On Tue, Feb 8, 2011 at 12:04 PM, Dan Kegel wrote: > > http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/faqs#mentor_apply > says projects can apply starting on Feb 28. > > In preparation, I moved the 2010 projects from > http://wiki.winehq.org/SummerOfCode > to > http://wik

Re: Wine Gecko 1.2.0 beta1

reproduce this ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry

Le 19/01/2011 13:07, Alexandre Julliard a écrit : Eric Pouech writes: you mean hardwiring the missing keys (potentially different according to terminal type) in the code? If they depend on terminal type they belong in terminfo, not in the registry. as I said, terminfo is not fully

Re: [Bug 25402] Woody Two Legs crashes with unimplemented function msvcr90.dll._wcslwr_s

s bug > #25769. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > --- You are receiving this mail because: --- > You are watching all bug changes. > > > -- -- Eric Pouech

Re: Alexandre Julliard : winedump: Try to load the PDB string table from file number 4 too.

2011/1/14 GOUJON Alexandre > On 01/13/2011 09:11 PM, Eric Pouech wrote: > >> Alexandre >> visiblement tu as un exemplaire de pdb sous la main différent de ceux que >> j'ai vu >> peux-tu me le passer (sauf si contrat spécifique CW bien sûr) >> j'ai to

Re: Alexandre Julliard : winedump: Try to load the PDB string table from file number 4 too.

ns streams dans les PDB, donc si j'en ai des différents, ca pourrait aider à trouver l'indirection (potentielle) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: [4/7] kernel32/tests: Demonstrate an input event handling peculiarity with WriteConsoleInputW.

xpect coalesce operation to happen only if coordinates are the same A+ 2011/1/11 Andrew Nguyen > --- > dlls/kernel32/tests/console.c | 165 > +++-- > 1 files changed, 159 insertions(+), 6 deletions(-) > > > > > > > -- -- Eric Pouech

Re: [PATCH 3/2] msvcrt: Implement _wcslwr_s

; + +if (!str || !len) please use the MSVCRT_CHECK_PMT as done in the other _s msvcrt's functions A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: 64-bit Notepad2 crashes

ELF 7f3aa090b000-7f3aa0c3d000 Export libwine.so.1 if you've compiled wine yourself, it's strange that libwine.so doesn't contain any dwarf information maybe you're loading another instance of libwine? A+ -- Eric Pouech "The problem

Re: wine-1.3.8 regression for the curses backend to wineconsole

paste was available for it. That backend worked fine (according to my notes) for wine-1.1.41. no need to open a PR for this it's already fixed in 1.3.9 A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Death to win9x?

On Tue, Nov 30, 2010 at 12:17 PM, Dan Kegel wrote: > I'm all for removing stuff that nobody needs anymore. I imagine there > are still a few popular older apps that will force us to keep some old > win9x behaviors around, though, so we probably won't be able > to remove the 'emulate win98' choic

Re: [PATCH] console: fix output for console handles opened with GENERIC_WRITE access

ap_access() function for the console. > > Signed-off-by: Martin Wilck > --- > server/console.c | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > > -- -- Eric Pouech

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

Le 10/11/2010 22:32, Alexandre Julliard a écrit : Eric Pouech writes: Le 10/11/2010 17:34, Alexandre Julliard a écrit : Eric Pouech writes: msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does Hence the wrappers inside msvcr90 around _itoa_s and _itow_s call

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

Le 10/11/2010 17:34, Alexandre Julliard a écrit : Eric Pouech writes: msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. Do you have an app that depends on this? no, just the current tests t

GetSystemPaletteEntries() patch

What was wrong with the patch sent in this post? http://article.gmane.org/gmane.comp.emulators.wine.devel/54403%29

Re: [PATCH 10/14] [Msvcrt*]: implemented _vc(w)printf

va_copy only exists in C99 wine requires C89 only A+ 2010/11/8 David Laight > > On Wed, Nov 03, 2010 at 10:53:55AM +0100, Alexandre Julliard wrote: > > Eric Pouech writes: > > > > > +int CDECL _vcprintf(const char* format, __ms_va_list xvalist) > > > {

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

alone, and factorize the discrepencies within msvcrt itself comments welcome A+ -- Eric Pouech

Re:

Le 07/11/2010 23:06, Greg Geldorp a écrit : From: Eric Pouech how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? Yeah, that's a bit weird. The only thing I can think of is some kind of timing issue

Strange test bot results

Hi Ge, how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot."

Re: [PATCH 10/14] [Msvcrt*]: implemented _vc(w)printf

Le 03/11/2010 10:53, Alexandre Julliard a écrit : Eric Pouech writes: +int CDECL _vcprintf(const char* format, __ms_va_list xvalist) { char buf[2048], *mem = buf; int written, resize = sizeof(buf), retval; - __ms_va_list valist; + __ms_va_list valist = xvalist; You can't c

Re: [PATCH] [Server]: fix access rights for console creation (#24792)

2010/10/27 Alexandre Julliard > > Eric Pouech writes: > > > +if (access & GENERIC_READ)access |= FILE_GENERIC_READ; > > +/* FIXME: we add FILE_READ_PROPERTIES access even in write-only > mode. > > + * As tested on Windows, this is not corr

Re: Debugging 64-bit Wine Apps with winedbg

Le 24/09/2010 05:12, Peter Urbanec a écrit : On 24/09/10 06:43, Eric Pouech wrote: sure send me the .exe+pdb (+source) I'll have a look at it Source and binaries sent to Eric in private, so that the list isn't polluted with megabytes of binaries. If anyone else is interested in

Re: [PATCH1/3] include/winternl: Add Logical Processor Information to SYSTEM_CPU_INFORMATION

ructures, but I didn't search a lot), and reverse engineering (using ntdll as a blackbox) may be of some help A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Debugging 64-bit Wine Apps with winedbg

I'm happy to provide test source code, 64-bit and 32-bit binaries and matching PDB files, if anyone is interested in looking at the issue. sure send me the .exe+pdb (+source) I'll have a look at it I only tested winedbg on 64bit with gcc A+ -- Eric Pouech "The problem

Re: Console issues in recent git

top ? - (?) Terminate process in the virtual desktop when it asks => where does this prompt come from ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: Console issues in recent git

Le 12/09/2010 00:26, Jerome Leclanche a écrit : Hi Eric, Ive been running your patch for a couple of days and I just noticed another case where it's not resetting terminal properties: - Run a program in winedbg (in my case, it was in a virtual desktop, too) - Wait for program to

Re: Console issues in recent git

Le 09/09/2010 18:13, Jerome Leclanche a écrit : Eric, When running a program with "r" in winedbg, I get: fixme:winedbg:dbg_run_debuggee Re-running current program with "\r" as args is broken Does this have anything to do with the EOL conversion issues? no, it has been

Re: Console issues in recent git

A) what's not yet fixed : - regression in EOF management A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams) diff --git a/dlls/kernel32/console.c b/dlls/kernel32/console.c index 9ac7

Re: Console issues in recent git

patchset ready that shall enable key/arrows support in bare console mode (with history bells & whistles... handy for any program with a CLI) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (

Re: Console issues in recent git

Le 02/09/2010 03:29, Jerome Leclanche a écrit : Anyone else's terminal emulators really acting up since the last git batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if there is a wine process running, until it's killed. This is probably a konsole bug, b

Re: Console issues in recent git

s yesterday, not sure what the cause is > (could be Eric's console patches, not cleaning up properly). > > To fix it, type `reset' in the offending terminal (even if you don't > see anything you type, just type reset). It will reset > all terminal attributes. > > Octavian > > > > > > -- -- Eric Pouech

Re: dbghelp: Remove unused functions?

image_private.h A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

Re: PDB files generated by Intel C++ Compiler

nd include/dbghelp.h with things like: cv_basic_types[T_64PVOID] = cv_basic_types[T_PVOID]; if it's something else, then that's another issue... A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

  1   2   3   4   5   6   7   8   9   10   >