Re: Is there a more important work?

2004-02-16 Thread Zimler Attila
Dimitrie O. Paun wrote: On Mon, 16 Feb 2004, Zimler Attila wrote: I meant to refresh only the modified part of the tree. This is what you meant too? Or if not could you explain it? Well, what I mean is when we add a new key into the regisry, we should siply add the corresponding item

Re: Is there a more important work?

2004-02-16 Thread Zimler Attila
Dimitrie O. Paun wrote: On Mon, 16 Feb 2004, Zimler Attila wrote: As previously noted in list, regedit delete patch is accepted. I think next I will try to implement regedit key rename support, and treeview refresh (on the modified part of the branch). Is it ok or there is a more important

Is there a more important work?

2004-02-16 Thread Zimler Attila
Hi List, As previously noted in list, regedit delete patch is accepted. I think next I will try to implement regedit key rename support, and treeview refresh (on the modified part of the branch). Is it ok or there is a more important work to do? Attila

Re: regedit - delete key patch

2004-02-15 Thread Zimler Attila
Dimitrie O. Paun wrote: On February 15, 2004 06:07 am, Zimler Attila wrote: +BOOL DeleteKey(HWND hwnd, HKEY hKeyRoot, LPCTSTR keyPath) +{ +BOOL result = FALSE; +LONG lRet; +HKEY hKey; + +lRet = RegOpenKeyEx(hKeyRoot, keyPath, 0, KEY_SET_VALUE, &hKey); +if (

TreeView_EditLabel

2004-02-15 Thread Zimler Attila
Hi List, I tried to implement StartKeyRename in regedit, but it seems that TreeView_EditLabel do nothing. (It seems it only returns FALSE). Why? Is it implemented? Attila

registry key delete

2004-02-15 Thread Zimler Attila
Hi List, I made a patch to delete key from registry with regedit. However the changes don't shows up until treeview is not refreshed. Could somebody help in implementing RefreshTreeView? Attila

using the FIXME macro

2004-02-14 Thread Zimler Attila
Hi List, I would like to use the FIXME macro in my piece of code. I found out that this macro is declared in "include/wine/debug" and my code compile's well, but I got an error at link time. The error message is: undefined reference to 'FIXME'. I think I should link a library to the code. But I

Re: Registry delete

2004-02-09 Thread Zimler Attila
Dimitrie O. Paun wrote: On Fri, 6 Feb 2004, Zimler Attila wrote: Hi, I tried to found out which value to use in framewnd.c to add key delete support (and rename). I found out that both key and value delete use ID_EDIT_DELETE. My question is: How can I separate the two event? Yes

Registry delete

2004-02-06 Thread Zimler Attila
Hi, I tried to found out which value to use in framewnd.c to add key delete support (and rename). I found out that both key and value delete use ID_EDIT_DELETE. My question is: How can I separate the two event? Attila

Re: New registry key adding patch

2004-02-02 Thread Zimler Attila
Dimitrie O. Paun wrote: On February 2, 2004 03:05 am, you wrote: Yes, I nee help :) It's the old problem :) what task could I start :) If I saw correctly in the list, regedit is implemented meantime :) We still need to add support for delete/rename of keys. Ok, I all will do it :) (if

Re: New registry key adding patch

2004-01-01 Thread Zimler Attila
Dimitrie O. Paun wrote: You use LoadString() to load the string (look at how we load error strings in edit.c even though there it's simple since the buffer is fixed size for now). Am I loaded correctly the string? Could you verify it for me? If yes, I will send the patch for including in the C

Re: New registry key adding patch

2004-01-01 Thread Zimler Attila
Hi, I give it a third try :) Dimitrie O. Paun wrote: On January 1, 2004 06:41 am, Zimler Attila wrote: This is working while "key name" string is not localized. After that this could introduce security bugs. Will it be localized? How to deal with situations like this? Well

Re: New registry key adding patch

2004-01-01 Thread Zimler Attila
Hi, I tried to remove objectionable codes. Here is the patch again. I used sprintf, because snprintf gives me a warning, that it is explicitly declared (stdio.h is included). This is working while "key name" string is not localized. After that this could introduce security bugs. Will it be local

Re: New registry key adding patch

2003-12-31 Thread Zimler Attila
Dimitrie O. Paun wrote: On December 31, 2003 11:18 am, Zimler Attila wrote: Cool, here are a few comments on the patch: + /* Modified by Attila ZIMLER <[EMAIL PROTECTED]> on 28th of dec 2003. + - New key adding is now supported. + */ Please don't add such stuff in the he

New registry key adding patch

2003-12-31 Thread Zimler Attila
Hi, I made the regedit program able to add new registry key (however, the key does not appear until next run of regedit in the browser tree - as I consulted it with Dimitrie, it will be handled later). The diff is made against todays cvs tree (as 2003 december 31). Attila PS: Dimitrie: what i

Re: Key exist query in registry

2003-12-30 Thread Zimler Attila
Dimitrie O. Paun wrote: I call RefreshListView() but the key doesn't appear in the list. Should we do some insert to the listview? Or this could be a bug? Hold on, are you inserting a key or a value? Values appear in the listview, keys in the treeview. I'm trying to insert a key. Sorry for

Re: Key exist query in registry

2003-12-30 Thread Zimler Attila
Dimitrie O. Paun wrote: From: Zimler Attila <[EMAIL PROTECTED]> How can I insert the newly created hKey to the keytree? (Because without this the newly created key only appears after restarting regedit:) In programs/regedit/framewnd.c, in function _CmdWndProc(), jus

Re: Key exist query in registry

2003-12-27 Thread Zimler Attila
Zimler Attila wrote: Hi List, Can somebody help me in what is the standard way to query if a key exists in the registry? I try to implement addig new key in regedit. Attila . Hi :) I received a mail which tries to explain how windows do this. Thanks for it. To make things clear - my

Key exist query in registry

2003-12-27 Thread Zimler Attila
Hi List, Can somebody help me in what is the standard way to query if a key exists in the registry? I try to implement addig new key in regedit. Attila

Using help files of windows programs

2003-12-25 Thread Zimler Attila
Hi, I have a (of course a legal) Borland C++ Builder. Could I use somehow the help files from it? (wo rebooting to windows) Attila

(Was: Frustration) Implementing write support for regedit

2003-12-24 Thread Zimler Attila
Dimitrie O. Paun wrote: In particular, there are two tasks that are quite good for someone new to the project: C.2. Write control panel applets for editing it C.8. Implement write support for regedit These are self containted, easy to understand and implement, and one of the big show stoppers

Frustration

2003-12-24 Thread Zimler Attila
Hi, I'm triing to find an error to work on. I was happy that so many people gave me hints on what should be fix. I tried to understand things but, it seems that this is to big thing for me at this moment. Could somebody assign me a little task in a bigger which (s)he is working on? And explain

Re: newbie wine developer question

2003-12-24 Thread Zimler Attila
Lionel Ulmer wrote: The DDraw code is full of FIXMEs that could be changed into TRACEs. So if the application works, no need to actually check the FIXMEs :-) Am I understanding it correctly: If the application work we can ignore fixmes? (With other words - to do some real work I need an applica

Re: newbie wine developer question

2003-12-24 Thread Zimler Attila
Mike Hearn wrote: On Tue, 2003-12-23 at 21:02, Zimler Attila wrote: fixme:xvidmode:X11DRV_XF86VM_SetCurrentMode Need to update SYSMETRICS after resizing display (now 640x480) I was going to suggest this one, but it seems a patch to remove it was already submitted by Alex a while back (but

Re: newbie wine developer question

2003-12-23 Thread Zimler Attila
Andreas Mohr wrote: Hi, On Tue, Dec 23, 2003 at 06:31:40PM +, Zimler Attila wrote: 2) I would like to fix some fixme (which I can reproduce), but I don't understand a lot of thins. (I'm new to wine, but not new to C). Could somebody help me to start involved in the developme

newbie wine developer question

2003-12-23 Thread Zimler Attila
Hi, Since I'm new in developing wine please forgive me if I ask a question that is answered earlier (I tried to search an answer for my questions, but I did not found.) 1) Should I report fixme's in bugzilla? (I guess, not, but I'm not sure). 2) I would like to fix some fixme (which I can repro