Re: winhttp: tests/server.c[new]: Add basic internal server test

2008-10-01 Thread Zac Brown
Zac Brown wrote: > Add basic internal server test. Thanks to Hans for some help. > > > > > As a note, these tests pass on XP and 2003.

Re: Praise of sorts for Wine re Softmaker Office 2008

2008-09-10 Thread Zac Brown
Dan Kegel wrote: > http://forum.ubuntuusers.de/topic/softmaker-office-2008--eine-alternative--vora/ > has a review of an office suite named Softmaker Office 2008, > available for Windows and now also Linux. The review says in part > > "Irritiert hat uns, daß die Windows-Version von Office 2008, d

Re: git still down...

2008-09-02 Thread Zac Brown
Dmitry Timoshkov wrote: > "Dan Kegel" <[EMAIL PROTECTED]> wrote: > >> $ git pull >> source.winehq.org[0: 209.46.25.134]: errno=Connection refused > > As a temporary solution I've replaced 'git://' protocol by 'http://' > in .git/config. > Should be up now anyway. I did a 'git fetch' this mornin

Crashing tests for WinHttp

2008-08-11 Thread Zac Brown
Hi all, Dan Kegel pointed out to me a couple of tests for WinHttp were reported as crashing in Wine, build 520ab5c26170 (the latest). Would the owners of machines "2000 wine-1.1.2" and "XP th" please shoot me an email. I'd like to see if I can reproduce the crash in wine. For better reference,

Re: winhttp: tests/winhttp.c: Add test for WinHttpSendRequest

2008-07-27 Thread Zac Brown
Hans Leidekker wrote: > On Friday 25 July 2008 22:13:18 Zac Brown wrote: > >> +#include >> >> #include >> #include >> +#include > > You shouldn't need these. > > -Hans > Thank you, scratch this patch AJ, I'll send another.

Re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

2008-07-18 Thread Zac Brown
James Hawkins wrote: > On Fri, Jul 18, 2008 at 9:11 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> James wrote: >>> I thought the idea was to implement winhttp and then >>> implement wininet on top of winhttp. Why are you importing wininet? >> As of January, Hans was still talking about implementing

Re: ntdll: Remove byte reversed U+3000 (CJK space) from being checked in RtlIsTextUnicode.

2008-07-18 Thread Zac Brown
Dan Kegel wrote: > Hang on, if you don't check U+3000 in the big endian > case, you probably shouldn't check it in the little endian > case, either, right? > > Well the problem is 0x0030 maps to a regular ASCII space. In order to really check this particular character in byte-reversed form it w

Re: winhttp: main.c: Add stub implementation for WinHttpGetDefaultProxyConfiguration

2008-07-10 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for WinHttpGetDefaultProxyConfiguration > > Ignore this, formatting is wrong.

Re: winhttp: tests/winhttp.c[new]: Add test for WinHttpOpenRequest

2008-07-10 Thread Zac Brown
Zac Brown wrote: > Add test for WinHttpOpenRequest. This test is modeled after > wininet/tests/http.c's InternetOpenRequest_test function. > > This is the first of many tests for getting Bug 14381 > (http://bugs.winehq.org/show_bug.cgi?id=14381) fixed with

Re: winhttp: tests/winhttp.c[new]: Add test for WinHttpOpenRequest

2008-07-10 Thread Zac Brown
Zac Brown wrote: > Add test for WinHttpOpenRequest. This test is modeled after > wininet/tests/http.c's InternetOpenRequest_test function. > > This is the first of many tests for getting Bug 14381 > (http://bugs.winehq.org/show_bug.cgi?id=14381) fixed with

Re: [RESEND]MSI:ACTION_AppSearchReg() should return backslash terminated paths - Solves bug 13838

2008-07-08 Thread Zac Brown
Massimo Del Fedele wrote: > I already verified that the patch does no harm AND solves a problem. > For me that's more than enough. > > Ciao > > Max > Can you provide proof that beyond the shadow of a doubt it will always be correct? One way to provide that proof is to write a test. -Zac

Re: [6/6] winhttp: main.c: Add stub implementation for WinHttpCloseHandle

2008-07-07 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for WinHttpCloseHandle > > ignore, forgot patch.

Re: Thoughts on implementation of winhttp.dll

2008-07-03 Thread Zac Brown
Hans Leidekker wrote: > On Wednesday 02 July 2008 23:56:51 Rob Shearman wrote: > >> How about: >> 3) Copy the networking sublayer from wininet into winhttp and build on top >> of that to implement winhttp. Reimplement wininet on top of winhttp. > > Drawback to this option is that you're going to

Re: winhttp: include/winhttp.h: Add more #define's for options

2008-07-02 Thread Zac Brown
Zac Brown wrote: > Add more #define's for options used in WinHttpOpenRequest, > WinHttpSendRequest, and WinHttp{Set/Query}Options. > > > > > --- &

Re: shell32: shellord.c: Implement SHGetNewLinkInfo[AW]. Fixes Bug 8082.

2008-07-02 Thread Zac Brown
Zac Brown wrote: > Implement SHGetNewLinkInfo[AW]. > > Fixes Bug 8082 (http://bugs.winehq.org/show_bug.cgi?id=8082) > > Changes: > * Implement SHGetNewLinkInfo[AW] > * Update tests > > > ---

Re: shell32: tests/shellord.c[new]: Add tests for SHGetNewLinkInfo[AW]

2008-07-02 Thread Zac Brown
Zac Brown wrote: > Add tests for SHGetNewLinkInfo[AW] > > Tests pass on Windows 2000, Windows XP and Windows Server 2003. > > Changes: > * Add initial tests for SHGetNewLinkInfo[AW] to shell32/tests/shellord.c > * Add shell32/tests/shellord.c > * Update s

Re: Thoughts on implementation of winhttp.dll

2008-07-02 Thread Zac Brown
Hans Leidekker wrote: > On Tuesday 01 July 2008 21:42:30 Zac Brown wrote: > >> Does anyone have thoughts on implementing parts of winhttp in terms of >> wininet? The primary issue that prevents entirely implementing winhttp in >> terms of wininet is that there is no direc

Thoughts on implementation of winhttp.dll

2008-07-01 Thread Zac Brown
Hi, I've been looking at implementing winhttp.dll. Does anyone have thoughts on implementing parts of winhttp in terms of wininet? The primary issue that prevents entirely implementing winhttp in terms of wininet is that there is no direct Win32 API for fetching an SSL certificate in winhttp.

Re: winhttp: Add IMPORTLIB line to winhttp/Makefile.in

2008-06-29 Thread Zac Brown
Zachary Brown wrote: > Add IMPORTLIB line to winhttp/Makefile.in > > > > > There are duplicates of this email. Accidentally sent it out on two accounts. Correct one should be from [EMAIL PROTECTED]

Re: [2/2] ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 7]

2008-06-26 Thread Zac Brown
Zac Brown wrote: > Add checking for control characters in both standard and byte-reversed > forms to (Rtl)IsTextUnicode. > > Changelog: > * Add if-statement to ensure we only found control characters in the > first 256 indices. If we found them beyond that, we don'

Re: context.c

2008-06-26 Thread Zac Brown
[EMAIL PROTECTED] wrote: > Has anyone looked at the changes put on the list for context.c? Just had > not heard anything.. > > I assume it is because I am new and all but still...just trying to help > per the request on the wine site =) > > > chris > ---

Re: shell32: iconcache.c: Add stub implementation for SHGetIconOverlayIndex[AW] (RESEND)

2008-06-25 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for SHGetIconOverlayIndex[AW]. > > Mentioned in Bug 7447, though it does not seem to need a full > implementation yet. Since its documented in MSDN, may as well add the > stub imple

Re: shell32: iconcache.c: Add stub implementation for SHGetIconOverlayIndex[AW]

2008-06-25 Thread Zac Brown
Zac Brown wrote: > Add stub implementation for SHGetIconOverlayIndex[AW]. > > --Zac > > > > > scratch this one.

Re: ntdll: reg.c: Fix return value of NtOpenKey when key handle is NULL

2008-06-20 Thread Zac Brown
Alexandre Julliard wrote: > Zac Brown <[EMAIL PROTECTED]> writes: > >> Could anyone give me some feedback on this patch? >> >> Talked to AJ about it pre-1.0 and he seemed to think its fine, maybe he'd >> chime >> in and let me know wha

Re: ntdll: reg.c: Fix return value of NtOpenKey when key handle is NULL

2008-06-19 Thread Zac Brown
Zac Brown wrote: > Change return value from STATUS_INVALID_PARAMETER to > STATUS_ACCESS_VIOLATION when retkey is null in NtOpenKey and remove > todo_wine from test. > > Tested on Windows XP, Windows 2000 and Windows 2003.

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 4]

2008-06-19 Thread Zac Brown
Michael Karcher wrote: > Am Donnerstag, den 19.06.2008, 12:52 -0700 schrieb Zac Brown: >> - Because these tests are mutually exclusive, a single goto label suffices >> for >> breaking the loop. > > As written, your tests are not mutually exclusive. It co

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 4]

2008-06-19 Thread Zac Brown
Zac Brown wrote: > Michael Karcher wrote: >> Am Donnerstag, den 19.06.2008, 12:52 -0700 schrieb Zac Brown: >>> - Because these tests are mutually exclusive, a single goto label suffices >>> for >>> breaking the loop. >> As written, your tests are no

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 4]

2008-06-19 Thread Zac Brown
Michael Karcher wrote: > Am Donnerstag, den 19.06.2008, 12:52 -0700 schrieb Zac Brown: >> - Because these tests are mutually exclusive, a single goto label suffices >> for >> breaking the loop. > > As written, your tests are not mutually exclusive. It co

Re: ntdll: rtlstr.c: Implement checking for control characters inRtlIsTextUnicode [try 2]

2008-06-19 Thread Zac Brown
Rolf Kalbermatter wrote: > Dan Kegel [mailto:[EMAIL PROTECTED] > >> e.g. >> >> if (flags & IS_TEXT_UNICODE_CONTROLS) >> for (i = 0; i < len; i++) >>switch (s[i]) { >>case '\t': >>case '\n': >>case 'r': >>case 0x20: >>

Re: ntdll: rtlstr.c: Implement checking for control characters in, RtlIsTextUnicode [try 3]

2008-06-19 Thread Zac Brown
Zac Brown wrote: > Implement setting of IS_TEXT_UNICODE_CONTROLS and > IS_TEXT_UNICODE_REVERSE_CONTROLS when control characters are present in > RtlIsTextUnicode. > > -Zac Brown > > > > &

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 2]

2008-06-19 Thread Zac Brown
John Klehm wrote: > On Wed, Jun 18, 2008 at 7:02 PM, Zac Brown <[EMAIL PROTECTED]> wrote: >> Implement setting of IS_TEXT_UNICODE_CONTROLS and >> IS_TEXT_UNICODE_REVERSE_CONTROLS when control characters are present >> in RtlIsTextUnicode. >> >> > > Ju

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 2]

2008-06-19 Thread Zac Brown
Dan Kegel wrote: > The array doesn't make much sense if you're not going to iterate over it. > It might be more readable if you replaced the array and long if > with a switch statement. > It would be nice to break out of the loop early. > The last two suggestions together kind of mean a goto, which

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode

2008-06-18 Thread Zac Brown
Zac Brown wrote: > Implement setting of IS_TEXT_UNICODE_CONTROLS and > IS_TEXT_UNICODE_REVERSE_CONTROLS when control characters are present > in RtlIsTextUnicode. > > > > > --- > dlls/

Re: Please have a look at the current Valgrind warnings

2008-06-08 Thread Zac Brown
Looks good... guess I know what I'll be after tomorrow ;). -Zac Dan Kegel wrote: > After a few days of cleaning up Valgrind warnings > in the Wine source tree, and adding suppressions > where it made sense. I've whittled the list of > Valgrind warnings down to 300 or so. > > This list is short e

Re: Winetest grrr...

2008-05-30 Thread Zac Brown
Ah woops, I misread the message. -Zac Juan Lang wrote: >> As a thought, did you consider just building the tests you needed via >> mingw32? > > Well, as I said, I did just build the test I needed, with MSVC. It > failed. That's why I tried winetest. > --Juan

Re: Winetest grrr...

2008-05-30 Thread Zac Brown
As a thought, did you consider just building the tests you needed via mingw32? I've found John Klehm's script (http://wiki.winehq.org/JohnKlehm at the top) to be useful for that as winetest.exe hard locks my laptop and my desktop... ewww. -Zac Juan Lang wrote: > Since my tiny little menu patch

Re: ntdll: Strengthen current tests and add new tests for asynchronous I/O.

2008-05-29 Thread Zac Brown
Woops, ignore this patch. Its got a couple things wrong with it. I'll send a fix later on. -Zac Zac Brown wrote: > Strengthen current tests and add new tests for asynchronous I/O. Missing > test for empty messages as well as thoroughly testing input and output > of read/

[Fwd: [advapi32] Correctly handle incorrect buffer sizes in LookupAccountNameA (RESEND)]

2007-12-27 Thread Zac Brown
incorrect buffer sizes in LookupAccountNameA (RESEND) Date: Fri, 21 Dec 2007 02:32:45 -0600 From: Zac Brown <[EMAIL PROTECTED]> Reply-To: wine-devel@winehq.org To: [EMAIL PROTECTED] Hi, Changelog: * Correctly handle incorrect buffer sizes in LookupAccountNameA Notes: * Fixes bug 1

Re: Anyone know how to produce a win16 pkzip self-extractor?

2007-12-24 Thread Zac Brown
Dan Kegel wrote: > On Dec 24, 2007 10:36 AM, Kevin Koltzau <[EMAIL PROTECTED]> wrote: >>> I also tried the DOS version, and that just hung (grumble). >> pkzip 2.5 for dos works fine under dosbox > > I am sick and tired of us wimping out and pointing people > to dosbox. Wine should be able to run

Re: Which is more important to Linux users, itunes or photoshop?

2007-12-24 Thread Zac Brown
Maarten Lankhorst wrote: > Hi Dan, > > Dan Kegel schreef: >> Not a real question, but I thought this graph was interesting: >> >> http://www.google.com/trends?q=dreamweaver+linux%2C+%22world+of+warcraft%22+linux%2C++itunes+linux%2C+photoshop+linux >> >> It seems iTunes on Linux is twice as popular

Re: advapi32: Fix domain length setting in LookupAccountNameW

2007-12-20 Thread Zac Brown
Zac Brown wrote: > Hi, > > Changelog: > * Fix value setting for *cchReferencedDomainName in LookupAccountNameW > * Fix LookupAccountNameA conversion from WCHAR to CHAR by setting proper '\0' > > Notes: > * This patch a

Re: shlwapi: Fix memory leak in test

2007-12-10 Thread Zac Brown
Alistair Leslie-Hughes wrote: > Hi, >Changelog: > shlwapi: Fix memory leak in test. > > Best Regards > Alistair Leslie-Hughes > > > No patch attached? -Zac

Re: Wine Weekly News

2007-12-10 Thread Zac Brown
Zachary Goldberg wrote: > I thought about it, but wasn't sure of the usefulness of such a > number. If consensus is that it would be worth having, i'll add it > for WWN 335. > > On Dec 10, 2007 3:57 PM, Jonathan Ernst <[EMAIL PROTECTED]> wrote: >> Hello, >> >> First, thank you for your work on th

Re: Valgrind support for our unit tests

2007-12-08 Thread Zac Brown
James McKenzie wrote: > Dan Kegel wrote: >> On Dec 8, 2007 9:13 AM, Robert Shearman <[EMAIL PROTECTED]> wrote: >> >>> Dan Kegel wrote: >>> + obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so >>> I'm not sure this will work for other people unless they log on as dank :-) >>>

Re: wininet: Add test for FtpGetCurrentDirectoryA

2007-12-01 Thread Zac Brown
James Hawkins wrote: > On Nov 30, 2007 3:47 PM, Zac Brown <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Changelog: >> * Add a test in dlls/wininet/tests/ftp.c for FtpGetCurrentDirectoryA >> >> Notes: >> * This test passes fully without error on Wind

Re: [Bug 10488] GIT of 16.11 Exeption becaus of VBA while analysing a text

2007-11-24 Thread Zac Brown
Zac Brown wrote: > [EMAIL PROTECTED] wrote: >> http://bugs.winehq.org/show_bug.cgi?id=10488 >> >> >> >> >> >> --- Comment #14 from Yolande Haneder <[EMAIL PROTECTED]> 2007-11-25 >> 00:30:20 --- >> Re: >> >> err:ole:S

Re: [Bug 10488] GIT of 16.11 Exeption becaus of VBA while analysing a text

2007-11-24 Thread Zac Brown
[EMAIL PROTECTED] wrote: > http://bugs.winehq.org/show_bug.cgi?id=10488 > > > > > > --- Comment #14 from Yolande Haneder <[EMAIL PROTECTED]> 2007-11-25 00:30:20 > --- > Re: > > err:ole:StdMarshalImpl_ReleaseMarshalData could not map object ID to stub > manager, oxid=370038, oid=d > err:

Disregard earlier ntdll/tests/env.c patches

2007-11-22 Thread Zac Brown
Hi, Please disregard any patches prior to the latest patch. It seems my mail server has been a little messed up. The only one to consider is the latest one that the wine-patches list has received. Thank you, Zac Brown -- Zac Brown (817-266-6867) [EMAIL PROTECTED] http://zacbrown.org