Re: make "bisected" a keyword in bugzilla?

2011-08-01 Thread Wolfram Sang
On 28/07/11 22:15, Austin English wrote: > On Sun, May 23, 2010 at 22:45, Wolfram Sang wrote: >>> Probably it would be better to add a field for commit id that caused >>> a regression just like there is one for url/keywords instead of inventing >>> new keywords. So a

Re: Ge (Greg) van Geldorp

2011-06-10 Thread Wolfram Sang
The sad news reached me two days ago that Ge (Greg) van Geldorp passed away. Please find below the mail from his brother. This is sad news indeed. The testbot he created is tremendously useful and a great achievement. He also was always helpful and nice when I asked him about it. His presenc

Re: [1/2] README: Update Linux requirements

2011-05-30 Thread Wolfram Sang
I also thought about moving 2.4.x in one context with 2.2.x, but at least no one else did so i didn't. Please do. Despite the question if it is "good enough", 2.4 is for sure not considered "current" anymore.

Re: Wine at LinuxTag 2011 - Driving a pun to far :)

2011-05-13 Thread Wolfram Sang
I'll be there as well, giving a kernel talk at 11am.

Re: clusapi: add stub for GetClusterInformation

2011-03-18 Thread Wolfram Sang
Content-Type: text/plain; charset="us-ascii"; Format="flowed" I am out of ideas if this is acceptable for wine-patches@, though:) I'd clearly say no because it obviously produces unpredictable results :) They are discouraged in kernel-space as well. Regards, Wolfram

Re: Wine and serial port AGAIN

2010-12-19 Thread Wolfram Sang
It would be very good! I'm voting even for including the 2.6.36 version into the next .36 patch (probably .36.3). The dot releases are for backported bug-fixes only. This is a new functionality, so it won't be in 2.6.36. Same for 2.6.37, which is in the stabilization phase now, usually no

Re: Wine and serial port AGAIN

2010-12-17 Thread Wolfram Sang
> OT: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0bca1b913affbd7e2fdaffee62a499659a466eb5 > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d281da7ff6f70efca0553c288bb883e8605b3862 > > This is kernel related :P Ehrm, where does that a

Re: Wine and serial port AGAIN

2010-12-17 Thread Wolfram Sang
> > It seems that the PL2303 driver doesn't implement TIOCGICOUNT > > /usr/src/linux/usb/serial/pl2303.c > > Well, no, this ioctl gets handled by the tty-layer. Yes, the driver > needs to define a get_icount-routine which it lacks. > > I think this is introduced in kernel 2.6.37 (

Re: Wine and serial port AGAIN

2010-12-17 Thread Wolfram Sang
On 17/12/10 11:21, Uwe Bonnes wrote: >> "Pavel" == Pavel Troller writes: > > Pavel> Hi! As a technician, I need often to use some form of serial > Pavel> port communication. My recent experience is with a program for > ... > Pavel> power-cycled. The radio is connected using a U

Re: [PATCH 1/4] wineaddon.cpl: Added initial Wine Add-ons Manager stub.

2010-12-06 Thread Wolfram Sang
What improvements are needed for 7zip? It seems to work fine here, I can use both the Windows and the Linux version to create self-extracting archives for Windows. That's exactly the problem of creating Windows self-extracting archives on Linux. How do you do that? Check http://www.bugaco.com/

Re: Death to win9x?

2010-12-02 Thread Wolfram Sang
The only problem is that testbot does not allow me to set an environment variable. All testbot knows are command line arguments. Well, you can use 7zip and its SFX-capabilities to do a lot more with testbot. I used this to invoke winhlp showing a specific helpfile :) For your case, you might e

Re: Stopping Win9x testing

2010-12-01 Thread Wolfram Sang
> I'll mark the Win9x VMs offline when there's nothing queued to run on them. > Then in a weeks time I can delete them after all jobs referring to them > have been retired/deleted (referential integrity in the database). That means they even won't be available then for some specific corner-case t

Re: Line Length (Was: Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2))

2010-09-28 Thread Wolfram Sang
>> It's better to use a commonly accepted 0xdeadbeef as an invalid last error >> value, and limit the line length somewhere at 80. > A line length of 80 is kinda outdated, I have talked to Alexandre and he > considers 100 a better value. I would have preferred 120 to hold for a > while. +1 \o/

Importing strchrnul() from gnulib?

2010-09-08 Thread Wolfram Sang
Hi, taking another approach at Bug 19070, I noticed that dlls/hhctrl.ocx/hhctrl.c has even more problems with commandline-handling. All three invocations of strchr() should better be strchrnul(). (Compare calling hh.exe with '-mapid' and '-mapid ' to see one difference). strchrnul ist protected by

Re: Some statistics about the 1.0->1.2 development cycle

2010-08-15 Thread Wolfram Sang
you'll have to reassign my patches to the "(None)" category. While I do Will do, of course. Also for all the other requests I get/got. for that; even my trips to the WineConfs are payed out of my own pocket. Sounds familiar ;) Regards, Wolfram

Re: Some statistics about the 1.0->1.2 development cycle

2010-08-15 Thread Wolfram Sang
But just for accuracy, I'm a frenchman. Ah, now I remember what I wanted to add to the README :) I did not change anything in the built-in country-detection which is still quite experimental, even upstream. Please just ignore it. I once thought about removing it, might do so later on. Than

Some statistics about the 1.0->1.2 development cycle

2010-08-15 Thread Wolfram Sang
Hello, I am going to speak about my "getting into wine development" at FrosCon (near Bonn/Germany) next weekend. During preparation, I was interested in some numbers, so I roughly modified 'kps' (kernel patch statistics) for wine. The outcome for the 1.0->1.2 cycle can be found here, if someb

Re: Please remove / block user from bugzilla

2010-07-16 Thread Wolfram Sang
> Very BAD: > - > Changelog: This fixes bug #4711 > > BAD: > > Changelog: Change the handling of flags X Y Z because this fixes bug #4711 > > OK: > --- > Changelog: Change a corner case in the handling of flags X Y Z (with tests). > This resolve the issue from bug #4711.

Re: Please remove / block user from bugzilla

2010-07-16 Thread Wolfram Sang
> For reference, there are two basic reasons for not referring to > bugzilla when sending patches, in the commit log or otherwise. The > first one is that patches should stand on their own. If the bug > contains important information that's relevant to the patch, that > should be included directly

Re: [PATCH] Fix EndDialog behaviour for OrCad.

2010-07-08 Thread Wolfram Sang
If you are saying they won't accept a patch because of this, I'd be tempted to say "for f**ks sake can I be bothered with such pettiness?", but I suppose "for the greater good" I'd resubmit. It is common behaviour for large scale projects, e.g. the Linux Kernel applies this rule, too. If you fr

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

2010-06-28 Thread Wolfram Sang
On 28/06/10 13:26, Alexandre Julliard wrote: > Wolfram Sang writes: > >> According to TestBot (#2851), all non-crashing Windows versions return 0. >> >> Found while working on Bug 21012. Although this patch doesn't cure this >> bug, I think it is still worth a

Re: [PATCH] user32: check for valid pointer in CURSORICON_CreateIconFromBMI

2010-06-23 Thread Wolfram Sang
On 23/06/10 15:32, Alexandre Julliard wrote: > Wolfram Sang writes: > >> @@ -884,6 +884,10 @@ static HICON CURSORICON_CreateIconFromBMI( BITMAPINFO >> *bmi, >> return 0; >> } >> >> +/* A few Windows versions crash getting NULL, b

Re: WINE and demoscene products

2010-06-12 Thread Wolfram Sang
On 12/06/10 08:37, Dan Kegel wrote: > Yeah, that's pretty cool. I ran Lifeforce as a demo at several talks > last year, it was very convincing. (Although, frankly, running Cool. > retail DVD-ROM games on day of beta or release is an even more > convincing feat if we can pull it off.) Sure thin

WINE and demoscene products

2010-06-11 Thread Wolfram Sang
Hi, demos [1] from the demoscene are pretty demanding and freely available stresstests, especially for everything 3D-related. The size-optimized productions (4KB, 64KB) might also exploit some lesser known side effects of bringing up a program. A review of running the most popular demos with wine

Re: Advice about a new project, and similarity to Wine's start

2010-06-05 Thread Wolfram Sang
> Is the AppDB software available for use on other projects? It is here and being GPL, I think you can use it :) http://source.winehq.org/git/appdb.git/ Good luck, Wolfram

Re: Voting for own bugs not allowed?

2010-05-25 Thread Wolfram Sang
> Let's disable it then, but that's no reason to close otherwise valid > bugs as invalid. Hmm, I am currently abusing the vote-system to mark bugs I am especially interested in right now. Is there any better way to do this? Searching for CC is not quite the same (but will do if needed). Regards,

Re: Voting for own bugs not allowed?

2010-05-25 Thread Wolfram Sang
> Voting for your own bug confirms it (changes status to NEW). You can not > confirm your own bugs. As simple as that. While I generally agree, the "status-changing" is an effect a number of bugzilla-users (especially new ones) are probably not aware of. Documentation helps here (on the voting-pag

Re: make "bisected" a keyword in bugzilla?

2010-05-23 Thread Wolfram Sang
> Probably it would be better to add a field for commit id that caused > a regression just like there is one for url/keywords instead of inventing > new keywords. So a 'regression' with a commit id would automatically mean > 'bisected'. That would also save time of finding the commit id by looking

Re: make "bisected" a keyword in bugzilla?

2010-05-23 Thread Wolfram Sang
Dmitry Timoshkov wrote: > Exactly. There shouldn't be not bisected bugs with the 'regression' keyword > in the first place. Just to get an idea how close the bugzilla is to the above, I tried to query the database how many bugs have 'regression' but no bisect. Alas, no success so far, even someth

Re: make "bisected" a keyword in bugzilla?

2010-05-22 Thread Wolfram Sang
>> but this isn't going to happen of course for obvious reasons (some >> reporters don't bother to respond in months). If no test was performed >>> a developer will see a report anyway, searching for a module of >> interest. > > I still think that REGRESSION != BISECTED, but i don't argue or enfor

make "bisected" a keyword in bugzilla?

2010-05-22 Thread Wolfram Sang
Hi, I noticed that Wylda uses "--private keyword: bisected" when appropriate. IMHO this could be useful as a real keyword, e.g. if you search for bugs you'd like to try tackling. Has this been considered already? Regards, Wolfram

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2010-04-26 Thread Wolfram Sang
> === W98SE (32 bit dib) === > dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, > StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, > &bmi, DIB_RGB_COLORS, SRCCOPY)] [...] > === WNT4WSSP6 (32 bit dib) === > dib.c:159: Test failed: Bitmap data not matching.

Handling of DDB in tests?

2010-04-25 Thread Wolfram Sang
Hi, while trying to deliver a testcase for Bug #14891 (Bitmaps with offset bits do not display correctly) I tried this patch: https://testbot.winehq.org/JobDetails.pl?Key=1740 Two VMs reported the correct pixel as 0x instead of 0x00ff. (The truly failed pixel would have 0x00010101 or

Re: Detecting patch sets

2010-04-13 Thread Wolfram Sang
>> you could, instead of only checking for the author, also try to check >> for the maximum amount of patches. If you find patch [Patch 1/7], I >> assume you currently wait for all 7 patches. Now if a patch 1/3 comes in >> between, you'll see that the maximum is different, in this case 3, so >> yo

Re: [PATCH] user32: honor bfOffBits in BITMAP_Load

2010-04-06 Thread Wolfram Sang
Dmitry Timoshkov wrote: > Wolfram Sang wrote: > >> +offbits = bmfh->bfOffBits - sizeof(BITMAPFILEHEADER); > >> +bits = (char *)info + (offbits ?: size); > > The purpose of offbits is not clear. It has the same purpose as 'offbits' i

Re: Winehq donation and DATA COMPRESSION

2010-01-30 Thread Wolfram Sang
> BTW I've done some cabinet.dll stuff some years ago. > Can anybody give me a hint to some easy-to-understand data compression > documentation? You mean in general? http://en.wikipedia.org/wiki/Data_Compression Should have enough links for the specific sub-topics. Regards, Wolfram

Re: Wine coding style

2010-01-25 Thread Wolfram Sang
are there any examples for Editor settings (e.g. emacs c-mode) resulting in acceptable indentation? http://wiki.winehq.org/HackingTips has some useful bits for vim. Maybe they give you an idea for emacs (so you could set up a similar page in the wiki ;)) Regards, Wolfram

Re: Patch feedback requested for OleCreatePropertyFrame()

2010-01-08 Thread Wolfram Sang
Geoffrey Hausheer wrote: > Would someone mind reviewing this for style/content? I still have no Can't say much about the content, but stylewise the pointer handling could be improved. For example, +if ( (iface==0) || (ppvObject==0) ) should at least use NULL instead of 0 as both are pointe

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Wolfram Sang
2040 | 36 | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109 0xc109 is NT_STATUS_MESSAGE_NOT_FOUND according to http://lists.samba.org/archive/jcifs/2004-February/003038.html. Interestingly, in dlls/ntdll/tests/error.c, there is already an entry for STATUS_MESSAGE_NOT_FOUND,

Re: Patch feedback requested for OleCreatePropertyFrame()

2010-01-04 Thread Wolfram Sang
task. There doesn't appear to be anything in this code that would be patent encumbered, but the code itself certainly falls under Hidenori's copyright which he has effectively revoked permission to use. Strictly speaking, this is not possible. Although IANAL, this code is LGPL, so he can't r

Re: Parser for cmd language?

2009-12-19 Thread Wolfram Sang
> We (reactos developers) toyed with the idea of spawning some of the > subprojects off in the past, so perhaps we could create a new > sourceforge project, something along the lines of FreeCMD and move the > project and revision history there. Has also relicensing such a spin-off been discussed?

Re: Wine performance improvement

2009-12-09 Thread Wolfram Sang
Stefan Dösinger wrote: Am 09.12.2009 um 09:36 schrieb 임은지: Thank you for your comments. I will cleanup the patch as you suggested and send it. Did you contact the kernel maintainers regarding the kernel side of your changes? I think including the Wine patch doesn't make sense until the kernel d

Re: Silencing RtlNtStatusToDosErrorNoTeb() a bit

2009-12-02 Thread Wolfram Sang
Hello Dmitry, thanks for your fast reply. Sorry, I might be still missing something, as I am a bit confused with some details. Dmitry Timoshkov wrote: Another solution might be to define, let's say, ERROR_WINE_FIXME for all real fixmes and convert them to ERROR_MR_MID_NOT_FOUND. If a FIXME

Silencing RtlNtStatusToDosErrorNoTeb() a bit

2009-12-01 Thread Wolfram Sang
Hi, while debugging an application (Project One, available at [1]), I noticed that wine (today's git) throws a lot of these fixmes: fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109 Looking around, I found this page[2] stating that ERROR_MR_MID_NOT_FOUND is an expected return value