On 12/11/2012 08:46 AM, Henri Verbeet wrote:
On 11 December 2012 16:05, wrote:
Cost to users:
Users with a working ALSA device "default" should experience no
drawback, only benefits. I believe this is the vast majority of users.
Users that edit their ~/.asoundrc to define other devices with
On 06/18/2012 12:07 PM, Lucas Zawacki wrote:
The bottom line is: can I add platform dependent code in joy.cpl for
this purpose? If that's not an option, do you have some other way to
do through joy.cpl or should it be registry only?
If you use generated device GUIDs that won't be as "platform dep
On 05/28/2012 12:53 PM, Lucas Zawacki wrote:
The solution I came up is in the attached patch, it's a little weird
It's not just weird it's incorrect. You shouldn't use that list or rely on
order of devices in that list.
Instead you should use get_joystick_index() to get the index. It's not
ex
Can I ask when we'll have the new forum software installed? It's been
discussed ages ago and we still using the same old crappy version.
Vitaliy.
On 04/15/2012 04:44 PM, Alexey Loukianov wrote:
With oprofile I hit another trouble - it seems that this tool is unable to
fetch symbols from libGL
Of course it won't - they are binary blobs from Nvidia. Not much to see
there. All you really looking for are time spent in that library.
Vitaliy.
On 04/09/2012 12:14 PM, Kornél Pál wrote:
I think this would work. (But don't know whether it was accepted.)
No, it won't work. Wine itself (ntdll & kernel32) accesses it.
Vitaliy.
On 04/08/2012 01:44 PM, Daniel Jelinski wrote:
Hardware messages are an alternative, but I couldn't find any relevant
examples, so I followed the path of least resistance.
These tests you wrote won't work. Emulating mouse up/down events with
anything other then hardware messages will not exercis
On 04/04/2012 12:34 PM, Henri Verbeet wrote:
On 4 April 2012 20:21, Eryk Wieliczko wrote:
I've been thinking about joining GSoC as a student this year. As an
idea I propose Raw Input, and I seek your advise. Is this topic good,
what are possible catches, etc.
I think that it might be possible t
On 03/27/2012 08:04 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
Dinput needs to talk to x11drv directly to get xi2 events. Same for
requests to clip cursor in exclusive mode. The current method of using
hooks can stay for backwards compatibility.
I'm not at all convinced
On 03/27/2012 02:29 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
If you have suggestions on how to do this differently please explain
them.
Dinput needs to talk to x11drv directly to get xi2 events. Same for requests
to clip cursor in exclusive mode. The current method of using
On 03/26/2012 08:15 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 03/26/2012 06:14 AM, Alexandre Julliard wrote:
Dmitry Timoshkov writes:
This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass
on a system without XInput2.
It will break dinput, we rely on
On 03/26/2012 06:14 AM, Alexandre Julliard wrote:
Dmitry Timoshkov writes:
This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass
on a system without XInput2.
It will break dinput, we rely on the clip rectangle being reset.
I'd say it again, dinput should not warp mouse u
On 03/24/2012 01:09 PM, Joey Yandle wrote:
Any code written for windows expects these values to
update every 15.6 ms.
Exactly. Wine's wineserver & fake kernel in form of ntoskernl can not work
with native speed by definition.
For example even earliest versions of safedisk (1.5) were really pic
On 03/24/2012 08:56 AM, Kornél Pál wrote:
On 3/22/2012 2:19 PM, Vitaliy Margolen wrote:
Since there are a plenty of ways to measure elapsed time, I don't think that
this specific way should generally be prohibited.
I'm not saying it should be prohibited. I'm saying it fixes o
On 03/21/2012 10:19 PM, Joey Yandle wrote:
It's been explained several times already that any approach to share data
between wineserver and clients is going to be rejected.
Can you point me to such an explanation? I joined wine-devel just
before posting my RFC. If this has been discussed pr
On 03/21/2012 10:19 PM, Joey Yandle wrote:
If not, can you look at the APC based patch I posted and let me know how
to make the callbacks happen with more precise timing?
Yes, that is the only possible way to do this currently in Wine. Separate
thread is a no-go. It will break some application
On 03/20/2012 03:43 AM, Jacek Caban wrote:
Hi all,
GSoC is starting this year and, if we want to have good applications, we
need to update our proposals. Usually the most attention is directed
into adding new ones, while we keep obviously bad (or just bad IMO)
proposals on the page. I'm planning
On 03/12/2012 06:11 AM, Andrew Eikum wrote:
Vitaliy,
On Sun, Mar 11, 2012 at 10:15:40AM -0600, Vitaliy Margolen wrote:
That information simply does not belong on Wine wiki. It talks about
making Jack work as Alsa sound device. This has nothing to do with
Wine in particular. Especially that he
On 03/12/2012 03:23 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 03/10/2012 09:44 AM, André Hentschel wrote:
Am 10.03.2012 17:37, schrieb Vitaliy Margolen:
On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote:
Hi,
Marked test as broken if it returns true.
+/* WoW64 return
On 03/11/2012 07:26 PM, Dan Kegel wrote:
On Sun, Mar 11, 2012 at 2:42 PM, Vitaliy Margolen
I guess it comes down to unnecessary roughness.
In what way? Telling a user if you don't comply to _our_ rules in _our_
place you will be banned is rough? You have other ideas how to stop anyone
On 03/11/2012 03:10 PM, Charles Davis wrote:
Sorry about the really long email, but I didn't want to flood your
inboxes with 5 separate responses.
On Mar 11, 2012, at 12:15 AM, Jerome Leclanche wrote:
There are a thousand bugs where I would agree with you, but Jeremy's
second post was "I don't
On 03/11/2012 12:52 PM, Dan Kegel wrote:
Vitaliy wrote:
Can you show me exactly where did I yell at him? Or where I wasn't polite enough
I think it was
http://bugs.winehq.org/show_bug.cgi?id=29922#c14
where you wrote
If that is yelling for you, then I'm definitely not understanding English...
On 03/11/2012 06:31 AM, Alex Bradbury wrote:
Recently user 'falktx' posted instructions on the Sound wiki page on
how to set up an ALSA to JACK bridge that would work with Wine. He did
this at the suggestion of aeikum:
14:45<@aeikum> okay. so it is possible to get this working correctly.
that's
First of all that me address your subject:
I really doubt Apple will ever help Wine, regardless what happens on our
bugzilla. Apple have pretty specific predisposition to open source and they
sure won't change it because of one unsuccessful bug report.
On 03/10/2012 09:33 PM, Charles Davis wro
On 03/10/2012 09:44 AM, André Hentschel wrote:
Am 10.03.2012 17:37, schrieb Vitaliy Margolen:
On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote:
Hi,
Marked test as broken if it returns true.
+/* WoW64 return TRUE with the LastError set */
+ok((!ret&& GetL
On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote:
Hi,
Marked test as broken if it returns true.
+/* WoW64 return TRUE with the LastError set */
+ok((!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER) || broken(ret),
"%d with error %d\n", ret, GetLastError());
This is inc
On 03/07/2012 01:07 PM, Daniel Oom wrote:
Hello, my name is Daniel Oom and I'm a computer science and
engineering student at Chalmers in Gothenburg, Sweden.
Welcome to Wine!
Would, for example: fix Steam's in-game overlay feature be a good goal?
Not really, as it's already working fine in most
On 03/06/2012 06:33 AM, joerg-cyril.hoe...@t-systems.com wrote:
Hi,
thank you. The 2 answers I received so far already highlight the
astonishing differences among native w7 systems:
Have you used timeBeginPeriod() in your tests? From long time ago Win NT
supported up to 10ms call back interva
On 03/04/2012 05:32 AM, Fernando Martins wrote:
the po file contains
#: winerror.mc:1541
msgid "The magazine is not present.\n"
Originally I assumed "magazine" was meant as a sort of storage since the
typical meaning of "periodical publication" would not seem to make much
sense in the context o
On 02/25/2012 05:30 AM, Robert van Herk wrote:
Try 2 fixes some blatant memory bug in the conformance test
---
Windows fopen has some fancy file modes 'T' and 'D'.
Currently, wine wrongly interprets 'T' as 't'. They should b
On 02/22/2012 09:09 AM, Aric Stewart wrote:
Hi,
I just had a very good conversation with the mediawiki people about
TranslateWiki. (http://translatewiki.net/wiki/Main_Page)
There are some snags right now but they are really interested in doing work
to accommodate us. We will see where that goes
On 02/19/2012 09:26 AM, Dan Kegel wrote:
Otherwise jqs spins.
Fixes http://bugs.winehq.org/show_bug.cgi?id=29936
+return CreateEventA(NULL, FALSE, FALSE, "Fake MemoryResourceNotification");
I don't think you want a named event here. Anonymous would be better, in
case the program will ask
On 02/16/2012 08:37 PM, Vitaliy Margolen wrote:
Fixes bug 29905.
---
Please ignore this. Didn't read the last bug comment.
Vitaliy.
Please don't! I want my window manager decide based on how I configured it
where to position new windows. And not every program open in the middle of
the screen just because it things it's the most important thing on my screen.
Vitaliy.
On 02/01/2012 11:17 AM, Marcel Hasler wrote:
2012/1/30 Marcel Hasler:
I've submitted a final patch. I don't think there's anything more I
can do to improve it.
Looks fine.
Vitaliy.
On 01/30/2012 03:08 AM, joerg-cyril.hoe...@t-systems.com wrote:
Michael Stefaniuc wrote:
But now I see basestd.h defines LONG32.
LONG32 is kinda redundant. LONG is 32bit on all Windows
versions on 16bit, 32bit and 64bit Windows.
Ah, thank you. However in our particular case, the value that
ge
On 01/29/2012 04:31 PM, Marcel Hasler wrote:
The limit 0x7fff mentioned in input.h doesn't concern the number of
iterations, just durations. I couldn't find anything on an upper limit
for 'value'. I've tested 0x7fff and it works just fine.
I'm afraid you'll have to dig up some documentation
On 01/29/2012 07:25 AM, fred wrote:
Hi Wine-Team
A old bugfix on my system
You need to fix at least these issues with your e-mail:
- One e-mail per patch.
- All patches needs to be submitted using git format-patch..
- You have to specify your full name in From: address
For more details see:
On 01/28/2012 05:56 PM, Marcel Hasler wrote:
According to the DirectX reference, IDirectInputEffect::Start accepts
INFINITE (aka -1) for the number of iterations. However, passing -1 to
Linux via input_event results in no effect being played at all. This
patch sets the number of iterations to the
On 01/29/2012 10:54 AM, Dmitry Timoshkov wrote:
Austin English wrote:
Forgot the include changes.
Forwarding it to LCMapString would be much better.
Also could we please stop adding stubs before the release? It seems every
new stub dll opens up another can of worms (or should I say bugs)
On 01/21/2012 10:07 AM, Jerome Leclanche wrote:
I think that's the point Henri was trying to make. Most of these components
are useless.
Sure, you *can* pinpoint every component down, but as Henri said, if you do
that, what's most likely to happen is you end up writing a patch.
It's probably wo
On 01/20/2012 12:45 PM, Austin English wrote:
On Fri, Jan 20, 2012 at 11:04, Dmitry Timoshkov wrote:
Henri Verbeet wrote:
On 20 January 2012 17:25, Dmitry Timoshkov wrote:
If the problem is sound related there are usually some known words in
the summary line describing the problem, why not
On 01/17/2012 09:32 AM, Aric Stewart wrote:
>
> The problem is that there is no XK keycode for just Shift, Control or Menu
> so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result the string
> XKeysymToString returns is a string with a _L or _R at the end, even if the
> "don't care" b
On 01/17/2012 11:19 AM, Lucas Zawacki wrote:
I want to get my dinput patches in before the code freeze, and besides
the ones that I tried to commit last week I have some patches touching
EnumDevicesBySemantics and ConfigureDevices, but I can't commit them
before the DIPROP_USERNAME and configurat
On 01/15/2012 01:46 PM, Stephen Chao wrote:
From my own experiences browsing most games' appdb page, everyone and their
brother (including myself) tinkers with d3d registry options.
That's exactly why those options where removed in the first place. To stop
everyone from breaking their configur
On 01/13/2012 12:05 AM, Erich E. Hoover wrote:
Real Name:
Erich Hoover
Changelog:
server: Add mechanism to store and retrieve information about a socket.
+
+/* Get and set user-accessible socket variables */
+@REQ(get_socket_variable)
+obj_handle_t handle;/* handle to t
On 01/10/2012 10:51 AM, Lucas Zawacki wrote:
2012/1/10 Vitaliy Margolen:
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote:
From: Lucas Fialho Zawacki
+static BOOL _write_private_profile_intW(const char *format, WCHAR*
section, WCHAR* key, int value, WCHAR* file)
I don't think th
On 01/09/2012 08:34 AM, Jay Yang wrote:
On 01/09/2012 09:46 AM, Vitaliy Margolen wrote:
On 01/08/2012 08:45 PM, Jay Yang wrote:
Some other issues - you will parse over parameters given to the program. Ex:
explorer /desktop=foo,800x600 program.exe /n /e
the "/desktop" command ca
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote:
From: Lucas Fialho Zawacki
You leaking FindFile handle. Need to use FindClose() to close it.
This is on top of more unchecked returns from HappAlloc.
Vitaliy.
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote:
From: Lucas Fialho Zawacki
+/* Set username in device */
+HeapFree(GetProcessHeap(), 0, This->username);
+This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) *
(lstrlenW(username) + 1));
+lstrcpyW(This->username, user
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote:
From: Lucas Fialho Zawacki
+static BOOL _write_private_profile_intW(const char *format, WCHAR* section,
WCHAR* key, int value, WCHAR* file)
I don't think this is such a good idea to mix ASCII and WCHAR parameters.
+static WCHAR path[] =
On 01/08/2012 08:45 PM, Jay Yang wrote:
Fixed some small formatting issues from last time.
Your patch strips spaces all over the place. For example:
+LPWSTR *argv;
+if(commandline[0]=='\0')
Need an empty line after variable declarations.
No space after "if". No space around equal opera
On 12/22/2011 04:45 PM, Michael Ost wrote:
Hi,
I'm seeing a SEGV crash when running any wine program with wine 1.3.24 in
gdb but not when running without the debugger. The crash is happening when
writing to memory allocated by CreateDIBSection in the function
create_alpha_bitmap(). The code is i
On 12/12/2011 04:34 PM, Scott Ritchie wrote:
Would it be appropriate to display those self-added bookmarks in Wine?
I'm worried there might be something I'm missing about the
implementation that would make this difficult or a bad idea.
It would only work with v6 controls, not the old dialogs Wi
On 12/04/2011 01:33 AM, Frédéric Delanoy wrote:
me> Could you explain what that "Sort Assigned" means?
author> I was planning on sorting the button/action mappings putting the
ones which already have an assigned mapping first, and then all the
others.
---
+AUTOCHECKBOX"Sort Assigned
On 12/01/2011 12:15 PM, André Hentschel wrote:
---
-{ "nt351", "Windows NT 3.5",3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack
2", 0, 0, "WinNT"},
+{ "nt351", "Windows NT 3.51", 3, 51, 0x421, VER_PLATFORM_WIN32_NT, "Service Pack
5", 5, 0, "WinNT"},
You need to do
On 11/27/2011 09:10 PM, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDet
On 11/27/2011 03:24 PM, Roger Cruz wrote:
Could you expand what exactly would not work?
Some copy-protection systems, and any other programs that do dlls patching
using IPC. They assume that some system dlls (namely ntdll, kernel32, and
user32) are always loaded to the same address for every sy
On 11/25/2011 04:14 AM, Jacek Caban wrote:
Hi Vitaliy,
On 11/25/11 04:17, Vitaliy Margolen wrote:
Fix QueryInterface, simplify use of AddRef, and replace
"LPDIRECTINPUTJOYCONFIG8"
with "IDirectInputJoyConfig8 *".
---
dlls/dinput/dinput_main.c | 7 ++
dlls/dinput/dinput_
On 11/24/2011 12:27 PM, Michael Stefaniuc wrote:
Hello Vitaliy,
On 11/24/2011 06:28 PM, Vitaliy Margolen wrote:
---
dlls/dinput/dinput_main.c|7 ++
dlls/dinput/dinput_private.h |2 +
dlls/dinput/joystick.c | 195 +
include/dinputd.h
On 11/19/2011 11:42 AM, André Hentschel wrote:
this catches more than one 0 after the space and possible 0s after the x
+if (/[[:space:]]0+x0*101$/) {
For more then one you should use "+" not "*". "*" means any number, including 0.
Vitaliy
On 11/16/2011 07:34 PM, Vitaliy Margolen wrote:
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable
declaration.
It's already forward declared few lines after DllMain(). So you should move
that declaration instead
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable
declaration.
It's already forward declared few lines after DllMain(). So you should move
that declaration instead.
Hm... it seems this patch already committed. Alexadre,
On 11/14/2011 04:04 AM, Francois Gouget wrote:
On Fri, 11 Nov 2011, André Hentschel wrote:
seen some "broken" project files which still worked with msvc but not with
winemaker
---
tools/winemaker |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/winemaker
On 11/06/2011 09:14 AM, Thomas Faber wrote:
+length = strlen(dll_directories[i]);
+assert(sizeof(buffer) > length + 1);
Please don't do this. Tests shouldn't assert because programmer failed to
pick the right buffer size of hard-coded strings.
+ok(GetLastError() ==
On 11/06/2011 09:30 AM, Thomas Faber wrote:
Hey,
On 2011-11-06 17:25, Vincent Povirk wrote:
I don't think you can rely on C:\Windows existing.
indeed. :)
But the function only requires valid path syntax, not a path that
actually exists.
Then you should be explicit about it with a path like "
I've got a general question about the Windows subsystem I'm a bit interested
of and considering spending some time trying to implement it. What I'm talking
about is "new" input handling API MS positions as the DirectInput successor:
XInput 1.x.
If you really want it to get in just do it via DI. Us
Few nit picks.
On 10/22/2011 02:53 PM, Lucas Fialho Zawacki wrote:
+static void _write_private_profile_intW(const char *format, WCHAR* section,
WCHAR* key, int value, WCHAR* file)
+{
+WCHAR* value_str = heap_printfW(format, value);
Here and everywhere else you not checking if memory alloca
On 10/20/2011 06:26 PM, Vitaliy Margolen wrote:
On 10/20/2011 06:18 PM, Dan Kegel wrote:
On Thu, Oct 20, 2011 at 5:15 PM, Vitaliy Margolen
wrote:
device.c:117: Test failed: GetDeviceData() should have failed: 80040207
device.c:120: Test failed: GetDeviceData() should have failed: 80040207
On 10/20/2011 06:18 PM, Dan Kegel wrote:
On Thu, Oct 20, 2011 at 5:15 PM, Vitaliy Margolen
wrote:
device.c:117: Test failed: GetDeviceData() should have failed: 80040207
device.c:120: Test failed: GetDeviceData() should have failed: 80040207
make: *** [device.ok] Error 8
Could be because of
Could be because of definition problems. Here's what I get compiling wine64:
../../../../wine.git/dlls/dinput/tests/device.c:117:5: warning: comparison
is always false due to limited range of data type
../../../../wine.git/dlls/dinput/tests/device.c:120:5: warning: comparison
is always false due
On 10/19/2011 09:49 AM, Jeremy Newman wrote:
On 10/19/2011 10:21 AM, Tijl Coosemans wrote:
The past few days there's been spam messages every few minutes and as
soon as you ban an account an other one appears. Obviously the bots have
figured out the answer to the captcha.
Alrighty then, time f
On 10/18/2011 07:37 PM, Vitaliy Margolen wrote:
So any admins actually watching and want to bad roberbdib3a on forum?
Also why aren't every moderator has these rights to block spammers, since we
have only one forum.
So no takers? I'm guessing we need more forum admins then, so more
So any admins actually watching and want to bad roberbdib3a on forum?
Also why aren't every moderator has these rights to block spammers, since we
have only one forum.
- Vitaliy
On 09/29/2011 02:11 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
The part you forgot is Linux (referring to kernel here) being the most
successful FOSS project, used on super computers, stock exchanges,
banks, etc. While Wine still in it's perpetual alpha-beta state,
limited
On 09/28/2011 11:04 AM, André Hentschel wrote:
Am 28.09.2011 15:09, schrieb Vitaliy Margolen:
On 09/28/2011 05:31 AM, Michael Stefaniuc wrote:
Vitaliy Margolen wrote:
On 09/27/2011 12:17 PM, Michael Stefaniuc wrote:
Wine is driven by wrong objectives. Most developers here don't give muc
On 09/28/2011 05:31 AM, Michael Stefaniuc wrote:
Vitaliy Margolen wrote:
On 09/27/2011 12:17 PM, Michael Stefaniuc wrote:
first place. It would be much better to see the entire conversion to
mmdevapi in a separate tree stabilized before making it's way to main tree.
Like in a develo
On 09/28/2011 04:18 AM, Alex Bradbury wrote:
Do correct me if I'm wrong here, but users who don't want regressions
in their favourite apps/games should be using the stable release. It
doesn't seem fair to complain about regressions being ignored unless
1.4 releases with a significant number of th
On 09/27/2011 12:17 PM, Michael Stefaniuc wrote:
On 09/27/2011 03:20 AM, Vitaliy Margolen wrote:
Could we please wait another week (until after the wineconf) before
doing these whole sale changes?
Please leave sound system and related winecfg code as-is.
Why?
Come to think of it this would
On 09/26/2011 09:10 AM, Andrew Eikum wrote:
On Mon, Sep 26, 2011 at 04:50:22PM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
I'm not satisfied with the removal of the audio tree from winecfg.
Beside allowing to switch or disable drivers, one key feature was to
allow inspecting the devices that
On 09/06/2011 08:46 AM, Octavian Voicu wrote:
On Tue, Sep 6, 2011 at 4:40 PM, Vitaliy Margolen
wrote:
The fix is not entirely correct. UNICODE_STRING does not have to have a
terminating \0 character. The code should not use str* functions on not
zero-terminated strings.
I was also unsure
On 09/06/2011 06:23 AM, Octavian Voicu wrote:
First one is an off-by-one error: RtlGetFullPathName_U, on success, returns
the number of bytes written, without counting the terminating NULL. The
allocated size for ntpath->Buffer didn't account for that NULL byte, so
for UNC paths the NULL byte wou
On 09/05/2011 08:59 AM, Henri Verbeet wrote:
On 4 September 2011 21:20, Vitaliy Margolen wrote:
Would you mind documenting recently added registry entries to wined3d on
Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find
description of "AlwaysOffscreen".
I upd
Henri,
Would you mind documenting recently added registry entries to wined3d on
Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find
description of "AlwaysOffscreen".
Vitaliy.
On 07/25/2011 11:54 AM, lo...@museresearch.com wrote:
- Does the development branch of WINE go through a battery of tests before
it is posted? What kind of criteria has to be met before a development
release is made available on the main page?
Each applied patch have to compile and pass all conf
On 07/22/2011 08:35 AM, Andrew Eikum wrote:
This is really crude, but does seem to work. I tested it correct with just
ALSA 1.0.24; ALSA 1.0.24's snd-pcm-oss and snd-pcm-mixer modules; and on
OSS4.2. It was also tested by Gerald Pfeifer on FreeBSD 8.2 and 9.0.
This lets us attempt to load the O
On 07/08/2011 12:01 PM, Lucas Fialho Zawacki wrote:
+memcpy(ps->wsz, This->owner, strlenW(This->owner)*sizeof(WCHAR));
You can use strcpyW instead. Or even lstrcpynW to guard against buffer overflow.
@@ -1459,10 +1469,22 @@ HRESULT WINAPI
IDirectInputDevice8WImpl_SetActionMap(LPDI
On 07/05/2011 07:20 PM, Austin Lund wrote:
+todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) +
sizeof(WCHAR), "unexpected len %u\n", len );
What is that magic number "88"? If it's a size of some structure - then
please use it explicitly.
Vitaliy.
On 07/05/2011 06:18 AM, Andrew Nguyen wrote:
---
dlls/dinput/dinput_main.c | 15 -
dlls/dinput/tests/Makefile.in |1 +
dlls/dinput/tests/dinput.c| 69 +
3 files changed, 84 insertions(+), 1 deletions(-)
create mode 100644 dlls
On 06/26/2011 08:49 AM, André Hentschel wrote:
Am 22.06.2011 06:26, schrieb Vincas Miliūnas:
+if (pDefRawInputProc&& pGetRawInputBuffer&& pGetRawInputData&&
pGetRawInputDeviceList&&
+pGetRawInputDeviceInfoA&& pGetRawInputDeviceInfoW&&
pGetRegisteredRawInputDevices&& pRegister
On 06/24/2011 11:10 PM, Lucas Zawacki wrote:
As a hello word programmer, i can't judge the code quality, but i
can say, that it worked nearly flawlessly. I was able to drive/play
on keyboard :-D
That's very nice to hear :)
The only issue i found in NFS's keyboard configuration:
* When i press
On 06/20/2011 09:36 PM, Austin Lund wrote:
On 20 June 2011 23:52, Vitaliy Margolen wrote:
+SERVER_START_REQ( create_snapshot )
You not checking if this call succeeded or not.
I've tried to include all the checks in the new patch.
+while (sizeof(
On 06/20/2011 04:06 PM, Lucas Fialho Zawacki wrote:
@@ -1391,9 +1391,24 @@ HRESULT WINAPI
IDirectInputDevice8AImpl_SetActionMap(LPDIRECTINPUTDEVICE8A iface
LPCSTR lpszUserName,
DWORD dwFlags
On 06/20/2011 08:36 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 06/20/2011 02:55 AM, Marcus Meissner wrote:
As this might be a X.org issue, should we packagers turn off
xinput2 support for the time being?
If that will fix all dinput regressions - absolutely. Or add a
registry
On 06/20/2011 02:31 PM, Austin English wrote:
On Mon, Jun 20, 2011 at 09:36, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 06/20/2011 02:55 AM, Marcus Meissner wrote:
As this might be a X.org issue, should we packagers turn off
xinput2 support for the time being?
If that will fix
On 06/20/2011 02:55 AM, Vincas Miliūnas wrote:
(see the message in the first part of the patch)
+struct raw_input
+{
+struct listentry;
+unsigned short usage_page;
+unsigned short usage;
+BOOL processed;
+BOOL retrieved;
+RAWINPUT raw;
+
+
On 06/20/2011 02:55 AM, Vincas Miliūnas wrote:
Fixed function name typo, compiler warnings, code style issues in a
fragment of new code and incorrect usage of wcslen in the tests instead
of lstrlenW after previous changes. My apologies :).
+#define DEADBEEF 0xdeadbeef
Please don't do this. J
On 06/20/2011 05:28 AM, Austin Lund wrote:
Thanks for the review. Does this patch address these concerns correctly?
No quite there yet:
+SERVER_START_REQ( create_snapshot )
You not checking if this call succeeded or not.
+while (sizeof(ULONG) + sizeof(SYSTEM_HAN
On 06/20/2011 02:55 AM, Marcus Meissner wrote:
As this might be a X.org issue, should we packagers turn off
xinput2 support for the time being?
If that will fix all dinput regressions - absolutely. Or add a registry
option to disable xinput2.
Vitaliy.
On 06/19/2011 08:15 PM, Austin Lund wrote:
[PATCH 2/4] server: Add function to count only valid handles in a process
This makes no sense. All handles are valid inside wineserver.
Vitaliy.
1 - 100 of 1269 matches
Mail list logo
