le devices? But change winealsa to use "default" device otherwise?
- Vitaliy
his is an extra bonus
and can be accomplished by disabling unwanted devices. So it's more of "nice
to have" category.
Vitaliy.
the index. It's not
exactly clear where this ID is used so I doubt returning the same ID for
different drivers will change anything
Vitaliy.
Can I ask when we'll have the new forum software installed? It's been
discussed ages ago and we still using the same old crappy version.
Vitaliy.
On 04/15/2012 04:44 PM, Alexey Loukianov wrote:
With oprofile I hit another trouble - it seems that this tool is unable to
fetch symbols from libGL
Of course it won't - they are binary blobs from Nvidia. Not much to see
there. All you really looking for are time spent in that library.
Vitaliy.
On 04/09/2012 12:14 PM, Kornél Pál wrote:
I think this would work. (But don't know whether it was accepted.)
No, it won't work. Wine itself (ntdll & kernel32) accesses it.
Vitaliy.
s will not exercise the entire chain.
For example search for "mouse_event" or SendInput.
Vitaliy.
t has to heavily interact with wine server. And any changes there
are hard to get right and eventually accepted.
So, if you have an idea of how you want to do it. And this idea is good
enough to go in - that's fine. But be ready to completely redesign & re-code
some pieces if design won't be accepted.
Vitaliy.
On 03/27/2012 08:04 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
Dinput needs to talk to x11drv directly to get xi2 events. Same for
requests to clip cursor in exclusive mode. The current method of using
hooks can stay for backwards compatibility.
I'm not at all convinced
On 03/27/2012 02:29 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
If you have suggestions on how to do this differently please explain
them.
Dinput needs to talk to x11drv directly to get xi2 events. Same for requests
to clip cursor in exclusive mode. The current method of using
On 03/26/2012 08:15 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 03/26/2012 06:14 AM, Alexandre Julliard wrote:
Dmitry Timoshkov writes:
This patch makes dlls/user32/input.c and dlls/user32/monitor.c tests pass
on a system without XInput2.
It will break dinput, we rely on
mouse under any circumstances.
Also, there is such a thing as non-exclusive background mode.
Vitaliy.
uld".
Of course this is all based on research I did 5 years ago. But surprisingly
enough those old Safedisk versions still work, assuming you have supported
gcc version, and few other requirements.
Vitaliy
On 03/24/2012 08:56 AM, Kornél Pál wrote:
On 3/22/2012 2:19 PM, Vitaliy Margolen wrote:
Since there are a plenty of ways to measure elapsed time, I don't think that
this specific way should generally be prohibited.
I'm not saying it should be prohibited. I'm saying it fixes o
e of those time
intervals are really tight.
-Vitaliy
applications. And no, there is no way
to make it more accurate. See other posts about this topic "CreateTimerQueue".
- Vitaliy.
nds on how to look at it:
1. Not directly helping Wine but along the same lines as Windows' wined3d.
2. Needs some tricky functions implemented.
3. Needs a way to build and incorporate win-pe wine dlls into Wine. This is
a tough one but helps some some applications as well.
Vitaliy.
system
joystick calibration" is though. Is it related to bug 24235 ?
You got it! That's the bug I was talking about.
There are other smaller things in dinput to fix of course:
- Fix forcefeedback (multiple bugs).
- Create helper thread on demand not at the same time as DInput (bug 21403).
-Vitaliy
On 03/12/2012 06:11 AM, Andrew Eikum wrote:
Vitaliy,
On Sun, Mar 11, 2012 at 10:15:40AM -0600, Vitaliy Margolen wrote:
That information simply does not belong on Wine wiki. It talks about
making Jack work as Alsa sound device. This has nothing to do with
Wine in particular. Especially that he
On 03/12/2012 03:23 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 03/10/2012 09:44 AM, André Hentschel wrote:
Am 10.03.2012 17:37, schrieb Vitaliy Margolen:
On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote:
Hi,
Marked test as broken if it returns true.
+/* WoW64 return
On 03/11/2012 07:26 PM, Dan Kegel wrote:
On Sun, Mar 11, 2012 at 2:42 PM, Vitaliy Margolen
I guess it comes down to unnecessary roughness.
In what way? Telling a user if you don't comply to _our_ rules in _our_
place you will be banned is rough? You have other ideas how to stop anyone
s "I don't plan on submitting patches to you frequently
enough to make it worth my time to read your policies and subscribe to
your lists.". That's not "trying to help", it's self-entitled
behaviour.
True. But my original point--that Vitaliy was unnecessaril
On 03/11/2012 12:52 PM, Dan Kegel wrote:
Vitaliy wrote:
Can you show me exactly where did I yell at him? Or where I wasn't polite enough
I think it was
http://bugs.winehq.org/show_bug.cgi?id=29922#c14
where you wrote
If that is yelling for you, then I'm definitely not understandi
orking correctly.
that's good to know
14:46< falktx> I can make a small package with my setup scripts
14:47<@aeikum> that might be handy to put up on the sound wiki page
http://wiki.winehq.org/Sound
If you look at the page edit history, you'll see the content has been
reverted
y Objective-C headers. He
was convinced that there could have been breakage, however. You--AJ, I'm
talking to you in particular--did not adequately explain to him why this
didn't break the build. Instead, you--Vitaliy in particular--practically
yelled at him--for trying to help! By this poi
On 03/10/2012 09:44 AM, André Hentschel wrote:
Am 10.03.2012 17:37, schrieb Vitaliy Margolen:
On 03/10/2012 12:36 AM, Alistair Leslie-Hughes wrote:
Hi,
Marked test as broken if it returns true.
+/* WoW64 return TRUE with the LastError set */
+ok((!ret&& GetL
rror());
This is incorrect. You can check or report result of GetLastError(). But not
both at the same time. You have to store the result in additional variable.
Then compare and report it.
Vitaliy
working fine in most cases. You just need a
"proper" version of gcc to compile Wine with.
You can find few ideas on what to do on GSOC Wiki page:
http://wiki.winehq.org/SummerOfCode
Vitaliy.
intervals, but only guaranteed if you set
time "precision" with timeBeginPeriod() to less then or equal to your period.
Vitaliy
s error.
Google only points to all sorts of malware when asked about this error code.
Vitaliy
don't flush to
disk if possible)");
+ break;
So what actually prevents you from properly implementing this? Especially
that Wine already supports temporary files. Search for MSVCRT__O_TEMPORARY
Vitaliy.
easier integration with translation sites?
Just my 2c.
Vitaliy.
rogram will ask for another event.
Vitaliy.
On 02/16/2012 08:37 PM, Vitaliy Margolen wrote:
Fixes bug 29905.
---
Please ignore this. Didn't read the last bug comment.
Vitaliy.
Please don't! I want my window manager decide based on how I configured it
where to position new windows. And not every program open in the middle of
the screen just because it things it's the most important thing on my screen.
Vitaliy.
On 02/01/2012 11:17 AM, Marcel Hasler wrote:
2012/1/30 Marcel Hasler:
I've submitted a final patch. I don't think there's anything more I
can do to improve it.
Looks fine.
Vitaliy.
getbuf_last is derived from is UINT32, not UINT, so for symmetry,
I still recommend the explicit LONG32.
UINT is the same as UNIT32:
basetsd.h:84 typedef unsigned int UINT32, *PUINT32;
windef.h:213 typedef unsigned intUINT, *PUINT;
Vitaliy.
aid you'll have to dig up some documentation about what is the max
value here is then. The fact that it works doesn't mean it's correct.
Vitaliy.
: http://wiki.winehq.org/SubmittingPatches
Vitaliy.
exceed 0x7fff as a maximum value.
Please don't make code "easier to read" by adding needless if / else. Your
first patch was fine.
Vitaliy.
). If we
looking to stabilize Wine it's sure is the wrong way to do it.
- Vitaliy
by bug subject - in most cases it's not accurate enough or
outright misleading. Same for the content, logs, etc.
Vitaliy.
o begin with I propose to create following components:
unknown-browser
unknown-core
unknown-d3d
unknown-gui
unknown-input
unknown-printing
unknown-sound
Probably forgot a few.
For triagers reassign bugs to area that looks close to the problem, unless
exact issue is known. For SMEs (Subject Matter Experts) to look through bugs
in their general area and reassign to more appropriate component.
Vitaliy.
if (nSize > idx - name)
lpBuffer[idx - name] = 0;
}
Of course need to account for rc.
Vitaliy
f). And enlarge that buffer if needed. So the next call will use
the new bigger buffer. This is not speed critical so should be fine with
heap buffer. Unless of course someone else have some objections.
* I'll drop the _ in front the functions from now on. Should I send
patches to remove it in the other functions that already use it?
Yes please, but it can wait.
Vitaliy.
ixed.
PS. If you finding yourself needed to add all your custom settings back -
save them as a .reg file. Then import it in one go using regedit.
Vitaliy.
stead of struct for
a storage. And drop size checks.
One more thing, keep in mind that time_t is not unsigned int. But long.
Vitaliy.
On 01/10/2012 10:51 AM, Lucas Zawacki wrote:
2012/1/10 Vitaliy Margolen:
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote:
From: Lucas Fialho Zawacki
+static BOOL _write_private_profile_intW(const char *format, WCHAR*
section, WCHAR* key, int value, WCHAR* file)
I don't think th
On 01/09/2012 08:34 AM, Jay Yang wrote:
On 01/09/2012 09:46 AM, Vitaliy Margolen wrote:
On 01/08/2012 08:45 PM, Jay Yang wrote:
Some other issues - you will parse over parameters given to the program. Ex:
explorer /desktop=foo,800x600 program.exe /n /e
the "/desktop" command ca
On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote:
From: Lucas Fialho Zawacki
You leaking FindFile handle. Need to use FindClose() to close it.
This is on top of more unchecked returns from HappAlloc.
Vitaliy.
;username, username);
No error checking if allocation fails.
+
+/* Free username */
+HeapFree(GetProcessHeap(), 0, This->username);
+
Comment is kind of redundant the property already called "username".
Vitaliy.
e,&didev);
No error checking.
+va_start(args, format);
+while (1)
+{
+buffer = HeapAlloc(GetProcessHeap(), 0, size);
+if (buffer == NULL)
+break;
+n = vsnprintfW(buffer, size, formatW, args);
+if (n == -1)
+ size *= 2;
+else if (n>= size)
+size = n + 1;
+else
+break;
+HeapFree(GetProcessHeap(), 0, buffer);
+}
+va_end(args);
You can't do this. It seems to be you have not tested it with initial buffer
too small. You have to do va_start & va_end every time you pass "args" to
another function.
+
+if (buffer == NULL) return NULL;
+ret = HeapReAlloc(GetProcessHeap(), 0, buffer,
sizeof(WCHAR)*(strlenW(buffer)+1) );
+if (ret == NULL) ret = buffer;
Why reallocate? It's pointless.
+extern WCHAR* _get_mapping_path(const WCHAR *device, const WCHAR *username)
DECLSPEC_HIDDEN;
Would you please drop leading underscore from all of your function names?
Vitaliy.
27;);
+LPWSTR next;
+if(end==NULL)
+next=(end=strchrW(curr,'\0'));
+else
+next=end+1;
...
+curr=next;
You end up parsing something like this as a valid param:
/n,/e,/select,c:\\
Vitaliy.
de is in user32/cursoricon.c.
This is not a crash, this is the way it supposed to work. At least until DIB
is finished and this hack isn't needed.
Wine uses this trick to detect when DIB memory needs to be synchronized with
the X server.
Vitaliy.
ld dialogs Wine currently
have. There is no place to add such bookmarks.
Vitaliy.
HECKBOX"Sort Assigned Mappings", IDC_CHECKBOXSORT, 120, 215, 90, 8
A better way of saying this would be "Show assigned first".
Vitaliy.
M_WIN32_NT, "Service Pack
5", 5, 0, "WinNT"},
You need to do the same in ntdll/version.c
Vitaliy.
t bot?
Vitaliy.
system process.
It was initially added to support SafeDisk copy protection. Now it's hard to
tell what other programs might depend on this.
If you do not have prelink, Wine will not be able to load these DLLs at the
same address and some programs will fail in mysterious ways.
-Vitaliy
On 11/25/2011 04:14 AM, Jacek Caban wrote:
Hi Vitaliy,
On 11/25/11 04:17, Vitaliy Margolen wrote:
Fix QueryInterface, simplify use of AddRef, and replace
"LPDIRECTINPUTJOYCONFIG8"
with "IDirectInputJoyConfig8 *".
---
dlls/dinput/dinput_main.c | 7 ++
dlls/dinput/dinput_
On 11/24/2011 12:27 PM, Michael Stefaniuc wrote:
Hello Vitaliy,
On 11/24/2011 06:28 PM, Vitaliy Margolen wrote:
---
dlls/dinput/dinput_main.c|7 ++
dlls/dinput/dinput_private.h |2 +
dlls/dinput/joystick.c | 195 +
include/dinputd.h
On 11/19/2011 11:42 AM, André Hentschel wrote:
this catches more than one 0 after the space and possible 0s after the x
+if (/[[:space:]]0+x0*101$/) {
For more then one you should use "+" not "*". "*" means any number, including 0.
Vitaliy
On 11/16/2011 07:34 PM, Vitaliy Margolen wrote:
On 11/16/2011 08:31 AM, Francois Gouget wrote:
---
I moved DllMain() to the end of the file so it comes after the variable
declaration.
It's already forward declared few lines after DllMain(). So you should move
that declaration instead
xadre, would you please give
people at least 24 hours to review all patches sent to wine-patches before
committing them?
Vitaliy.
e:]]0x0101$/) {
+if (/0x.*101$/) {
The various .* worry me a bit. Would something like [0-9a-fA-F]* be
permissive enough?
I think he was trying to match "x" too. At a very minimum the match needs to
be less greedy (.*?).
Vitaliy.
, i,
wine_dbgstr_w(buffer));
+break;
+}
Same for this.
+ok(buffer[0] == 0 || /* XP, 2003 */
+ buffer[0] == 'A', "i=%d, Buffer overflow\n", i);
Please mark bad case with broke() to check for correct Wine behavior.
Also please combine A & W tests. They do mostly the same things.
Vitaliy.
like "c:\Some\Valid\Path".
Then people won't have questions.
Vitaliy.
face. And another 5 to get it fixed.
Vitaliy.
ning?
+IDirectInputDevice_GetDeviceInfo(&This->IDirectInputDevice8W_iface,
&didevi);
You should use IDirectInputDevice8W_from_impl() function instead of directly
accessing internals.
+memcpy(username, find_data.cFileName, (end -
find_data.cFileName + 1) * sizeof(WCHAR));
No checking for big enough buffer. Assuming that file names are in specified
format.
Also I'm not exactly sure why do you need a mapping user name anyway? Wine
does not support multiple users. The user currently running Wine would be
the one created all the files. All this seems to be redundant.
Vitaliy.
On 10/20/2011 06:26 PM, Vitaliy Margolen wrote:
On 10/20/2011 06:18 PM, Dan Kegel wrote:
On Thu, Oct 20, 2011 at 5:15 PM, Vitaliy Margolen
wrote:
device.c:117: Test failed: GetDeviceData() should have failed: 80040207
device.c:120: Test failed: GetDeviceData() should have failed: 80040207
On 10/20/2011 06:18 PM, Dan Kegel wrote:
On Thu, Oct 20, 2011 at 5:15 PM, Vitaliy Margolen
wrote:
device.c:117: Test failed: GetDeviceData() should have failed: 80040207
device.c:120: Test failed: GetDeviceData() should have failed: 80040207
make: *** [device.ok] Error 8
Could be because of
ts in PSDK (and
remove that last L) I'd say ignore this.
Vitaliy.
On 10/20/2011 09:46 AM, Dan Kegel wrote:
Hi Vitaliy,
could you check on win64? I had a test failure there with your patch.
- Dan
On Thu, Oct 20, 2011 at 7:49 AM, wrote:
This is an experimental automated build and test service.
time for me to change the question... Done!
The new question is:
What operating system does Wine run applications from?
Should be obvious for a human.
Hope that won't upset users of other well known OS .
Any ETA on the new version of PHPBB?
Vitaliy.
On 10/18/2011 07:37 PM, Vitaliy Margolen wrote:
So any admins actually watching and want to bad roberbdib3a on forum?
Also why aren't every moderator has these rights to block spammers, since we
have only one forum.
So no takers? I'm guessing we need more forum admins then, so more
So any admins actually watching and want to bad roberbdib3a on forum?
Also why aren't every moderator has these rights to block spammers, since we
have only one forum.
- Vitaliy
On 09/29/2011 02:11 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
The part you forgot is Linux (referring to kernel here) being the most
successful FOSS project, used on super computers, stock exchanges,
banks, etc. While Wine still in it's perpetual alpha-beta state,
limited
On 09/28/2011 11:04 AM, André Hentschel wrote:
Am 28.09.2011 15:09, schrieb Vitaliy Margolen:
On 09/28/2011 05:31 AM, Michael Stefaniuc wrote:
Vitaliy Margolen wrote:
On 09/27/2011 12:17 PM, Michael Stefaniuc wrote:
Wine is driven by wrong objectives. Most developers here don't give muc
On 09/28/2011 05:31 AM, Michael Stefaniuc wrote:
Vitaliy Margolen wrote:
On 09/27/2011 12:17 PM, Michael Stefaniuc wrote:
first place. It would be much better to see the entire conversion to
mmdevapi in a separate tree stabilized before making it's way to main tree.
Like in a develo
,
everywhere (forum, bugzilla, irc) we tell users to upgrade to latest
development version, because we not going to fix any bugs in old "stable"
versions.
-Vitaliy
On 09/27/2011 12:17 PM, Michael Stefaniuc wrote:
On 09/27/2011 03:20 AM, Vitaliy Margolen wrote:
Could we please wait another week (until after the wineconf) before
doing these whole sale changes?
Please leave sound system and related winecfg code as-is.
Why?
Come to think of it this would
n functionality back
in, though.
Andrew
Could we please wait another week (until after the wineconf) before doing
these whole sale changes?
Please leave sound system and related winecfg code as-is.
Vitaliy.
On 09/06/2011 08:46 AM, Octavian Voicu wrote:
On Tue, Sep 6, 2011 at 4:40 PM, Vitaliy Margolen
wrote:
The fix is not entirely correct. UNICODE_STRING does not have to have a
terminating \0 character. The code should not use str* functions on not
zero-terminated strings.
I was also unsure
tions on not
zero-terminated strings.
Vitaliy
On 09/05/2011 08:59 AM, Henri Verbeet wrote:
On 4 September 2011 21:20, Vitaliy Margolen wrote:
Would you mind documenting recently added registry entries to wined3d on
Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find
description of "AlwaysOffscreen".
I upd
Henri,
Would you mind documenting recently added registry entries to wined3d on
Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find
description of "AlwaysOffscreen".
Vitaliy.
ature in that respect?
Yes. Current development version should be able to run majority of simple
64-bit applications. And some big 64-bit applications with some issues.
Vitaliy.
rivers and make them fail, unless explicitly asked for.
Vitaliy.
ActionMap(LPDIRECTINPUTDEVICE8W iface
LPCWSTR lpszUserName,
DWORD dwFlags)
You need to modify ascii version of SetActionMap as well.
Vitaliy.
On 07/05/2011 07:20 PM, Austin Lund wrote:
+todo_wine ok( len>= sizeof(UNICODE_STRING) + 88 + sizeof(type_event) +
sizeof(WCHAR), "unexpected len %u\n", len );
What is that magic number "88"? If it's a size of some structure - then
please use it explicitly.
Vitaliy.
dlls/dinput/tests/dinput.c
Patches look good to me.
Vitaliy.
depend on each other there should
be a comment.
the rest of that patch looks fine to me
I don't see a point here. It's all or nothing. There is only one raw input
version, that is implemented starting from WinXP. All those functions are
required.
Vitaliy.
wine. Attached are two dumps of
the keyboard objects with builtin and native dinput for comparison.
This is not related to data format. But auto-generated events in x11drv to
turn on/off num/lock. Apparently native dinput has a mechanism to ignore
these events.
Vitaliy.
On 06/20/2011 09:36 PM, Austin Lund wrote:
On 20 June 2011 23:52, Vitaliy Margolen wrote:
+SERVER_START_REQ( create_snapshot )
You not checking if this call succeeded or not.
I've tried to include all the checks in the new patch.
+while (sizeof(
consistent with spacing around parentheses - either put
spaces on both sides, or don't put at all.
+memset(&dp,0,sizeof(dp));
Please don't needlessly zero structures. You setting most values of it
anyway. And please don't forget spaces after comas.
Otherwise looks really good!
Vitaliy.
On 06/20/2011 08:36 AM, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 06/20/2011 02:55 AM, Marcus Meissner wrote:
As this might be a X.org issue, should we packagers turn off
xinput2 support for the time being?
If that will fix all dinput regressions - absolutely. Or add a
registry
On 06/20/2011 02:31 PM, Austin English wrote:
On Mon, Jun 20, 2011 at 09:36, Alexandre Julliard wrote:
Vitaliy Margolen writes:
On 06/20/2011 02:55 AM, Marcus Meissner wrote:
As this might be a X.org issue, should we packagers turn off
xinput2 support for the time being?
If that will fix
uffer (an array of fixed size with head and
tail pointers) instead of a list here.
Vitaliy.
to more GetLastError outside of ok() function call. See
other tests as example.
+static BOOL get_raw_input_data_wnd_proc_was_called = FALSE;
Static variables automatically set to 0 at the start. You don't need to do
it explicitly.
Vitaliy.
Also why do you need to zero allocated memory if
you assigning all of it valid values?
Vitaliy.
On 06/20/2011 02:55 AM, Marcus Meissner wrote:
As this might be a X.org issue, should we packagers turn off
xinput2 support for the time being?
If that will fix all dinput regressions - absolutely. Or add a registry
option to disable xinput2.
Vitaliy.
1 - 100 of 1277 matches
Mail list logo
