Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

2012-07-08 Thread Ulrik Dickow
On 24-06-2012 23:55, Ulrik Dickow wrote: > This resolves bug #26226. Should be corrected to read something like "This resolves bug #26226 for some, but not all applications", as noted in my comment on http://bugs.winehq.org/show_bug.cgi?id=26226 a few minutes ago. (I should proba

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

2012-06-24 Thread Ulrik Dickow
Hello again Nikolay and others, I'm back online. The first attachment is try 2 of the second patch, i.e. the one discussed in this thread. I hope it meets all of your concerns. I adjusted my plan slightly at this point: Den 12-06-2012 13:55, Ulrik Dickow skrev: > Den 12-06-2012 13:21,

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

2012-06-13 Thread Ulrik Dickow
I'll return to this patch -- merge, apply requested changes, test again -- a week from now. I'm unfortunately occupied elsewhere in the mean time. Thank you for your patience and quick & useful replies. - Ulrik

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-13 Thread Ulrik Dickow
document versions (CLSIDs) than before, it was necessary to change the Subject of the patch. How do I make sure that the old patch changes status to Superseded on http://source.winehq.org/patches/ ? E.g. use the old subject with "(try 2)" added in the E-mail header, but the new Subject

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.

2012-06-12 Thread Ulrik Dickow
Den 12-06-2012 13:21, Nikolay Sivov skrev: > On 6/12/2012 11:55, Ulrik Dickow wrote: >> Patch 2 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . >> >> >> > >> +/* Emit appropriate fixme or warning in case of unsupported or invalid >> namesp

Re: [1/2] msxml3/tests: Reduce code duplication for the namespace change tests.

2012-06-12 Thread Ulrik Dickow
Den 12-06-2012 13:11, Nikolay Sivov skrev: > On 6/12/2012 11:52, Ulrik Dickow wrote: >> +/* create on element and try to alter namespace after that */ >> +doc = (doc_version == 0 ? >> + create_document(&IID_IXMLDOMDocument) : >> +