eally relevant with showing how the
function itself should work, so removing it will be fine (I'll be
sending a patch shortly removing it).
Thanks for pointing this issue out.
--
Thomas Mullaly
thomas.mull...@gmail.com
e don't mix CoTaskMemAlloc functions with HeapFree
functions.
--
Thomas Mullaly
thomas.mull...@gmail.com
Hi Gerald,
On Tue, Nov 2, 2010 at 6:51 PM, Gerald Pfeifer wrote:
> Hi Thomas,
>
> the following change of yours
>
> commit bced2e21dbc548ef9d41e3ff11384d7ad964c929
> Author: Thomas Mullaly
> Date: Sat Oct 9 11:02:17 2010 -0400
>
> urlmon: Implemented base cas
il the todo's were removed. So I decided
(since removing the todo's just by themselves resulted in a lot of changes)
to keep this patch separate from the 5/7 patch. Of course, if it's
preferred, I can always merge the changes into patch 5/7 and resubmit this
set.
--
Thomas Mullaly
thomas.mull...@gmail.com
y assistance. The job has been in the "running" state for 24+
hours already, without any progress being made.
--
Thomas Mullaly
thomas.mull...@gmail.com
#x27;t have anything to do
with the quality of the code in the patch ;-) ).
Anyways, I'm hoping that somebody in charge of the test bot might be able to
fix the traffic jam it's causing.
[1] https://testbot.winehq.org/JobDetails.pl?Key=4570
<https://testbot.winehq.org/JobDetails.pl?Key=4570>
--
Thomas Mullaly
thomas.mull...@gmail.com
35"; on uri_test[60].
> uri.c:2856: Test failed: Error: Expected a length of 23 but got 20 on
> uri_tests[60].str_props[2].
>
There seems to subtle differences between the implementations of CreateUri,
since these tests only failed on machines with IE7 installed and passed on
the machines with IE8 installed...
--
Thomas Mullaly
thomas.mull...@gmail.com
On Wed, Jul 28, 2010 at 8:14 AM, Alexandre Julliard wrote:
> Thomas Mullaly writes:
>
> > ---
> > dlls/urlmon/uri.c | 88
> > +++-
> > 1 files changed, 86 insertions(+), 2 deletions(-)
>
> It doesn't wo
'll submit a new patch here shortly.
--
Thomas Mullaly
thomas.mull...@gmail.com
Hi Jacek,
Test
should be integrated with Wine tests. See dlls/shlwapi/tests/url.c
and dlls/wininet/tests/url.c for an idea of how it should be done.
Thank you, shlwapi's url test was very helpful and has given me some
good ideas for testing.
If
you have specific questions, feel free to ask he
>
> In general, the idea looks right, that's how it probably should be
> implemented. This is an implementation detail through. The bigger and
> more important problem is URI parsing and canonicalization. That's where
> most of work needs to be done. In this case tests will be also very
> importan
You could use dynamic array for that or a list with a Uri_PROPERTY
value as a key for example and a data as an offset and length. Another
way is to compute each property offset only when it's requested and
store it. An obvious bad case for that is a long uri. So probably one
pass property com
Hi, my name is Thomas Mullaly and I am a undergraduate in the Computer
Science department at Kent State University and I would very much like
to participate in this years GSoC. I saw under your project ideas page
that the IUri API still needs implemented and I thought that this would
be a good
13 matches
Mail list logo
