Re: server: Always redraw children when parent's pos/size changed in any way (Try 2).

2013-05-08 Thread Sergey Guralnik
On 2013-05-06 13:24, Sergey Guralnik wrote: Alexandre Julliard writes: ... It doesn't make sense to have all these complicated tests if we are going to always repaint anyway, which is essentially what your patch does. There has to be more to it than that. This version uses the same log

Re: riched20: Fix richtext copy/paste to OOffice.

2013-04-29 Thread Sergey Guralnik
On 2013-04-30 9:25, Nikolay Sivov wrote: On 4/30/2013 10:20, Sergey Guralnik wrote: When copying cyrillic text from wordpad (or any richedit) to Open Office document I get unreadable text. It seems like some another codepage was used to display text. This path solves this problem. --- dlls

Re: server: Map update region to children even if window just moved.

2013-04-29 Thread Sergey Guralnik
On 2013-04-25 16:06, Sergey Guralnik wrote: --- dlls/user32/tests/win.c |1 - server/window.c |5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) Is something wrong with this one? -- Sergey

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 5).

2013-04-12 Thread Sergey Guralnik
On 2013-04-10 14:28, Sergey Guralnik wrote: It's better, but testing the message sequence doesn't seem very useful, particularly since you don't differentiate parent and child messages. Also you should test the region before the move to show that it's the move that'

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().

2013-04-08 Thread Sergey Guralnik
On 2013-04-04 15:19, Sergey Guralnik wrote: Playing with one application, that uses extrac32.exe, I've found that Wine's extrac32 can't process some command lines, that cause no problem with native one. ... Is this patch or explanation not clear enough? (Still marked as "New") -- Sergey

Re: extrac32: Preprocess command line before passing to CommandLineToArgvW().

2013-04-04 Thread Sergey Guralnik
On 2013-04-04 15:19, Sergey Guralnik wrote: Playing with one application, that uses extrac32.exe, I've found that Wine's extrac32 can't process some command lines, that cause no problem with native one. ... There are two ways to solve this promlem: - write own parser for extrac32,

Re: [PATCH 1/3] extrac32: Implement more strict command line processing.

2013-03-28 Thread Sergey Guralnik
On 2013-03-26 10:17, Sergey Guralnik wrote: Is some problem with this series? -- Sergey

Re: user32/tests: SetWindowPos() propagates update region from WS_CLIPCHILDREN child to its children (try 3).

2013-03-06 Thread Sergey Guralnik
On 2013-03-04 10:39, Sergey Guralnik wrote: This patch demonstrates the most interest case from previous versions. When SetWindowPos() moves child window, that has some invalid area, it also invalidates children of this window according to its update region, even if moved window has

Re: user32/tests: Test invalidating during SetWindowPos() (resend).

2013-02-24 Thread Sergey Guralnik
On 2013-02-21 15:44, Sergey Guralnik wrote: This patch marked as "Pending" without any comment at wine-devel. Is something wrong with it? (Maybe there should be more test cases?) -- Sergey

Re: [PATCH] Support a protection scheme which reset the GS selector - v2

2013-02-08 Thread Sergey Guralnik
On 2013-02-07 17:00, Alessandro Pignotti wrote: +opcode=(unsigned char*)context->Eip; +if (*opcode==0x65 && /* GS segment instruction prefix */ +context->SegGs!=ntdll_get_thread_data()->gs) Segment-override prefix may be preceded by repeat or operand-size override prefixes. So

Re: winemenubuilder: Try to wait for creating icon files (try 2).

2013-01-29 Thread Sergey Guralnik
On 2013-01-23 16:34, Sergey Guralnik wrote: It supersedes next patch: From 4ca51cf16c5be2bcf34dddb7f33fe043c1d777c4 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik Date: Tue, 22 Jan 2013 15:58:20 +0200 Subject: winemenubuilder: Use only existing file for icon creating. The logic is the same

Re: user32/tests: Test standard scrollbar's initialization (try 2).

2013-01-17 Thread Sergey Guralnik
On 2013-01-15 12:27, Sergey Guralnik wrote: I have no feedback yet. Is it not clear enough? -- Sergey

user32/tests: Add tests for class small icons (try 3).

2012-09-18 Thread Sergey Guralnik
There are two patches that stay at queue more than weeek, and have no comments yet: From 5c723835fb9b8b56ccaf2a22256524c84b358fe9 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik Date: Tue, 11 Sep 2012 10:24:56 +0400 Subject: [PATCH 1/2] user32/tests: Add tests for class small icons (try 3

user32/tests: Add test for SetFocus() (with few todo)(Try 2).

2012-09-18 Thread Sergey Guralnik
Alexandre Julliard writes: Not really. If you want to test purely the Wine behavior, then you shouldn't be waiting for window manager events. If the window manager is involved then you can't guarantee that a given window will always get focus. If your app breaks because the window manager do

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

2012-09-17 Thread Sergey Guralnik
Alexandre Julliard wrote: Sergey Guralnik writes: I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add tes

Re: user32/tests: Add test for SetFocus() (with few todo)(Try 2).

2012-09-13 Thread Sergey Guralnik
I've sent next patch more than month ago, and have no comments about it. From 57adc6991431cd765dcdb97082263db834e4b533 Mon Sep 17 00:00:00 2001 From: Sergey Guralnik Date: Thu, 9 Aug 2012 17:12:56 +0400 Subject: user32/tests: Add test for SetFocus() (with few todo)(Try 2). Is anything

Re: [PATCH 2/2] user32: Correct class small icons behavior (try 2).

2012-09-07 Thread Sergey Guralnik
On 2012-09-07 15:24, Sergey Guralnik wrote: This patch based on MSDN's description of WNDCLASSEX structure: ... hIconSm: Handle to a small icon that is associated with the window class. If this member is NULL, the system searches the icon resource specified by the

Re: wine/server: removed obsolete one-iteration loop from request forming macro

2012-08-21 Thread Sergey Guralnik
On 2012-08-22 6:26, Архад wrote: #define SERVER_START_REQ(type) \ -do { \ -struct __server_request_info __req; \ ... -(void)reply; \ -do - -#define SERVER_END_REQ \ -while(0); \ -} while(0) +struct __server_request_info __req; \ ... +(void)rep

Re: [PATCH 1/2] comctl32/tests: Add test for MCN_SELECT/MCN_SELCHANGE notifications.

2012-08-16 Thread Sergey Guralnik
On 2012-08-16 16:28, Marvin wrote: === WNT4WSSP6 (32 bit monthcal) === monthcal.c:1258: Test failed: monthcal hit test: the msg 0x000f was expected, but got msg 0x1001 instead This is unrelated to my patch. -- Sergey

user32: Add test for ComboBox repositioning behavior (try 2).

2012-07-02 Thread Sergey Guralnik
Alexandre Julliard writes: @@ -5807,6 +5814,13 @@ static void test_combobox_messages(void) log_all_parent_messages--; ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); +SetWindowLongPtr(combo, GWLP_WNDPROC, (LONG_PTR)combobox_hook_proc_2); +SendMes

user32: Add test for ComboBox repositioning behavior (try 2).

2012-06-29 Thread Sergey Guralnik
Marvin wrote 29.06.2012 10:14: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails