Re: [1/2] winex11: Cache XRandR 1.0 display mode. (try 2)

2013-05-10 Thread Sam Edwards
On 05/10/2013 10:51 AM, Ruslan Kabatsayev wrote: Hi, Won't such code fail if the mode is changed outside wine? Regards, Ruslan Unfortunately it will, but the only way to fix that is to listen for an XRandR event indicating that the mode has changed. The screen_width/screen_height values c

Re: [1/3] winex11: Select for XRandR screen change events and implement an event handler.

2013-05-10 Thread Sam Edwards
On 05/10/2013 09:11 AM, Alexandre Julliard wrote: Sam Edwards writes: Yeah, I don't call it until patch 2 in the series. This patch just introduces it without calling it, which does cause a warning. (I hope this doesn't violate the "atomic patches" rule.) It does, you

Re: [1/3] winex11: Select for XRandR screen change events and implement an event handler.

2013-05-10 Thread Sam Edwards
On 05/09/2013 12:36 PM, Alexandre Julliard wrote: It's okay only because you are not actually calling it ;-) Yeah, I don't call it until patch 2 in the series. This patch just introduces it without calling it, which does cause a warning. (I hope this doesn't violate the "atomic patches" rule.)

Re: [PATCH] dlls/gdi32/freetype.c: A better divide by zero fix, report bad fonts.

2013-05-07 Thread Sam Edwards
rge font->aveWidth %d\n", font->aveWidth); font->aveWidth = 0; } But even then, the sanity check itself sounds like a workaround for a much deeper bug. Maybe add a "FIXME: Investigate why this is necessary" comment while you're at it? Best, Sam

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-05 Thread Sam Edwards
On 05/04/2013 10:38 PM, Max TenEyck Woodbury wrote: $ grep ' has tmHeight=0, aveWidth=' 201305055-make-test-native.log err:font:get_text_metrics Font named 'Emmentaler-Brace' has tmHeight=0, aveWidth=3! err:font:get_text_metrics Font named 'Emmentaler-Brace' has tmHeight=0, aveWidth=3! err:fo

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Sam Edwards
at instead, thus making this patch unnecessary because tmHeight will always be nonzero anyway. >From f5dc537a3799b9c4507cb0c8aefcc4ee73d2a0b5 Mon Sep 17 00:00:00 2001 From: Sam Edwards Date: Sat, 4 May 2013 21:58:19 -0600 Subject: gdi32: [HACK] Print which font is causing division-by-zero proble

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Sam Edwards
patch is the right thing to do, because we must prevent a division by zero in that case. If Windows absolutely disallows tmHeight=0, then the bug is actually that Wine allows tmHeight=0, and so we should be focusing on that instead. Hope this helps, Sam

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Sam Edwards
On 05/04/2013 12:59 PM, Max TenEyck Woodbury wrote: You are trying to make this about me. It is not. Windows fairly obviously does not do this 'sanity' test. Wine is supposed to imitate windows. To do this absolutely correctly, the whole 'sanity' test should go away. This sounds like an excell

Re: winex11.drv

2013-05-01 Thread Sam Edwards
On 05/01/2013 05:38 AM, Christopher Cope wrote: On 05/01/2013 07:21 AM, Christopher Cope wrote: I am unsure how the "enum x11drv_atoms" in the file dlls/winex11.dev/x11drv.h works. My /usr/include/Xatom.h defines XA_LAST_PREDEFINED as 68. Presumably, therefore XATOM_Rel_X and XATOM_Rel_X shou

Re: winex11.drv

2013-05-01 Thread Sam Edwards
ght, the Rel_X and Rel_Y values are (supposed to be) 81/82. Maybe your compiler is doing something strange or looked at the wrong values by mistake? Hope this helps, Sam #include #include "config.h" #include "x11drv.h" void _printatom(const char *name, enum x11drv_atoms value)

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics. (try 3)

2013-05-01 Thread Sam Edwards
7;ll try to get try 4 sent in either today or tomorrow, but it depends how long it takes me to understand this bug (and any other impact it may have that we're not seeing) completely. Thanks, Sam

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-30 Thread Sam Edwards
On 04/29/2013 08:20 AM, Alexandre Julliard wrote: Well, there was no backtrace since winedbg crashes. Fortunately gdb works: Big thanks! I found the problem (it only happened with subpixel rendering, which I don't have enabled) and am resending the patches now. :)

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-29 Thread Sam Edwards
On 04/26/2013 08:17 AM, Michael Stefaniuc wrote: Sam, look at the size of the address. It is the 64bit build that crashes. bye michael Michael: Thanks for the advice; I noticed that too and have been running both 64-bit and 32-bit tests. (Although, it's perplexing to me that a c

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-25 Thread Sam Edwards
s well. Can anyone else verify? Did something mess up during AJ's build? Thanks for the help, Sam

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-24 Thread Sam Edwards
This series has been waiting in the queue for a few days now. Does this need further discussion, or can it be committed? Thanks, Sam On 04/20/2013 08:08 AM, Sam Edwards wrote:

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-23 Thread Sam Edwards
rk ...) And yeah, Wine's Notepad does keep the lines spaced well apart. I don't (and can't) know if that's the case on Windows or not, but it might be worth looking into later. Thanks, Sam

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-23 Thread Sam Edwards
ins about the ttf being corrupt. Is there a similar font that will work on Windows that I could try? Thanks, Sam

Re: [PATCH 2/2] gdi32: Clip font glyphs to fit within text metrics.

2013-04-22 Thread Sam Edwards
On 04/19/2013 10:32 AM, Max TenEyck Woodbury wrote: As I understand it, some fonts deliberately have glyphs larger than their metrics bounding boxes. Clipping them is almost certainly not a good idea. Forgive my disbelief, but can you provide an example? It seems like Windows has the same cl

Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)

2013-04-01 Thread Sam Edwards
s patchset (with the reset_device() change included) so that it can be reviewed and committed while I'm busy with ddraw (and send the ddraw tests in a separate patch), or is this patchset unacceptable until I include the ddraw tests? Thanks, Sam

Re: wined3d: Properly handle WS_VISIBLE and WS_EX_TOPMOST style flags on fullscreen windows.

2013-03-31 Thread Sam Edwards
e->style^style) & WS_VISIBLE; Spaces around the (second) ^, please. Done. :) Thank you, Sam

Re: [PATCH] d3d9/tests: Add test for IDirect3DDevice9_Reset with BackBufferWidth/Height = 0.

2012-11-06 Thread Sam Edwards
ct(), but why SetWindowPos()? Is this preferred over MoveWindow() for any reason? > Testing the viewport dimensions is useful, but it probably wouldn't > hurt to check the swapchain's presentation parameters and the > backbuffer's surface desc as well. Good catch, I forgot to copy the relevant code for that. Thanks, Sam

Re: Guide for creating new AppInstall tests

2009-12-29 Thread Sam S.
Hi Austin, thank you for your reply. I'll give it another try. Btw, I do realise that some questions of the step-by-step list I gave at the end are already (at least partially) answered in various places - this was intended more as an outline of how a step-by-step guide useful to users with no pr

Guide for creating new AppInstall tests

2009-12-28 Thread Sam S.
ed test-scripts to Thanks! Sam PS: When will there be a new WWN?

DOS interrupts in Wine

2005-03-14 Thread Sam Lauber
Does Wine correctly implement all the DOS Services and interrupts? Samuel Lauber -- _ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

Re: Microsoft genuine downloads looking for wine

2005-02-18 Thread Sam Lauber
Agreed. Can't we just delete HKEY_CLASSES_ROOT/Software/Wine or move it to another name? > >> In any case, at least from a technical point of view, going > >> around such test ought to be fairly simple > If the mere existence of this key makes the validation fail, what's > to stop a virus fro

Wrapper for Winelib

2004-12-05 Thread Sam Lauber
I *think* I've figured out a way to make regular Unix programs with winelib. My idea is, make winemaker generate a C file called "winelib-wrap.c" that contains: #include int main(void) { return (int) WinMain(NULL, NULL, NULL, NULL); } Then link it with the EXE encapusulated in a .so, a

Re: working together on stdole.tlb and a end to dcom9x

2004-11-29 Thread Sam Lauber
l try it with InstallShield. Samuel Lauber - Original Message - From: "Boaz Harrosh" <[EMAIL PROTECTED]> To: "Sam Lauber" <[EMAIL PROTECTED]> Subject: Re: working together on stdole.tlb and a end to dcom9x Date: Mon, 29 Nov 2004 10:18:43 +0200 > &

Re: working together on stdole.tlb and a end to dcom9x

2004-11-28 Thread Sam Lauber
No. I used the InstallShield program for Flash MX, and it didn't work. Without stdole32.tlb, it whined like a baby about OLE. With stdole32.tlb, it (not the whole system) froze up during the "preparing" stage when it hit 100% and left a phantom window that was blank when and after I quit Wine. I

Major Winelib Problems

2004-11-25 Thread Sam Lauber
I followed the tutorial for Winelib on my Linux system, building notepad. I examined the file "./notepad2" with readelf, and it said "Not an ELF file", and I do not have an a.out system. I opened it with my text editor (attached is the text I saw) and I was disappointed. Instead of a real "port"

Cards.dll improvements

2004-03-28 Thread Sam
> On Sat, 27 Mar 2004 14:22:44 -0500, Sam wrote: > > This patch implements invisibleghost, deckx and decko > > drawing modes, and improves ghost drawing mode. > > It also includes graphics needed by these drawing modes. > > Hi, I'm sure you're doing the righ