Re: [PATCH 1/2] mstask: Implemented CreateTrigger.

2008-08-22 Thread Roy Shea
> dlls/mstask/task.c |4 ++-- > dlls/mstask/tests/task.c |2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Please disregard this and the subsequent patch in the set. Patchwatecher found a few incorrect todo_wine statements that I forgot to remove. A revised version of the t

Re: [PATCH 1/3] mstask/test: NewWorkItem conformance test

2008-07-30 Thread Roy Shea
Howdy, >> +const GUID invalid_id = {0x, 0x, 0x, >> +{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}}; > > You can use GUID_NULL and eliminate this local. After looking at other tests in wine I decided to use DEFINE_GUID to declare my own GUID_NULL for the test. T

Re: ws2_32: update to WSASendTo / last error patch

2008-07-17 Thread Roy Shea
Howdy, > In the future, please attach your test patch to a message in > wine-devel asking someone to run the test in windows. I just ran your tests. The new tests ran without problems on my Win2K and WinXP systems. However I do have a few other comments. Your formatting is not consistent with

Re: [PATCH 1/3] mstask: TaskScheduler stub with AddRef, QueryInterface, and Release

2008-07-17 Thread Roy Shea
Broken patch set :( Please disregard this sequence (1-3) of patches. I'll send a revised version out later today. Peace, -Roy On Thu, Jul 17, 2008 at 1:37 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > --- > dlls/mstask/Makefile.in |2 + > dlls/mstask/mstask_main.c

Re: [1 of 2] comctl32: add test for disabling owner of modal property sheets

2008-07-08 Thread Roy Shea
Hello Vincent, Looks like you've some DOS line breaks mixed into this patch through the register_parent_wnd_class function. Not sure if you meant to do that. Peace, -Roy On Tue, Jul 8, 2008 at 3:22 PM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > > > > >

Re: wintrust/test: Verify array length before calling memcmp in test (RESEND)

2008-07-07 Thread Roy Shea
> What's with the weird spacing? Thanks for the catch. I spaced on the spacing. Revised patch with corrected spacing is attached. Peace, -Roy From 11425fd623f6375937b3d97c8d682506cc08d39a Mon Sep 17 00:00:00 2001 From: Roy Shea <[EMAIL PROTECTED]> Date: Mon, 7 Jul 2008 16:13:33

Registering mstask without DllRegisterServer

2008-07-02 Thread Roy Shea
Howdy, I'm looking for advice on how to add registry entries for an implementation of the mstask Task Scheduler Service. The mstask DLL does not provide DllRegisterServer or DllUnregisterServer. To mirror this within my version I'm assuming that DllRegisterServer / DllUnregisterServer are off li

Re: ntdll: rtlstr.c: Implement checking for control characters in RtlIsTextUnicode [try 4]

2008-06-20 Thread Roy Shea
Hello Zac, > Does anyone have feedback on whether they believe the tests for normal > control characters vs reversed control characters should be mutually > exlusive? I took a look at the documentation. My read is that the tests are not mutually exclusive. Given your current version and my read

Re: [PATCH] svchost: Implementation of svchost (revised submission)

2007-11-27 Thread Roy Shea
On Tue, Nov 27, 2007 at 03:37:50PM -0600, James Hawkins wrote: > On Nov 27, 2007 3:21 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > > This is a revised and standalone version of svchost patch. Changes in > > this revision include: > > > > - Unicode based with a simp

Re: bits: Description of patch set (resend 2) (0/26)

2007-11-19 Thread Roy Shea
On Mon, Nov 19, 2007 at 08:31:31PM -0600, James Hawkins wrote: > On Nov 19, 2007 6:19 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > > Howdy, > > > > This is another resend of the BITS patch set. This resend changes > > svnhost to be ANSI based, merges patches 2

Re: svchost: Added base implementation of svchost (1/27)

2007-11-19 Thread Roy Shea
Hello Juan, Thank you for the code review! A quick clarification about HeapFree: > Some judicious use of goto could reduce code for all your error paths. > Remember that HeapFree of a NULL pointer is allowed. The docs for HeapFree state "If this pointer is NULL, the behavior is undefined." So

svchost Patch Question

2007-11-12 Thread Roy Shea
Howdy, I'm looking for advice on how to clean up the implementation of svchost. The latest version is available at: http://www.winehq.org/pipermail/wine-patches/2007-November/046467.html If the stopper for this patch is the lack of a DLL using it, I can resend svchost later this week when I hav

Re: Problem with client manually starting services

2007-11-08 Thread Roy Shea
On Thu, Nov 08, 2007 at 12:21:42PM -0800, Roy Shea wrote: > On Thu, Nov 08, 2007 at 12:00:28PM +, Robert Shearman wrote: > > Roy Shea wrote: > > >Howdy All, > > > > > >I'm developing missing services in Wine and am running into problems > > >wi

Re: Problem with client manually starting services

2007-11-08 Thread Roy Shea
On Thu, Nov 08, 2007 at 12:00:28PM +, Robert Shearman wrote: > Roy Shea wrote: > >Howdy All, > > > >I'm developing missing services in Wine and am running into problems > >with how Wine starts services. In Windows a service can be started > >using &quo

Problem with client manually starting services

2007-11-07 Thread Roy Shea
Howdy All, I'm developing missing services in Wine and am running into problems with how Wine starts services. In Windows a service can be started using "net start ", assuming that the service is properly added to the registry. In Wine it appears that the user must manually start the service bef

New DLL, Server and Service Documentation

2007-10-31 Thread Roy Shea
Howdy All, This autumn I began learning both Wine and COM. A combination of limited documentation and trouble finding the right example code for my task at hand made this a difficult process. In an attempt to help other new Wine and COM developers I wrote a tutorial on COM development the Wine w

rpc: (resend) Add missing headers

2007-10-23 Thread Roy Shea
these includes throuh windows.h. Peace, -Roy On Tue, Oct 23, 2007 at 09:50:25AM -0700, Roy Shea wrote: > Howdy, > > The REGISTER_PROXY_DLL_ROUTINES macro defined in rpcproxy.h calls > DisableThreadLibraryCalls. This patch adds two header files needed > for calls to DisableThr

Re: Bits: DLL name and svchost questions

2007-10-03 Thread Roy Shea
On Wed, Oct 03, 2007 at 12:09:36PM -0700, Roy Shea wrote: > (1) Shall I add bits to wine in dlls/bits or dlls/qmgr? I recommend > the former, since current Windows documentation refers to "bits". But > this may confuse folks who don't understand the tie between qmgr and

Bits: DLL name and svchost questions

2007-10-03 Thread Roy Shea
Howdy All, Thanks for helping me these past weeks as I get started with Wine development! I'm gaining a better understanding of the bits (Background Intelligent Transfer Service) COM service. Bits is run as a service via the svchost group netsvcs. Within netsvcs is the BITS service that is tied

Re: bits[1/3]: Minimal Background Intelligent Transfer Service (bits) implementation

2007-09-27 Thread Roy Shea
Howdy, On Thu, Sep 27, 2007 at 02:55:40PM +0200, Stefan D?singer wrote: > Am Donnerstag, 27. September 2007 12:58:46 schrieb Alexandre Julliard: > > Roy Shea <[EMAIL PROTECTED]> writes: > > > Resubmission of a bare bones bits implementation. > > > > There i