Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers [try 4]

2007-11-23 Thread Roman Mamedov
Roderick Colenbrander wrote: > The main reason why the D3DX_CAPABLE macros should be used before checking > the renderer string is that not in all cases all extensions are around while > the rendering string can still be the same. I think it's is quite difficult to say for sure what will be bett

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers [try 4]

2007-11-23 Thread Roman Mamedov
Roderick Colenbrander wrote: > I think the code should be like this (in pseudo code) this way also other > cards will at least be classified: > > case VENDOR_MESA: > if(D3D9_CAPABLE(gl_info) >if(strstr(gl_info->gl_renderer, "R300")) >card = radeon_9500; >else >

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers [try 3]

2007-11-22 Thread Roman Mamedov
Roderick Colenbrander wrote: > I would really ask you to use the D3DX_CAPABLE() macros as not using them can > result in bad problems. E.g. a game assuming a certain d3d functionality is > there while it isn't backed by any GL extension. > You certainly do have a point. I will redo the patch a

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

2007-11-21 Thread Roman Mamedov
James Hawkins wrote: >> If you send in a fixed patch, you need to add some variation of 'try >> X' in the subject, where X is the number of tries you're on. On top >> of this, you need to say in the body what you've changed between >> submissions. Thank you. I think I did mention the change in th