son is not
going to work.
Then following code would work better:
ULONG newsize = sizeof(WSACMSGHDR) + CMSG_ALIGN(len);
/* Make sure there is at least enough room for this entry */
if (newsize > *maxsize)
return 0;
/* else */
*maxsize -= newsize;
Rolf Kalbermatter
d be rewritten like this without functional change:
272 ok((result || GetLastError()==NTE_BAD_ALGID), "%08x\n",
GetLastError());
273 if (!result) return FALSE;
But boolean logic is in general not as obvious in one glance.
Rolf Kalbermatter
hen done in C many
more people in the Wine project can participate even if they do not know
much about the Mac API.
Rolf Kalbermatter
what the different syntax elements mean.
Rolf Kalbermatter
le it is. After all, if only one or two people
>can work with Obj-C code, it can bit-rot that much more quickly.
I think this is in fact the major issue here. There is certainly interest in
starting such a project but maintaining it is a completely different beast.
Rolf Kalbermatter
ence with Object-C might be even
bigger as it is likely using more advanced techniques.
Rolf Kalbermatter
where sometimes a range
of error codes is accepted as valid result.
Rolf Kalbermatter
C will fail for the A calls (but there
are also other RPC problems that make Windows-Wine RPC not work
well).
Rolf Kalbermatter
clares MapLS in winbase.h.
According to this http://support.microsoft.com/kb/195310 it's a 16-32bit
thunking only function so it may not mean much on NT based kernels at all.
Maybe your SDKs are not to old but to new to contain any reference to
these functions :-).
Rolf Kalbermatter
n Windows XP SP3
userAgent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6)
Gecko/2009011913 Firefox/3.0.6
Rolf Kalbermatter
er process
that gets started.
Maybe ShellDDEInit even should protect itself from being called multiple
times to start up the server.
Rolf Kalbermatter
Rolf Kalbermatter
> -Original Message-
> From: Jeremiah Flerchinger [mailto:jeremiah.flerchin...@gmail.com]
> Sent: Thursday, February 05, 2009 7:33 PM
> To: Rolf Kalbermatter
> Cc: wine-devel@winehq.org
> Subject: RE: Stub DDE interface for Progman.exe
>
>
t would IMHO only be possible if the shell executable, which normally is
just explorer
creating the actual desktop view had been replaced by a different executable
that does
not initialize the shell DDE interface properly.
Rolf Kalbermatter
t;me like it would make sense to use this library rather than spinning a
>separate implementation. Any comments are appreciated.
Do you have somewhere the specific WMF file in question? The license is a
"bit" to expensive to buy it just to test this ;-)
Rolf Kalbermatter
he OLE subsystem too in your case. Most probably there are not
many systems around using an original Win95 installation anymore but
still technically CoInitializeEx() may not be available on all Win95
systems.
Rolf Kalbermatter
other possible display
drivers such as the
quartz driver. Windows 2K/XP does appear to do it mostly in the Eng... GDI
functions
which would have been another possibility.
Vista changed the entire GDI/display driver business seriously again and I
have no idea
how it does work there.
Rolf Kalbermatter
that correctly a second patch
after
the test has been added as todo_wine would certainly be welcome.
Rolf Kalbermatter
hich would still
be a reason to try to implement that behaviour in Wine too. However you will
likely have to do quite
a bit more tests to then figure out the exact conditions under which this
behaviour is applied under
newer Windows versions.
Rolf Kalbermatter
not resolve to other DLLs implicitedly loaded by that DLL eventhough
they are in
the same directory than the referencing DLL.
Rolf Kalbermatter
or two days ago after updating my git repository
and found in configure a warning about xml2-dev (if I'm not mistaken) being
not available. Installed that and the error went away.
Guess someone broke the optional dependancy on the xml2-devel package. I
think I remember some noise on this mailinglist from someone stating that
Wine without xml2 should be considered broken anyhow.
Rolf Kalbermatter
Zac Brown [mailto:[EMAIL PROTECTED]
> Rolf Kalbermatter wrote:
> > Dan Kegel [mailto:[EMAIL PROTECTED]
> >
> >> e.g.
> >>
> >> if (flags & IS_TEXT_UNICODE_CONTROLS)
> >>for (i = 0; i < len; i++)
> >>
;r':
>case 0x20:
> out_flags |= IS_TEXT_UNICODE_CONTROLS;
> goto done;
>default:
>}
> }
> done:
Shouldn't a break instead of the goto work too?
Rolf Kalbermatter
that is a valid argument
to not do them. Typically to do a good test costs more time than an
actual implementation of a function and Wine development could
be sped up by not writing tests. But it would only implement more
functionality with a lot more errors (or should that be less bugs :-).
Rolf Kalbermatter
entries for a Wine hard stub
and then two patches to ROS, one implementing a soft stub in ROS and the
other
adding a call to ExitProcess to this stub so the shutdown process can
continue.
Is this reverse engineering?
Rolf Kalbermatter
ssed
something. Getting a long list of errors and sometimes crashes out
of the box really leaves a bad taste and also makes it much harder to
verify that my own modifications to it later on didn't break it in some
ways.
Rolf Kalbermatter
point cmd.exe just should call ShellExecuteEx for
file types
it doesn't know about and get the registry handling for free in that way.
Possibly the
import of shell32 would need to be done dynamically or delayed in that case.
Rolf Kalbermatter
mewhat weird line wrapping (or better lack
thereof)
this looks like what I had in mind. I don't see the benefit of adding
something
simple like this into libwine_port.
But of course it's Alexandre's call.
Rolf Kalbermatter
lso ideas how to solve that problem.
http://www.google.nl/codesearch?q=isinf&ie=UTF-8&oe=utf-8&rls=org.mozilla:en
-US:official&client=firefox-a&um=1&sa=X&oi=codesearch_group&resnum=4&ct=titl
e
Rolf Kalbermatter
ibrary modules, even if they are not
really PE files?
Of course Windows can't deal with them. For a Windows compatible DLL
you do need a cross compiler like MingW or compile the sources in MSVC.
It should be the same here as what is actually the situation for the
test framework.
Rolf Kalbermatter
hat allows users
to download every single Warez application that is out there without risking
more or less the same problems as you would get under Windows. And once Wine
has gotten the wide spread use we would all like to see, the next step to
Wine aware viri and such is not that big, believe me.
Rolf Kalbermatter
Jens,
Please diff your patches from the top level wine directory itself, as it
is it's not helpful since the patch utility couldn't even know which of
the many path.c files in the source tree needs to be patched, and the
maintainer has a lot more things to do than to search where a patch could
apply to.
Rolf Kalbermatter
ip ntdll.dll or ntos.exe or other core DLL source code ever.
Rolf Kalbermatter
he changes something at the according files.
> configure.ac
> Makefile.in
> in the folder ~/wine-git/
Rolf Kalbermatter
inux itself although not as painless
isn't that difficult either.
For my Windows box I use Media Player Classic with QT and RM codec support
now and that works almost flawlessly.
Rolf Kalbermatter
pes already then let it work that
way. It's also possible that the performance gain by the smaller
code is compensated by the more direct Ndr routine calls compared
to NdrClientCall(2) which has to marshall the data entirely based
on its own runtime type format parsing.
Rolf Kalbermatter
midl generated proxy code using -Oicf looks at least quite trivial.
Any opinions about this anyone?
Rolf Kalbermatter
not. I know there are (ancient) C compilers that will bark
when the # is not the first character in a line as the preprocessor
will then not see it as a valid preprocessor line and simply ignore
it.
Rolf Kalbermatter
OutExt) /
> abs(InExt)) + OutOrg;
> +return ( (InExt - (In - InOrg)) * OutExt / InExt ) + OutOrg;
> }
>
> LPOPENCONTEXT AddPacketToContextQueue(LPWTPACKET packet, HWND hwnd)
Rolf Kalbermatter
I wouldn't really know how to do some of
my programs
without sometimes using a debugger, although that happens to usually break
into my own
code but in the case of an exception, also not.
Rolf Kalbermatter
few incidents of clearly bad code sequences generated,
but have to admit that I don't remember if Wine was affected too by this.
Rolf Kalbermatter
n copy protected applications under Wine
most of those gcc versions should just work fine.
Rolf Kalbermatter
atal could be if someone
happens to pass in a variable that was declared like
long *ptr;
Then the offset calculation would be all wrong.
Rolf Kalbermatter
oCompletionCallback returned
ERROR_CALL_NOT_IMPLEMENTED\n");
>+ok (0, "BindIoCompletionCallback returned
ERROR_CALL_NOT_IMPLEMENTED\n");
> return;
> }
I don't think this check makes much sense after the change anymore. It's at
best a skip() for older Windows versions.
Rolf Kalbermatter
0038
>
>That address (0x00460038) is suspect. It looks like part of a Unicode
string.
>Something about how this driver is loaded is buggy, I'm guessing
ntoskrnl.exe
>is a bit too stubby for it yet.
I think this conclusion is a bit to simple. Considering the module base
address
of 0x46 this address could be quite legitime.
Rolf Kalbermatter
sor,
+icon, or one of the comdlg controls such as +imagelist.
Several calls to
trace:x11drv:X11DRV_SetWindowPos win 0x30274 window (0,0)-(1,14)
client (0,0)-(1,14) style 5001000b
right after that look also suspicious.
Rolf Kalbermatter
unning that application to look for the likely cause of this
problem as there are quite a few functions in Wine that call
X11DRV_CreateBitmap somewhere and somehow.
Rolf Kalbermatter
to call NtGetTickCount64() directly here
as is also done in NtGetTickCount().
On a side note: I wonder if older C compiler versions will simply do the
right
coercion from ULONGLONG to DWORD in these cases.
Rolf Kalbermatter
f( ( r == ERROR_SUCCESS ) || ( type == REG_DWORD ) )
+if( ( r == ERROR_SUCCESS ) && ( type == REG_DWORD ) )
should be enough. Since the funtion returned with success the type must be
valid now.
Rolf Kalbermatter
to be just executed them
without any concern, while people usually didn't realize that were simply
executables.
Rolf Kalbermatter
s
for the display name so checking for an explicit string length simply won't
work, which was your main criticisme here in the beginning.
Rolf Kalbermatter
translated. Also, on XP SP2 the A function returns the size in ASCI chars
that
the W function will need in bytes. Not a behaviour I feel Wine should
imitate
without an app that would need that behaviour.
I'll be gone for two weeks for vacation. If anyone wants to continue on that
please feel free. Otherwise I'll be picking this up afterwards.
Rolf Kalbermatter
that. Last time I
did a Wine test skip didn't exist at all.
Still on a clean Wine install I don't see how we can currently do many
useful service API tests at all.
Rolf Kalbermatter
make use of
EnumServicesStatusExW
from all other functions with some translation in them. Your approach avoids
translations
at the cost of making the common enumeration function quite a bit more
complicated.
I'm not sure which one I like more.
Rolf Kalbermatter
ic so that meaningful tests could be done
on Wine. Or maybe someone knows of a service that is going to be added to a
standard Wine installation soon?
Rolf Kalbermatter
7;t cover that range although they might have a large enough
range
for this problem.
Rolf Kalbermatter
ow you to use a switch statement in
net_service()
and make the code a lot easier to read. Also adding new commands won't make
the
whole such a big mess as it would now.
Also consider to use TRUE and FALSE as return value. This being a Windows
tool
and not a Unix one it seems clearer to me.
Rolf Kalbermatter
7;t
done
anything with Winelib and only tried once to build the crosstests.
Rolf Kalbermatter
Rolf Kalbermatter [mailto:[EMAIL PROTECTED]
>+GetServiceDisplayName(SCManager, service_name, NULL, buffer_size);
>+if(!buffer_size)
>+{
>
>Apart from GetServiceDisplayName() currently not being implemented in Wine,
this won't work!
>*buffer_size won't be a
me, buffer_size);
+}
Your mail client wrapped the patch again it seems. Sending as an attachment
might work better.
Rolf Kalbermatter
James Hawkins [mailto:[EMAIL PROTECTED] wrote:
>
>On 4/24/07, Rolf Kalbermatter <[EMAIL PROTECTED]> wrote:
>> Changelog
>> dlls/advapi32/service.c
>>- Make service_start_process return the pid to the caller
>>
>
>-/* FIXME: Put the pid int
Visual C 6.0 had for standard C code.
Rolf Kalbermatter
Alexandre Julliard [mailto:[EMAIL PROTECTED] wrote:
>"Rolf Kalbermatter" <[EMAIL PROTECTED]> writes:
>
>> +size = *lpcchBuffer * sizeof(WCHAR);
>> +ret = RegGetValueW(hscm->hkey, lpServiceName, szDisplayName,
RRF_RT_REG_SZ, &am
driver function to DIB_Status_Conf instead of
DIB_Status_GdiMod.
>2. Export LockDIBSection/Unlock to gdi32.
>
>Adding more exports is not nice but there really is no way around
>that, right?
That and a lot of the other points wouldn't be necessary with above
approach.
But there might be another complication with this I haven't seen yet.
Rolf Kalbermatter
>
> ** server can't find 147.179.151.66.in-addr.arpa: NXDOMAIN
If it would be Windows I would say some spyware/spamware has hijacked your
lmhost file. But this way??
At least here everything seems alright.
Rolf Kalbermatter
Dmitry Timoshkov wrote:
>"Rolf Kalbermatter" <[EMAIL PROTECTED]> wrote:
>
>> +#include
>
>What is this for? According to the Alexandre's comments we should convert
all the
>Wine builtin apps to unicode intead of promoting usage of TCHAR that leads
least an
idea. Coming up with yet a different Wine specific interface would first
require some architectural design work too but maybe you have done
something in that direction already.
Rolf Kalbermatter
ntation is basically
impossible without disassembling most of syssetup. Maybe that a stub
implementation is enough to get MDAC setup to work.
Rolf Kalbermatter
rations, with the last ones probably being also
the most complex ones. More esoteric operations such as Arcs will eventually
have to be implemented too somehow but wouldn't be the most important ones
to start with.
Rolf Kalbermatter
e. And I
personally
don't think it should be done in the X11 driver as that will require to do
the same work
in the quartz driver again and any other graphics display driver that may
come up in the
future. Basically it will be unmaintainable once there is more than one
possible display
driver in Wine.
Rolf Kalbermatter
ellips on your
>DIB surface...
Thanks Ge for this lengthy and good explanation. As to the drawing
optimization
I don't think that is a real trouble, certainly not to start with. Wine
wants first
something working correct and then one can decide if some fancy optimization
for
(dashed) lines, ellipses etc are at its place.
Rolf Kalbermatter
however automatic regression testing for display issues
is
not always possible so to some extend it is also about running all kinds of
graphic intense packages and finding problems or differences to how it was
before.
Rolf Kalbermatter
l32 are both also Wine specific and therefore
can't be replaced by Windows ones this won't matter either it would seem.
You can try to post a proper patch to both kernel32 and ntdll to
wine-patches and then let Alexandre decide if he wants to apply it.
Rolf Kalbermatter
shared video memory), it might
be possible
to use the DIB engine too, but that would be the drivers decision and as
said I'm
not yet sure that is how it's done under Windows nor if it should be done
this way.
Rolf Kalbermatter
y would
still be done
through the driver of course so everything would be transparent as far as
the capabilities
of the used display device itself allow for that.
Rolf Kalbermatter
ails branch into the local dibeng API for apropriate
functions.
Rolf Kalbermatter
a bigger chance of
someone trying to get it finally started the right way.
Rolf Kalbermatter
server
through other means than TCP/IP.
Rolf Kalbermatter
probably be the only way to get that working. But I think
it is safe to assume that that would require quite some work in Wine
before this could possibly work, not to talk about license issues.
Rolf Kalbermatter
ine) needs to provide
all functions this driver is accessing in order for the driver loading
even being successful.
Rolf Kalbermatter
n would ever make it in the mainstream kernel.
Rolf Kalbermatter
e best.
Wouldn't such a combination of two apps mess up under real Windows too?
I mean if they both write to the boot block or whatever on the disk device
directly and change the same offsets then it's going to be a mess. Why
should Wine be able to deal better with that than real Windows?
Rolf Kalbermatter
post wat unnecessarily rude and harsh,
especially considering that Bob did submit a bunch of patches no matter
if they were accepted into Wine or not.
Rolf Kalbermatter
ose that provide the most support in
terms
of code submissions, testing and documentation get to say the most and I think
it
has been clear that most of them are quite content if not happy with the modus
operandi. Of course Alexandre can be a pain sometimes but he has been always
with
a reason as far as I can tell.
Rolf Kalbermatter
work under Wine would not only require Windows kernel
driver support in Wine but also transparent hardware
access for those drivers through some mechanisme since the actual hardware
driver needs that and that
is one path Wine is not gonna head anytime soon.
Rolf Kalbermatter
ctions
needing to be thread safe so there this function had some use and it was just
ported to Win32 to make existing software still load despite the fact that it
can't really provide the parameter checking it makes one believe to do.
Rolf Kalbermatter
Alexandre Julliard wrote:
> Rolf Kalbermatter <[EMAIL PROTECTED]> writes:
>
> > Alexandre Julliard schrieb:
> >
> >>I fail to see in how far returning an error is hiding a bug.
> >>Imho if the library detects an error[*] it should pass the
>
you would talk about a stable and final Wine release (which with Wine chasing
the Windows API propably never will be) this might be a little different but
we talk about a software project heavily under development.
Rolf Kalbermatter
tial differences
between different platforms but it does happen.
Rolf Kalbermatter
forwarding to rpcrt4.UuidCreate
that generates a (pseudo)random GUID. To mimick Windows I would say this
should be done at wineinstall (or self-registration of the advapi DLL?).
Rolf Kalbermatter
or explanations.
Wouldn't it be better to place that into a help file and add a Help
button to the dialog that opens up that help file (possibly with
context sensitive help)?
Rolf Kalbermatter
and
especially hooking in Windows for sure can be a tricky business.
Rolf Kalbermatter
the build system would simply behave
as is. Watch out though that you probably do not want to include every
possible public header file, due to some conflicts. But for the majority
of windows.h and friends this could be a good solution.
Rolf Kalbermatter
> On Thu, Jan 12, 2006 at 09:02:42PM +0100, Rolf Kalbermatter wrote:
> > Thomas Weidenmueller wrote:
> >
> > > We've been using PCH with GCC for a long time in ReactOS,
> it's been
> > > working very well and reliable. Compiling ReactOS i
how PCH is supposed to work under MSVC, but for me not
having projects containing million lines of c code,
disabling PCH always was the most simple and reliable solution).
Rolf Kalbermatter
I have to say that I'm still using MSVC 6 so
there is a good chance that more recent MSVC systems have better dependency
tracking in precompiled headers.
Rolf Kalbermatter
ack. I did newsgroups in the past for a forum that
had a news link but some changes to that gateway made the newsgroup
less and less usable.
Rolf Kalbermatter
d
noticed a specific issue with GUIDs. Maybe I can learn a bit here.
For instance the GUIDs IID_IAVIStreaming and CLSID_AVIFile used in avifil32.dll
are put by wine in the uuid.lib/dll file but the two MS SDKs I tried do not seem
to provide these exports in either uuid.lib nor vfw32.lib(avifil32.
cessary at all?
Rolf Kalbermatter
If somebody wants to
make this work for his Wine copy I think he needs to
hack the resources in user32 themselves.
Rolf Kalbermatter
he T-Online suite. Otherwise
this would mean that you can't run it on a non-German Windows installation and I
would certainly guess that there are several people who run for instance the US
or UK English Windows version for one reason or the other. So what would they
have to do?
Rolf Kalbermatter
1 - 100 of 185 matches
Mail list logo
