Re: Help / Mentoring

2013-10-14 Thread Ricardo Filipe
Hello Hugh, I'd be more than happy to help you review your patches, although I am no wineconsole expert, I believe I could help you get your changes into wine. Contact me if no better offer comes around :) cheers 2013/10/11 Hugh McMaster : > Can anyone help me on this? I do realize that winecons

Re: Mono Update

2013-10-14 Thread Ricardo Filipe
IMHO it is more than time. Mono has several release cycles of new features that we are not taking advantage of with wine-mono cheers 2013/10/14 Alistair Leslie-Hughes : > Hi, > > wine-mono hasn't been updated in nearly a year.Should it be time to > consider a new release? > > Thoughts. > > Be

Re: [appdb] Upgrade to xinha svn head to fix issues with xinha editors not appearing in Firefox 15

2012-06-19 Thread Ricardo Filipe
2012/6/18 André Hentschel : > http://bugs.winehq.org/show_bug.cgi?id=30820 > --- >  xinha/Xinha.css                                    |  229 +- >  xinha/XinhaCore.js                                 |12107 > ++-- >  xinha/contrib/php-xinha.php                        |   29 +- >  xi

Re: A copyright question to wine developpers

2012-06-11 Thread Ricardo Filipe
2012/6/11 Michael Stefaniuc : > Hello! > > On 06/11/2012 10:54 AM, Christophe-Marie Duquesne wrote: >> To my understanding, wine is a reimplementation of the MS system. As >> far as I understand, you take MS public headers and reimplement their >> functions. If that is how it works, then how do you

Re: po/pt_PT.po: several translations

2012-03-01 Thread Ricardo Filipe
thank you for taking on this task! i have not had the time to look at this for 1.4. some remarks: #: gdi32.rc:25 msgid "Western" -msgstr "" +msgstr "Oriental" Ocidental? #: ieframe.rc:46 -#, fuzzy msgid "&Standard bar" -msgstr "Barra de &Estado" +msgstr "&Barra padrão" i think "Barra de Estad

Re: Vista/w2k8/w7 users, please test mmdevapi base render test

2011-10-05 Thread Ricardo Filipe
hi joerg, i have some failures on my win7 machine with 5.1 sound: render.c:167: Returned periods: 10. ms 3. ms render.c:179: pwfx: 0075F060 render.c:180: Tag: fffe render.c:181: bits: 32 render.c:182: chan: 6 render.c:183: rate: 48000 render.c:184: align: 24 render.c:185: extra: 22 render.

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)

2011-07-07 Thread Ricardo Filipe
2011/7/8 Christian Inci > On 07/08/2011 01:22 AM, Juan Lang wrote: > > Hi Christian, > > this isn't quite what Alexandre meant. *What* did you fix? Saying > > you did so isn't enough. > > Thanks, > > --Juan > I'm sorry, I thought you can see it out of the sourcecode. > > PATCH 1: Don't load any

Re: GSoC: dinput8 Action Mapping

2011-06-24 Thread Ricardo Filipe
there was no commit round today yet. usually allow for 2 days to pass if your patches are still "new". if then there is no feedback you can try asking in #winehackers 2011/6/24 Lucas Zawacki > Is there any problem with the latest patches I sent? They're sitting > there with the 'New' status but

Re: Wrong AppDB link

2011-06-19 Thread Ricardo Filipe
it's not there nor in the bug link queue. so it seems someone got to it already :) 2011/6/18 > > Hi, > > by mistake i linked a wrong bug to FAR Manager: > > http://appdb.winehq.org/objectManager.php?sClass=version&iId=15928 > > Could someone remove a link from FAR to bug 27406, please? > > > Tha

Re: [1/2] d3dx9/test: Add UpdateSemantics test.

2011-06-09 Thread Ricardo Filipe
2011/6/9 Henri Verbeet > On 9 June 2011 13:01, Michael Mc Donnell wrote: > > On a side note, failing to get a device means that the d3dx tests are > > always skipped on the testbot? > > > The ones that need a device, yes. The testbot machines are all VMs, so > they don't have real display hardwa

Re: [PATCH 01/13] dsound: New sample rate converter core functions.

2011-02-11 Thread Ricardo Filipe
2011/2/11 Krzysztof Nikiel > 2011/2/11 Dmitry Timoshkov : > > Krzysztof Nikiel wrote: > > > >> > You can't send Makefile changes separately from added/removed > >> > files, a patch should not add dead code. > >> > >> Could you explain "dead code", all 13 parts need to be applied, > >> otherwise

Re: ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces

2011-02-02 Thread Ricardo Filipe
2011/2/2 Qian Hong > Dear Nikolay and James, > > On Sun, Jan 30, 2011 at 11:09 PM, James McKenzie > wrote: > > Qian: > > > > I would like to echo Nikolay's comment and add one more: > > > > Please search through the Bug Reports before submitting a new one. > > I really feel very sorry, I apologi

Re: setupapi.dll: Call from 0x7b839292 to unimplemented function setupapi.dll.CM_Get_DevNode_Status (Crashing while running a USB production tool)

2011-01-19 Thread Ricardo Filipe
2011/1/19 Qian Hong > Dear All, while testing a USB production tool with unofficial USB > patches + native oleaut32.dll, > I got a crashing and such logs: > > wine: Call from 0x7b839292 to unimplemented function > setupapi.dll.CM_Get_DevNode_Status, aborting > wine: Unimplemented function setupap

Re: new

2010-10-23 Thread Ricardo Filipe
2010/10/23 Michael Sgier > Hi > > I'm new to this but know that MS Flight Simulator would one need little > tweak to run flight school etc. (already worked once) > > So I've downloaded git and would be thankful for hints on how to proceed > and find those bugs in FS9. I also would prefer using Ec

Re: LLVM compilation

2010-10-11 Thread Ricardo Filipe
;> >> You can ask Austin English, too. He builds Wine with Clang and sends >> patches to fix the warnings Clang reports. >>> My understanding is that WINE tries hard >>> to be pretty portable and non-GCC-specific, so I would expect good >>> results... > >

Re: [1/2] user32: fix FindWindowEx behavior if window name is an empty charachter

2010-10-05 Thread Ricardo Filipe
2010/10/5 Louis Lenders : >>It would be better to avoid duplicate GetWindowTextW() calls. > > I thought a long time how to fix this, but i couldn't find another way than > this one, because we need to find out whether or not the window title is > empty, and afaik we can only do that by calling Ge

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]

2010-10-01 Thread Ricardo Filipe
2010/10/1 Reece Dunn : > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more cha

Re: winscard.dll

2010-09-29 Thread Ricardo Filipe
2010/9/29 viny : >> However, I don't see any credits to me or IDRIX in you submission. > > I don't understand Mounir : after patching, all wine Winscard sources files > contain/keep this words : > "Copyright 2007 Mounir IDRASSI  (mounir.idra...@idrix.fr, for IDRIX)" > >> In the coming days, I'll pr

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)

2010-09-22 Thread Ricardo Filipe
2010/9/21 Mike Kaplinskiy : > Thanks for the feedback Alexandre. The complexity of the wine APC & > I/O system never stops amazing me. Third time's the charm? > > try 3: correctly use an apc to free internal async structures (which > would explain why we have the apc parameter...). Strangely moving

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Ricardo Filipe
2010/8/2 Jeff Cook : > What compiler are you running? It works fine for me and I don't see > any errors or warnings. > > On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard > wrote: >> Jeff Cook writes: >> >>> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>>      for (id = 0; id <

Re: [PATCH 2/2] dlls/ntdll/file.c: Return a different status code.

2010-07-25 Thread Ricardo Filipe
2010/7/25 Max TenEyck Woodbury : > --- >  dlls/ntdll/file.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 86c200f..c32baa0 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -2150,7 +2150,7 @@ NTSTATUS WINAP

Re: Portuguese (Brazil) translation of Wine at 100%

2010-07-09 Thread Ricardo Filipe
2010/7/9 Paul Vriens : > On 07/09/2010 12:56 PM, Michael Stefaniuc wrote: >> >> Paul, >> >> Paul Vriens wrote: >>> >>> Many thanks to Gustavo who brought the Portuguese (Brazil) translation >>> to a 100%. >>> >>> The list of 100% translations is slowly growing, we now have 7 (not >>> counting the o

Re: avifil32: Update Portuguese (Brazilian) translation

2010-06-23 Thread Ricardo Filipe
2010/6/23 Gustavo : > Updated Brazilian Portuguese translation and changed codification of > resource file to UTF-8 > > > > hi gustavo! thanks for doing the .br translations, and fixing sizes i overlooked in the .pt translation. :) however, you need to add the following line to the beginning of t

Re: Call for translators

2010-06-09 Thread Ricardo Filipe
hey paul, i believe i can get to them this weekend as i said. 2010/6/9 Paul Vriens : > On 05/27/2010 07:37 PM, Ricardo Filipe wrote: >> >> i'm adding myself to the list atm. i'll finish the portuguese portugal >> translations next week. > > Hi Ricardo, > &

Re: removed as supermaintainer of Microsoft Office installer

2010-05-28 Thread Ricardo Filipe
2010/5/28 Scott Ritchie : > On 05/27/2010 11:28 AM, Rosanne DiMesio wrote: >> Someone, obviously another admin, has removed me as supermaintainer of the >> Microsoft Office installer entry. >> >> I would like to know who, and why. >> >> Yes, I am royally pissed off. > > I believe it happens automa

Re: Call for translators

2010-05-27 Thread Ricardo Filipe
i'm adding myself to the list atm. i'll finish the portuguese portugal translations next week. if you wish to finish that work until then belnac please do so, i'm quite busy these days. 2010/5/27 Paul Vriens : > On 05/27/2010 06:23 PM, belnac wrote: >> >> On Thu, 2010-05-27 at 17:46 +0200, Paul V

Re: Re[2]: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile

2010-03-18 Thread Ricardo Filipe
2010/3/18 Ilya Basin : > PV> If this is no longer a todo_wine you should change the filename_tests > PV> struct: > You're right. > > Do you have any clue why this block of code was added to > SHELL_execute() ? > > try git blame and see if the commit message is of any help...

Re: Student Interested in Google Summer of Code 2010

2010-01-27 Thread Ricardo Filipe
hi arjun, it's good to see your interest :) tony has been searching for someone to integrate his gsoc work, see: http://www.winehq.org/pipermail/wine-devel/2010-January/081160.html maybe you are that guy? ;) it would serve as an introduction to the d3d environment at least. maybe too much idk. i

Re: winex11.drv: Added missing mouse position clipping. (try 2)

2010-01-23 Thread Ricardo Filipe
2010/1/22 Lauri Kenttä : > hi lauri. i'm glad you take people's comments with a grain of salt. vitaliy was a bit condescending but he said "please" :D it's unfortunate but we have to get used to it. i know it's not the best to entice developers but it's what we have, and it's good, stay around and

Re: New version of my test for bug 4543

2009-11-19 Thread Ricardo Filipe
2009/11/19 Charles Davis : > Hi, > > This is a new version of my test for bug 4543. This time, I followed > Dmitry's suggestion of using the existing functions for comparing the > contents of EMFs. I can't build tests for Windows both due to bug 20763 > and due to the fact that I don't have any Win

Re: transl and sublangs are not showing neutral

2009-07-08 Thread Ricardo Filipe
2009/7/8 Paul Vriens > Ricardo Filipe wrote: > >> >> >> 2009/7/8 Paul Vriens > paul.vriens.w...@gmail.com>> >> >> >>Paul Vriens wrote: >> >>Ricardo Filipe wrote: >> >>hi mikolaj, &g

Re: transl and sublangs are not showing neutral

2009-07-08 Thread Ricardo Filipe
2009/7/8 Paul Vriens > Paul Vriens wrote: > >> Ricardo Filipe wrote: >> >>> hi mikolaj, >>> >>> in transl the Portuguese language (not Portugese :( ) is not showing most >>> of the neutral strings for it's sublangs (portugal and b

transl and sublangs are not showing neutral

2009-07-07 Thread Ricardo Filipe
hi mikolaj, in transl the Portuguese language (not Portugese :( ) is not showing most of the neutral strings for it's sublangs (portugal and brazil). i think this is not how it should be... in each sublang it should show the Neutral derived strings and the warning that neutral is being used and sh

Re: AppDB test results in Spanish

2009-07-02 Thread Ricardo Filipe
2009/7/2 Ben Klein > 2009/7/2 Paul Vriens : > > Ben Klein wrote: > >> > >> Who feels like translating some test results? > >> > >> > http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingId=38908 > >> > >> > > > http://translate.google.com/translate?js=n&prev=_t&hl=en&ie=UTF-8

Re: A new kid

2009-06-29 Thread Ricardo Filipe
2009/6/29 MD.IMAM HOSSAIN > Dear WINE Developers, > > A short biography of me: > > A University Student of Electrical & Electronics Engineering Department. > Live in Bangladesh in the city of Chittagong. I am a moderate Linux User, A > moderate C programmer and have little knowledge about C++ pr

Re: transl: fix score-counter

2009-06-29 Thread Ricardo Filipe
2009/6/29 André Hentschel > If e.g. 4 langs are on score 1, then next score entry is 5. > This corrects the counter, so that next score is 2 > --- > transl/php/index.php |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > the score right now gives a count of the number of languag

Re: Fixing EOL in logging messages

2009-06-27 Thread Ricardo Filipe
2009/6/27 Frédéric Delanoy > Hi, > > I'm intending to fix some non-\n-terminated strings for different logging > classes (MESSAGE, TRACE, ...) > > For each class, should I send (1) a patch for *each* affected module or (2) > just a "generic" one ? > > Solution (1) seems a bit like overkill for me

Re: Removing active maintainers

2009-06-25 Thread Ricardo Filipe
2009/6/25 Rosanne DiMesio > On Thu, 25 Jun 2009 13:41:39 +0100 > Ken Sharp wrote: > > > There were 300 comments, all removed. I asked you to do this, between > > 15 maintainers, and you couldn't be bothered. That is why you were > removed. > > > > Doing nothing is no help to anyone, as you hav

Re: wine-patches Digest, Vol 47, Issue 188

2009-06-23 Thread Ricardo Filipe
2009/6/23 Pavel Procházka > hello > I want to ask you if i should resend the patch in correct form, sorry for > the last patch. > Thank you for answer > do not send "normal" messages to wine-patches. send those to wine-devel, wine-patches is for messages with attached patches only. yes, you sho

Re: winetest data generation

2009-06-14 Thread Ricardo Filipe
2009/6/14 André Hentschel > I need to have a look into the sourcecode of the scripts behind " > test.winehq.org". > Where can i find it? > http://source.winehq.org/git/tools.git/?a=tree

Re: Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.

2009-05-20 Thread Ricardo Filipe
2009/5/20 Tim Wright > The EvE-online updater blows up because it's trying to set the download > priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to > return S_OK is sufficient to allow it to work. > > Third attempt at sending. For some reason, it isn't being posted from > g

Re: (try3)Fix ATI HD4800 being reported as ATI 9500

2009-05-15 Thread Ricardo Filipe
2009/5/15 Robert Key > Same patch but with the 2048MB X2 comment removed, thanks > Roderick. > > the previous try has been commited today... so if you want to fix the comment you have to send another patch, or leave it like it is.

Re: Wine policy question: What is considered "reverse engineering"/what is acceptable?

2009-05-13 Thread Ricardo Filipe
2009/5/13 Daniel Santos > I was recently attempting to isolate the cause of a hang in Lord of the > Rings Online and had it in a debugger. I mentioned this on IRC and was told > that I was "reverse engineering" and any patch I came up with would not be > accepted. I find this rather confusing a

Re: DIB Engine : Almost 100% working

2009-05-10 Thread Ricardo Filipe
2009/5/10 Warren Dumortier > 2009/5/10 Massimo Del Fedele : > > Massimo Del Fedele ha scritto: > >> > >> Well, after some (many) bugfixes and additions, the mighty DIB Engine is > >> almost 100% > >> operational. > >> On one of tested apps (MSN Messenger) it behaves even better than > original >

Re: Romanian translation (again)

2009-05-03 Thread Ricardo Filipe
2009/5/3 Dimitriu Petru > I'm here again for the Romanian translation of Wine. > I only want somebody to change in the translation "Proprietă?i pentru" > with "Proprietăţi pentru" because it shows ugly in ReactOS. > > Thanks in advance, > Petru > > > you can send translations patches to wine (you

Re: The DIB engine... does anyone know how to get it into Wine?

2009-04-28 Thread Ricardo Filipe
i second the plea. Autocad is one of those applications that many windows users NEED to have working to even consider a change to linux, even at the enterprise level many would switch for it. the other day i had a friend in Naval Engineering ask me if it was possible to use Autocad in wine so he c

Re: GSoC: Improving DOS graphics

2009-03-30 Thread Ricardo Filipe
2009/3/29 Daniel Kraft > Hi, > > I would be interested in working on WINE for Google Summer of Code (as I > would like to get into WINE and learn more about it from the developer's > side of view; I imagine this is a very educational and interesting > experience in addition to being simply an int

Re: Anything wrong with these patches ?

2009-03-23 Thread Ricardo Filipe
2009/3/23 Massimo Del Fedele > winex11.drv: SetDIBits fails when startscan != 0 > http://www.winehq.org/pipermail/wine-patches/2009-March/070788.html > (solves a bug on SetDIBits when transfer partial bitmap) > > gdi32/path.c -- Allow PATH_ExtTextOut() handle non printable characters > http://www

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-23 Thread Ricardo Filipe
2009/3/23 James Hawkins > On Mon, Mar 23, 2009 at 9:38 AM, Ricardo Filipe > wrote: > > i know it's not what it does, it's an alternative someone refered in irc. > i > > was wondering what you think would be the correct approach, since both > fix > >

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-23 Thread Ricardo Filipe
ins > On Sun, Mar 22, 2009 at 4:04 PM, Ricardo Filipe > wrote: > > my next task was to fix this eheh. > > i think it would make more sense to just change > > > > if(!params->PathBuffer && !params->PathBufferSize) > > > > to > > >

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-22 Thread Ricardo Filipe
my next task was to fix this eheh. i think it would make more sense to just change if(!params->PathBuffer && !params->PathBufferSize) to if(!params->PathBuffer) as it was talked about in irc, it doesn't make much sense to check for pathbuffersize when pathbuffer is null... the max_path removal

Re: [AppDB] Entry for Everquest 2

2009-03-18 Thread Ricardo Filipe
as i said before, it was an uninformed decision, and yes, not enough time was left for feedback from the maintainers. we thought that appdb WOULD save all the data when moving, not only tests. it serves as example for us for the future, unfortunatly with problems to the EQ2 users. as i said before,

Re: [AppDB] Entry for Everquest 2

2009-03-15 Thread Ricardo Filipe
agreed. either that or do a new link that copies EVERYTHING. i've CCed the appdb site manager to see what he thinks :) 2009/3/15 Rosanne DiMesio > On Sun, 15 Mar 2009 18:23:20 + > Ricardo Filipe wrote: > > > no test data was lost. it is all in the new link. > >

Re: [AppDB] Entry for Everquest 2

2009-03-15 Thread Ricardo Filipe
actually ben, how to's and warnings also went away. i think beaulieu already found them elsewhere and updated the page with them, thanks ;) sorry about that again, i'll post a bug for moving data to also copy the rest of the page... 2009/3/15 Ben Klein > 2009/3/16 Ricardo Filipe

Re: [AppDB] Entry for Everquest 2

2009-03-15 Thread Ricardo Filipe
/3/15 John Beaulieu > Hey, you caused comments, data, and maintainers to be removed. Thats not > cool. > > On Sun, 2009-03-15 at 11:18 +, Ricardo Filipe wrote: > > not really... it's a completly new game. i'll see if i can do > > something... > >

Re: [AppDB] Entry for Everquest 2

2009-03-15 Thread Ricardo Filipe
all that is changed it was me. i kept everything on context, although i forgot to copy EQ2 description :S what i meant is that you or other EQ maintainer ask to be EQ2 maintainer ;) 2009/3/15 Charity Abbott > On Sun, Mar 15, 2009 at 7:40 AM, Ricardo Filipe > wrote: > > done. i&

Re: [AppDB] Entry for Everquest 2

2009-03-15 Thread Ricardo Filipe
done. i've created a new application and moved test data there. unfortunatly appdb doesn't move comments so those are lost :( i wait for the EQ maintainers to step up for EQ2 :P http://appdb.winehq.org/objectManager.php?sClass=application&iId=9400 2009/3/15 Ben Klein > I just noticed that the e

Re: [AppDB] Entry for Everquest 2

2009-03-15 Thread Ricardo Filipe
not really... it's a completly new game. i'll see if i can do something... 2009/3/15 John Beaulieu > This is really nitpicking isn't it? > > On Sun, 2009-03-15 at 12:02 +1100, Ben Klein wrote: > > I just noticed that the entry for "Everquest II", the sequel to > > "Everquest", is listed as versi

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-04 Thread Ricardo Filipe
2009/3/4 Andreas Rosenberg > > Sorry, but I disagree with you opinion. > > A conformance test should verify if an API call works like documented. > > The MSDN documentation specifies nothing regarding error codes for > GetUserProfileDirectory. > > http://msdn.microsoft.com/en-us/library/bb762280(

Re: [7/7] setupapi/tests: start dialog.c test file with a test for SetupPromptForDiskA

2009-02-23 Thread Ricardo Filipe
sure, i'll do that and resend :) thanks for your feedback. 2009/2/23 Paul Vriens > > Hi, > > Could you turn that skip() into a win_skip()? Usually it's a good idea to > do a > SetLastError(0xdeadbeef or something like that) before calling the > function, > especially because you are relying on t

Re: msadp32.acm, winemp3.acm: Removed compiler warning

2009-02-20 Thread Ricardo Filipe
you should send one patch per email, dan should have told you that :P good to see you guys on the project :) 2009/2/20 Adam Stoelting > Hello, > > These are my first patches. I am graduate student at UCLA and am trying to > help with porting Wine to 64 bit. I haven't seen any Microsoft source

Re: [8/9] setupapi: implement SetupPromptForDiskA by wrapping around W version

2009-02-18 Thread Ricardo Filipe
2009/2/19 Juan Lang > Hi Ricardo, > > +DialogTitleW = MultiByteToUnicode(DialogTitle, CP_UTF8); > You should be using CP_ACP here, not CP_UTF8. Same applies to > remaining character conversions. In fact, you could use strdupAtoW > instead. > --Juan > > that is something i should have asked.

Re: Wine64 - msvcrt dll test fix

2009-02-18 Thread Ricardo Filipe
this was commited already today. :) http://source.winehq.org/git/wine.git/?a=shortlog 2009/2/18 Juan M. Navarro > Resending as plain text. > > Thanks, > Juan > > On Tue, Feb 17, 2009 at 12:19 PM, Juan M. Navarro > wrote: > > Hello all! > > > > This is my first patch ever, and first open source

Re: big patch to implement SetupPromptForDisk (please comment)

2009-02-17 Thread Ricardo Filipe
2009/2/17 Vincent Povirk > > > I'm curious what happens if you tell if you're looking for a file on > C: that you know exists. If it doesn't bring up a dialog, that might > allow you to create a few tests that succeed. > > Vincent Povirk > > i could do that, if i had implemented IDF_CHECKFIRST :p

Re: advapi32: GetNamedSecurityInfoExA Stub

2009-02-16 Thread Ricardo Filipe
Ah, right you are, thanks. > > I guess that should have read 'most obviously incorrect'. > > I cannot find any reference to GetNamedSecurityInfoEx with or without > the A or W on http://www.msdn.microsoft.com. I have looked several > times over the last six months or so. Is there another MSDN som

big patch to implement SetupPromptForDisk (please comment)

2009-02-16 Thread Ricardo Filipe
ine. yhey! it lacks LOTS of details though, i just implemented the juice of it and some simple details. regards. From 80a9d7e2031153ec296638dcc60fb9475e111572 Mon Sep 17 00:00:00 2001 From: Ricardo Filipe Date: Mon, 16 Feb 2009 20:59:13 + Subject: setupapi: implement SetupPromptForDiskA/W ---

Re: Wine talk on FOSDEM

2009-02-15 Thread Ricardo Filipe
2009/2/15 Stefan Dösinger > Am Sonntag, 15. Februar 2009 23:03:27 schrieb Marcus Meissner: > > Hi, > > > And my slides are here (feel free to reuse): > > http://files.opensuse.org/opensuse/en/0/05/Fosdem2009-wine.pdf > Just skimmed over them out of curiosity, found one mistake: GameGuard does > n

Re: Updated cebit presentation. Looking for ideas...

2009-02-15 Thread Ricardo Filipe
2009/2/15 Dan Kegel > On Sun, Feb 15, 2009 at 1:26 PM, Marcus Meissner > wrote: > > Btw, I have run my last 3 Wine presentations in > > OpenOffice_org 2.4 for Win32. > > > > Did not give much crowd "h" effect though. > > I guess I'm not trying to impress, I'm trying to reassure. > So maybe d

Re: AppDB new design: Top 10s still look ugly

2009-02-15 Thread Ricardo Filipe
hi andré, alex didn't apply your patch. he just fixed the .css to give it the same style as it had before. 2009/2/15 André Hentschel > Hello, > Bug #16466 is declared as fixed. but it isnt. my patch should do > something else. > I wanted let each top 10 in its own color(platin, gold or bronce) a

Re: Updated cebit presentation. Looking for ideas...

2009-02-15 Thread Ricardo Filipe
> > > > A before/after of Safari with corefonts might also be good, to show an > > example of what winetricks can fix. > > Heh. Safari without corefonts hangs. Hard to capture that in a screenshot > :-) > > > you can do that with steam :P

Re: How to get more info on timed out/crashed tests?

2009-02-11 Thread Ricardo Filipe
2009/2/11 Juan Lang > Hi all, > > there are a number of tests at test.winehq.org that indicate that > they're timed out or crashed. The difficulty is, I have no access to > machines running the version of Windows on which the test is timing > out or failing, and the data about the crash are not

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Ricardo Filipe
2009/2/11 Alexandre Julliard > > That's not a useful number, many files run a lot of tests, of which a > huge majority always succeeds. Having a single failure among 10,000 > tests means that the test failed, and it's something bad that should be > taken care of. Showing that as a 99.99% success

RE: MSI Patch Feedback

2009-01-09 Thread ricardo filipe
>>"How should I attempt to test the changes I have made" > I don't see testcases for any of these changes. Adding conformance > tests would be the best first course of action: > > http://wiki.winehq.org/ConformanceTests > http://wiki.winehq.org/WritingConformanceTests > > -- > -Austin > > he is

RE: Contribution to the Toolbar common control

2008-12-31 Thread ricardo filipe
although he used disassembly to check our implementation, he gave msdn proof for the notifications he talked about... and didn't contribute code. > Date: Wed, 31 Dec 2008 08:45:43 -0600 > From: austinengl...@gmail.com > To: alanf...@gmail.com > Subject: R

RE: xinput: Add stub XInputEnable

2008-12-28 Thread ricardo filipe
CC: wine-devel@winehq.org > > Sorry guys, that was a really bad patch I submitted much better ones > to wine-patches already. > > [1/2] xinput: Added prototypes to header file > [2/2] xinput: Added stub for XInputEnable >> 2008/12/28 ricardo filipe : >> it's al

RE: xinput: Add stub XInputEnable

2008-12-28 Thread ricardo filipe
it's almost that. but it needs some changes. first you put the prototypes after the defines and typedefs, they may be needed for the prototypes. second you don't put variable names in the protypes, it should be something like: DWORD WINAPI XInputGetState(DWORD, XINPUT_STATE*); see the xinput.h

RE: Simplify dlls/comctl32/nativefont.c

2008-12-27 Thread ricardo filipe
are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ... > Date: Sat, 27 Dec 2008 08:57:44 +0100 > From: ger...@pfeifer.com > To: wine-patc...@winehq.org > Subject: Simplify dlls

patch to fix bug 8072, but need some help with tests

2008-12-15 Thread ricardo filipe
69af26da3cf57c8324ee3fa724f40 Mon Sep 17 00:00:00 2001 From: Ricardo Filipe Date: Tue, 16 Dec 2008 00:38:25 + Subject: comdlg32: notify with CDN_INCLUDEITEM on IShellBrowserImpl_ICommDlgBrowser_IncludeObject for each object that is to be included in the browser window --

RE: [1\3] setupapi: add CM_Locate_DevNodeA\W stubs

2008-12-12 Thread ricardo filipe
:36 +0100 > > Am Friday 12 December 2008 01:42 schrieb ricardo filipe: > > >--- a/dlls/setupapi/setupapi.spec > >+++ b/dlls/setupapi/setupapi.spec > >@@ -53,7 +53,7 @@ > > @ stub CM_Free_Res_Des > > @ stub CM_Free_Res_Des_Ex > > @ stub CM_Free_Res_Des_Hand

RE: appdb sidebar has issues

2008-12-09 Thread ricardo filipe
played within the > intended confinement, however it is smaller than the rest of the AppDB text > and thus a tiny bit harder to read than it should be.> > Firefox 3> > > Alexander> > On Tuesday 09 December 2008 20:47:10 ricardo filipe wrote:> > http://img186.i

RE: comdlg32: includeobject needs to notify window with CDN_INCLUDEITEM

2008-12-08 Thread ricardo filipe
so i just saw this insightful comment in filedlg.c: * FIXME: CDN_FILEOK is wrong implemented, other CDN_ messages likely too must be why it doesn't really notify the window :\ send_message() needs to be fixed for this. > From: [EMAIL PROTECTED] > To: wine-devel@winehq.org > Subject: comdlg32:

comdlg32: includeobject needs to notify window with CDN_INCLUDEITEM

2008-12-07 Thread ricardo filipe
___ Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger! http://www.amigosdomessenger.com.br/From 864bce99c2d1aa8c4117118081081f0dde48d22c Mon Sep 17 00:00:00 2001 From: Ricardo Filipe <[EMAIL PROTECTED]> Date: Sun, 7 Dec 2008 20:39:09 + Subject: commdlg: make inclu

RE: Coverity Telco coming up

2008-12-02 Thread ricardo filipe
even if there are admins the information about them and how to apply is well hidden and not easy to join :) so it's a good subject to bring...> Date: Tue, 2 Dec 2008 15:54:39 -0600> From: [EMAIL PROTECTED]> To: [EMAIL PROTECTED]> Subject: Re: Coverity Telco coming up> CC: wine-devel@winehq.org>

dead stores in advapi32

2008-11-20 Thread ricardo filipe
hi rob. i have some dead stores in advapi32 files that i would like to clarify. first, what do you want to do on lines 173 and 194 of cred.c? now, there are also 3 dead assignments in cred.c, lines 992, 199 and 1064. i didn't understand what you meant in your last email about my patch that remo

RE: netapi32: Actually return a couple of return values.

2008-11-19 Thread ricardo filipe
return a couple of return values. > To: [EMAIL PROTECTED] > > > ricardo filipe <[EMAIL PROTECTED]> found a couple of dead return > value assignments in nbt.c and netbios.c > > Fix up these error paths. > --- > dlls/netapi32/nbt.c | 12 +++- >

dead stores in msxml3

2008-11-18 Thread ricardo filipe
hi leslie. i'm tracking some dead stores with Clang and there are some in dlls/msxml3/saxreader.c i'm hoping you can tell me if the stores are to be removed for performance or if they should be checked in each iteration for correctness: file dlls/msxml3/saxreader.c lines: 1163 1166 1213 1216 re

dead stores in netapi32

2008-11-18 Thread ricardo filipe
hi juan! i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with. file dlls/netapi32/nbt.c: lines: 419 839 1185 1192 1201 file dlls/netapi32/netbios.c: lines: 634 636 i thought you might want to have a look at it :) regards,

RE: dlls/cabinet: fix dead stores (llvm/clang)

2008-11-18 Thread ricardo filipe
> Date: Tue, 18 Nov 2008 10:17:46 +0100> From: [EMAIL PROTECTED]> To: [EMAIL > PROTECTED]> CC: [EMAIL PROTECTED]; wine-devel@winehq.org> Subject: Re: > dlls/cabinet: fix dead stores (llvm/clang)> > On Tue, Nov 18, 2008 at > 03:11:52PM +0800, Dmitry Timoshkov wrot

RE: Splitting the appdb Top 25 list

2008-10-17 Thread ricardo filipe
i think that list could prove useful, although i agree it could be split on to apps and games, makes all sense. even if devs don't look at it right now maybe someone does and wants to hack on top voters. the MTGO 3 example is interesting, i'm the maintainer of the game, and that surge in the f