On Sun, 16 Aug 2009 13:18:56 -0500, you wrote:
>Howdy Rein,
>
>I don't believe you're supposed to add English resources to
>non-English rc files. The dialog will automatically fall back to
>English if not present. It messes up the translation stats..
Is that so? I looked through the changelog for
On Sat, 15 Aug 2009 10:46:19 -0700, you wrote:
>
>14 months seems to be more than reasonable to repair a regression. I'm
>worried about having to forever maintain a separate installation of
>Wine just to use this program. I'll be happy to test further if
>someone is going to work on this bug but r
On Mon, 03 Aug 2009 21:02:30 +0200, you wrote:
>
>
>Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've
>got a new failure on my Win2k box.
>
>I did a first patch to filter Win2k failure that happens on
>GetSaveFileNameW case only but, according to test.winehq.org, Win9x
>boxes a
Responding to all your comments:
On Fri, 24 Jul 2009 00:02:01 -0400, you wrote:
>On Thu, Jul 23, 2009 at 10:28 PM, Juan Lang wrote:
>>> I think what Rein means is that the unix socket fd backing the windows
>>> socket handle is always non-blocking - and if he is, he may be
>>> correct:
Yes, tha
Hi,
I am looking at bug #12048 http://bugs.winehq.org/show_bug.cgi?id=12048
>From a relay trace it is easy enough to find where the app is getting
dead-locked and why it should not.
It is calling recv() on a socket that was previously:
1) set to blocking with a WS_ioctlsock() call with cmd WS_F
On Tue, 21 Jul 2009 09:19:02 +0200, you wrote:
>Rein Klazes wrote:
>> Show the problem with the application in bug report #12171.
>> +todo_wine
>> +ok( !ret ||
>> +broken( 0), /* win98, NT */
>> +"ModifyMenu should have fail
On Sat, 04 Jul 2009 00:10:02 +0400, you wrote:
>Hi.
>
>Trying to fix some ListView bugs I've found that on native (XP SP2)
>system this call:
>---
>GetSystemMetrics(SM_CXICONSPACING)
>---
>doesn't return the value specified in appearance -> advanced settings of
>Display properties sheet.
>
>I've
On Fri, 03 Jul 2009 07:49:33 +0200, you wrote:
>Hi Rein,
>
>This one introduced extra test failures on Vista. On 1 Vista box and
>W2K8 the test times out (crashes?).
>
>Could you have a look.
I have submitted a fix. Works for me on Vista, XP (real) and W2k, W2k8
(vmware).
Rein.
On Fri, 03 Jul 2009 07:49:33 +0200, you wrote:
>Hi Rein,
>
>This one introduced extra test failures on Vista. On 1 Vista box and
>W2K8 the test times out (crashes?).
>
>Could you have a look.
No time outs here, but I see the failures. The PostMessage( ...,
WM_COMMAND, IDOK, ...) seems not enoug
On Thu, 18 Jun 2009 16:01:20 -0500, you wrote:
>cert.c:1627: warning: logical || with non-zero constant will always
>evaluate as true
That (in dlls/crypt32/tests) looks like a real bug to me.
Rein.
On Tue, 16 Jun 2009 17:49:31 +0200, you wrote:
>So:
>
>1. Some (all?) resizing stuff is not supported on Win95/NT4
Agreed. I can reproduce and I will fix it.
>2. The size of the desktop matters for the sizing results.
Indeed, I did test this on win2k, win2k3 and winXP, all tests succeeded.
Maki
On Thu, 11 Jun 2009 16:30:57 +0400, you wrote:
>> http://bugs.winehq.org/show_bug.cgi?id=5
>There's nothing about why it's so important. These 25, 35 or 20 lines to
>allow means nothing.
>Actually I don't see any problem here, and, yes, I'm subscribed on
>wine-bugs list and this full log pas
On Thu, 7 May 2009 01:54:23 -0500, you wrote:
>On Thu, May 7, 2009 at 1:52 AM, Rein Klazes wrote:
>> Fixes bug 10845
>>
>> Changes from previous patch: menu position calculations moved to
>> nonclient.c.
>
>Can you add a testcase?
I don't see what yo
On Fri, 01 May 2009 22:15:16 +0200, you wrote:
>Rein Klazes writes:
>
>> What is already in the tests:
>>
>> 1) You need the alloc flag for instance when SetScrollInfo or
>> SetScrollRange is called on a window without the WS_[HV]SCROLL styles. I
>> can a
On Fri, 01 May 2009 13:13:05 +0200, you wrote:
>Rein Klazes writes:
>
>> -if (!infoPtr && alloc)
>> +if (!infoPtr && ( alloc || (wndPtr->dwStyle & (WS_VSCROLL |
>> WS_HSCROLL
>> {
>
>This bit doesn't look right
On Sun, 26 Apr 2009 19:46:24 +0200, you wrote:
>> +scrollbar_test_default( 0);
>> +if( 0) { /* enable this when the todo's in scrollbar_test_default are fixed
>> */
>> +scrollbar_test_default( WS_HSCROLL);
>> +scrollbar_test_default( WS_VSCROLL);
>> +scrollbar_test_default( WS_HSC
On Tue, 21 Apr 2009 17:48:44 +0200, you wrote:
>> +skip("memcpy not found\n");
>
>I doubt any version of the dll is missing memcpy, and even so that
>should be a separate patch.
Yes, I was not paying attention. The problem was the handle to the
msvcrt.dll. When compiled with Visual Studi
On Sun, 12 Apr 2009 11:29:06 +0500, you wrote:
>Currently the only way to lauch such applications is either to use
>terminal and cd to working directory and then run application, or
>create custom bash launcher,
Third option:
In the existing launcher instead of:
wine "X:\pathto\program.exe"
On Wed, 08 Apr 2009 11:39:08 +0200, you wrote:
>Rein Klazes writes:
>
>> @@ -203,9 +203,9 @@ void WINAPI _fpMath( CONTEXT *context )
>> context->Eax &= ~0x; /* set AX to 0 */
>> break;
>>
>> -case 11: /* just returns the
On Thu, 02 Apr 2009 17:21:37 +0200, you wrote:
>It doesn't work here:
>
>../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p
>user32_test.exe.so combo.c && touch combo.ok
>combo.c:143: Tests skipped: Invalid Marlett font heights
>combo.c:143: Tests skipped: Invalid Marlett font height
Reece Dunn schreef:
There is a checklist that Alexandre uses to judge patches before he
accepts them. I can't remember the link to this, though.
- Reece
I can not remember this checklist, I would be interested if you find it.
And I think the delay has to do with the nature of this patch: u
Rein Klazes schreef:
Hi,
Proposed fix for some problems mentioned in the previous patch.
I hope putting the logic in menu.c is an acceptable way to cross
the window<->menu border. If you want it somewhere else, let me know.
Rein.
Several rounds of commits have gone by. Still not co
Reece Dunn schreef:
= Implementation Comments:
+/* FIXME: this check is performed several times, here and in the called
+ functions. That could be optimized */
+if( !hMenu || !MENU_GetMenu( hMenu )) {
+SetLastError( ERROR_INVALID_MENU_HANDLE) ;
+return FALSE;
+}
On Tue, 11 Apr 2006 10:24:14 +0200, you wrote:
>> Hi,
>>
>> There are a couple of entries in the bug database (at least #4334 and
>> #4664) where the application calculates a wrong pointer for bitmap data.
>> The application survives on Windows but crashes on wine.
>>
>>
>> Changelog:
>> dlls/x
On Sat, 08 Apr 2006 08:44:24 -0400, you wrote:
>On Sat, 2006-04-08 at 12:48 +0200, Rein Klazes wrote:
>> dlls/user : menu.c
>> Fix dereferencing a potential NULL pointer.
>
>This patch seems to be doing more than avoiding a NULL dereference.
That should not be. You ma
On Sat, 11 Mar 2006 19:23:14 -0800, you wrote:
>Pardon intrusion by this Wine user into this technical discussion.
>
>Is the problem with Pegasus Mail (PM) that is mentioned below something that
>is
>new with Wine 0.9.9? I know that I saw termination of "the complete program"
>whenever I sent a
On Sat, 11 Mar 2006 12:30:39 -0700, you wrote:
>> Not pasting back traces will make following the bug list by email rather
>Well it might be true, but to a point. Most of the debug traces are too
>wide and e-mail wraps them (so does maillist archive). That _does_ make
>it nearly impossible to se
On Sat, 11 Mar 2006 08:14:03 -0700, you wrote:
>Change Log: Add note to attach and not paste logs and back traces.
>
>Files changed: template/en/default/bug/edit.html.tmpl
>template/en/default/bug/create/create.html.tmpl
Not pasting back traces will make following the bug list by email rather
us
On Fri, 24 Feb 2006 14:29:45 -0600, you wrote:
>Author: Francois Gouget <[EMAIL PROTECTED]>
>Date: Fri Feb 24 15:34:09 2006 +0100
>
>user32: Handle WM_ENDSESSION in DefWinProc().
>DefWinProc() should call PostQuitMessage() on WM_ENDSESSION if the
>shutdown is proceeding.
Hi Francois,
This pat
On Tue, 28 Feb 2006 12:38:13 +0100, you wrote:
>This will badly hurt performance, you don't want to check alignment on
>every pixel. You should only check on the first one and copy 1 to 3
>pixels as needed to align things properly, then do the 4 pixels at a
>time thing.
Yes, it was rather optimiz
On Sat, 18 Feb 2006 15:18:00 +0100, you wrote:
>Hello,
>
>> This patch is giving me trouble:
>
>does the following patch help to solve your problem?
>
Yup, it works fine now.
Thanks,
Rein.
Hallo Martin.
This patch is giving me trouble:
>Author: Martin Fuchs <[EMAIL PROTECTED]>
>Date: Sat Feb 11 12:16:56 2006 +0100
>
>shell32: SHELL32_GetItemAttributes()
>- correct documentation which incorrectly claimed not to set any
> attribute bits
>- retrieve file attributes using SHGetPathF
On Fri, 10 Feb 2006 22:10:29 -0600, you wrote:
>- ULONGLONG time = *secs * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970;
>+ /* time < 0 means a date before midnight of January 1, 1970 */
>+ if (*secs < 0) return NULL;
I think the comment is incorrect: it should be *secs < 0;
>- if (st.wYear
On Fri, 27 Jan 2006 10:28:04 -0800, you wrote:
>(Apart from the other discussion) are you sure that you really
>mean that?
>"If the length is explicitly stated to be zero then don't do the
>calcrect but if the length is to be measured and happens to come
>out as zero then do do the calcrect"
>I
On Wed, 25 Jan 2006 14:57:19 +0100, you wrote:
>Also I think IS_STRING_ITEM is fine, there's no
>reason to add _ONLY since there's no other macro that would do a less
>specific test.
Naming can be bad, misleading and ambiguous by itself. I may not have
come up with something really pretty, but I
On Wed, 25 Jan 2006 07:49:57 -0800 (PST), you wrote:
>Hi Rein,
>
>-if (!str) return 0;
>+if (!str || count == 0) return 0;
> if (count == -1) count = strlenW(str);
>-if (count == 0) return 0;
>+if (count == 0) {
>+if( flags & DT_CALCRECT) {
>+rect->right = r
On Fri, 06 Jan 2006 22:41:00 -0500, you wrote:
>
>The set last error function added to GetMenuStringA and GetMenuStringW
>removed this check which seems to be still needed.
>if (!IS_STRING_ITEM(item->fType)) return 0;
>
>I have tried several times to make a patch of the changes required but I
>
On Mon, 26 Dec 2005 21:50:54 -, you wrote:
>Glancing through the patch, I see what you are trying to do, and some
>comments (and remember this is just from a glance so far)
>
>1. I'm not sure the MENU_SetItemData for the ownerdraw case is correct as it
>doesn't actually take a copy of the data
On Mon, 26 Dec 2005 10:57:04 -, you wrote:
>>You are correct. The real problem is that the text field should not be
>>used anymore for bitmaps handles after the hbmpItem field was added just
>>for that. This is proven by the fact that strings cannot only be
>>combined with owner draw menu, but
On Mon, 26 Dec 2005 16:13:10 +0800, you wrote:
>
>The fact that you need to intorduce the txtWasAllocated flag suggests that
>something is wrong. Also MF_OWNERDRAW certainly does not qualify as a MF_STRING
>alias. I'll try to play with your test case and see if I can find a better fix.
You are co
On Fri, 16 Dec 2005 19:06:13 +0100, you wrote:
>Also visually I do not see the failure that you are supposedly fixing.
Nah, I did not look straight. The flaw is visible but does not cause the
test to fail.
Rein.
On Fri, 16 Dec 2005 22:17:29 +0800, you wrote:
>Hello,
>
>here is hopefully a correct version of the patch.
>
>Changelog:
>Rein Klazes <[EMAIL PROTECTED]>
>Add another set of ScrollDC tests.
>Dmitry Timoshkov <[EMAIL PROTECTED]>
>Add
On Wed, 14 Dec 2005 22:42:28 +0800, you wrote:
>Well, the committed patch 1) does fix a visual glitch in the app I'm working on
>and 2) passes all the current tests.
1) You know that doesn't make it right. I see it causing visual glitches
in *three* programs here, girotel, native hh.exe and win
On Tue, 13 Dec 2005 23:53:07 +0800, you wrote:
>Changelog:
>Dmitry Timoshkov <[EMAIL PROTECTED]>
>There is no need to offset the source rectangle in the reverse
>direction before scrolling.
>
>--- cvs/hq/wine/dlls/x11drv/scroll.c 2005-11-22 12:41:07.0 +0800
>+++ wine/dlls/x11
On Mon, 5 Dec 2005 19:29:38 +, you wrote:
>On 12/5/05, Rein Klazes <[EMAIL PROTECTED]> wrote:
>>
>> On Win9x,ME RegCreateKeyEx ignores the backslash character if the subkey
>> begins with one. With a regression test.
>>
>
>Note that I'm not agains
On Mon, 05 Dec 2005 12:07:32 +0100, you wrote:
>
>You can't return from inside a __TRY block.
I did not know. Here is the next attempt:
Changelog:
dlls/ddraw : main.c, Makefile.in
Catch access violations when calling the DirectDrawEnumerateProc.
Rein.
--- wine/dlls/ddraw/main.c 2005-
On Sat, 3 Dec 2005 09:44:07 +0100, you wrote:
>> This is wrong. No user program should modify our internal data. I think
>> you need to copy this data into heap before passing it to the app. You
>> should make simple test to check if the data returned on windows is
>> within heap or not.
>
>Yeah,
On Tue, 29 Nov 2005 17:37:21 +0100, you wrote:
>Rein Klazes <[EMAIL PROTECTED]> writes:
>
>> Not included in the new release, no comments. Is there a problem with
>> this one ?
>
>I think it would be cleaner to have WineEngGetFontData do the right
>thing directly,
On Tue, 29 Nov 2005 10:33:49 -0600, you wrote:
> if (num_startup)
>+{
>+num_startup--;
> return 0;
>+}
Yes, that is more correct. Re-reading the MSDN this is what should be
happening.
Changelog:
dlls/winsock: socket.c
dlls/winsock/tests : sock.c
(With
On Tue, 29 Nov 2005 02:43:39 +0100, you wrote:
>... some _mbsinc calls
>
>... some putc calls
>
>And finally ...
>
>0009:Call msvcrt.fclose(7fe8fa90) ret=7f81ecf0
[snip]
>0009:Ret msvcrt.fclose() retval= ret=7f81ecf0
>0009:Call kernel32.OpenFile(7fe60252
>"i:\\mnt\\privat\\Origin6\\UNT
Hi,
>Modified files:
> dlls/wldap32 : control.c init.c winldap_private.h
> include: winldap.h
> tools/winapi : win32.api
>
>Log message:
> Francois Gouget <[EMAIL PROTECTED]>
> winldap.h should include windeh.f and schnlsp.h.
> Enclose the API def
On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
>Hi,
>
>with the latest winetest suite I've noticed the following changes:
>
>- On win98 my taskbar get's twice the size it used to be.
>- On win98/winxp the window border is a lot thicker.
>- On winxp the icons in my taskbar are a lot bigger. And als
On Mon, 21 Nov 2005 14:28:14 +0100 (CET), you wrote:
>the problem with the big icons is due to the fact that (somehow)
>CaptionWidth is changed.
I see it now, on XP in the Tele Tubby mode. Classic Windows is alright.
Hmm, it looks like the icons get bigger on about any SP_SETNONCLIENT
call. I n
On Sun, 20 Nov 2005 17:02:21 +0100, you wrote:
>Hi,
>
>with the latest winetest suite I've noticed the following changes:
>
>- On win98 my taskbar get's twice the size it used to be.
>- On win98/winxp the window border is a lot thicker.
>- On winxp the icons in my taskbar are a lot bigger. And als
On Tue, 15 Nov 2005 11:20:10 +0200, in gmane.comp.emulators.wine.user
you wrote:
> Hi all,
>
>I found that some applications does not work more. The last successfull
>version was 20050310.
>For testing I can propose one example :
>http://hem.bredband.net/alivor/ichat121b6.exe
In general if
On Wed, 28 Sep 2005 23:53:28 +0100, you wrote:
>I've tried the following
>
>1. Use DebugBreak before and after the RegisterClassEx16 call with no temp
>defined
>- Stacks are identical as far as winedbg traces (0x60 bytes)
Hi Jason,
This winedbg stack trace (info stack) is equivalent to the exami
On Sun, 18 Sep 2005 14:03:39 -0700, you wrote:
>http://bugs.winehq.org/show_bug.cgi?id=3348
>describes a scrolling problem that is probably pretty
>easy to fix.
>
>The nullsoft(?) installer used by picasa 2
>seems to have a problem with text scrolling
>in the latest snapshot of wine. Scrolling
>u
On 28 Jul 2005 11:46:46 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > | trace:module:load_dll looking for L"comm.dll" in
> > L"E:\\bin\\gt3\\GTWin;.;d:\\win98\\system;d:\\WIN98;d:\\windows;d:\\windows\\system;h:\\shared;r:\\x86\\Setup&q
On 27 Jul 2005 16:37:18 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > Girotel uses a 32 bit comm.dll located in the programs directory, which
> > is also the current directory. After this change I need to add an dll
> > override to load the prog
On Thu, 7 Jul 2005 13:26:11 -0500, you wrote:
> ChangeSet ID: 18748
> CVSROOT: /opt/cvs-commit
> Module name: wine
> Changes by: [EMAIL PROTECTED] 2005/07/07 13:26:11
>
> Modified files:
> dlls/ntdll : loadorder.c
>
> Log message:
> Use the same defaults for module
On Mon, 25 Jul 2005 21:28:27 +0200, you wrote:
>
> Hi Rein,
>
> could you try the attached patch. It's a hack and we probably need an
> implementation of softpub.h. I just want to make sure Girotel doesn't
> use the same ActionID
Yes that works. Here is the Girotel's output:
| fixme:wintrust:Wi
On Thu, 14 Jul 2005 13:37:53 +0200 (CEST), you wrote:
> Hi,
>
> currently we return ERROR_SUCCESS for WinVerifyTrust. Process Explorer
> expects some data because of this.
>
> As no trust provider is implemented yet, return TRUST_E_PROVIDER_UNKNOWN
> instead.
Paul,
Girotel was perfectly happy
On Wed, 8 Jun 2005 12:32:27 +0100, you wrote:
>
> /***
> + * reg_get_logfont
> + *
> + * Tries to retrieve logfont info from the specified key and value
> + */
> +static BOOL reg_get_logfont(LPCWSTR key, LPCWSTR v
On Mon, 30 May 2005 11:14:01 +0200 (CEST), you wrote:
> The other trickle we're seeing is with timezones. So in a similar way
> maybe we could get the data from the site below and import it all:
> http://www.timeanddate.com/library/abbreviations/timezones/
That is a very limited number of timezo
On Fri, 20 May 2005 13:11:47 +0200, you wrote:
> Thanks, that solved the problem;
> Would it be possible to make configure warn about the gif library (and
> disable using it) when it's the wrong library version? Just an idea (no
> I don't have any experience with hacking configure scripts)
Yo
On Thu, 19 May 2005 22:46:26 +0200, you wrote:
> olepicture.c:938: error: `DGifOpen' undeclared here (not in a function)
> olepicture.c:938: warning: type defaults to `int' in declaration of
> `pDGifOpen'
> olepicture.c: In function `_gif_inputfunc':
> olepicture.c:970: error: structure has no me
On Wed, 18 May 2005 21:15:05 +0200, you wrote:
> Rein Klazes wrote:
> > On Tue, 17 May 2005 23:06:51 +0200, you wrote:
> >>+RtlSystemTimeToLocalTime(&sys_time, &local_time);
> >>+/* liExpTimeZoneBias is not the s
On Tue, 17 May 2005 23:06:51 +0200, you wrote:
> +RtlSystemTimeToLocalTime(&sys_time, &local_time);
> +/* liExpTimeZoneBias is not the same as tzi.Bias since it
> takes
> + * disabled DST correction into account (tested on WinXP). */
> +
On Thu, 12 May 2005 02:59:38 -0500, you wrote:
> Hey,
>
> This is a patch for the WM_LBUTTONUP msg problem, but I've taken the
> advice of Dmitry and now all messages are dispatched.
>
> Changelog
> * Make sure all msg's are dispatched while tracking a WM_LBUTTONDOWN msg.
Patches like this have
On Tue, 10 May 2005 14:55:22 +0200, you wrote:
> Rein Klazes wrote:
> > +case WM_MEASUREITEM:
>
> How about an ok( ((MEASUREITEMSTRUCT*)lparam)->itemHeight > 0, ... )
> here? :)
Of course. I just did not want to add a complaining test case.
Please commit a patch
On 06 May 2005 16:01:06 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > I managed to fixed it in two ways:
> >
> > 1. put a
> > X11DRV_CoerceDIBSection( physDevDst, DIB_Status_InSync, FALSE );
> > at the end of X11DRV_BitBlt.
On Sun, 8 May 2005 21:00:28 +0200, you wrote:
> On 05/08/2005 04:21:46 PM, Rein Klazes wrote:
> > About the magic number: I looked at the value on Win2k and WinME with
> > different resolutions ( desktop->properties->settings, click on
> > advanced tab and change wh
On Sun, 8 May 2005 13:30:30 +0200, you wrote:
> On 05/08/2005 12:25:18 PM, Rein Klazes wrote:
> > That does not seem correct on the Win2k system that I am using for
> > testing.
>
> Right. Windows sets itemHeight before and not after WM_MEASUREITEM.
> Sorry for that.
&g
On Sun, 8 May 2005 11:14:52 +0200, you wrote:
> This fixes bug 2764 (the scrolling issue seems to be resolved
> already?). Verified this behaviour on WinXP and changed the comment to
> reflect that.
>
> ChangeLog:
> Ignore requested height for non-menubar ownerdraw popups too.
>
> Index: men
On Sat, 7 May 2005 19:48:02 +0900, you wrote:
> "Rein Klazes" <[EMAIL PROTECTED]> wrote:
>
> > >> E:\\MSVC\\BIN\\WINTEE32.EXE -h2a -vn
> >
> > 5e is the 16 bit window handle.
>
> 2a I'd guess, not 5e.
You guess correctly.
>
>
On 07 May 2005 14:21:42 +0200, you wrote:
> > Is anything else needed, I wonder?
>
> Yes, try something like this:
>
> Index: dlls/user/win.c
Works great. Thanks,
Rein.
Hi,
Another case where I don't think I know enough of the finer details for
a
correct solution.
MS Visual C++ 1.5 IDE - 16 bit win application - communicates its window
handle to WINTEE32.EXE - win32 app - to handle the build process:
>> E:\\MSVC\\BIN\\WINTEE32.EXE -h2a -vn
5e is the 16 bit
Hi,
Here is another problem in BigJig a jigsaw puzzle game (free download at
www.lenagames.com).
The program calls BitBlt with destination an in memory DIB. Inside
BitBlt, the destination bits are set to PAGE_NOACCESS:
| 0009:Call kernel32.VirtualProtect(727f,00123324,0001,77a5f7bc)
ret
Hi,
cc to wine-devel: I may overlooked something here.
The patch fixes a problem in BigJig a jigsaw puzzle game (free download
at www.lenagames.com) when it generates the pieces. The jigsaw piece
shapes are generated with a series of short (5-7 points) Polyline calls,
followed by a call to FloodF
On Mon, 2 May 2005 09:29:41 -0700 (PDT), you wrote:
> Hi Rein,
>
> > Indeed, what happens if you try this obvious patch:
> (snip context)
> -if ((width >= 0x1) || (height >= 0x1))
> +if ((height && width >= 0x1) || (width && height >= 0x1))
>
> This obvious patch is quite
On Fri, 29 Apr 2005 10:46:31 -0400, you wrote:
> This seems wrong to me on
> three counts: (1) MSDN states that if either width or height is zero, a 1x1
> monochrome bitmap is returned
Indeed, what happens if you try this obvious patch:
>8
On Tue, 19 Apr 2005 00:39:49 +0200 (EET), you wrote:
> The patch [1] causes WordViewer97 to stop redrawing correctly after the
> visible part of a loaded document has been scrolled. I may switch to
> another workspace and back to paint the thing OK and this annoys me.
>
> I think it is a bug. I
On 13 Apr 2005 17:11:57 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > --- wine/dlls/x11drv/dib.c 2005-04-13 08:55:39.0 +0200
> > +++ mywine/dlls/x11drv/dib.c2005-04-13 13:24:10.0 +0200
> > @@ -3484,6 +3484,41 @@ static v
On 13 Apr 2005 11:59:02 +0200, you wrote:
> >
> > What am I doing wrong here?
>
> Nothing, there's no way to avoid the race. You just need to ignore the
> BadMatch error in that case.
Right, here is the next try:
Changelog:
dlls/x11drv : dib.c
In X11DRV_DIB_SetImageBits avoid BadMatch err
On 11 Apr 2005 17:48:58 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > I tried to do this, you need to clip to the visible region as well. I
> > could not get it 100% full proof because of races between the clip
> > calculations and the
On Sat, 09 Apr 2005 10:19:36 +0200, you wrote:
> > Are you suggesting more checks then that the pixels are within the
> > dimensions of the drawable?
> you need at least to use the intersection of the bitmap and the drawable (not
> sure both start at (0,0) corner though).
I tried to do this, you
On Sat, 09 Apr 2005 07:15:43 +0200, you wrote:
> > I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a
> > patch from you. The patch (attached) is only 5 years old, I am sure you
> > remember all the details ;)
> sure... since RLE encoding can have holes (ie, it can jump a coup
Hi Eric,
I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a
patch from you. The patch (attached) is only 5 years old, I am sure you
remember all the details ;)
To be precise, I get X-errors in the calls to XGetSubImage caused by out
of range parameters. Fixing this by some par
On Mon, 28 Mar 2005 07:54:12 -0500, you wrote:
> As for the initial problem that I've
> reported (http://www.winehq.org/hypermail/wine-devel/2002/09/0748.html),
> you are correct, it's about interaction with the invalidated region.
> I've figured that while you have your hands wet in that code, ma
On 29 Mar 2005 21:03:27 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > windows : scroll.c
> > dlls/user/tests : win.c
> >
> > If ScrollWindowEx is called with SW_SCROLLCHILDREN flags for a window
> > with a
On 28 Mar 2005 12:48:11 +0200, you wrote:
> Rein Klazes <[EMAIL PROTECTED]> writes:
>
> > dlls/user : scroll.c
> > dlls/user/tests : win.c
> >
> > - GetScrollRange should return an empty range, both upper and lower
> > limit z
On Sun, 27 Mar 2005 11:34:12 -0500, you wrote:
> On Fri, Mar 25, 2005 at 11:11:04AM -0600, Alexandre Julliard wrote:
> > Modified files:
> > windows: scroll.c
> > dlls/x11drv: scroll.c
> > dlls/user/tests: win.c msg.c
> >
> > L
On Tue, 08 Mar 2005 09:53:07 +0100, I wrote:
> Hmm, this is about pixels that are copied from the outside of the
> visible region to the inside (that area will be invalidated and
> repainted if called through ScrollWindowEx, but with noticeable
> flickering and there might be direct uses of Scroll
On 07 Mar 2005 19:44:07 +0100, you wrote:
> > +for( i = 0; i < rdata->rdh.nCount; i++, rect += step) {
> > +DPtoLP(hdc, (LPPOINT)rect, 2);
> > +TRACE("Bit blitting %s to %ld,%ld\n",
> > wine_dbgstr_rect(rect),
> > +rect->left + d
On Wed, 02 Mar 2005 21:01:22 +0200, you wrote:
> I get it from the lack of an answer that MSDEV installs the regular way,
> and that it is able to compile a project with output redirected into the
> IDE so you can double click on errors and stuff?
Yes you can, console windows pop-up where they
On Sun, 20 Feb 2005 16:41:09 +0100, you wrote:
> On Sun, 20 Feb 2005 16:04:54 +0100
> Rein Klazes <[EMAIL PROTECTED]> wrote:
> >
> > Does this patch help?
> >
> > Rein.
>
> Unfortunately not - still the exact same error.
Surprise :(
OK, I can try o
On 10 Feb 2005 21:19:46 +0100, you wrote:
> Carl Sopchak <[EMAIL PROTECTED]> writes:
>
> > I guess my problem is that I have NO CLUE as to how this SHOULD be handled.
> >
> > Should the style be set to (style & ~WS_VISIBLE) when the rectangle is
> > {0,0;0,0}? Should {0,0;0,0} be considered
identified the concrete patch that introduces the problem.
>
> It's this one made by Rein Klazes:
> http://www.winehq.org/hypermail/wine-cvs/2005/01/0612.html
>
> What I see happening is the following:
>
> [EMAIL PROTECTED] system $ wine gothic.exe
> wine: Un
On Sun, 13 Feb 2005 10:31:12 +0100, you wrote:
> With one inline asm-statement this function would smaler and faster.
You are underestimating what compilers can do.
Filling some Gigabytes with your patch
(gcc 3.4, optimization -O2):
real0m32.037s
user0m29.584s
sys 0m0.051s
Origina
On Sun, 13 Feb 2005 13:43:34 +0100, you wrote:
> Rein Klazes wrote:
>
> >Hi,
> >
> >FrameRgn paints a frame around a region, the frame should be painted on
> >the inside of the edges, not the outside as it does now.
> >
> >
> It's a shame tha
1 - 100 of 262 matches
Mail list logo
