Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

2013-10-10 Thread Phil Krylov
Hello, On Thu, Oct 10, 2013 at 3:24 AM, Ken Thomases wrote: > On Oct 9, 2013, at 4:49 PM, Phil Krylov wrote: >> Do you consider adding an option to stop interpreting Command as Alt? > > I have not considered it. What would be gained? Do you want the Command key > interpre

Re: winemac: Add registry settings to make Option keys send Alt rather than accessing additional characters from the keyboard layout.

2013-10-09 Thread Phil Krylov
Thanks! Do you consider adding an option to stop interpreting Command as Alt? On Thu, Oct 10, 2013 at 1:30 AM, Ken Thomases wrote: > --- > dlls/winemac.drv/cocoa_window.m | 22 -- > dlls/winemac.drv/macdrv_cocoa.h |2 ++ > dlls/winemac.drv/macdrv_main.c |7 +++ > 3

Re: winemac: Don't return characters for Ctrl-(non-letter symbol) keypresses from ToUnicodeEx() as X11 driver already does (try 2)

2013-09-10 Thread Phil Krylov
Hi, On Tue, Sep 10, 2013 at 6:05 AM, Ken Thomases wrote: > Is there a specific problem that you're trying to fix? Yes. I didn't file a bug report yet, but an application I am using (IBM Translation Manager) has some functionality bound to Ctrl-[0-9/] keypresses. Now with the Mac driver when I pr

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode.

2013-09-03 Thread Phil Krylov
Hello, >-ME_EndToUnicode(unicode, wszText); >+unicode ? ME_EndToUnicode(1200, wszText) : ME_EndToUnicode(CP_ACP, >wszText); Personally I dislike this stuff in C code. Especially when you could make it shorter: ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText) -- Ph.

Re: Aric Stewart : usp10: Update diacritical script handling for non OpenType Itemization.

2013-03-14 Thread Phil Krylov
Hello, On Fri, Mar 15, 2013 at 12:52 AM, Aric Stewart wrote: > I am just getting back from a vacation so I will review this and your other > patch early next week when I am fully back. > > Thanks for doing work here! Thanks for replying, wasn't sure you saw my posts. And of course thanks for yo

Re: Aric Stewart : usp10: Update diacritical script handling for non OpenType Itemization.

2013-03-07 Thread Phil Krylov
Hello Aric, On Tue, Feb 5, 2013 at 11:25 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: ef4b7c5948e43d4ceeed98ba4ddbf6c59d36 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=ef4b7c5948e43d4ceeed98ba4ddbf6c59d36 > > Author: Aric Stewart > Date: Tue

Re: richedit: Store richedit version rather than boolean bEmulateVersion10 value

2008-07-03 Thread Phil Krylov
On 03/07/2008, Dylan Smith <[EMAIL PROTECTED]> wrote: > On Thu, Jul 3, 2008 at 2:01 PM, Juan Lang <[EMAIL PROTECTED]> wrote: > > > Hi Dylan, > > > > - if (!editor->bEmulateVersion10 || (editor->nEventMask & ENM_UPDATE)) > > + if (!editor->dwEmulatedVersion || (editor->nEventMask & ENM_UPDAT

Re: richedit: Store richedit version rather than boolean bEmulateVersion10 value.

2008-07-01 Thread Phil Krylov
On 29/06/2008, Dylan Smith <[EMAIL PROTECTED]> wrote: > On Sun, Jun 29, 2008 at 4:20 AM, Phil Krylov <[EMAIL PROTECTED]> wrote: > > Of course this looks most sane. But I'm asking if you're going to make > > use of the dwEmulatedVersion other than "< 0

Re: richedit: Store richedit version rather than boolean bEmulateVersion10 value.

2008-06-29 Thread Phil Krylov
2008/6/27 Dylan Smith <[EMAIL PROTECTED]>: > Currently msftedit.dll is implemented by loading riched20.dll and then > riched20.dll registers the classes that msftedit.dll normally register. > Native msftedit.dll appears to be a full implementation of the richedit > controls, rather than a wrapper.

Re: richedit: Store richedit version rather than boolean bEmulateVersion10 value.

2008-06-27 Thread Phil Krylov
Hi, 2008/6/27 Dylan Smith <[EMAIL PROTECTED]>: > riched20.dll is implementing all the versions of richedit controls (1.0, 2.0, > 3.0, and 4.1), so it is better to store the version that is being emulated. > The bEmulateVersion10 value is replaced with dwEmulatedVersion. I thought it implements 1.

Re: Wine code freeze in seven weeks; volunteers needed to fix 1.0 bugs

2008-03-16 Thread Phil Krylov
Hi, > > That patch is old and crusty and doesn't apply anymore. James should > > have an updated version. One thing I can add from looking at that patch is that the comments about the deficiency of MS richedit tables handling are true only for versions <=2.0. Later versions, including msftedit,

Re: Do we need a forum?

2008-02-19 Thread Phil Krylov
Hi, On 19/02/2008, Dan Kegel <[EMAIL PROTECTED]> wrote: > Steven Edwards wrote: > > My thoughts, as well as > > Tom's was that by creating a "blessed" location, all third parties as > > well as vendors that develop Wine related products could say "if you > > want to discuss using a vendor provided

Re: wine and msys rxvt.exe

2007-02-26 Thread Phil Krylov
On 26/02/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: "Wesley Parish" <[EMAIL PROTECTED]> wrote: > failed to load libX11.dll Looks like rxvt.exe is linked to an MSys provided X11 libraries that require a Windows X11 sever to be present and running. That's a sort of layer on layer and I don't

Re: WineD3D: Fix my name

2007-01-11 Thread Phil Krylov
Hi Dmitry, On 11/01/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: I'd say that since converting resources to UTF-8 makes them not compatible with any other resource compiler except wrc, IMO that's a bad idea At least one free resource compiler that claims to support UTF-8: http://www.jorgon.

Re: WineD3D: Fix my name

2007-01-11 Thread Phil Krylov
Hi Dmitry, On 11/01/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > At least one free resource compiler that claims to support UTF-8: > http://www.jorgon.freeserve.co.uk/#rc Unfortunately it's not Microsoft's rc.exe, i.e. not something I'm interested to compare wrc output/compatibility with.

Re: CRichEditCtrl: Performance issue

2006-11-17 Thread Phil Krylov
Hello, On 16/11/06, Renu Rajput <[EMAIL PROTECTED]> wrote: I am facing a performance issue in CRichEditCtrl under Wine. My application reads data from a *.dat file and displays it in the CRichEdit editor. When I try to open large data files, it takes a lot of time(around 4-5 minutes) to open the

Re: CRichEditCtrl: Performance issue

2006-11-17 Thread Phil Krylov
Hello, On 16/11/06, Renu Rajput <[EMAIL PROTECTED]> wrote: I am facing a performance issue in CRichEditCtrl under Wine. My application reads data from a *.dat file and displays it in the CRichEdit editor. When I try to open large data files, it takes a lot of time(around 4-5 minutes) to open the

Re: explorer: Build on Darwin versions prior to 8.0

2006-11-05 Thread Phil Krylov
Sorry guys, wrong list ;-) -- Ph.

explorer: Build on Darwin versions prior to 8.0

2006-11-05 Thread Phil Krylov
Hello, In Darwin versions prior to 8.0, the DiskArbitration framework was a private framework, that is, the headers were not included in SDK and the API was changing in every version. This patch fixes the build in these OS versions. -- Ph. diskarb.patch Description: Binary data

Re: Still can't even compile Wine at PowerPC-based Linux-box.

2006-10-08 Thread Phil Krylov
Hi Peter, If all you want is to build a Winelib program for Linux/ppc, you can try to comment out shdocvw-related stuff from dlls/Makefile.in, and rebuild. Will work fine if your application does not want this particular dll. On 09/10/06, Mike McCormack <[EMAIL PROTECTED]> wrote: > I have no cl

Re: msi/iTunes and questions

2006-09-20 Thread Phil Krylov
Hi, On 20/09/06, Paul Vriens <[EMAIL PROTECTED]> wrote: The single-quotes should be needed as the SQL statement in the trace showed: trace:msi:MSI_DatabaseOpenViewW L"SELECT `Message` FROM `Error` WHERE `Error` = The installlation of QuickTime did not complete successfully. iTunes requires Quic

Re: segfaults with last selection repaint patch in riched20

2006-08-11 Thread Phil Krylov
Hi Krzysztof, On 11/08/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: What are the circumstances? Is it after some delete/insert operation, or just after document load? Well I have not traced the whole sequence of calls to richedit, but from the display I can suppose the following. I am doin

segfaults with last selection repaint patch in riched20

2006-08-10 Thread Phil Krylov
Hi Krzysztof, I was getting a segfault in ME_MarkForPainting() after that patch (BTW great work), and started looking through the code. One thing I found was obviously a typo which can be easily fixed (BTW I don't know for sure but I'd also update pLastSelStartPara and pLastSelEndPara here): ---

Re: riched20: modify ME_CharFromPoint to work properly with password controls

2006-08-08 Thread Phil Krylov
Hi Matt, On 07/08/06, Matt Finnicum <[EMAIL PROTECTED]> wrote: This patch modifies ME_CharFromPoint to work properly with password controls (the patch i sent in / got committed a couple days ago). Should not the temp string be freed afterwards? -- Ph.

Re: riched20: new selection invalidation logic

2006-08-08 Thread Phil Krylov
Have you even tried your code on purposely broken rtf? How does it handle it? Broken rtf can only possibly break the RTF reader code, although it has not been happening for quite a long time. And the asserts are there to report Wine riched20 developer's errors, not the app developers'. -- Ph.

Re: [Bug 5769] Regression of wine 0.9.6 in riched20 causes program to fail

2006-07-28 Thread Phil Krylov
I was using fresh GIT from 2006-07-26.

Re: RESEND: enhmetafile: Read and write support for little-endian EMFs on big-endian machines

2006-07-05 Thread Phil Krylov
Hi, "Doctor, why everybody ignores me?" - "Next, please." -- Ph. On 03/07/06, Phil Krylov <[EMAIL PROTECTED]> wrote: Hi, Is anything wrong with that patch? On 25/06/06, Phil Krylov <[EMAIL PROTECTED]> wrote: > Hi, > > This version has no ugly mac

Re: RESEND: enhmetafile: Read and write support for little-endian EMFs on big-endian machines

2006-07-03 Thread Phil Krylov
Hi, Is anything wrong with that patch? On 25/06/06, Phil Krylov <[EMAIL PROTECTED]> wrote: Hi, This version has no ugly macros and adds read support. Diffed against current CVS. ChangeLog: enhmetafile: Read and write support for little-endian EMFs on big-endian machines. -- Ph.

Re: forgotten patch

2006-06-22 Thread Phil Krylov
On 22/06/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: This patch apparently has been lost, and there's at least one bug inBugzilla that the patch seems to fix (bug# 4452, checked here). http://www.winehq.org/pipermail/wine-patches/2006-January/023875.htmlI don't see anything wrong with the patc

Re: x11drv: question about byte-swapping for DIBs

2006-04-19 Thread Phil Krylov
On Thu, 20 Apr 2006 00:10:42 +0200 Willie Sippel <[EMAIL PROTECTED]> wrote: > Am Mittwoch, 19. April 2006 22:50 schrieb Eric Frias: > > I'm trying to debug a problem in which 24-bit .bmps don't display > > correctly from a winelib application on a big-endian sparc host when > > displaying on a lit

Re: x11drv: question about byte-swapping for DIBs

2006-04-19 Thread Phil Krylov
On Wed, 19 Apr 2006 16:50:47 -0400 Eric Frias <[EMAIL PROTECTED]> wrote: > I'm trying to debug a problem in which 24-bit .bmps don't display > correctly from a winelib application on a big-endian sparc host when > displaying on a little-endian intel PC. In this case, the image is > garbled, wi

Re: enhmetafile: Create little-endian EMF files on big-endian machines (fixed)

2006-04-19 Thread Phil Krylov
On Wed, 19 Apr 2006 12:52:35 +0200 Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Phil Krylov <[EMAIL PROTECTED]> writes: > > > Anything wrong with this patch? Should I try to improve it in the direction > > of > > supporting more metafile record types

Re: enhmetafile: Create little-endian EMF files on big-endian machines (fixed)

2006-04-19 Thread Phil Krylov
Hi, On Tue, 11 Apr 2006 20:03:22 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > This patch fixes the generation of EMF files (which are little-endian by > nature) > on big-endian machines. It is by no means complete - some record types are > still > unsupported, and rea

Re: dosdevices

2006-04-18 Thread Phil Krylov
On Tue, 18 Apr 2006 22:38:11 +1000 Robert Lunnon <[EMAIL PROTECTED]> wrote: > All, > I am having some considerable problems dealing with a simple issue. > In .wine/dosdevices, devices are listed followed by a colon like in dos. This > makes perfect sense except that the colon is often used in UN

Re: [gdi] bug reading/writing metafiles on sparc

2006-04-13 Thread Phil Krylov
On Thu, 13 Apr 2006 16:39:02 -0400 Eric Frias <[EMAIL PROTECTED]> wrote: > Phil Krylov wrote: > > >I have submitted a patch that fixes creation of on-disk _enhanced_ metafiles > >a few days ago: > > > >http://article.gmane.org/gmane.comp.emulators.wine.patc

Re: [gdi] bug reading/writing metafiles on sparc

2006-04-13 Thread Phil Krylov
On Thu, 13 Apr 2006 22:39:57 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > It byteswaps EMF records just for writing to disk. Adding > byteswapping for reading from disk seems very easy - just feed the file > content to the same byteswapper functions. I think it is a bit more clea

Re: [gdi] bug reading/writing metafiles on sparc

2006-04-13 Thread Phil Krylov
On Thu, 13 Apr 2006 11:58:02 -0400 Eric Frias <[EMAIL PROTECTED]> wrote: > Due to little-endian/big-endian differences, winelib on Sparc can't read > windows metafiles generated on a PC (or on Wine on x86), and conversely > PCs can't read metafiles created on a Sparc. It looks like there are a

Re: README: Updated to not point users at wineinstall and to mention fontforge

2006-04-10 Thread Phil Krylov
On Mon, 10 Apr 2006 04:43:59 -0400 Segin <[EMAIL PROTECTED]> wrote: > Add these lines for those people that ask us how to use ~ARCH fontforge > instead of RTFMing: > > To enable ~ARCH fontforge without setting your whole system ~ARCH, do > this (as root): > > echo "=media-gfx/fontforge-2006040

Re: README: Updated to not point users at wineinstall and to mention fontforge

2006-04-10 Thread Phil Krylov
On Mon, 10 Apr 2006 10:05:33 +0200 Kai Blin <[EMAIL PROTECTED]> wrote: > * Phil Krylov <[EMAIL PROTECTED]> [10/04/06, 11:52:01]: > > On Mon, 10 Apr 2006 08:18:51 +0200 > > Kai Blin <[EMAIL PROTECTED]> wrote: > > > > > Also added fontforg

Re: README: Updated to not point users at wineinstall and to mention fontforge

2006-04-10 Thread Phil Krylov
On Mon, 10 Apr 2006 08:18:51 +0200 Kai Blin <[EMAIL PROTECTED]> wrote: > Also added fontforge to the build requirements list, with a note to Gentoo > users to update their version of fontforge, as the version currently used in > Gentoo doesn't work. Too late: today's Gentoo Portage has fontforg

Re: richedit20: Implement EM_FORMATRANGE

2006-04-04 Thread Phil Krylov
On Tue, 4 Apr 2006 11:46:18 +1000 Troy Rollo <[EMAIL PROTECTED]> wrote: > + * *** Notes on tables *** > + * > + * The CHARRANGE structure passed in the FORMATRANGE structure is not > + * sufficient to deal with tables, where we would need information on the > + * start position for text in each co

Re: Debugging X errors?

2006-03-28 Thread Phil Krylov
On Tue, 28 Mar 2006 15:25:26 -0500 Segin <[EMAIL PROTECTED]> wrote: >(Try this: select some text in Wine, and middle click in a > Xterm, nothing happens! Go back to the Windows app, tell it to copy the > text, and try to paste it into the xterm, nothing again! I think it's a > bug IMHO) You nee

Re: riched20: add EM_EXSETSEL conformance tests and fixes bug 4462

2006-03-16 Thread Phil Krylov
On Thu, 16 Mar 2006 22:31:40 -0800 (PST) Brian Chang <[EMAIL PROTECTED]> wrote: > +/* get the current selection and text length */ > +RichEditANSIWndProc(hWnd, EM_GETSEL, (WPARAM) &start, (LPARAM) &end); > +textlen = RichEditANSIWndProc(hWnd, WM_GETTEXTLENGTH, 0, 0); This looks strang

Re: riched20: Implements FR_WHOLEWORD for EM_FINDTEXT

2006-03-06 Thread Phil Krylov
On Sun, 05 Mar 2006 14:20:47 -0800 Lei Zhang <[EMAIL PROTECTED]> wrote: > +if ((flags & FR_WHOLEWORD) && iswalnum(wLastChar)) Probably a test checking if native richedit does not use user's word breaking procedure (set via EM_SETWORDBREAKPROC) for FR_WHOLEWORD searches would be cool. --

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT

2006-02-24 Thread Phil Krylov
On Fri, 24 Feb 2006 10:48:47 -0800 Lei Zhang <[EMAIL PROTECTED]> wrote: > On Friday 24 February 2006 04:39 am, Phil Krylov wrote: > > On Fri, 24 Feb 2006 12:24:45 +0100 > > > > Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > > Phil Krylov <[EMAIL PR

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT

2006-02-24 Thread Phil Krylov
On Fri, 24 Feb 2006 12:24:45 +0100 Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Phil Krylov <[EMAIL PROTECTED]> writes: > > > On Tue, 21 Feb 2006 14:08:38 -0800 > > Lei Zhang <[EMAIL PROTECTED]> wrote: > >> > >> Hi Phil, > >>

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT

2006-02-24 Thread Phil Krylov
On Tue, 21 Feb 2006 14:08:38 -0800 Lei Zhang <[EMAIL PROTECTED]> wrote: > On Tuesday 21 February 2006 12:42 pm, you wrote: > > On Tue, 21 Feb 2006 10:19:01 -0800 > > > > Lei Zhang <[EMAIL PROTECTED]> wrote: > > > - while (pCurItem && > > > pCurItem->member.run.strText->szData[nCurEnd - nMatch

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT

2006-02-21 Thread Phil Krylov
On Tue, 21 Feb 2006 10:19:01 -0800 Lei Zhang <[EMAIL PROTECTED]> wrote: > - while (pCurItem && pCurItem->member.run.strText->szData[nCurEnd - > nMatched - 1] == text[nLen - nMatched - 1]) > + while (ME_CharCompare(pCurItem->member.run.strText->szData[nCurEnd - > nMatched - 1], text[nLe

Re: msftedit.dll

2006-02-03 Thread Phil Krylov
On Sat, 4 Feb 2006 00:07:24 +0100 Stefan Leichter <[EMAIL PROTECTED]> wrote: > +2 stub IID_IRichEditOle > +3 stub IID_IRichEditOleCallback > +4 stub CreateTextServices > +5 stub IID_ITextServices > +6 stub IID_ITextHost > +7 stub IID_ITextHost2 > +8 stub REExtendedRegisterClass > +9 stub RichEditA

Re: Text Object Model and Richedit?

2006-01-30 Thread Phil Krylov
On Mon, 30 Jan 2006 08:31:59 -0800 Dan Kegel <[EMAIL PROTECTED]> wrote: > I stumbled across the doc for the "Text Object Model", > which looks like the COM interface to Richedit and > anything like it: > > http://windowssdk.msdn.microsoft.com/library/en-us/shellcc/platform/commctls/richedit/texto

Re: [patch] updated riched20 conformance test

2006-01-29 Thread Phil Krylov
On Tue, 24 Jan 2006 12:23:09 -0800 Thomas Kho <[EMAIL PROTECTED]> wrote: > Attached is a small patch to add a riched20 conformance test. I think it's a good test, but I'd add "flags %08x",...flags to the failing test messages, because all these failures are due to unimplemented flags. And probab

Re: Mac OS X/Intel port

2006-01-22 Thread Phil Krylov
On Sun, 22 Jan 2006 01:12:09 -0600 Chris Campbell <[EMAIL PROTECTED]> wrote: >I just recently downloaded the CVS of WINE and tried to build it > on an Apple Intel machine. I ran into some problems during the build > and fixed them. I then got to the server and the build quit on > conte

Re: translation of wine/programs/wcmd/Ru.rc

2006-01-16 Thread Phil Krylov
On Mon, 16 Jan 2006 18:00:04 +0300 Roman <[EMAIL PROTECTED]> wrote: > I've translaten most of the messages There are some typos: +из другого bat-файла. При по завершении вывываемого командного файла, управление возвращается\n\ should be: +из другого bat-файла. По завершении вызываемого командн

Re: user: Implement scrolling in popup menus

2006-01-15 Thread Phil Krylov
Hi, Anything wrong with that patch? (Yes I know that separate arrow bitmaps should be used instead of the scrollbar ones. But I can't draw ;) On Sat, 7 Jan 2006 16:54:15 +0300 Phil Krylov <[EMAIL PROTECTED]> wrote: > ChangeLog: > > Added scrolling support to popup menus wh

Re: RESEND: winecfg: Added "Use PRIMARY selection" option

2006-01-10 Thread Phil Krylov
On Tue, 10 Jan 2006 20:23:20 +0100 Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Phil Krylov <[EMAIL PROTECTED]> writes: > > > ChangeLog: > > > > Added support for "Use PRIMARY selection" clipboard option. > > I don't think we want a

Re: user: Fix dropdown combo creation when there is no space for an edit control

2006-01-09 Thread Phil Krylov
Hi, Sorry, I meant: ChangeLog: Fixed dropdown combo creation when there is NO space for an edit control. -- Ph.

Re: winecfg: Added "Use PRIMARY selection" option

2006-01-01 Thread Phil Krylov
Hi, On Fri, 30 Dec 2005 12:43:56 +0100 Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > Added support for "Use PRIMARY selection" clipboard option. > One question: Why not make this the default? This would be the unix way to > use > the clipboard. It would be OK for me, but probably there was so

Re: enhmfdrv: Return proper values from GDI APIs

2005-10-23 Thread Phil Krylov
On Fri, 21 Oct 2005 16:14:25 +0200 Alexandre Julliard <[EMAIL PROTECTED]> wrote: > I think it would be cleaner to simply fall through to the generic code > after calling the driver for these operations. Also there's no need to > add a FIXME on every single operation, this will cause a lot of noise

Re: enhmfdrv: Return proper values from GDI APIs

2005-10-21 Thread Phil Krylov
Hi, Are there any problems to apply this patch before 0.9? On Mon, 17 Oct 2005 03:43:55 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > Hi, > > This patch fixes EMF rendering in some programs that depend on the fact > that SetTextAlign(), SetBkMode(), SetROP2(), SetP

CopyEnhMetaFile() on big endian arch

2005-09-27 Thread Phil Krylov
Hi, My problem is: CopyEnhMetaFile() creates a .wmf file from a HENHMETAFILE by simple dumping of data to the file. On big-endian platforms (in my case - PowerPC) the resulting file is not a valid WMF. To make it valid, we need to convert all binary data to little-endian. I'd like to make it wor

Re: build errors

2005-09-27 Thread Phil Krylov
On Mon, 26 Sep 2005 22:53:18 -0300 Marcelo Duarte <[EMAIL PROTECTED]> wrote: > To fix the problem for me, instead of clean, I__d do the folowing command > in wine tree: > rm */*/*.spec.* Thanks, it works. But isn't "make clean" supposed to do this job? -- Ph.

build errors

2005-09-26 Thread Phil Krylov
Hi, I can't build current CVS version of Wine: ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./kernel32.spec comm.drv.spec.o krnl386.exe.spec.o stress.spec.o system.drv.spec.o toolhelp.spec.o win87em.spec.o windebug.spec.o atom16.o error16.o kernel16.o registry16.o toolhelp16.o win8

Re: listview: infoPtr might be invalid after WM_NOTIFY

2005-09-21 Thread Phil Krylov
On Tue, 20 Sep 2005 16:20:50 -0500 Robert Shearman <[EMAIL PROTECTED]> wrote: > Since this was a behaviour in our file open dialog, did we even verify > that this was a listview bug or is it that destroying the listview in > the middle of a notification is something that you shouldn't do? The n

Re: Need help debugging a memory corruption bug in shfldr_unixfs.c

2005-09-12 Thread Phil Krylov
On Fri, 9 Sep 2005 15:09:24 -0400 "Dimi Paun" <[EMAIL PROTECTED]> wrote: > From: "Phil Krylov" <[EMAIL PROTECTED]> > > OK, should we then make a patch which adds an IsWindow() check after every > > notification in every control? This one fixes a real

Re: LTSpice/SwitcherCad III Regression with Rich text patch ID=19048

2005-09-10 Thread Phil Krylov
On Sat, 10 Sep 2005 13:49:23 -0400 paul <[EMAIL PROTECTED]> wrote: > I did regression testing and found patch Id=19048 triggers this error > > wine-pthread: run.c:142: ME_RunOfsFromCharOfs: Assertion `nCharOfs >= > nParaOfs' failed. > > filed http://bugs.winehq.org/show_bug.cgi?id=3239 > The

Re: Need help debugging a memory corruption bug in shfldr_unixfs.c

2005-09-09 Thread Phil Krylov
On Fri, 9 Sep 2005 13:59:05 -0400 "Dimi Paun" <[EMAIL PROTECTED]> wrote: > From: "Phil Krylov" <[EMAIL PROTECTED]> > > Here is a patch which adds checking if the window has been destroyed at > > that point. I don't know if it is acceptable but i

Re: Need help debugging a memory corruption bug in shfldr_unixfs.c

2005-09-08 Thread Phil Krylov
Hi Michael, On Thu, 8 Sep 2005 23:10:18 +0200 Michael Jung <[EMAIL PROTECTED]> wrote: > Wouldn't it be enough to call notify_click after notify_itemactivate? I've > attached a modification of your patch, which does just this. Seems to work > fine for me. Probably, but what if some apps depend

Re: Need help debugging a memory corruption bug in shfldr_unixfs.c

2005-09-08 Thread Phil Krylov
On Fri, 26 Aug 2005 23:03:33 +0200 Michael Jung <[EMAIL PROTECTED]> wrote: > Every time you double click a folder, the current ShellView object is > destroyed and a new one is created. Given that I have to browse into like 30 > different folders before it crashes on me, I can't pin down the rele

Re: Opposite for wine_get_unix_filename()

2005-09-03 Thread Phil Krylov
On Sat, 03 Sep 2005 09:52:25 + Jacek Caban <[EMAIL PROTECTED]> wrote: > You may use wine_get_dos_file_name(). Oh sorry, somehow I missed that... -- Ph.

Opposite for wine_get_unix_filename()

2005-09-03 Thread Phil Krylov
Hi, What can I use as a function opposite to wine_get_unix_filename() (e.g. to pass a filename to GetSaveFileNameW() dialog)? -- Ph.

Re: Need help debugging a memory corruption bug in shfldr_unixfs.c

2005-08-29 Thread Phil Krylov
On Fri, 26 Aug 2005 22:10:16 +0200 Michael Jung <[EMAIL PROTECTED]> wrote: > 2) Did other people see this bug already? Yes, I confirm it. -- Ph.

Re: Automatic ANSI<>Unicode message translation

2005-08-21 Thread Phil Krylov
On Tue, 26 Jul 2005 21:26:29 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > "Phil Krylov" <[EMAIL PROTECTED]> wrote: > > > Oh sorry. For some reason I thought that HIWORD(wParam) is used for some > > other data. Here is a new patch, is it

Re: RICHED20: Avoid flicker

2005-08-18 Thread Phil Krylov
On Sun, 14 Aug 2005 17:53:33 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > this patch needs to be applied after the "Re: RICHED20: Implement > EM_SETRECT, EM_SETRECTNP and WM_SETREDRAW messages (fixed)" patch. > > ChangeLog: > > Avoid flicker in RichEdit using

Re: RichEdit flicker

2005-08-14 Thread Phil Krylov
On Sat, 13 Aug 2005 18:51:06 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > > The paragraph structure should include not MEPF_REWRAP and MEPF_REPAINT > > flags, but indexes of rows from which to start re-wrapping and repainting > > (e.g. nStartRewrap and nStartRepain

Re: RichEdit flicker

2005-08-13 Thread Phil Krylov
On Sat, 13 Aug 2005 12:47:19 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > The paragraph structure should include not MEPF_REWRAP and MEPF_REPAINT > flags, but indexes of rows from which to start re-wrapping and repainting > (e.g. nStartRewrap and nStartRepaint). The wrapping

RichEdit flicker

2005-08-13 Thread Phil Krylov
Hi Krzysztof, I want to change wrapping and painting code to minimize flickering and maximize performance. >From what I see, the following could be done: The paragraph structure should include not MEPF_REWRAP and MEPF_REPAINT flags, but indexes of rows from which to start re-wrapping and repaint

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Phil Krylov
Hi Dmitry, On Tue, 26 Jul 2005 16:56:31 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > The key word is "the whole" wparam. So, there is no need to truncate it > by using LOWORD. Oh sorry. For some reason I thought that HIWORD(wParam) is used for some other data. Here is a new patch, is it

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Phil Krylov
On Tue, 26 Jul 2005 16:31:50 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > "Phil Krylov" <[EMAIL PROTECTED]> wrote: > > > > This patch is not correct. All messages which potentially go through > > > wineserver > > > s

Re: Automatic ANSI<>Unicode message translation

2005-07-26 Thread Phil Krylov
On Tue, 26 Jul 2005 16:04:22 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > This patch is not correct. All messages which potentially go through > wineserver > should be posted/sent via unicode. OK, then how you would suggest to solve the problem described in previous messages of this thr

Re: Automatic ANSI<>Unicode message translation

2005-07-25 Thread Phil Krylov
On Tue, 26 Jul 2005 10:15:58 +1000 Troy Rollo <[EMAIL PROTECTED]> wrote: > If you call SendMessageW under native Windows the translation happens. If you > call SendMessageA it does not. This is all exactly what I would expect. > > By my test, sending 0xf301 with SendMessageA gets 0xf301 on Windo

Re: change in dlls/version/info.c breaks IBM Translation Manager

2005-07-25 Thread Phil Krylov
Hi, On Mon, 25 Jul 2005 21:37:09 +0200 Paul Vriens <[EMAIL PROTECTED]> wrote: > could you try the attached. I only convert the win32 to win16 if we are > not getting a request for '\' or '\VarFileInfo\Translation'. Both > requests do not need a conversion anyway. > > This is just a quick hack f

Re: change in dlls/version/info.c breaks IBM Translation Manager

2005-07-24 Thread Phil Krylov
Hi Paul, On Sun, 24 Jul 2005 19:17:42 +0200 Paul Vriens <[EMAIL PROTECTED]> wrote: > Will come up with a fix soon. Thanks a lot! -- Ph.

Re: change in dlls/version/info.c breaks IBM Translation Manager

2005-07-24 Thread Phil Krylov
On Sun, 24 Jul 2005 11:56:38 +0200 Paul Vriens <[EMAIL PROTECTED]> wrote: > could you also send me a +ver trace? Here it is (attached). -- Ph. trace Description: Binary data

change in dlls/version/info.c breaks IBM Translation Manager

2005-07-23 Thread Phil Krylov
Hello, http://cvs.winehq.org/cvsweb/wine/dlls/version/info.c.diff?r1=1.47&r2=1.48&f=h This recent change in dlls/version/info.c breaks IBM Translation Manager on startup: > wine: Unhandled exception (thread 0009), starting debugger... > WineDbg starting on pid 0x8 > Unhandled exception: page fau

Re: RICHED20: EM_SETZOOM / EM_GETZOOM implementation

2005-07-22 Thread Phil Krylov
On Fri, 22 Jul 2005 16:32:17 -0400 "Dimi Paun" <[EMAIL PROTECTED]> wrote: > From: "Phil Krylov" <[EMAIL PROTECTED]> > > Added EM_GETZOOM and EM_SETZOOM RichEdit message handlers. > > > + case EM_GETZOOM: > > +if (!wParam || !lParam) &

Re: RICHED20: TODO list additions

2005-07-22 Thread Phil Krylov
Hi Dmitry, On Sat, 23 Jul 2005 00:41:42 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > What kind of hyphenation richedit needs? Would an automatic, not > dictionary based algorithm suffice? Actually I'm unsure if the original RichEdit implements any hyphenation algorithm itself. However,

Re: Fix ntdll compilation in Darwin

2005-06-30 Thread Phil Krylov
Hi Dmitry, On Thu, 30 Jun 2005 22:27:01 +0900 "Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: > "Phil Krylov" <[EMAIL PROTECTED]> wrote: > > > Index: dlls/ntdll/cdrom.c > > ===

Re: wine/dlls/crypt32 tests/encode.c encode.c

2005-06-15 Thread Phil Krylov
Hi, this change gives me a lot of errors when compiling: make[3]: Entering directory `/home/phil/build/wine/dlls/crypt32/tests' ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole encode.o main.o protectdata.o testlist.o -o crypt32_test.exe.so -L../../../ libs/port -lwine_port -L

Re: storage32.c fix for big endian arch

2005-05-17 Thread Phil Krylov
Please disregard, Pierre d'Herbemont already sent the same few hours before :) -- Ph. On Tue, 17 May 2005 21:41:41 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > ChangeLog: > > Fixed storage32.c compilation in big endian architectures. > > Patch: > &g

Re: Resend: RICHED20: fall back to simple test

2005-04-20 Thread Phil Krylov
On Thu, 21 Apr 2005 00:58:10 +0900 Mike McCormack <[EMAIL PROTECTED]> wrote: > You've done great work, and I thought you would want to know about a > problem with it so you could correct it. No need for "sorry" :) I wrote "sorry" because I feel sorry :) I should give a more thorough testing to

Re: ie6install richedit regression

2005-04-20 Thread Phil Krylov
On Mon, 18 Apr 2005 21:43:46 +0200 Paul van Schayck <[EMAIL PROTECTED]> wrote: > http://cvs.winehq.org/patch.py?id=17049 > > This richedit patch broke ie6install.exe (doesn't start). As far as I > can see the character stream is not setuped correctly. There is an > endless loop of ME_PropagateCha

Re: Resend: RICHED20: fall back to simple test

2005-04-20 Thread Phil Krylov
Hi, On Wed, 20 Apr 2005 04:31 pm, Mike McCormack wrote: > > Hi Phil, > > > > This patch broke Internet Explorer 6 installation. The installer gets > > into an infinite loop reading the License text for the first dialog. > > > > Mike Sorry. See the fix on wine-patches. -- Ph.

Re: Riched20: thanks + regression "beta" not shown

2005-04-01 Thread Phil Krylov
On Fri, 01 Apr 2005 18:04:32 +0200 Tobias Burnus <[EMAIL PROTECTED]> wrote: > Hmm, I think the reason for my boxes was that I didn't install > symbol.ttf from Windows (I had only a "Symbol Set BT" and bitmap fonts > before). Yes, I also noticed some problems with font substitution... -- Ph.

Re: Fwd: Wine install fails on Gentoo with `SYS_sigaction' undeclared

2005-03-26 Thread Phil Krylov
Hi, > I am using Gentoo with a linux kernel of 2.6.10 on a dual-Xeon 3.2ghz > 64-bit system. I am using Gentoo with 2.6.10 on 32-bit Athlon XP and don't have this problem, so I suppose it must be something with 64-bitness. -- Ph.

Re: Riched20: thanks + regression "beta" not shown

2005-03-24 Thread Phil Krylov
Hi, On Thu, 24 Mar 2005 10:13:30 +0100 Tobias Burnus <[EMAIL PROTECTED]> wrote: > Regression: One of the later riched20 patches, possibly > http://cvs.winehq.org/patch.py?id=16672, caused a regression with the > richedit control in Diamond. > > Before it showed a beta character from the Symbol f

Re: RICHEDIT: RTF reader i18n (now with font charset support)

2005-03-21 Thread Phil Krylov
On Mon, 21 Mar 2005 14:40:38 +0300 Vitaly Lipatov <[EMAIL PROTECTED]> wrote: > > > Will we do this code in locale independent manner? Why we have > > > ansiCodePage=1252 by default? > > > > It is locale independent. 1252 is the default value used if RTF does not > > specify another codepage (which

Re: RICHEDIT: RTF reader i18n (now with font charset support)

2005-03-18 Thread Phil Krylov
On Fri, 18 Mar 2005 15:12:01 +0300 Vitaly Lipatov <[EMAIL PROTECTED]> wrote: > В сообщении от 17 Март 2005 13:20 Phil Krylov написал(a): > > this patch replaces my precious patch "RICHEDIT: RTF reader i18n" and > > needs to be applied after Krzysztof

Re: richedit patches by Phil Krylov

2005-03-14 Thread Phil Krylov
On Mon, 14 Mar 2005 19:31:25 +0100 Krzysztof Foltman <[EMAIL PROTECTED]> wrote: > > ChangeLog: > > Initial implementation of EM_STREAMOUT and RTF writer. > > Nice to see this functionality implemented (I really didn't want to > implement it myself). Very good code too. Thanks. Thanks :) > Th

Re: richedit patches by Phil Krylov

2005-03-14 Thread Phil Krylov
On Mon, 14 Mar 2005 19:31:25 +0100 Krzysztof Foltman <[EMAIL PROTECTED]> wrote: > > ChangeLog: > > Initial implementation of EM_STREAMOUT and RTF writer. > > Nice to see this functionality implemented (I really didn't want to > implement it myself). Very good code too. Thanks. Thanks :) > Th

Re: richedit patches by Phil Krylov

2005-03-14 Thread Phil Krylov
On Mon, 14 Mar 2005 20:25:52 +0100 Krzysztof Foltman <[EMAIL PROTECTED]> wrote: > Phil Krylov wrote: > > > The RTF reader still has to be teached Unicode. Currently most of my > > existing > > .rtf documents are totally garbled. > > Can you fix it ? Judgin

  1   2   >