Re: user32: implement support for HBMENU_POPUP_* magic menu bitmaps and use them to decorate the system menu

2009-02-20 Thread Peter Oberndorfer
On Freitag 20 Februar 2009, Rein Klazes wrote: > Hi, > > See subject. > > Rein. > Hi, mostly minor code style comments. >      if( hMenu ) { > +        MENUINFO minfo; > +        MENUITEMINFOW miteminfo; >          POPUPMENU* menu = MENU_GetMenu(hMenu); >          menu->wFlags |= MF_SYSMENU |

Re: [resend2] gdi32/tests: Add a test for GdiGetCodePage().

2008-12-14 Thread Peter Oberndorfer
On Sonntag 14 Dezember 2008, ByeongSik Jeon wrote: > http://bugs.winehq.org/show_bug.cgi?id=16325 > > 2008-12-14 (Sun), 13:34 +0100, Paul Vriens wrote: > > Could you turn the skip in this piece of code: > > > > +if (!pGdiGetCodePage) > > +{ > > +skip("GdiGetCodePage not available

Re: [1/2] richedit: Created initial tests for windowless richedit controls. (try 2)

2008-11-08 Thread Peter Oberndorfer
On Samstag 08 November 2008, Dylan Smith wrote: > (Ensured compiler independence by modifying byte code templates) > > The initial tests added simply call CreateTextServices, and query for > the ITextServices interface, then cleans up. > > Since CreateTextServices needs an implementation of IText

Re: msvcrt: scanf fix a typo

2008-09-20 Thread Peter Oberndorfer
> > > > I'm still positive the original author meant to use capital P. > > There's no point in adding yet another test for a number that is > > different by one digit. > > > I have to agree with James here. The original author (Peter Oberndorfer) >

Re: Most common winetest failures on wine

2008-05-19 Thread Peter Oberndorfer
On Montag 19 Mai 2008, Jeremy White wrote: > > ntdll:info is a flaky test marked todo_wine that succeeds sometimes: > > "info.c:822: Test succeeded inside todo block: Expected to read 0 > > bytes, got 0" > > Hardy seems to be the common variable for failures, and it seems as though > an actual fai

Re: user32: correct the caption bar and it's buttons' sizes

2008-02-13 Thread Peter Oberndorfer
ings Peter From 62066e37c5a01155eff03b01af76010a521cd114 Mon Sep 17 00:00:00 2001 From: Peter Oberndorfer <[EMAIL PROTECTED]> Date: Wed, 9 Jan 2008 17:22:39 +0100 Subject: [PATCH] fix caption bar being too high by 1 pixel To: [EMAIL PROTECTED] this problem was introduced in commit 567b6facab5623857b3

Re: RegOverridePredefKey stub

2008-01-27 Thread Peter Oberndorfer
On Sonntag 27 Januar 2008, Jens Nestler wrote: > Hello all, > > I'm a Windows software developer and I'm trying to execute an application > under the wine environment. > Now I have a problem introduced with wine 0.9.49. > > I use the function RegOverridePredefKey from the advapi32.dll. > In wine

Re: [PATCH] ntdll: remove bogus VALGRIND_DISCARD

2008-01-06 Thread Peter Oberndorfer
On Sonntag 06 Januar 2008, Peter Oberndorfer wrote: > > VALGRIND_DISCARD is used to discard block description handles > (which are created by VALGRIND_CREATE_BLOCK) > but it was called with the return value of VALGRIND_MAKE_xxx macros > which all return 0x > dlls/ntdll/

Re: [PATCH] [2/2] winhttp: stub impl of WinHttpGetIEProxyConfigForCurrentUse

2007-09-26 Thread Peter Oberndorfer
On Wednesday 26 September 2007, Peter Oberndorfer wrote: > --- > dlls/winhttp/main.c | 25 + > dlls/winhttp/winhttp.spec |2 +- > 2 files changed, 26 insertions(+), 1 deletions(-) > There is a 'r' missing in the patch title. it shou

Re: [PATCH] fix small spelling mistakes

2007-09-20 Thread Peter Oberndorfer
On Thursday 20 September 2007, Juan Lang wrote: > Hi Peter, > > > correct spelling of iff -> if > > Just so you know, iff is a common abbreviation meaning "if and only > if." I don't think that's any clearer in the cases you modified, so I > think your patch is fine, I just thought you (and othe

Re: tests: show summary and last executed test in case of a crash

2007-05-23 Thread Peter Oberndorfer
On Tuesday 22 May 2007 22:06, Paul Vriens wrote: > Peter Oberndorfer wrote: > > Some tests on http://test.winehq.org/data/ seem to crash silently. > > > Hi, > > Remember that not all 'Crashes' on the mentioned site are real crashes. Most > Vista tests I'

tests: show summary and last executed test in case of a crash

2007-05-22 Thread Peter Oberndorfer
Some tests on http://test.winehq.org/data/ seem to crash silently. This patch might be useful for debugging such crashes. It prints out the last ok/trace that was executed before the crash, the exception address and the type of the crash. It also print out the summary that is normally printed at t

Re: Implement MsiBreak Feature - Bug 8243

2007-05-03 Thread Peter Oberndorfer
On Thursday 03 May 2007 05:45, EA Durbin wrote: Hi, > patch created by Anastasius Focht for Bug 8243. > >+#include /* for getpid() */ >+#include /* for getpid() */ Do we really need to write out unix pid? AFAIK Winedbg can attach to windows process IDs just fine. >+ if( MessageBo

Re: (resend) Scroll window fix

2007-03-03 Thread Peter Oberndorfer
On Tuesday 13 February 2007 14:38, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still > falls within the clipping rect. This generates an additional update > region that needs to be invalidated. > includes a test > Hi, I think your patch has a problem. I

Re: Unknown issue with test.winehq.org

2007-03-01 Thread Peter Oberndorfer
On Thursday 01 March 2007 08:30, Paul Vriens wrote: > Alexandre Julliard wrote: > > Paul Vriens <[EMAIL PROTECTED]> writes: > > > >> exception: 42 tests executed (0 marked as todo, 0 failures), 0 skipped. > >> exception: 279 tests executed (0 marked as todo, 5 failures), 0 skipped. > >> > >> The f

Re: [PATCH 3/3] ntdll: fix up instruction pointer in context insideraise_exception

2007-02-19 Thread Peter Oberndorfer
On Monday 19 February 2007 09:37, Dmitry Timoshkov wrote: > "Peter Oberndorfer" <[EMAIL PROTECTED]> wrote: > > > I'm not fully sure if the fixup also happens for other architectures > > (i guess not) > > so this patch is more a RFC > > >

ntdll: test that shows RtlRaiseException with EXCEPTION_BREAKPOINT mangles Eip of context

2007-02-12 Thread Peter Oberndorfer
This test is supposed to show that the Eip field in the context is fixed up somewhere inside RtlRaiseException or NtRaiseException (test for NtRaiseException not included) for (only) EXCEPTION_BREAKPOINT exception For others context.Eip is not changed. Since real exceptions on wine also take tha

Re: scroll window fix

2007-01-25 Thread Peter Oberndorfer
On Thursday 25 January 2007 18:56, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still falls > within the clipping rect. This generates an additional update region > that needs > to be invalidated. > includes a test Hi, I can't argue about the correctness o

Re: user32: Restore old WM_SIZE handler in mdi child

2007-01-21 Thread Peter Oberndorfer
On Monday 08 January 2007 11:31, Dmitry Timoshkov wrote: > Hello, Hi, this patch seems to cause http://bugs.winehq.org/show_bug.cgi?id=7190 Each time a MDI child window gets a WM_SIZE the left most menu entry disapperars. The problem is that MDI_RestoreFrameMenu is called for each WM_SIZE message,

Re: dbghelp: fix debuglink crash, accessing memory after munmap

2007-01-21 Thread Peter Oberndorfer
On Sunday 21 January 2007 16:25, Eric Pouech wrote: > Peter Oberndorfer a écrit : > > Winedbg would crash on my system when trying to set a breakpoint (loading > > the debug info from a .debug file) > > The problem is that hash_table_elt adds the symbols of the .debug file

Re: [1/2] WineD3D: Mark GL Surface Clean after Fresh Surface Download

2007-01-03 Thread Peter Oberndorfer
On Wednesday 03 January 2007 02:48, Phil Costin wrote: > This patch resets the SFLAG_GLDIRTY flag for a surface once the GL surface > data has been refreshed in surface_download_data(). > > Thanks to Stefan Dösinger for his advice in IRC during the implementation of > these 2 patches. > diff --gi

Re: comctl32: fix imagelist regression from "comctl32: Remove Nx1 assumptions in ImageList_Read"

2006-12-11 Thread Peter Oberndorfer
On Sunday 10 December 2006 16:57, Peter Oberndorfer wrote: > The patch comctl32: Remove Nx1 assumptions in ImageList_Read > (e74b0ee9102470d1b866e94c54527b34806cf876) > would produce black images on the toolbar of IDA Pro Demo after clicking one > of the listviews on the right >

XRenderFindDisplay crash / user32 winex11 initialisation order problem

2006-12-08 Thread Peter Oberndorfer
Hi, today i wanted to create a test for CreateCompatibleDC so i created a exe with this content [1] just to find out it crashes wine inside XRenderFindDisplay [2] The reason is that the CreateCompatibleDC call in gdi executes LoadLibrary winex11.drv which in turn also loads user32.dll, because w

Re: [PATCH 1/9] dinput: Move acquired flag to the base device class.

2006-12-01 Thread Peter Oberndorfer
On Friday 01 December 2006 07:23, Vitaliy Margolen wrote: > Sorry ignore my previous patches. I didn't send them in the proper order. > > --- > dlls/dinput/device.c | 28 > dlls/dinput/device_private.h |3 +++ > dlls/dinput/joystick_linux.c | 23 ++

Problem with NtReadVirtualMemory and wine server connection

2006-09-26 Thread Peter Oberndorfer
Hi, throught a problem in winedbg i found out that NtReadVirtualMemory has a problem, when reading into a invalid local buffer. it uses wine_server_set_reply( req, buffer, size ); to read the data supplied by the server directly into application memory of unknown state. when the read call hits ba

Re: mapi32: Write-strings warnings fix

2006-06-03 Thread Peter Oberndorfer
On Saturday 03 June 2006 16:33, Andrew Talbot wrote: > Changelog: > mapi32: Write-strings warnings fix. > > diff -urN a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c > --- a/dlls/mapi32/sendmail.c 2006-05-23 17:24:40.0 +0100 > +++ b/dlls/mapi32/sendmail.c 2006-06-03 14:44:21.00

Re: Possible regression in CVS wine

2005-09-04 Thread Peter Oberndorfer
On Sunday 04 September 2005 20:41, Pavel Troller wrote: > Hi! > I've just upgraded wine on my son's computer by today's CVS. He tried > some games and one of them stopped working. It's hind95 and the game bails > out on an illegal instruction - outb, jumping into winedbg. Backtrace shows > just 3

Re: wine/dlls/ntdll loadorder.c

2005-07-28 Thread Peter Oberndorfer
On Thursday 28 July 2005 23:14, Alexandre Julliard wrote: > Peter Oberndorfer <[EMAIL PROTECTED]> writes: > > Same thing happens here with WinDbg 6.5.3.7 which comes with dbghelp.dll > > in app directory. > > If you mean it fails to load dbghelp completely then that

Re: wine/dlls/ntdll loadorder.c

2005-07-28 Thread Peter Oberndorfer
On Thursday 28 July 2005 11:46, Alexandre Julliard wrote: > Rein Klazes <[EMAIL PROTECTED]> writes: > > | trace:module:load_dll looking for L"comm.dll" in > > | L"E:\\bin\\gt3\\GTWin;.;d:\\win98\\system;d:\\WIN98;d:\\windows;d:\\win > > |dows\\system;h:\\shared;r:\\x86\\Setup" > > | trace:module:MO

instance problem in CreateWindowEx{A,W,16}

2003-12-27 Thread Peter Oberndorfer
Hello Trying to run PEview.exe i found a problem. First i create a window with CreateWindowEx and pass 0 as instance. When trying to read the instance with GetWindowLong(hWnd,GWL_HINSTANCE) # Wine returns 0 as passed to the function. # Win 98 returns 0x40 which is what GetModuleHandle( NULL )

Re: Console problem

2003-12-23 Thread Peter Oberndorfer
Michael Stefaniuc wrote: Hi, On Mon, Dec 22, 2003 at 08:11:28PM +0100, Peter Oberndorfer wrote: I'm trying to get the freeware version of IDA (console) working, but if you mean ida37fw? My experience is based on that one. I tried freeware version 4.1 It was previously avaliab

Console problem

2003-12-22 Thread Peter Oberndorfer
Hello I'm trying to get the freeware version of IDA (console) working, but if i run it in wine it just hangs. If i run it with winedbg it works fine. I found out that the problem is that AllocConsole is never called for the application if it is being run from wine. But since IDA runs in the console