Re: winemac: Null-terminate an snprintf-ed key name buffer in case of short buffer.

2013-03-28 Thread Per Johansson
On Wed, Mar 27, 2013 at 7:22 PM, Ken Thomases wrote: > --- This has probably been discussed before, but shouldn't snprintfW be safe against this kind of thing, the way POSIX snprintf is? Regards, -- Per Johansson

Re: [7/10] winemenubuilder: Create a basic Info.plist.

2013-03-20 Thread Per Johansson
On Tue, Mar 19, 2013 at 5:57 AM, Ken Thomases wrote: > On Mar 17, 2013, at 12:18 PM, Per Johansson wrote: > >> +namestr = CFStringCreateWithCString(NULL, link_name, >> CFStringGetSystemEncoding()); > > You should use CFStringCreateWithFileSystemRepresentation() to

Re: [0/10] Launcher app bundles on OS X

2013-03-18 Thread Per Johansson
structs > (but not the structs themselves). Hi, I believe I only removed static where it was needed. Utility functions are kept in winemenubuilder.c, and some of them are referenced from xdg.c and/or appbundler.c. Thus static was removed from those. Regards, -- Per Johansson

Re: [1/3] Make mac driver the default on OS X

2013-03-07 Thread Per Johansson
tant? :) Yes, they are. But even more importantly, most of us Europeans also need it to type [, ], {, }, ~, |, etc. Even @ is option-2 for me. Regards, -- Per Johansson

Re: Making wine default to the Mac Driver on OS X

2013-03-05 Thread Per Johansson
ssh. It seems to be using a private API to fetch this though: http://www.opensource.apple.com/source/launchd/launchd-442.26.2/support/launchctl.c Regards, -- Per Johansson

Re: Making wine default to the Mac Driver on OS X

2013-03-04 Thread Per Johansson
in winecfg in that case. Virtual desktop is already there and has a similarly large impact. Environment variables feel a bit too volatile to be depended upon. Launching from terminal or through desktop very well might have different variables set. If global configuration is needed, it should be through a configuration file, IMO. wine.inf could handle it, except it's overwritten when upgrading. Regards, -- Per Johansson

Re: Compiling Wine on Mac OS X 10.8.2?

2013-02-03 Thread Per Johansson
ce http://source.winehq.org/git/wine.git/commit/c14bdaf1ddb7d0e5587f63f1216b61c9ecb7a8c3). The only other option I'm aware of is gcc-apple-4.2 from macports. Regards, -- Per Johansson

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.

2013-01-06 Thread Per Johansson
ng about --args (which I just learnt about), that was also added in 10.6. Regards, -- Per Johansson

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used.

2013-01-02 Thread Per Johansson
target_alias prefix, but with the proper arch parameter. A combination of this patch and mine for llvm-mc. Either -arch or -Xassembler -triple -Xassembler target_alias Regards, -- Per Johansson

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-02 Thread Per Johansson
k anyway (wine bug 28030), so it might just as well get an error compiling if we get clang working. Regards, -- Per Johansson

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-01 Thread Per Johansson
On Tue, Jan 1, 2013 at 7:11 PM, Per Johansson wrote: > On Tue, Jan 1, 2013 at 6:00 PM, Charles Davis wrote: >> >> The right thing IMO is to test if we're compiling with Clang. If we are, >> then we should test if Clang is using its integrated assembler; if it is, >

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-01 Thread Per Johansson
in > configure and send it to the list--something I really should've done a while > ago. Sure, sounds like a better plan. I tried briefly to use clang, but there were a lot of undefined symbol errors I wasn't sure how to fix. Tell me if you want some help with the patch. Regards, -- Per Johansson

Fwd: [PATCH 3/8] winemac: Implement GetDeviceCaps().

2012-12-20 Thread Per Johansson
pparently). I'll let you guys decide on 10.5 or 10.6, but I'd like to note that all intel Mac should be able to run 10.6, as per Apple's website <http://support.apple.com/kb/SP575>. Regards, -- Per Johansson

Re: (resend) programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Icns format

2012-10-17 Thread Per Johansson
unchpad, has larger ones and the dock is dynamic based on the number of items it contains. Regards, -- Per Johansson

Fwd: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-12 Thread Per Johansson
as effective in my experience (especially AVL trees). Regards, -- Per Johansson

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-25 Thread Per Johansson
On Tue, Sep 25, 2012 at 10:57 AM, Francois Gouget wrote: > On Tue, 25 Sep 2012, Per Johansson wrote: > > > Hi, > > > > I should probably add a note that when I wrote this I had some doubts it > it > > belongs in start.exe, and I still somewhat do. > > >

Re: [5/6] start: Support getting the file to open by AppleEvent. (resend)

2012-09-24 Thread Per Johansson
action with the host (is that what we call it btw?). If you think that's more appropriate I can work on that instead of adding this to start. Regards, -- Per Johansson 2012/9/23 Per Johansson > 0006-start-Support-getting-the-file-to-open-by-AppleEvent.patch Description: Binary data

Re: [3/8] winemenubuilder/tests: Added tests for XDG files

2012-09-19 Thread Per Johansson
7;t work, the changed variable is not found by winemenubuilder. Should I perhaps change winemenubuilder to use GetEnvironmentVariableA instead of getenv, will that work with the normal Unix environment? Regards, -- Per Johansson

Re: [PATCH 3/3] winemenubuilder: Implement OS X application bundles.

2012-07-29 Thread Per Johansson
24 jul 2012 kl. 17:40 skrev Per Johansson: > <0003-winemenubuilder-Implement-OS-X-application-bundles.txt> Just noticed I managed to intruduce a typo when removing associations support (the associations init function shouldn't be NULL). Please disregard this for now. Re

Re: start: Support getting the file to open by AppleEvent.

2012-07-26 Thread Per Johansson
24 jul 2012 kl. 17:49 skrev Per Johansson: > I've also managed to write a function which fetches the AppleEvent using > Objective-C, which can be seen here: > <https://github.com/morth/molae/blob/master/molae.m>. > > I suppose if there's no way to get this file

Re: windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts. Resend.

2012-07-25 Thread Per Johansson
der_CreateNewFrame': icnsformat.c:686: error: 'IcnsEncoder' has no member named 'encoder' icnsformat.c:686: error: 'IcnsEncoder' has no member named 'encoder' Regards, -- Per Johansson

Re: start: Support getting the file to open by AppleEvent.

2012-07-24 Thread Per Johansson
19 jul 2012 kl. 20:00 skrev Per Johansson: > 19 jul 2012 kl. 18:11 skrev Alexandre Julliard : > >> You really don't want to do that. > > Alright, but like I said earlier there's really no other good way to support > associations without using Objective-C.

Re: start: Support getting the file to open by AppleEvent.

2012-07-19 Thread Per Johansson
19 jul 2012 kl. 18:11 skrev Alexandre Julliard : > Per Johansson writes: > >> Uses a private API. > > You really don't want to do that. Alright, but like I said earlier there's really no other good way to support associations without using Objective-C. I&#

App bundle patches for OS X

2012-07-08 Thread Per Johansson
on this code once every few months or so, so if it's deemed that there's too many problems, anyone should feel free to pick up this code and make it done (it'd be nice if you notified me though). Regards, -- Per Johansson

Re: WineHQ database compromise

2011-10-11 Thread Per Johansson
tried that email at appdb.winehq.org but it said "user does not exist". Can I assume it was completely deleted? Regards, -- Per Johansson

Re: Tests failing on OSX

2011-09-22 Thread Per Johansson
22 sep 2011 kl. 11:49 skrev Francois Gouget: > On Wed, 21 Sep 2011, Charles Davis wrote: > [...] >>> I also wondered if Xquartz brings it's own X11 headers and libraries. I >>> haven't found any, so I'm still using /usr/X11/include and /usr/X11/bin. >> Xquartz puts its include and lib files in /

Re: IPv6 issue on TestBot?

2011-09-22 Thread Per Johansson
22 sep 2011 kl. 12:14 skrev Michael Stefaniuc: > Wow! /66? And that works? While the standard allows for that you "should > use /64" which everybody and his dog read it as that is the only thing > that needs to work and the only thing that get tested. IPv6 brings back > the class-full thinking wh

Re: configure.ac: add -Werror to default compiler options

2011-09-01 Thread Per Johansson
1 sep 2011 kl. 03:27 skrev Dan Kegel: > At which point it would probably be a fine idea to add -Werror by default; > buildbot will help keep everyone in sync, even if they're using a compiler > that doesn't catch as many warnings as the one buildbot uses. We use -Werror at my company, but I thin

Re: configure.ac: add -Werror to default compiler options

2011-09-01 Thread Per Johansson
e's also a few warnings while building on OS X. I don't have access to it now, or I'd send the list. -- Per Johansson

Re: Tasks request

2011-08-25 Thread Per Johansson
any things that can be done to help Wine: bug hunting, > fixes, triage (http://bugs.winehq.org/), test applications for > regressions(http://appdb.winehq.org/), translations > (http://wiki.winehq.org/Translating, > http://source.winehq.org/transl/), etc. For coding tasks, http://wiki.winehq.org/SummerOfCode might also be of use. -- Per Johansson

Re: winemenubuilder: appbundle patch 20110618

2011-08-19 Thread Per Johansson
Hi Steven, list, I tried both AppleScript and shell script versions and AppleScript doesn't really add anything, so it's probably better to go with shell script and generate the bundle manually. I'll see if I can help smoothing it out. -- Pelle Johansson 17 aug 2011 kl. 00.06 skrev Steven Edwa

OSA-applets on OS X

2011-08-16 Thread Per Johansson
way was much more simple. Any feedback is appreciated, -- Per Johansson Ps. If someone tries to apply it you'll probably get a conflict around line 3065 since the patch currently assumes that my other patch[1] to winemenubuilder is already applied. [1] http://www.winehq.org/pipermail/