On Tue, Nov 8, 2011 at 12:18 PM, Stefan Dösinger wrote:
> On Tuesday 08 November 2011 01:14:22 Octavian Voicu wrote:
>> The idea behind using triangles was to fit everything in one screen so
>> I could debug it visually very easily. I'm thinking I can still have
>>
the primary surface, in different
positions for each test.
> On Monday 07 November 2011 23:27:13 Octavian Voicu wrote:
>> + DWORD expected[] = { GRAY, WHITE, YELLOW2, YELLOW, GREEN, GREEN, BLUE,
> BLUE };
> Please make data const where you can.
Point taken.
>> + /*
2011/11/7 Frédéric Delanoy :
> + /* Note: '==' can't be returned by WCMD_parameter since '=' is a
> separator */
> + p = paramEnd + 1;
> + while (*p == ' ' || *p == '\t')
> + p++;
> +
> + if (!p || *p != '=' || !(p+1) || *(p+1) != '=')
> + goto syntax_err;
> +
> + strcpyW(
On Thu, Nov 3, 2011 at 8:00 PM, Christian Inci
wrote:
> But my C is a bit rusty, so I don't know a clean way to enumerating an enum.
You cannot enumerate an enum. An enum is just a way to define a bunch
of related constants. If you don't set explicit values, they will get
consecutive values (firs
On Wed, Nov 2, 2011 at 3:41 PM, Henri Verbeet wrote:
> I'm not sure all that matter a whole lot here though, the more
> interesting question is probably how you managed to get the surface to
> be in the offscreen location without a swapchain.
According to git blame, Stefan managed to do that :)
[1] The demo of The Longest Journey, available for download here (to
reproduce, click on the Begin Journey, press ESC to skip intro movies;
notice how rendered characters look):
http://games.softpedia.com/get/Games-Demo/The-Longest-Journey-161-Demo.shtml
From a8367fd5229d153ecbcd8a14f6a5a57775
stion -- how to draw the contents of the window-less window?
Can this approach ever work? Any comments or suggestions are welcome.
Octavian
From bf558e09e148c7873d6a5c9138577fc953649cd4 Mon Sep 17 00:00:00 2001
From: Octavian Voicu
Date: Mon, 31 Oct 2011 00:57:29 +0200
Subject: winex11.drv: Make
On Thu, Oct 27, 2011 at 2:01 AM, Josh Juran wrote:
> @ stub -arch=win64
> ??0?$basic_ifstream@DU?$char_traits@D@std@@@std@@QEAA@PEBDHH@Z
> @ stub -arch=win64 ??_D?$basic_ifstream@DU?$char_traits@D@std@@@std@@QEAAXXZ
You forgot to update the win64 stubs in the spec file.
Octavian
On Thu, Oct 13, 2011 at 11:12 AM, Saulius Krasuckas wrote:
> I am troubled by seeing (via test.winehq.org) your ddraw:refcount tests to
> account only results for "VMware SVGA 3D" adapter/driver (and only those
> with 3D acceleration disabled), I guess.
>
> But if this driver is 3D-enabled or just
On Wed, Oct 12, 2011 at 11:22 PM, Josh Juran wrote:
> My understanding is that accessing element n or greater in an array[n]
> is undefined behavior, but declaring a huge array and allocating only
> part of it is valid.
It's a commonly used pattern in C. You declare a size-one array at the
end of
On Mon, Oct 10, 2011 at 10:04 AM, Henri Verbeet wrote:
> Can't you just handle this in ddraw_surface_delete_attached_surface()?
> I.e., replace the Release calls in
> ddraw_surface?_DeleteAttachedSurface() with a
> IUnknown_Release(Surf->attached_iface) in
> ddraw_surface_delete_attached_surface()
2011/10/2 Frédéric Delanoy
> - for (i = (indexLow + indexHigh) / 2; !impl && indexLow <= indexHigh;
> - i = (indexLow + indexHigh) / 2)
> + for (i = indexHigh / 2; !impl && indexLow <= indexHigh; i = (indexLow +
> indexHigh) / 2)
How about following code:
while (!impl && indexLow
On Thu, Sep 29, 2011 at 12:59 PM, Dan Kegel wrote:
> Do you object to Greg's existing testbot emails, too?
They're annoying when they are spurious...
Octavian
On Tue, Sep 20, 2011 at 4:05 PM, Bernhard Loos
wrote:
> +#define __WINE_GENERIC_CF_DLL_MAIN_CONTENT \
> +return __WINE_PS_ENTRY(DllMain(hInstDll, fdwReason, lpv));
I think __WINE_PS_ENTRY needs only be applied to DllMain, not its
argument, so second line should read:
+
On Tue, Sep 20, 2011 at 9:27 PM, Qian Hong wrote:
> Is there any good ways to get the git-describe-like version number
> from the daily build ppa version number?
> That's useful while running a regression test. For example, I'd like
> to know exactly what is wine1.3_1.3.28+daily-20110912
> in http
On Sun, Sep 18, 2011 at 8:37 PM, Francois Gouget wrote:
> + TRACE("-- vmode %#x, flags %#x", view_params->pfs->ViewMode,
> view_params->pfs->fFlags);
> + if (view_params->prcView)
> + TRACE(", left %d, top %d, right %d, bottom %d",
> view_params->prcView->left,
> + view
2011/9/18 Dan Kegel :
> 2011/9/18 Dan Kegel :
>> Don't let this one languish - it makes a huge difference for me!
>
> I should mention: with your latest additions to the cmd tests,
> time to run the cmd tests is starting to go off the cliff,
> and is now above four minutes... but with your efficien
On Fri, Sep 16, 2011 at 2:30 PM, Jacek Caban wrote:
> --- a/dlls/vbscript/compile.c
> +++ b/dlls/vbscript/compile.c
> static HRESULT compile_while_statement(compile_ctx_t *ctx, while_statement_t
> *stat)
> {
> -unsigned start_addr;
> +unsigned start_addr, prev_label;
...
> +if(stat-
On Wed, Sep 14, 2011 at 1:56 PM, Jacek Caban wrote:
> --- a/dlls/vbscript/compile.c
> +++ b/dlls/vbscript/compile.c
> @@ -658,9 +658,26 @@ static HRESULT create_function(compile_ctx_t *ctx,
> function_decl_t *decl, functi
> func->code_ctx = ctx->code;
> func->type = decl->type;
>
> +
On Tue, Sep 13, 2011 at 12:36 PM, Jacek Caban wrote:
+const char *debugstr_variant(const VARIANT *v)
+{
...
+case VT_I2:
+return wine_dbg_sprintf("{VT_I4: %d}", V_I2(v));
Should be "{VT_I2: %d}".
Octavian
On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget wrote:
> - assert(0 && "bad encoding in load_encoding_name");
> + assert("bad encoding in load_encoding_name");
Hello,
assert() is a debug macro which generates some code such that, during
runtime: if the argument is non-zer
2011/9/9 Frédéric Delanoy
> Patch is OK, but for consistency, shouldn't the externals be put at
> the start of wcmdmain.c, just after the inbuilt[][]10]?
> This way, you could see directly which command is built-in, and which
> is external.
>
+ make it static const, since it's not used outside o
On Thu, Sep 8, 2011 at 6:37 PM, Octavian Voicu wrote:
> You are dereferencing 'closest' without checking if it's non-NULL. It
> can be NULL if control jumps to the 'exit' label for several cases.
> This only applies to winealsa; for wineoss there are no gotos.
--- a/dlls/winealsa.drv/mmdevdrv.c+++ b/dlls/winealsa.drv/mmdevdrv.c>
@@ -1310,17 +1313,14 @@ exit:
> LeaveCriticalSection(&This->lock);
> HeapFree(GetProcessHeap(), 0, formats);
>
> -if(hr == S_OK || !out){
> -CoTaskMemFree(closest);
> -if(out)
> -*out = N
2011/9/7 André Hentschel :
> + if (!str || !*str) return NULL;
> return strlwrW( str );
>+if (!str || !*str) return NULL;
>return struprW( str );
It seems strange to return NULL when called with an empty, non-NULL
string. Maybe it should be `return str' instead (so it covers both t
On Wed, Sep 7, 2011 at 11:27 AM, Francois Gouget wrote:
> Actually, paper size is the more common term.
...
> --- a/programs/winecfg/winecfg.rc
> +++ b/programs/winecfg/winecfg.rc
...
> - IDS_COL_DRIVELETTER "Letter"
> + IDS_COL_DRIVELETTER "#msgctxt#Paper size#Letter"
While
On Tue, Sep 6, 2011 at 4:40 PM, Vitaliy Margolen
wrote:
> The fix is not entirely correct. UNICODE_STRING does not have to have a
> terminating \0 character. The code should not use str* functions on not
> zero-terminated strings.
I was also unsure about this when coding the patch, but I read her
2011/9/5 Frédéric Delanoy :
> + static WCHAR string[MAX_PATH];
Why make this static? It's only a temporary buffer and it's only used
once, when building the cache.
Octavian
On Thu, Sep 1, 2011 at 9:34 PM, Lucas Fialho Zawacki
wrote:
> +STRINGTABLE
> +BEGIN
> + IDS_ACTIONCOLUMN "Action"
> + IDS_OBJECTCOLUMN "Object"
> +END
I think you should only keep the string table in dinput.rc. The
dialog(s) should go in En.rc so they can be localized, like it's
On Wed, Aug 31, 2011 at 3:25 PM, Octavian Voicu wrote:
> They are not used anymore. Last change was with the release of wine 1.0.
> Sent as attachment because of the huge lines.
Alexandre,
This patch was sent before I got your reply on wine-devel, so you can ignore it.
Probably was
On Thu, Sep 1, 2011 at 7:21 PM, Dan Kegel wrote:
> I just checked, and none of our .c, .h, or .po files have embedded
> CR's. I guess it would be ok to strip trailing CR's on incoming
> patches, I'll do that.
That's weird, did they blacklist the 0x0d character from the encoding
of Unicode charac
2011/9/1 Dan Kegel :
> This patch found a bug in my scripts - it failed to grep the patch
> for sender and subject - but it looks like there might be something
> wrong with the patch itself, it doesn't apply here.
The patch uses dos line endings, that's why it doesn't apply.
Octavian
On Thu, Sep 1, 2011 at 4:02 PM, Francois Gouget wrote:
> @@ -295,7 +295,8 @@ static void scmdatabase_autostart_services(struct
> scmdatabase *db)
> argv[0] = service->name;
> argv[1] = NULL;
> err = service_start(service, 1, argv);
> - /* FIXME: do something if the
On Thu, Sep 1, 2011 at 3:05 PM, Alex Bradbury wrote:
> As this seems like as good a place as any for Ubuntu packaging of wine
> - do you see any fix in the future for gstreamer support on Wine when
> compiling on 64-bit Ubuntu? The current Wine configure script (quite
> correctly) disables support
On Thu, Sep 1, 2011 at 4:27 AM, Dan Kegel wrote:
> At which point it would probably be a fine idea to add -Werror by default;
> buildbot will help keep everyone in sync, even if they're using a compiler
> that doesn't catch as many warnings as the one buildbot uses.
Have you tried compiling on 64
2011/8/31 Alexandre Julliard :
> That sort of thing should be on the wiki. READMEs in the source are
> never maintained properly.
Speaking of obsolete documentation, we should remove the
documentation/ChangeLog.* files. They haven't been updated since wine
1.0 and are confusing. I tried sending a
2011/8/31 Frédéric Delanoy :
> My point was simply to make sure that subsequent wine patches, maybe a
> year or two from now, won't make it "work" again (think regression)
You got that wrong -- it *does* work on Wine already :)
I think we can be more permissive in this aspect, it's not like some
w
On Wed, Aug 31, 2011 at 3:11 AM, Lucas Zawacki wrote:
> Any pointers on what's the set of winapi functions used to store and
> retrieve data in windows? I've searched MSDN for almost 30 minutes and
> no luck.
Try SetWindowLongPtr [1] / GetWindowLongPtr [2].
You probably want to use the W variants
2011/8/30 Frédéric Delanoy :
> You don't test the result of your 'mkdir "foo:"'. You can't know from
> the test whether the dir was created and removed, or never existed.
That's the whole point! I tested in cmd prompt on a Windows XP machine
(and I assume all Windows versions act the same in this
On Tue, Aug 30, 2011 at 6:56 PM, Ben Peddell wrote:
> A modification of the timestamp patch from Bernhard Loos should help us
> find what calls are taking the longest.
>
Speaking of that, I've been trying to compile cmd tests with profiling (-pg,
for use with gprof), but no luck. I added -pg to b
2011/8/29 Octavian Voicu
> Alexandre already committed the patch, so if native passes the test I can
> send a test for the next iteration. On the other hand, if native chokes on
> the colon, then we shouldn't add any testcases. If it works, might also
> throw a @pwd@ in there
2011/8/29 Frédéric Delanoy
> Might be a good idea to add a simple testcase
>
Not sure yet how native is going to handle this, because windows doesn't
allow colons in filenames. I submitted a job to the testbot to check this
[1].
Alexandre already committed the patch, so if native passes the tes
Hello,
I've noticed a lot of timeouts for cmd tests lately, which is not so
surprising with all the new incoming tests.
I think test_builtins.cmd should be split in a few files, which would
then be run separately. An added benefit is that it would permit
putting tests that affect other tests in s
On Thu, Aug 25, 2011 at 3:31 PM, Jacek Caban wrote:
> As long as there is a failure (like in your patch), I'm fine with return.
> Just let's not pretend it's somehow valid run with skip() call. Also testing
> hres is cleaner than unk, IMO.
Yeah, the skip will only come after a failure because unk
On Thu, Aug 25, 2011 at 2:59 PM, Jacek Caban wrote:
> Those are failures on Wine, so tests are fine, it's Wine that needs fixing.
Yes, the first test usually fails on Wine. Nonetheless, if
CoCreateInstance fails for whatever reason (like it happens on that
NT4 machine, for example), running the r
On Thu, Aug 25, 2011 at 2:38 PM, Jacek Caban wrote:
> Where do you get such a broken installation from? I don't see such failures
> on test.winehq.org.
Hi Jacek,
It's not only me, see [1]. It fails every time on WOW64 giving
something like this [2].
It's a different crash from the win64 one (whi
2011/8/25 Frédéric Delanoy :
> + const WCHAR inW[] = {'i','n'};
> + const WCHAR doW[] = {'d','o'};
...
Hello,
After these patches get in, it might be a good idea to make all these
strings static. Even if they are const, the compiler still needs to
generate code to initialize the arrays on the s
On Tue, Aug 23, 2011 at 3:13 PM, Joris Huizer wrote:
> On 08/23/2011 11:45 AM, Hans Leidekker wrote:
>
>> +if (!strcmpiW( package, unsquashed ))
>>
>
> I'm confused about the last part of the function.
> I think if the comparison between 'package' and 'unsquashed' fails, you
> want to return a
On Mon, Aug 22, 2011 at 1:54 PM, Michał Ziętek wrote:
> +static HRESULT WINAPI TextStream_QueryInterface(ITextStream *iface, REFIID
> riid, void **ppv)
> +{
> +WINE_TRACE("(%s %p)\n", wine_dbgstr_guid(riid), ppv);
> +
> +if(IsEqualGUID(&IID_IUnknown, riid)
> + || IsEqualGUID(&IID_IDi
On Fri, Aug 12, 2011 at 12:59 PM, Michael Mc Donnell
wrote:
> Is it ok to use roundf and rintf? They're both C99 functions.
>
Hello,
As far as I know C99 is not allowed. However, you can emulate round by
doing:
floorf(val + 0.5f)
According to [1] floorf is C99 (only floor is C89), but includin
On Sat, Aug 6, 2011 at 2:49 PM, Octavian Voicu wrote:
> A proper fix would be a patch to configure.ac to detect the correct
> PKG_CONFIG_PATH for the target architecture. There is also a proposed change
> [1] to pkgconfig to allow you to specify the host system type for
> cross-compi
On Sat, Aug 6, 2011 at 1:06 PM, Marcus Meissner wrote:
> src.visrect.left = src.x = 0;
> src.visrect.top= src.y = 0;
>
These two lines become redundant after your patch.
Octavian
On Sat, Aug 6, 2011 at 12:08 AM, Alex Villacís Lasso <
a_villa...@palosanto.com> wrote:
> El 02/08/11 17:38, Octavian Voicu escribió:
>
> When building a 32-bit wine in a 64-bit build environment with
>> default glib headers (gstreamer uses glib.h), glib 64-bit types
&
On Thu, Aug 4, 2011 at 10:53 AM, William Pettersson <
william.petters...@gmail.com> wrote:
> Yes, I have a 550 and not a 560, hence I'm just asking here. I cannot
> confirm that the 560 renderer string has capital "TI", but google searches
> seem to imply that the capitalisation follows the 550 re
On Thu, Aug 4, 2011 at 11:10 AM, Francois Gouget wrote:
> --- a/po/ja.po
> +++ b/po/ja.po
> @@ -8641,8 +8641,8 @@ msgstr ""
> "---\n"
>
> #: net.rc:44
> -msgid "%s %S %S Open resources: %lu\n"
> -msgstr "%s %S
2011/8/3 André Hentschel
> a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6
>
Doesn't look like a valid commit... which one is that?
Octavian
2011/7/29 Frédéric Delanoy :
> On Fri, Jul 29, 2011 at 22:05, Octavian Voicu
> wrote:
>> I believe you can also use this syntax [put for instruction in
>> parentheses, add | sort at the end]:
>> (for ... ...) | sort
>
> Yeah, but as usual, when NT4 enters in the
2011/7/29 Frédéric Delanoy :
> +rem for /d %%i in (ba*) do echo %%i>> tmp
> +rem sort < tmp
> +rem del tmp
I believe you can also use this syntax [put for instruction in
parentheses, add | sort at the end]:
(for ... ...) | sort
Btw, it's a horrible hack, but until you'll have a wine sort you can
On Fri, Jul 29, 2011 at 9:55 AM, Paul Vriens wrote:
>> + win_skip("Not on WOW64, skipping test.\n");
>
> Why a win_skip()? Isn't a normal skip() more appropriate?
Year, you're right, win_skip didn't make much sense. I was only
thinking at GetSystemWow64DirectoryW when I wrote that (which,
On Wed, Jul 27, 2011 at 6:44 PM, Wolfgang Walter wrote:
> - char src_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )];
> - BITMAPINFO *src_info = (BITMAPINFO *)src_bmibuf;
> - char dst_bmibuf[FIELD_OFFSET( BITMAPINFO, bmiColors[256] )];
> - BITMAPINFO *dst_info = (BITMAPINFO *)dst_bm
On Tue, Jul 26, 2011 at 12:46 AM, Andrew Eikum wrote:
+for(p = driver_name; p; p = next + 1){
+next = strchrW(p, ',');
+if(next)
+*next = '\0';
+
+if(load_driver(p))
+return TRUE;
+
+
On Sun, Jul 24, 2011 at 4:11 PM, Massimo Del Fedele wrote:
> Having seen many patches related to DIB engine lately, I built latest
> sources and tried it No speed enhancements on AutoCAD, my test app.
> So, I wonder if the engine is already working, at least partially, or not.
> If yes, there'
On Fri, Jul 22, 2011 at 5:55 PM, Alexandre Julliard wrote:
> No, it won't work anyway. You'd need to duplicate all the rules for the
> test resources too, and I don't want to have to make the build process
> even more of a mess. The existing crosstest hacks are already bad
> enough.
I guess I did
On Fri, Jul 22, 2011 at 5:29 PM, Alexandre Julliard wrote:
> There's a reason for that. Tests are very limited in what they are
> allowed to use from Wine, but programs aren't. In particular you can't
> use any of the portability routines or configure check for cross
> builds. You really need a se
On Sun, Jul 10, 2011 at 1:17 PM, Alistair Leslie-Hughes
wrote:
> Subject: [PATCH] Implement CreateXmlWriter
...
> +/*
> + * XMLLite IXmlReader tests
> + *
...
> +typedef struct _xmlreader
> +{
> +IXmlWriter IXmlWriter_iface;
> +LONG ref;
> +} xmlwriter;
Looks like you have some copy-paste
2011/7/7 Frédéric Delanoy :
> c = outbuffer[sizeof(outbuffer) - 1];
> ok(ungetc(c, file) == c, "ungetc did not return its input for
> bufmode=%x\n", bufmodes[bufmode]);
> ok(!feof(file), "feof after ungetc returned EOF for bufmode=%x\n",
> bufmodes[bufmode]);
> - ok
2011/7/7 Frédéric Delanoy :
> --- a/dlls/msvcrt/tests/file.c
> +++ b/dlls/msvcrt/tests/file.c
> @@ -132,21 +132,21 @@ static void test_fileops( void )
> rewind(file);
> for (i = 0, c = EOF; i < sizeof(outbuffer); i++)
Isn't c = EOF in for initialization also a dead assignment?
Oct
2011/6/15 Frédéric Delanoy :
> + if(err == out_nl) {
> + if (!is_todo_wine)
> + ok(0, "unexpected end of line %d (got '%.*s', wanted
> '%.*s')\n",
> + line, (int)(out_nl-out_ptr), out_ptr,
> (int)(exp_nl-exp_ptr), exp_ptr);
> + else
>
include in my patches.
>
> On Mon, Jun 13, 2011 at 5:06 PM, Octavian Voicu
> wrote:
> > Hello,
> > Shouldn't you also increment SERVER_PROTOCOL_VERSION
> > in include/wine/server_protocol.h?
> > Octavian
>
Hello,
Shouldn't you also increment SERVER_PROTOCOL_VERSION
in include/wine/server_protocol.h?
Octavian
On Mon, Oct 4, 2010 at 5:07 AM, Nicholas van Oudtshoorn
wrote:
> Just to note, KDE/Dolphin already has built-in support for thumnbailing exe
> files. (Although, in Fedora at least, it's not enabled by default; just tell
> dolphin to show previews for "Microsoft Windows Executables".
>
> I've also
On Fri, Oct 1, 2010 at 11:18 PM, Scott Ritchie wrote:
> Includes much prettier icons, support for Vista icons (with icoutils
> 0.29.1) and more.
>
> Screenshots and a description are at:
> http://wiki.winehq.org/exe-thumbnailer
Nice! Any plans for Kubuntu / KDE support? :)
Octavian
On Thu, Sep 9, 2010 at 1:46 PM, Scott Ritchie wrote:
> This would be relatively simple to implement, and would even be doable
> with a shell script outside of Wine. Just md5sum the .exe, compare it
> with a blacklist, pop the warning if so, and if not pass it to the
> normal Wine process.
Wouldn
On Tue, Sep 7, 2010 at 9:42 PM, Lei Zhang wrote:
> It would be helpful if you provide the content of your debian/
> directory. I wrote my own debian/control file and what not and built a
> wine-gecko-1.1.0 .deb over the weekend. I haven't finished working on
> the main Wine packages, but I'll tak
d3c4106d6f6d587ec4b9013692dc1cf6da29c279 still doesn't fix the initial
problem (see log below).
There is still another problem in shlobj.h caused by the inclusion
on shobjidl.h from an extern C block:
http://source.winehq.org/git/wine.git/?a=blob;f=include/shlobj.h;h=cda13060195f1c4104ee226f41321
On Sat, Sep 4, 2010 at 9:00 PM, Jacek Caban wrote:
> On 9/4/10 2:28 PM, Octavian Voicu wrote:
>
> There are some recent crashes in urlmon:url (32 bit) that seem to be
> related to wine gecko. The crashes are pretty random (usually crashes at
> "asynchronous https test&quo
On Mon, Aug 23, 2010 at 10:00 PM, Jacek Caban wrote:
> It's not yet fully tested and I need help with this. I'd appreciate any
> help with testing. Almost all changes required by the new Gecko were
> possible to be committed to current Wine. The attached patch contains
> remaining bits. All you n
On Thu, Sep 2, 2010 at 1:52 PM, GOUJON Alexandre wrote:
> On 09/02/2010 12:10 PM, Alexandre Julliard wrote:
>
>> That's ugly and inefficient, especially since the common case is to not
>> modify it.
>>
>>
> Well, in fact I don't modify the content.
> I just trim the output of bstr_from_xmlChar( xm
On Thu, Sep 2, 2010 at 10:17 AM, Alexandre Julliard wrote:
> Octavian Voicu writes:
>> If this is not the correct approach, can you suggest a better one? I
>> definitely need a constant like MCI_INTEGER3264 to replace all the
>> MCI_INTEGERs in MCI_STATUS return type (addin
On Thu, Sep 2, 2010 at 4:29 AM, Jerome Leclanche wrote:
> Anyone else's terminal emulators really acting up since the last git
> batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if
> there is a wine process running, until it's killed. This is probably a
> konsole bug, but still.
On Wed, Sep 1, 2010 at 9:20 PM, Jacek Caban wrote:
> On 9/1/10 7:45 PM, Octavian Voicu wrote:
>>
>> MCI_INTEGER64 is only defined for _WIN64 in DDK.
>>
>> MCI_INTEGER3264 is wine specific and will be needed because MCI_STATUS
>> return type is MCI_INTEGER64 in
In order to prevent copy-paste errors, the changes were generated
using the following script, executed from git root (there are two very
long lines, might not work if they're wrapped):
for i in MCI_OPEN MCI_CLOSE MCI_ESCAPE MCI_PLAY MCI_SEEK MCI_STOP
MCI_PAUSE MCI_INFO MCI_GETDEVCAPS MCI_SPIN MCI_
On Wed, Sep 1, 2010 at 12:56 PM, Alexandre Julliard wrote:
> Piotr Caban writes:
>
>> @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase,
>> 12)
>> basic_string_char* __thiscall MSVCP_basic_string_char_erase(
>> basic_string_char *this, size_t pos, size_t len)
>>
On Mon, Aug 30, 2010 at 9:25 PM, David Adam wrote:
> Does not work for me :crying: I voluntary added trailing space to my file.
> Nothing appears in red. I obtain in white and black
> testcooperativelevels_normal();ESC[m
> ESC[32m+ESC[mESC[32m testcooperativelevels_normal_other_ddraw();ESC
On Mon, Aug 30, 2010 at 2:11 PM, GOUJON Alexandre wrote:
> Can someone add this here
> http://wiki.winehq.org/GitWine#head-b20b05157175835751686365f9818ae978ceca23
Added this to the wiki. Can't find a way to create links to sections
within the page though; the ids of the sections are regenerated
On Mon, Aug 30, 2010 at 2:11 PM, GOUJON Alexandre wrote:
> Hey, that's pretty cool.
>
> Can someone add this here
> http://wiki.winehq.org/GitWine#head-b20b05157175835751686365f9818ae978ceca23
> ?
>
> Thanks for the tip Octavian !
Well, that's what I love about git the most -- the pretty colored
Try running:
git config --global color.ui auto
This will activate colorful output for all git commands (in particular
for `git diff' too).
Then, when you run `git diff' from a terminal you will see whitespace
errors (eg. trailing whitespace) highlighted with a red background.
Hope it helps,
Oct
2010/8/29 Mariusz Pluciński :
> Could you tell me is there proper way to tell make to track changes in my
> custom file? Expected effect is running wrc while build if there was
> modification in my .gdf.xml file (currently, it is started only if .rc file
> was modified). Of course, Makefiles in Win
On Fri, Aug 27, 2010 at 7:36 PM, wrote:
> Octavian Voicu wrote:
>>> so binary compatibility in RC files is required
>>We don't have this right now. Native winmm.dll uses integer resource
>>ids (id 200 for core commands, [...])
>>Wine currently uses string ids
&
On Fri, Aug 27, 2010 at 4:25 PM, Eric Pouech wrote:
> 2010/8/27 Octavian Voicu octavian.vo...@gmail.com
>> I didn't think it was necessary to test on native systems. The command
>> parsing looks like internal winmm stuff, which makes no difference to
>> the exported
Same here.
-- Forwarded message --
From: Octavian Voicu
Date: Thu, Aug 26, 2010 at 3:12 PM
Subject: Re: [PATCH 1/3] winmm: Fix mciSendString command parsing on 64-bit.
To: joerg-cyril.hoe...@t-systems.com
On Thu, Aug 26, 2010 at 2:15 PM, Octavian Voicu
wrote:
> I just loo
For some reason I forgot to hit reply to all.
-- Forwarded message --
From: Octavian Voicu
Date: Thu, Aug 26, 2010 at 2:15 PM
Subject: Re: [PATCH 1/3] winmm: Fix mciSendString command parsing on 64-bit.
To: joerg-cyril.hoe...@t-systems.com
On Thu, Aug 26, 2010 at 1:11 PM
On Thu, Aug 26, 2010 at 8:11 PM, Juan Lang wrote:
> Hi David, I know this was committed already, but something caught my
> eye that I didn't understand:
>
> + if(This->navpane.show ^ show_navpane)
>
> Is this a cute way to write if(This->navpane.show && show_navpane) ?
> If so, why ^ rather tha
On Tue, Aug 24, 2010 at 12:44 PM, Alexandre Goujon wrote:
> - todo_wine ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of
> China.936")
> + ok(!strcmp(ret, "Chinese (Simplified)_People's Republic of
> China.936")
> + || broken(!strcmp(ret, "Chinese_People's Republic
2010/8/24 Oldřich Jedlička :
> + ok((GetRValue(color) == 0xFF && GetGValue(color) == 0xFF &&
> GetBValue(color) == 0xFF) ||
> + broken(GetRValue(color) == 0xFF && GetGValue(color) == 0 &&
> GetBValue(color) == 0), // broken driver
> + "got R %02X G %02X B %02X, ex
2010/8/23 Oldřich Jedlička :
> + // Check it out
You have a C++ style comment in this patch and I don't think it's allowed.
Octavian
2010/8/21 GOUJON Alexandre :
> [format]
> headers = "To: wine-patches \nReply-To:
> wine-devel \n"
As the name of the section suggests, this adds header lines to files
generated with `git format-patch'. If you then send those files with
`git send-email', it should work. If you `git send-ema
On Thu, Aug 19, 2010 at 4:56 PM, Jerome Leclanche wrote:
> Broken programs will crash on wine if they, for example, pass
> arguments to GetObject in the wrong order.
> This fixes bug #18864.
> +if (buffer && ((ULONG_PTR)buffer >> 16) == 0)
Wouldn't a __TRY ... __EXCEPT_PAGE_FAULT be bett
Not sure if it's useless. I thing it's intended to separate the static
part of the menu (Add to favorites) from the dynamically generated
list of favorite items that follows (which isn't implemented yet).
Octavian
On Thu, Aug 5, 2010 at 3:58 PM, Joris Huizer wrote:
> In this patch, you have this code:
>
> + void *ret = NULL;
> //...
> + ret = HeapAlloc(GetProcessHeap(), 0, 4 * samples);
> + for(i = 0;i < 32;i++) {
> //...
> + memcpy((void*) (((DWORD) ret) + (4 * i)), lr.pBits, 4);
> //...
>
1 - 100 of 140 matches
Mail list logo
