Re: Wine and multiarch on Debian Testing

2012-11-12 Thread Nicolas Le Cam
to see if file differs, I can recheck if necessary. I can also check #677657 to see if things has changed since bug report and provide a patch if needed. libgl1-nvidia-glx doesn't depend on libxvmc1 so it should be a problem anymore (at least if you use nvidia packages from unstable). Unfortunately I didn't have much time to spend on not so trivial packages and Debian freeze doesn't really help accepting patches, even if multiarch is a release goal ... -- Nicolas Le Cam

Re: include: fix mingw64 build

2012-07-17 Thread Nicolas Le Cam
2012/7/17 Jacek Caban : > On 07/15/12 14:21, Nicolas Le Cam wrote: >> Hi Jacek, >> >> Could it be backported into stable 2.x ? This will allow distros to >> package it with the next stable release of mingw-w64. > > I've just committed it to 2.x branch. It&#x

Re: include: fix mingw64 build

2012-07-15 Thread Nicolas Le Cam
2012/7/4 Jacek Caban : > On 07/03/12 20:10, Jacek Caban wrote: >> On 06/29/12 03:35, Austin English wrote: >>> On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam >>> wrote: >>>> 2012/6/29 Austin English : >>>>> Fixes http://bugs.winehq.

Re: include: fix mingw64 build

2012-07-03 Thread Nicolas Le Cam
2012/7/3 Jacek Caban : > On 06/29/12 03:35, Austin English wrote: >> On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: >>> 2012/6/29 Austin English : >>>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>>> >>>> -- >>>> -A

Re: include: fix mingw64 build

2012-06-28 Thread Nicolas Le Cam
2012/6/29 Austin English : > On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam wrote: >> 2012/6/29 Austin English : >>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>> >>> -- >>> -Austin >>> >>> >>> >> Hi Austin, &

Re: include: fix mingw64 build

2012-06-28 Thread Nicolas Le Cam
.h by default. BTW, won't that break mingw32 build ? [1] http://source.winehq.org/patches/data/84070 -- Nicolas Le Cam

Re: po: English (neutral / Great Britain) spelling fixes.

2012-05-03 Thread Nicolas Le Cam
2012/5/3 Frédéric Delanoy : > On Thu, May 3, 2012 at 7:07 AM, Nicolas Le Cam wrote: >> Le 3 mai 2012 02:45, "Francois Gouget" a écrit : >> >> >>> @@ -9429,9 +9429,9 @@ msgstr "" >>>  "start [options] document_filename\n" >&

Re: po: English (neutral / Great Britain) spelling fixes.

2012-05-02 Thread Nicolas Le Cam
normally (neither minimised nor maximised).\n" > "/W[ait] Wait for started program to finish, then exit with its exit " > "code.\n" > "/UnixUse a Unix filename and start the file like windows explorer.\n" Hi Francois, Shouldn't the end of words between brackets be translated too ? -- Nicolas Le Cam

Re: [PATCH] mscoree: Print the correct values in a TRACE.

2012-03-23 Thread Nicolas Le Cam
Le 23 mars 2012 22:21, Charles Davis a écrit : > > On Mar 23, 2012, at 3:09 PM, Nicolas Le Cam wrote: > >> Le 23 mars 2012 21:41, Lauri Kenttä a écrit : >>> --- >>>  dlls/mscoree/mscoree_main.c |    2 +- >>>  1 file changed, 1 insertion(+), 1 del

Re: [PATCH] mscoree: Print the correct values in a TRACE.

2012-03-23 Thread Nicolas Le Cam
 TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), > cchBuffer, dwlength); > +    TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), pVersion, cchBuffer, > dwlength); > >     if(!dwlength) >         return E_POINTER; > -- > 1.7.9.4 > > > Hi Lauri, Should be %s debugstr_w(pVersion) IMHO. -- Nicolas Le Cam

Re: Web based translation tool

2012-03-15 Thread Nicolas Le Cam
ange sets divided based on > translator. > > Generally it is #2 that has been the hardest for projects to cope with. > > -aric > > Hi Aric, I don't know weblate but as it is based on git (its home page says 'Tight git integration - every change is represented by Git commit') I think #2 and #3 should be handled easily. -- Nicolas Le Cam

Re: msvcp90/tests: Don't redefine __thiscall (resend).

2012-03-13 Thread Nicolas Le Cam
Le 13 mars 2012 16:28, Alexandre Julliard a écrit : > Nicolas Le Cam writes: > >> @@ -60,11 +60,13 @@ static char* (__cdecl *p_Copy_s)(char*, size_t, const >> char*, size_t); >>  static unsigned short (__cdecl *p_wctype)(const char*); >>  static MSVCP__Ctypev

Re: [PATCH 6/6] d3dxof: Do not allow separator to terminate the string. Only the double quote can do that.

2012-03-10 Thread Nicolas Le Cam
Le 10 mars 2012 17:56, Christian Costa a écrit : > Le 09/03/2012 16:11, Nicolas Le Cam a écrit : >> >> Le 9 mars 2012 14:22, Christian Costa  a écrit : >>> >>> Le 09/03/2012 14:08, Nicolas Le Cam a écrit : >>>> >>>> Le 9 mars 2012 13:39, Ch

Re: [PATCH 6/6] d3dxof: Do not allow separator to terminate the string. Only the double quote can do that.

2012-03-09 Thread Nicolas Le Cam
Le 9 mars 2012 14:22, Christian Costa a écrit : > Le 09/03/2012 14:08, Nicolas Le Cam a écrit : >> >> Le 9 mars 2012 13:39, Christian Costa  a écrit : >>> >>> Le 08/03/2012 21:23, Alexandre Julliard a écrit : >>>> >>>> Christian Costa  

Re: [PATCH 6/6] d3dxof: Do not allow separator to terminate the string. Only the double quote can do that.

2012-03-09 Thread Nicolas Le Cam
** [d3dxof.ok] Error 2 >> > I updated my tests and just remember sizeof must no be used in traces. BTW > what should it be avoided ? > > Christian > > Because there's no C89/C90 portable way of printf'ing a size_t. -- Nicolas Le Cam

Re: Web based translation tool

2012-03-09 Thread Nicolas Le Cam
ource files for context -- Nicolas Le Cam

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-25 Thread Nicolas Le Cam
2012/1/25 Nicolas Le Cam : > 2012/1/25 Francois Gouget : >> On Wed, 25 Jan 2012, Detlef Riekenberg wrote: >> >>> On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: >>> > On 22 January 2012 19:44, Detlef Riekenberg wrote: >>> > > -

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-24 Thread Nicolas Le Cam
world revolves around you, >                 quit staring at the GPS display while driving. > > static variables are zero-initialized by default I don't think that's the problem. Perhaps it's because with such a patch, only the first unhandled flag will be reported and not others (wich can be of a different value), so using a bit mask to only report once every unhandled flags will be better ? -- Nicolas Le Cam

Re: [PATCH] kernel32: Output message to stderr in UTF-8

2011-10-25 Thread Nicolas Le Cam
help clarify which should be used? > > -Alex > See Dmitry response to your patch : http://article.gmane.org/gmane.comp.emulators.wine.devel/87295 -- Nicolas Le Cam

Re: WineHQ database compromise

2011-10-11 Thread Nicolas Le Cam
03/02/best-practice-password-management-for-internet-web-sites/ >> >> I am very sad to have to report this.  We have so many challenges in our >> world today that this is a particularly painful form of salt for our wounds. >> >> However, I think it is urgent for everyone to know what happened. >> >> Cheers, >> >> Jeremy >> >> >> > > > Thanks for the early notice ! Testbot passwords should also be reset as it seems it doesn't allow password reset / change ATM. (At least I wasn't able to find that possibility) -- Nicolas Le Cam

Re: winspool.drv: Correct test for Device Capabilities

2011-09-09 Thread Nicolas Le Cam
ing it to 'if ($OtherFileName =~ m/^([\w_\-]+)(|\.[\w]+)_test(|64)\.exe$/)' should fix the problem (same change should be applied at line 258). [1] http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/winetestbot;a=blob;f=bin/WineRunBuild.pl;h=4b85ac719edfabdb88c32698f2e8474090454ac5;hb=HEAD#l180 -- Nicolas Le Cam

Re: (resend)usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-25 Thread Nicolas Le Cam
r wrote: >> >> On Thu, 2011-08-25 at 07:38 -0500, Aric Stewart wrote: >>> >>> Yes,  it depends on if it is a RTL or LTR string.  That is correct. >> >> What I meant is that it does not always match the right hand operand >> in the test condition. >> >> > > > toolchain differences ? -- Nicolas Le Cam

Re: About building test suite for Windows

2011-06-12 Thread Nicolas Le Cam
t two, so if anybody could help me > about why isn't mingw32 detected, I would like it. > > Thanks. > - Patrick > > > If I read the port's makefile right, using ./configure CROSSCC="mingw32-gcc" should help. -- Nicolas Le Cam

Re: po: Update French translation

2011-05-06 Thread Nicolas Le Cam
Le 6 mai 2011 08:41, Frédéric Delanoy a écrit : > 2011/5/6 Nicolas Le Cam : >>>  #: regedit.rc:88 >>> -#, fuzzy >>>  msgid "Modify Binary Data..." >>> -msgstr "Modifier les données &binaires" >>> +msgstr "Modifier le

Re: po: Update French translation

2011-05-05 Thread Nicolas Le Cam
>  #: regedit.rc:88 > -#, fuzzy >  msgid "Modify Binary Data..." > -msgstr "Modifier les données &binaires" > +msgstr "Modifier les données &binaires..." I'm not sure you can add a keyboard accelerator if there isn't one in the original message. -- Nicolas Le Cam

Re: po: Update French translation

2011-04-28 Thread Nicolas Le Cam
one isn't correct. There's not only one handle when available but many so it should take an 's' in the negative form too. Thanks for your work ! -- Nicolas Le Cam

Re: d3dx9_36: Fix uninitialized variable warnings.

2011-04-26 Thread Nicolas Le Cam
2011/4/26 Matteo Bruni : > 2011/4/26 Nicolas Le Cam : >> msdn tells us to use 0 to disable colorkey [1]. Let me know if you >> think it isn't the correct things to do. >> >> [1] http://msdn.microsoft.com/en-us/library/bb172902%28v=vs.85%29.aspx >> >>

Re: inetcpl: Update French translation

2011-04-13 Thread Nicolas Le Cam
312, 126 > +CONTROL "trackbar", IDC_SEC_TRACKBAR, "msctls_trackbar32", > +TBS_VERT | TBS_AUTOTICKS | TBS_BOTH | TBS_REVERSED, 8, 98, > 32, 100 > +LTEXT "", IDC_SEC_LEVEL, 48, 102, 180, 12 > +LTEXT "", IDC_SEC_LEVEL_INFO, 48, 114, 260, 80 > +END > + > /* "Content" propsheet */ > IDD_CONTENT DIALOG 0, 0, 320, 220 > STYLE WS_CAPTION | WS_CHILD | WS_DISABLED > -- > 1.7.4.3 > > > > -- Nicolas Le Cam

Re: inetcpl.cpl: Update French translation

2011-03-12 Thread Nicolas Le Cam
2, 242, 10 > "Vous pouvez effacer les pages en cache, les cookies et autres données." should be better. > +PUSHBUTTON "&Effacer les fichiers...", IDC_HISTORY_DELETE, 151, 86, > 77, 14 > +PUSHBUTTON "&Paramètres...", IDC_HISTORY_SETTINGS, 233, 86, 77, 14 > > END > > -- > 1.7.4.1 > > -- Nicolas Le Cam

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

2011-02-08 Thread Nicolas Le Cam
if(pi2) >>> + HeapFree(GetProcessHeap(), 0, pi2); >>> >> NULL check before HeapFree() is not needed. >> > Ok, I have removed the NULL check. > > + TRACE("return %d\n", ret); >>> >> This trace is redundant. >> > Ok, I have removed this TRACE(). > > I have make an other patch. > > Thank you > > Loīc > > > > > Hi Loïc, In addition to Dmitry and Andrew comments, you're adding a lot of trailing spaces (git apply output : warning: squelched 22 whitespace errors warning: 27 lines add whitespace errors.), there's also no need for an extra newline after the end label. -- Nicolas Le Cam

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

2011-02-08 Thread Nicolas Le Cam
icture[3]=4; > +/*Create the top to bottom image (images' bottom scan line is at the > bottom in memory).*/ > +bi.bmiHeader.biHeight=-2; /*We specify that we want a top to bottom > image by specifying a negative height.*/ > +bmptb=CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > +/*Write to this top to bottom bitmap.*/ > +picture[0]=1; > +picture[1]=2; > +picture[2]=3; > + picture[3]=4; > + > +bi.bmiHeader.biWidth=1; > + > +bi.bmiHeader.biHeight=2; > +GetDIBits(hdc, bmpbt, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > +ok(pixelOut==1, "Bottom-up -> bottom-up should have first scanline."); > +GetDIBits(hdc, bmptb, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > +ok(pixelOut==3, "Top-down -> bottom-up should have last scanline."); > + > +bi.bmiHeader.biHeight=-2; > +GetDIBits(hdc, bmpbt, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > +ok(pixelOut==1, "Bottom-up -> top-down should have first scanline."); > +GetDIBits(hdc, bmptb, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > +ok(pixelOut==3, "Top-down -> top-down should have last scanline."); > + > +DeleteObject(bmpbt); > +DeleteObject(bmptb); > +} > + > START_TEST(bitmap) > { > HMODULE hdll; > @@ -3080,4 +3190,6 @@ START_TEST(bitmap) > test_bitmapinfoheadersize(); > test_get16dibits(); > test_clipping(); > +test_GetDIBits_single_pixel_destination(); > +test_GetDIBits_info_query(); > } > -- > 1.7.1 > > > > Hi Jack, You forgot trailing \n in the ok() calls. -- Nicolas Le Cam

Re: tests/amstream.c doesn't test anything

2011-01-12 Thread Nicolas Le Cam
I added this to my automated test script. I'll add one this evening now that I've just found http://learn.creativecommons.org/. -- Nicolas Le Cam

Re: kernel32/tests: typo fixes

2010-09-07 Thread Nicolas Le Cam
tandardDate.wMonth=10; > tzW.StandardDate.wDayOfWeek=0; /*sunday */ > > You missed that one! -- Nicolas Le Cam

Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread Nicolas Le Cam
as parameter [2] so it should be because of your modified D3DXCreateMesh implementation which isn't visible in your patch. [1] http://source.winehq.org/git/wine.git/?a=blob;f=dlls/d3dx9_36/mesh.c#l586 [2] http://source.winehq.org/git/wine.git/?a=blob;f=dlls/d3dx9_36/tests/mesh.c#l988 -- Nicolas Le Cam

Re: mmdevapi: Make MMDevice_[GS]etPropValue() static.

2010-08-31 Thread Nicolas Le Cam
computer. > > > I don't know of a 'clean' way (and I'm also interested if anyone knows) but, at least, lib32v4l-0 is available for squeeze and sid since early june (it also seems to be in lenny-backports but from the older, now removed, libv4l source package). -- Nicolas Le Cam

Re: jscript: Added support for Function.arguments property.

2010-07-27 Thread Nicolas Le Cam
tches.pm2010-07-27 13:58:41 +0200 +++ b/lib/WineTestBot/Patches.pm2010-07-27 14:10:07 +0200 @@ -102,7 +102,7 @@ my $FileType = "patch$1"; my $BaseName = $2; my $TestSet = $3; - if ($TestSet =~ m/^(.*)\.c$/) +if ($TestSet =~ m/^(.*)\..*$/) { $TestSet = $1; } -- Nicolas Le Cam

Re: mmio: Wrap TRACE strings with debugstr_a / debugstr_an (try 2)

2010-07-20 Thread Nicolas Le Cam
> > IDs of the previous attempt and discussion (now redundant) are 63620, 63625 > and > 63725. > > Tim > > Hi Tim, Format specifiers shouldn't be necessary now that you use debugstr_an. -- Nicolas Le Cam

Re: shell32_test64.exe shlexec: 5-6 DDE tests always fail on testbot W7PROX64

2010-07-20 Thread Nicolas Le Cam
ta/d494bda30f1b5b9bc37f094bd8874d3aeeaf8840/win7_wtb-w7prox64-64/shell32:shlexec.html > > Another question: winetest64-latest.exe extracts individual test > binaries to the temp folder and runs them. How do you extract the > binaries without running? > > -- > > > > winetest64-latest.exe -x DIR (use --help or have a look in programs/winetest/main.c to see other possibilities). -- Nicolas Le Cam

Re: configure.ac: Don't try to rm dirs.

2010-06-28 Thread Nicolas Le Cam
2010/6/28 Alexandre Julliard : > Nicolas Le Cam writes: > >> Hi, >> >> This patch allows to do a make clean in a wine tree configured with >> with-wine64 option and fix following errors : >> rm: cannot remove `fonts': Is a directory >> rm: cannot r

Re: How do you make x64 crosstests?

2010-06-26 Thread Nicolas Le Cam
bian/ubuntu but I'm stuck with the same problem, it can't find libgcc, although it is installed in /usr/lib/gcc/amd64-mingw32msvc/4.4.4/ by gcc-mingw32 package. I remember seeing documentation on how to build crosstests on the wiki but it seems to have disappeared from it (with a circular reference now between ConformanceTests and MakeTestFailures pages). -- Nicolas Le Cam

Re: Tests for msvcrt

2010-06-24 Thread Nicolas Le Cam
ead but that may not be installed on > the tested system. > > Any thoughts? > > Paul Chitescu > > > > What about loading msvcrt, fallback on loading msvcrt80 and win_skip if you can't find them in both libraries? -- Nicolas Le Cam

Re: Running tests on wine

2010-06-06 Thread Nicolas Le Cam
results are from winetest runs. As I > remember winetest runs it as 'wine oleaut32_tests.exe typelib' with some env > variable to set a platform (this will enable todos output, AFAIK). >> >> Thanks >> >> Results are from a winetest64 test suite running under wine64. If it's the failure on this particular box that you want to debug, just ask, results were sent from my laptop. -- Nicolas Le Cam

Re: wineserver: Fix French manpage

2010-04-12 Thread Nicolas Le Cam
Le 12 avril 2010 11:02, Frédéric Delanoy a écrit : > 2010/4/9 Nicolas Le Cam : >> Le 9 avril 2010 13:30, Frédéric Delanoy a écrit >> : >>> 2010/4/9 Nicolas Le Cam : >>>> Hi Frédéric, >>>> >>>>>+processus clients se sont term

Re: WineTestBot: phase 3 implemented

2010-04-11 Thread Nicolas Le Cam
her priority than the jobs generated from wine-patches > submissions. > > Happy testing, Ge. > > > > Hi Greg, Perhaps you could also check for programs//tests/ now that at least cmd has tests. WineTestBot is a wonderful tool, thanks for supporting and improving it! -- Nicolas Le Cam

Re: wineserver: Fix French manpage

2010-04-09 Thread Nicolas Le Cam
Le 9 avril 2010 13:30, Frédéric Delanoy a écrit : > 2010/4/9 Nicolas Le Cam : >> Hi Frédéric, >> >>>+processus clients se sont terminés. Ceci évite le coût inhérent à l'arrêt >> sont -> soient >> >>>+\fIwineserver\fR dans le chemin systè

Re: tools: Add French translation of wineprefixcreate manpage

2010-04-09 Thread Nicolas Le Cam
n/modifier/behaviour "alterator" > which seems the purpose of an command-line option IMHO. > > Frédéric > > On Fri, Apr 9, 2010 at 9:25 AM, Nicolas Le Cam wrote: >> Hi Frédéric, >> >>>+N'afficher aucun message de statut. >> It doesn't r

Re: loader: Fix French translation of wine manpage

2010-04-09 Thread Nicolas Le Cam
Le 9 avril 2010 13:37, Frédéric Delanoy a écrit : > 2010/4/9 Nicolas Le Cam : >> Hi Frédéric, >> >>>+\fIwineserver\fR dans le chemin système ou quelques autres emplacements >>>vraisemblables. >>>[...] >>>+"wine" dans le chemin systèm

Re: tools: Add French translation of wineprefixcreate manpage

2010-04-09 Thread Nicolas Le Cam
Hi Frédéric, >+N'afficher aucun message de statut. It doesn't really matter but as you don't use infinitive form elsewhere perhaps "N'affiche" could be better. Thanks again for your work. -- Nicolas Le Cam

Re: wineserver: Fix French manpage

2010-04-09 Thread Nicolas Le Cam
Hi Frédéric, >+processus clients se sont terminés. Ceci évite le coût inhérent à l'arrêt sont -> soient >+\fIwineserver\fR dans le chemin système ou quelques autres emplacements >vraisemblables. "potentiels" or "possibles" suit better. -- Nicolas Le Cam

Re: loader: Fix French translation of wine manpage

2010-04-09 Thread Nicolas Le Cam
l'ordre de chargement des DLL utilisées >lors du >+processus de chargement d'une DLL. Le comportement par défaut est spécifié >dans le >+fichier de configuration. Deux types de bibliothèques peuvent actuellement >être chargées >+dans l'espace d'adressage d'un processus : les DLL natives de >+Windows Should be "chargés" Thanks for your work. -- Nicolas Le Cam

Re: [PATCH] user32/tests: check that SetCursorPos doesn't call hooks.

2010-01-21 Thread Nicolas Le Cam
"Hooks called\n"); > + >     UnhookWindowsHookEx(hook2); >  done: >     DestroyWindow(hwnd); > -- > 1.6.6 > > > > Hi Lauri, What about resetting hook_proc2_call_times to 0 before calling SetCursorPos and just checking if it has changed ? Also other static variables used in hook procs aren't prefixed, this is more trivial but everyone is encouraged to follow current code style of the file. -- Nicolas Le Cam

Re: d3d8: Fix a ptrdiff_t warning on 64-bit.

2010-01-11 Thread Nicolas Le Cam
2010/1/11 Alexandre Julliard : > Nicolas Le Cam writes: > >> @@ -175,7 +175,7 @@ static DWORD d3d8_allocate_handle(struct >> d3d8_handle_table *t, void *object, enu >>          entry = t->free_entries; >>          if (entry->type != D3D8_HANDLE_FREE) >>

Re: Use GCC's -Wlogical-op if possible

2010-01-04 Thread Nicolas Le Cam
: logical ?||? with non-zero constant will always >>> evaluate as true >> >> Gerald > > The attached is what I have on my F12 box (gcc 4.4.2 20091222): > > -- > Cheers, > > Paul. > > > > Most of them are false positives because of a problem between gcc 4.{3,4}.x and the strchr being defined as a macro in libc, see gcc bug #36513 [1]. My karmic box seems to output the same. [1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36513 -- Nicolas Le Cam

Re: Conformance tess for cmd?

2009-12-19 Thread Nicolas Le Cam
t; "The problem with designing something completely foolproof is to > underestimate the ingenuity of a complete idiot." (Douglas Adams) > What about redirecting io pipes and use CreateProcess ? msdn has some examples : http://msdn.microsoft.com/en-us/library/ms682499%28VS.85%29.aspx -- Nicolas Le Cam

Re: mapi32: add French translation

2009-12-17 Thread Nicolas Le Cam
nce de client mail MAPI." should be simpler and more correct. -- Nicolas Le Cam

Re: shdocvw: Fix test for non-english IE MUI (try 2)

2009-12-11 Thread Nicolas Le Cam
Browser Control'\n", wine_dbgstr_w(sName)); +else /* Non-English cannot be blant. */ +ok(sName!=NULL, "get_Name return a NULL string.\n"); Did you mean blank ? -- Nicolas Le Cam

Re: My script for doing testing

2009-11-25 Thread Nicolas Le Cam
il configured, but > since I use webmail, I went with the 'sit and wait' method. For other > projects that script would obviously need a different strategy (though > I don't other projects are running winetest.exe daily ;-)). > > -- > -Austin > > > You could watch http://test.winehq.org/builds/ to see if there is any update (a push is followed by a test build). -- Nicolas Le Cam

Re: shell32/tests: Fix Program Manager DDE Conformance Test Failures

2009-11-15 Thread Nicolas Le Cam
ized systems. So the test is not completely correct and only work on English system. That's why I proposed to skip the two tests on (and only on) such systems. I'll try to use a window message thread to see if it helps. PS: Please bottom post on wine-devel -- Nicolas Le Cam

Re: shell32/tests: Fix Program Manager DDE Conformance Test Failures

2009-11-14 Thread Nicolas Le Cam
at line 510 (before your patch) but then the next call fails. Is there a better solution than skipping those two calls ? If not I'll just send a skipping patch. -- Nicolas Le Cam

Re: (retry) msctf/tests: handle an occassional unexpected SetFocus from wine

2009-11-07 Thread Nicolas Le Cam
uted (0 marked as todo, 8 failures), 0 skipped. If you need me to do more tests, just ask, I'm willing to go green ;) -- Nicolas Le Cam

Re: msctf/tests: handle an occassional unexpected SetFocus from wine

2009-11-07 Thread Nicolas Le Cam
2009/11/7 Aric Stewart : > --- >  dlls/msctf/tests/inputprocessor.c |    5 - >  1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > Aric, is this for my versatile machine ? -- Nicolas Le Cam

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-11-02 Thread Nicolas Le Cam
2009/10/30 Jacek Caban : > Hi Nicolas, > > Nicolas Le Cam wrote: >> >> Hi Jacek, >> >> Thanks for feedback. >> It should handle pointer in every corners IMHO, the left corner can >> cause failures in winetest. >> >> I'll try to find

Re: mshtml/tests: Fix events test when pointer is on a corner.

2009-10-30 Thread Nicolas Le Cam
2009/10/30 Jacek Caban : > Hi Nicolas, > > Nicolas Le Cam wrote: >> >> Hi, >> >> Since commit 8272ecd3f2235b923f2ec67bb51d051bdfbf466f I'm having >> errors on events tests. >> >> I just found that it only fails if pointer is on any corner

Re: kernel32/tests: add more tests for Formatmessage{A,W} (try 2)

2009-10-30 Thread Nicolas Le Cam
t; defined in our headers: > > 15100 : ERROR_MUI_FILE_NOT_FOUND > 15105 : ERROR_MUI_FILE_NOT_LOADED > > Could you have a look? > > -- > Cheers, > > Paul. > > > w2k-sp4-fr has French locale. I didn't have time to investigate right now but if you need more tests just ask. -- Nicolas Le Cam

[RFC] mshtml/tests: Fix events test when pointer is on a corner.

2009-10-27 Thread Nicolas Le Cam
it for me but I'm not sure it's the right fix, so I'm sending it to wine-devel. Tested on Win2k SP4 and WinXP SP2 (both with IE6). -- Nicolas Le Cam From 27f127c3e61fa7108f13b7582875681a39b752c6 Mon Sep 17 00:00:00 2001 From: Nicolas Le Cam Date: Tue, 27 Oct 2009 19:05:47 +0100 S

Re: [1/2] user32/tests/cursoricon.c: DrawState: New Testcase for correct drawing of Icons

2009-10-01 Thread Nicolas Le Cam
; > > > Feedback is welcome! > > Wilfried Pasquazzo > > PS: When this gets committed, I can add other tests for DrawState(), > to e.g. test for > correct drawing of the "Disabled" effect. > > > > Hi Wilfried, If test fails on Wine, mark them todo_wine. -- Nicolas Le Cam

Re: cppcheck sept 18 redux

2009-09-22 Thread Nicolas Le Cam
spec that explains it? Coz the way I > read it, it has to dereference dmW, otherwise how would the compiler > find the address of the array? ... so confused :) > > Luke. > > > Luke, Wine's current code is basically equivalent to the one above, where there's no dereference : #include typedef struct _s_test { char pointer[5]; } s_test; int main() { s_test *s = NULL; long diff = (const char*)(&s->pointer[0]) - (const char*)s; printf("diff=%ld\n", diff); return 0; } -- Nicolas Le Cam

Re: cppcheck Sept 18

2009-09-20 Thread Nicolas Le Cam
in a previous mail, there's no bug and the code is perfectly valid. Even if you send a patch to please cppcheck, you should report it as being a false positive. Chris, Please try to filter out those lines, they were already there in your previous reports. -- Nicolas Le Cam

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Nicolas Le Cam
2009/9/12 Mike Kaplinskiy : > On Sat, Sep 12, 2009 at 11:24 AM, Mike Kaplinskiy > wrote: >> On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam >> wrote: >>> 2009/9/12 chris ahrendt : >>>> >>>> Here is the run for Friday Sept. 11 with the

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Nicolas Le Cam
source > leak: fd_cwd > [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible > null pointer dereference: dmW - otherwise it is redundant to check if > dmW is null at line 272 > > > Chris > > Hi Chris, All false positives, you can filter them. -- Nicolas Le Cam

Re: CPPCheck for Sept 8th

2009-09-09 Thread Nicolas Le Cam
2009/9/9 chris ahrendt : > Nicolas Le Cam wrote: >> 2009/9/9 Alexandre Julliard : >>> chris ahrendt writes: >>> >>>> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource >>>> leak: old_cwd >>> This is the only one

Re: CPPCheck for Sept 8th

2009-09-09 Thread Nicolas Le Cam
reports. > > -- > Alexandre Julliard > julli...@winehq.org > > > Not necessary false positives. Errors in dlls/msvcrt/tests/file.c, for example, are real but expected errors, as it's the purpose of the test to see how it behaves on Windows in such situation. -- Nicolas Le Cam

Re: More winehq.org improvements and issues: About page now links to articles in the wiki

2009-08-04 Thread Nicolas Le Cam
to duplicate this possibility on every pages. -- Nicolas Le Cam

Re: [2/2] comdlg32/tests: Fix a failing test on Win2k and above.

2009-08-03 Thread Nicolas Le Cam
2009/8/4 Paul Vriens : > Nicolas Le Cam wrote: >> >> Hi, >> >> Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've >> got a new failure on my Win2k box. >> >> I did a first patch to filter Win2k failure that hap

Re: Testers on windows needed

2009-07-28 Thread Nicolas Le Cam
ileop: 622 tests executed (0 marked as todo, 0 failures), 0 skipped. No new failures on root drive directories or network directories. -- Nicolas Le Cam

Re: Create our own temp directory to make sure it's not the Windows directory.

2009-07-25 Thread Nicolas Le Cam
2009/7/24 Paul Vriens : > Paul Vriens wrote: >> >> Nicolas Le Cam wrote: >>> >>> 2009/7/24 Paul Vriens : >>>> >>>> Nicolas Le Cam wrote: >>>>> >>>>> 2009/7/24 Paul Vriens : >>>>>> >>&

Re: Create our own temp directory to make sure it's not the Windows directory.

2009-07-24 Thread Nicolas Le Cam
2009/7/24 Paul Vriens : > Nicolas Le Cam wrote: >> >> 2009/7/24 Paul Vriens : >>> >>> Hi Alexandre, >>> >>> This one introduced a test failure on several W2K, XP and W2K3 boxes. No >>>  idea why (yet) though. >>> >>> --

Re: Create our own temp directory to make sure it's not the Windows directory.

2009-07-24 Thread Nicolas Le Cam
2009/7/24 Paul Vriens : > Hi Alexandre, > > This one introduced a test failure on several W2K, XP and W2K3 boxes. No >  idea why (yet) though. > > -- > Cheers, > > Paul. > > > Hi Paul, Alexandre, It seems to only be a short vs long pathname problem. -- Nicolas Le Cam

Re: [winhttp/tests] Fix a test failure on some W2K/XP systems

2009-07-22 Thread Nicolas Le Cam
!ret && GetLastError() == ERROR_INVALID_PARAMETER, > +    ok((!ret && GetLastError() == ERROR_INVALID_PARAMETER) || > +        broken(ret), /* Earlier winhhtp versions on W2K/XP */ >         "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); > >     info.lpszProxy = normalString; > -- > 1.6.0.6 > > > > > Hi Paul, You did a small typo here. winhhtp -> winhttp Bye -- Nicolas Le Cam

Re: How to expanding environmental variables?

2009-07-17 Thread Nicolas Le Cam
no linking at all, it's "C:\Documents and Settings\All Users\Documents" on both sides. If you have access to the registry, the full path of this folder is contained (at least on 2K and XP) in the key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Folders\Common Documents -- Nicolas Le Cam

Re: Doing better than barely keeping up with bug reports - Bug Day this Monday (July 20)

2009-07-17 Thread Nicolas Le Cam
o > > > RecentChanges page says : DELETED BugDay 12:33 InformationsDmitryTimoshkov #01 Not useful, eveone works on bugs or features at its own preference, at its own time -- Nicolas Le Cam

Build a6beb5066884 w2k-sp4-fr-netwrkdrv test results

2009-07-06 Thread Nicolas Le Cam
Hello, Strangely the network drive has been disconnected during the test. Could you remove it ? I will rerun and resubmit it after checking that results are correct. -- Nicolas Le Cam

Re: kernel32: Add a trailing '\n' to a MESSAGE trace

2009-07-02 Thread Nicolas Le Cam
Le 2 juillet 2009 09:29, Frédéric Delanoy a écrit : > Last time I submitted this (pretty trivial) patch, it got ignored. > If it's in a bad format, please let me know! > > Frédéric Hi Frédéric, System messages already contain a new line, you don't need to add a second one. -- Nicolas Le Cam

Re: NT4 passing

2009-06-17 Thread Nicolas Le Cam
ures on several >> platforms: >> >> - IE8 >> - Different dpi settings (only Detlef I guess ;) ) >> - Locale dependent tests >> - comctl32 < 5.80 >> - < IE6 (or even earlier on none IE). > > Also tests dependent on the system drive being C:\. > > -- > -Austin > > > And tests that don't work on root drive directories or network drives. -- Nicolas Le Cam

Re: user32: Test request (cursoricon)

2009-06-13 Thread Nicolas Le Cam
for LOTRO (mostly handling invalid calls properly). > > Thanks, > Daniel > > > > > > Tested on a French Win2k SP4 (on VirtualBox). No failures. -- Nicolas Le Cam

Re: Which virtualization software should I choose

2009-06-11 Thread Nicolas Le Cam
2009/6/11 Paul Vriens : > On 06/11/2009 11:30 AM, Nicolas Le Cam wrote: >> >> 2009/6/11 Paul Vriens: >>> >>> Hi, >>> >>> Just upgraded to Fedora 11 and (yet again) having issues with VMware >>> Workstation. >>> >>&g

Re: Which virtualization software should I choose

2009-06-11 Thread Nicolas Le Cam
ons, it works quiet well. It also manages snapshots and have a CLI. See w2k-sp4-fr results on winetest. It has passed the test suite once (I didn't run latest builds but I will). Unfortunately, I don't know VMWare Workstation at all, so I can't tell you what are the differences. -- Nicolas Le Cam

Re: Tests passing on one more platform!

2009-06-03 Thread Nicolas Le Cam
rt4 was already an unknown part of Windows for me, with widl added it was way over my head. Alexandre saved my day by disabling it :) Now back to fix tests on root drive directory and network drive. [1] http://www.winehq.org/pipermail/wine-devel/2009-April/074843.html -- Nicolas Le Cam

Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.

2009-05-07 Thread Nicolas Le Cam
more obvious. > > I expect the problem is more the form: touching sensitive nonclient > code. > > Rein. > > > Even if it's obvious that this is the right behavior, it's always useful to add a test, at least to prevent regressions. -- Nicolas Le Cam

Re: [4/4] (Try2) msi/tests: Fix package test when run on a different drive than C:\.

2009-04-22 Thread Nicolas Le Cam
2009/4/22 James Hawkins : > On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam wrote: >> Try2: Use helper function added in second patch, as suggested by James. >> >> This one finally fixes current relative path test to expect correct >> value. >> > > Thi

Re: [4/4] msi/tests: Fix package test when run on a different drive than C:\.

2009-04-21 Thread Nicolas Le Cam
2009/4/21 James Hawkins : > On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam wrote: >> This one finally fixes current relative path test to expect correct >> value. >> > > +    drives = GetLogicalDrives(); > +    lstrcpyA(path, "A:\\"); >

Re: (Try2) wininet/tests: Fix HttpSendRequestW test on Win2k platform.

2009-04-20 Thread Nicolas Le Cam
2009/4/20 Hans Leidekker : > On Monday 20 April 2009 20:14:14 Nicolas Le Cam wrote: > >> Win2k SP4 seems to be the only platform that follows what msdn says (see >> http://msdn.microsoft.com/en-us/library/aa384247(VS.85).aspx). > > wininet is bundled with Internet Explorer

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread Nicolas Le Cam
2009/4/16 James Hawkins : > On Wed, Apr 15, 2009 at 5:21 PM, Nicolas Le Cam wrote: >> 2009/4/16 James Hawkins : >>> On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam >>> wrote: >>>> While trying to solve ACTION_AppSearchDr problem revealed by my

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.

2009-04-15 Thread Nicolas Le Cam
2009/4/16 James Hawkins : > On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam wrote: >> While trying to solve ACTION_AppSearchDr problem revealed by my previous >> patch, I discovered that MSI_RecordGetStringW was returning a buffer >> length of 1 on null and empty strings. &

Re: [PATCH 1/2] comctl32/tests: Test expanding of a invisible sub tree.

2009-04-15 Thread Nicolas Le Cam
myRect, FALSE); > +todo_wine > +    ok(!nodeIIVisible, "Node II should not be visible.\n"); > +} > + > + >  START_TEST(treeview) >  { >     HMODULE hComctl32; > @@ -819,4 +897,6 @@ START_TEST(treeview) >         TranslateMessage(&msg); >         DispatchMessageA(&msg); >     } > + > +    TestExpandInvisible(); >  } > -- > 1.5.4.3 > > > > Hi Florian, I think you should use already created dialog and treeview. Place your new function just after TestCallback(), clear tree view and fill it, then just test visibility of expandable items. -- Nicolas Le Cam

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
2009/4/13 James McKenzie : > Nicolas Le Cam wrote: >> 2009/4/13 James McKenzie : >> >>> Nicolas Le Cam wrote: >>> >>>> James, >>>> >>>> Here are updated patches for part 3 & 4 of my previous patch set. Tell >>>>

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
2009/4/13 James McKenzie : > Nicolas Le Cam wrote: >> James, >> >> Here are updated patches for part 3 & 4 of my previous patch set. Tell >> me if you think I could submit them to wine-patches. >> >> For patch 3, the only todo_wine is when launche

Re: wininet: Add tests for asynchronous HttpSendRequestEx/HttpEndRequest.

2009-04-12 Thread Nicolas Le Cam
2009/4/11 Hans Leidekker : > On Saturday 11 April 2009 15:20:06 Nicolas Le Cam wrote: > >> Is there no way to avoid use of cached connections or to clean the >> cache before those two tests ? >> Perhaps moving both tests up and down instead of sleeping at end of >>

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
rive dir, as it doesn't make sense to execute it in this case. If needed I can remove the skip and change expected value to be first fixed drive when test is run on root drive dir. But this is already tested by patch 3 (when run on a root drive dir). -- Nicolas Le

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.

2009-04-12 Thread Nicolas Le Cam
2009/4/12 James McKenzie : > Nicolas Le Cam wrote: >> 2009/4/11 Ben Klein : >> >>> 2009/4/11 Nicolas Le Cam : >>> >>>> 2009/4/11 James Hawkins : >>>> Let met explain : >>>> >>>> Running test on wine in folder C:\

  1   2   >