Seeing if there was anything I can do to help either of these patches move
along. Don't want them to get lost.
~Nate
On Sun, 6 Dec 2009, Huw Davies wrote:
By the way, in storage32.h the filename member of struct StorageBaseImpl is
declared as
WCHAR filename[DIRENTRY_NAME_BUFFER_LEN];
shouldn't it be
WCHAR filename[DIRENTRY_NAME_MAX_LEN];
?
Huw.
Looking at it, I can't tell. Perhaps Vincent Povirk can expl
Kirill,
I see what you're getting at. The valgrind error comes about when we call
get_column_info in streams.c. No string is allocated for table_name there,
so the pointer remains uninitialized.
I am unfamiliar with the streams use case, but looking at
tests/db.c:test_streamtable(), I think
Could someone give me a pointer as to how you reproduce this trace? I've
spent some time fiddling with valgrind, the WINETEST_WRAPPER env var, and
--enable-maintainer-mode, all to no avail.
~Nate
On Wed, 28 Oct 2009, Dan Kegel wrote:
Hi Nate,
your patch seems to have caused new valgrind war
Resubmit of patch.
Patch separated into test and fix components.
Patch rebased.
tableName variable --> table_name
Commented code removed.
Unused variables removed
Unnecessary debug printf's removed.
Thanks for the review,
~Nate
On Thu, 1 Oct 2009, Hans Leidekker wrote:
Hi Nate,
Your patch a
