Re: d3dx9_36: Use cross-platform versions of infinity and NaN.

2011-07-09 Thread Misha Koshelev
On Jul 9, 2011 9:46 AM, "Dylan Smith" wrote: > > On Sat, Jul 9, 2011 at 10:16 AM, Misha Koshelev wrote: > > Does the attached patch work on MS Visual Studio 2010? This passes all tests. > > Ya, it should work. I was only building test applications using the > cl f

Re: d3dx9_36: Use cross-platform versions of infinity and NaN.

2011-07-09 Thread Misha Koshelev
On Tue, Jul 5, 2011 at 8:18 AM, Dylan Smith wrote: > On Tue, Jul 5, 2011 at 8:27 AM, Marvin wrote: >> === WXPPROSP3 (32 bit math) === >> math.c:2275: Test failed: Got , expected 7fff or 7fff for index 18. > > 0.0f/0.0f = -nan (0xffc0) > -(0.0f/0.0f) = nan (0x7fc0) > > msvc complains a

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

2011-02-26 Thread Misha Koshelev
On Sat, Feb 26, 2011 at 4:48 PM, Juan Lang wrote: > Hi Misha, > >> My own (very unhelpful) diagnosis of the pattern is that, for the >> mantissa values: >> >> 2018.5 should round to 2018 >> 2019.5 should round to 2020 > > The pattern appears to be "round half to even", which you may read > about o

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

2011-02-26 Thread Misha Koshelev
> Hi Misha, > > ... > > I'm attaching your patch with some modifications (mostly I took some > missing pieces from my old, way broken, patch). It seems to help a bit > but it's not perfect yet. It fixes handling of > 65520.0 values and > denormalized numbers. The interesting bit was to have some ad

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

2011-02-21 Thread Misha Koshelev
2011/2/20 Rico Schüller : > Hi, > > I have a small hint to the D3DXFloat32To16Array function. It seems that some > values are handled in some other way. > > A small test: >        D3DXFLOAT16 res; >        union p >        { >            float f; >            DWORD d; >        } x; > >        x.d =

Re: Anyone using Wine D3D under Parallels?

2011-02-17 Thread Misha Koshelev
On Thu, Feb 17, 2011 at 5:36 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Actually, before reinstalling OSX I used the CrossOver X11 setup to compile > and run Wine. It also has a few other missing libraries. On my other machine > I compiled a few libraries fr

Re: Somewhat barebones patch to implement D3DXCreateRenderToSurface for bug 24899, how much more needs to be implemented?

2011-02-17 Thread Misha Koshelev
On Thu, Feb 17, 2011 at 6:37 PM, Matteo Bruni wrote: > 2011/2/16 Misha Koshelev : > The patch stubs all methods of ID3DXRenderToSurface, right? I think > you can already send it, even if it lacks the actual implementation. > Does it make any game go further? Yes, it does stub those

Re: Anyone using Wine D3D under Parallels?

2011-02-17 Thread Misha Koshelev
For future reference, here is how I was able to quickly compile wine's git version with all the libraries helpfully installed by MacPorts. sudo port install wine-devel When this is finished, go to the Wine GIT folder, and do: ./configure CPPFLAGS='-I/usr/X11/include -I/opt/local/include' LIBS='-

Re: Anyone using Wine D3D under Parallels?

2011-02-16 Thread Misha Koshelev
On Wed, Feb 16, 2011 at 4:00 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 16.02.2011 um 02:24 schrieb Misha Koshelev: >> What would you recommend using? Do you mean MacOS itself in this >> specific instance, or was that a genera

Somewhat barebones patch to implement D3DXCreateRenderToSurface for bug 24899, how much more needs to be implemented?

2011-02-16 Thread Misha Koshelev
wine code base, how much more of ID3DXRenderToSurface needs to be implemented? Thank you Misha From 9fcf342ea2a08e57a8de2da0e566a2b182f160d4 Mon Sep 17 00:00:00 2001 From: Misha Koshelev Date: Wed, 16 Feb 2011 10:58:00 -0500 Subject: d3dx9: Implement barebones D3DXCreateRenderToSurface for bug

Re: Anyone using Wine D3D under Parallels?

2011-02-15 Thread Misha Koshelev
On Tue, Feb 15, 2011 at 6:50 PM, Henri Verbeet wrote: > On 15 February 2011 21:37, Misha Koshelev wrote: >> and noticed that although glxinfo reports: >> misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render >> direct rendering: Yes >> OpenGL rende

Re: D3DXCreateTorus patch... thoughts?

2011-02-15 Thread Misha Koshelev
24de063112569 Mon Sep 17 00:00:00 2001 From: Misha Koshelev Date: Tue, 15 Feb 2011 16:21:43 -0500 Subject: d3dx9: Implement D3DXCreateTorus. To: wine-patches Reply-To: wine-devel --- dlls/d3dx9_36/d3dx9_36.spec |2 +- dlls/d3dx9_36/mesh.c| 133 +++ dlls/

Anyone using Wine D3D under Parallels?

2011-02-15 Thread Misha Koshelev
I am trying some simple patches for: http://bugs.winehq.org/show_bug.cgi?id=24642 and noticed that although glxinfo reports: misha@ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render direct rendering: Yes OpenGL renderer string: Parallels using NVIDIA GeForce GT 330M OpenGL Engine

D3DXCreateTorus patch... thoughts?

2011-02-13 Thread Misha Koshelev
This is for http://bugs.winehq.org/show_bug.cgi?id=23930 Based on my prior mesh patches. Test bot reports success: https://testbot.winehq.org/JobDetails.pl?Key=9240 Thank you Misha From c2c3f5299cad1d78cff4457716c550687b818706 Mon Sep 17 00:00:00 2001 From: Misha Koshelev Date: Sun, 13 Feb

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-12 Thread Misha Koshelev
guys, I get it. We are trying to have the function work on non-IEEE systems. How about the attached. It's basically if (in == 0.0f) return (sign ? 0x8000 : 0x); Seems to work: https://testbot.winehq.org/JobDetails.pl?Key=9224 What do you think? Misha From d7fc1883325a00c351505391

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Misha Koshelev
On Fri, Feb 11, 2011 at 3:58 PM, Stefan Dösinger wrote: > Am Freitag 11 Februar 2011, 20:48:58 schrieb Misha Koshelev: >> Stefan et al: >> >> Thank you. How about this guy? > >> +    if (exp > 31) >> +    { >> +        /* too big */ >> +      

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-11 Thread Misha Koshelev
On Wed, Feb 9, 2011 at 4:40 AM, Stefan Dösinger wrote: > Am Dienstag 08 Februar 2011, 22:45:52 schrieb Misha Koshelev: >> I don't have msvc. Please suggest how I can check this. Thank you. Yours >> Misha > According to http://www.johndcook.com/math_h.html it exists, but has

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-10 Thread Misha Koshelev
On Thu, Feb 10, 2011 at 6:13 AM, Stefan Dösinger wrote: >> The brace goes in column 1 so that [[ and ]] work in vi. >> Putting the function name in column 1 lets you search for the >> definition using the anchored regexp ^function_name\> > Code style in Wine doesn't have anything to do with editor

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-09 Thread Misha Koshelev
On Wed, Feb 9, 2011 at 4:40 AM, Stefan Dösinger wrote: > Am Dienstag 08 Februar 2011, 22:45:52 schrieb Misha Koshelev: >> I don't have msvc. Please suggest how I can check this. Thank you. Yours >> Misha > According to http://www.johndcook.com/math_h.html it exists, but has

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-08 Thread Misha Koshelev
I don't have msvc. Please suggest how I can check this. Thank you. Yours Misha On Feb 8, 2011 4:01 PM, "Stefan Dösinger" wrote: Am Dienstag 08 Februar 2011, 17:52:06 schrieb Misha Koshelev: > switch (fpclassify(in)) Is this portable? Does it work on msvc too?

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-08 Thread Misha Koshelev
On Tue, Feb 8, 2011 at 12:02 AM, Dmitry Timoshkov wrote: > Misha Koshelev wrote: > >> +static inline unsigned short float_32_to_16(const float *in) > >> +static inline float float_16_to_32(const unsigned short *in) { > > Is there a reason that you pass a pointer t

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-07 Thread Misha Koshelev
On Mon, Feb 7, 2011 at 6:20 PM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 07.02.2011 um 23:49 schrieb Misha Koshelev: > I have no full explanation yet, just bits and pieces. By the way, if you > haven't done so already I rec

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-07 Thread Misha Koshelev
On Mon, Feb 7, 2011 at 2:14 PM, Stefan Dösinger wrote: > Am Montag 07 Februar 2011, 19:37:09 schrieb Misha Koshelev: >> Stefan: I believe this is actually a _difference_ between Windows versions. >> >> As you will note on the full results from winetestbot as well as my >&

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-07 Thread Misha Koshelev
On Mon, Feb 7, 2011 at 3:32 AM, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > Am 07.02.2011 um 03:37 schrieb Misha Koshelev: >> +    FLOAT full[10] = { 1.0f, -2.0f, 6.55e4, 6.10352e-5, 5.96046e-8, 0.0f, >> -0.0f, INFINITY, -INFINITY,

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

2011-02-06 Thread Misha Koshelev
Sorry guys. Looks like there are differences between Windows version. Sigh. Will fix. Henri, will you get a chance to look at the patch before I re-send so that I can fix any other defects you might see? I don't want to send too many resends to the list. Thank you so much Misha On Sun, Feb 6, 2

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)

2010-09-16 Thread Misha Koshelev
On Thu, 2010-09-16 at 10:25 +0200, Henri Verbeet wrote: > On 16 September 2010 02:23, misha680 wrote: > > Could you possible clarify your statement > > "though I wonder if implementing DrawSubset() isn't going to require > > creating a > > vertex declaration anyway." > > > > My understanding from

Re: Must copy static const D3DVERTEXELEMENT9 into dynamically alllocated D3DVERTEXELEMENT9 * before pointer passed correctly in Wine?

2010-09-07 Thread Misha Koshelev
On Tue, 2010-09-07 at 15:56 +0200, Henri Verbeet wrote: > On 7 September 2010 14:43, misha680 wrote: > > LPD3DVERTEXELEMENT9 is a D3DVERTEXELEMENT9 *, > > http://msdn.microsoft.com/en-us/library/bb172630%28VS.85%29.aspx > > > > so LPD3DVERTEXELEMENT9 * is a D3DVERTEXELEMENT9 **, and to get at the

Re: d3dx9: Implement D3DXFVFFromDeclarator.

2010-08-31 Thread Misha Koshelev
On Tue, Aug 31, 2010 at 7:58 AM, Henri Verbeet wrote: > On 31 August 2010 14:47, misha680 wrote: >> As you can see by the tests added, colors and normals have an ordering that >> is specifically constrained within the FVF. >> > Well yes, but I'd say that ordering should apply to *any* FVF element

Re: d3d9 equivalent of D3DXFVFFromDeclarator?

2010-08-28 Thread Misha Koshelev
On Fri, Aug 27, 2010 at 10:53 PM, Henri Verbeet wrote: > On 28 August 2010 02:44, Misha Koshelev wrote: >> I am looking again at d3d9, but feel like I am running in circles a >> little bit trying to chase down where convFVF and convertedDecls is >> coming from. >> >

d3d9 equivalent of D3DXFVFFromDeclarator?

2010-08-27 Thread Misha Koshelev
Dear All: Thanks a lot Henri for your wonderful D3DXDeclaratorFromFVF patches. It is wonderful to be exposed to the "right" way to implement this function. I am starting to look at D3DXDeclaratorFromFVF, as this would be the next step before implementing ID3DXMesh. I am looking again at d3d9, b

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-25 Thread Misha Koshelev
On Wed, 2010-08-25 at 12:28 +0200, Henri Verbeet wrote: > On 25 August 2010 04:04, misha680 wrote: > > What do you think about this one on top of those? I will wait to send to > > wine-patches until your patches have been committed. > > http://wine.1045685.n5.nabble.com/file/n2652101/0004-d3dx9-Im

Re: d3dx9: D3DXCreateMeshFVF

2010-07-31 Thread Misha Koshelev
"Misha Koshelev" wrote: >> Instead of implementing D3DXCreateMeshFVF, wouldn't it be better to >> implement D3DXCreateMesh and call the latter from D3DXCreateMeshFVF by >> previously using D3DXDeclaratorFromFVF? >> >> D3DXCreateMeshFVF would

Re: d3dx9: D3DXCreateMeshFVF

2010-07-31 Thread Misha Koshelev
> Instead of implementing D3DXCreateMeshFVF, wouldn't it be better to > implement D3DXCreateMesh and call the latter from D3DXCreateMeshFVF by > previously using D3DXDeclaratorFromFVF? > > D3DXCreateMeshFVF would be pretty straight then: > 1. get the const LPD3DVERTEXELEMENT9 *pDeclaration from

d3dx9: D3DXCreateMeshFVF and ID3DXMesh... let the criticism begin

2010-07-26 Thread Misha Koshelev
s, should be fairly simple compared to this part. In any case, I eagerly (anxiously) await constructive criticism/feedback/suggestions. Thank you Misha >From 1c7a93a3e18fcf117eef2b9dd7c0086b51872f52 Mon Sep 17 00:00:00 2001 From: Misha Koshelev Date: Mon, 26 Jul 2010 20:16:43 -0500 Subject:

d3dx9: D3DXCreateMeshFVF and ID3DXMesh... let the criticism begin

2010-07-26 Thread Misha Koshelev
ciate all your feedback. Please see complete message below. Thank you Misha -- Forwarded message -- From: Misha Koshelev Date: Mon, Jul 26, 2010 at 8:29 PM Subject: d3dx9: D3DXCreateMeshFVF and ID3DXMesh... let the criticism begin To: wine-devel@winehq.org Cc: Henri Verbeet , tony.

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5)

2010-07-26 Thread Misha Koshelev
On Tue, 2010-07-27 at 05:56 +0300, Octavian Voicu wrote: > On Tue, Jul 27, 2010 at 5:04 AM, Misha Koshelev wrote: > > Linking same file in test and main dll: I am not aware of a precedent for > > this but if there is one of course I would be glad to be shown otherwise. > > O

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5)

2010-07-26 Thread Misha Koshelev
moving the lookup table calculation from the helper function which we will also use for, at the very least, the cylinder test, inside the actual compute_sphere function itself? Thank you Misha On Jul 26, 2010 8:40 PM, "Octavian Voicu" wrote: On Tue, Jul 27, 2010 at 4:15 AM, Mish

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5)

2010-07-26 Thread Misha Koshelev
ot; wrote: On Tue, Jul 27, 2010 at 4:15 AM, Misha Koshelev wrote: > Why do you ask? > > Ar... That's why I was asking, as I suppose you can't use functions from the test in the implementation, nor have internal functions used in the tests. Only way I see it is to have something

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 5)

2010-07-26 Thread Misha Koshelev
> On Tue, Jul 27, 2010 at 1:30 AM, Misha Koshelev wrote: > > I have spent quite a bit of time with Henri on IRC re this patch (thank you > > so much) and it now has his blessing. > > > > Hopefully everyone else's as well :) > > Looks nice, but I have

Sorry for all the repeat emails :(

2010-07-24 Thread Misha Koshelev
They did not seem to go through this morning. My apologies for the (apparently unnecessary) resends. Misha

d3dx9: general direction/goal - speed, code "prettiness", etc?

2010-07-24 Thread Misha Koshelev
Dear All: Given my recent work on this bug: http://bugs.winehq.org/show_bug.cgi?id=22918 and on D3DXCreateSphere, with the latest iteration being: http://www.winehq.org/pipermail/wine-patches/2010-July/091176.html I have been giving quite a bit of thought to d3dx9 and to mesh creation functions

d3dx9: general direction/goal - speed, code "prettiness", etc?

2010-07-24 Thread Misha Koshelev
would have to download and extract. I appreciate all your comments. Thank you Misha -- Forwarded message -- From: Misha Koshelev Date: Sat, Jul 24, 2010 at 10:33 AM Subject: d3dx9: general direction/goal - speed, code "prettiness", etc? To: wine-devel Cc: Henri Verbe

Fwd: d3dx9: general direction/goal - speed, code "prettiness", etc?

2010-07-24 Thread Misha Koshelev
My apologies this does not seem to be going through with attachment and I cannot upload from my phone. Will send link shortly. Thank you. Misha -- Forwarded message -- From: "Misha Koshelev" Date: Jul 24, 2010 11:35 AM Subject: d3dx9: general direction/goal - s

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 2)

2010-07-22 Thread Misha Koshelev
I hate to do this but I would rather look bad as a person than taint Wine with imperfect code. Thus, I will please ask to hold my very own patch for the moment. I don't honestly know that there is a better way to come up with indices but I have some ideas, mainly looking at: http://local.wasp.uwa

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere.

2010-07-22 Thread Misha Koshelev
> > +static DWORD compute_sphere_test_index_data(FLOAT radius, UINT slices, > > UINT stacks) > I haven't really thought this through yet, but would it perhaps be > simpler to calculate the faces a vertex is part of, instead of the > other way around? > Please find attached the relevant data. I

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-20 Thread Misha Koshelev
On Mon, 2010-07-19 at 22:48 -0600, Vitaliy Margolen wrote: > On 07/19/2010 08:59 PM, Misha Koshelev wrote: > > Unfortunately, the more intuitive > > git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old > > > > does not seem to result in patches that

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-20 Thread Misha Koshelev
On Mon, 2010-07-19 at 22:48 -0600, Vitaliy Margolen wrote: > On 07/19/2010 08:59 PM, Misha Koshelev wrote: > > Unfortunately, the more intuitive > > git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old > > > > does not seem to result in patches that

Quick legal question... teapot related

2010-07-20 Thread Misha Koshelev
If I take a publicly available teaset: http://www.sjbaker.org/teapot/teaset.tgz And run it through a Microsoft function: http://msdn.microsoft.com/en-us/library/bb205470%28v=VS.85%29.aspx D3DXTesselateRectPatch for example And then copy the vertex buffer and index buffer and save them... Do I ha

Fyi patch submission information on wiki updated for GitHub

2010-07-19 Thread Misha Koshelev
isha-d630:~/src/wine-git$ >From 03180708b36aab9efd566c8971da7b60924500bf Mon Sep 17 00:00:00 2001 From: Misha Koshelev Date: Wed, 7 Jul 2010 09:59:52 -0500 Subject: d3dx9: Test number of vertices for D3DXCreateSphere, retrieve vertex buffer. To: wine-patches Reply-To: wine-devel --- dlls/d3dx9_36/tests/mesh.c |

My sincerest sincerest apologies

2010-07-19 Thread Misha Koshelev
Dear All: I am very very sorry for the spam I have created via my testbot failures. I have struggled quite a bit merging my git repository with upstream Wine today. In fact, when I generated individual patches using git-format-patch from my GitHub repository and then used git-am on the correspond

Re: Quick license question for teapot

2010-07-19 Thread Misha Koshelev
On Mon, 2010-07-19 at 20:49 +0200, Stefan Dösinger wrote: > Am 19.07.2010 um 20:33 schrieb Misha Koshelev: > > As for teapot, Henri recommends looking at freeglut. I know wine is: > > http://www.winehq.org/license > > GPL 2.1 > Actually, it is LGPL 2.1. > > I don

Quick license question for teapot

2010-07-19 Thread Misha Koshelev
Dear All: Sorry to bother - apparently Owen Rudge has done quite a bit of basic texture work, so I will await his patches to start my texture work. As for teapot, Henri recommends looking at freeglut. I know wine is: http://www.winehq.org/license GPL 2.1 Freeglut is "freeglut is released under t

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
Thank you. I will take a look at this tomorrow morning. On Jul 18, 2010 8:05 PM, "Jeff Zaroyko" wrote: On Mon, Jul 19, 2010 at 10:48 AM, Misha Koshelev wrote: > I believe the GLMap2f... I don't know if this is entirely necessary for your purpose, but OpenGL has a feedback b

Re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
I believe the GLMap2f functions are actually creating further vertex data... I could be wrong though. Thx Misha On Jul 18, 2010 5:46 PM, "Roderick Colenbrander" wrote: On Sun, Jul 18, 2010 at 11:58 PM, Misha Koshelev wrote: > On Sun, 2010-07-18 at... How raw do you want to

re: D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
On Sun, 2010-07-18 at 14:37 -0700, Dan Kegel wrote: > IMHO, our criterion is "we only need to implement what apps really need", > and for the moment, that app probably could live with a stub for > D3DXCreateTeapot. When we run into a complaint about > our lousy teapot, we can create a better one.

D3DXCreateTeapot and reverse engineering?

2010-07-18 Thread Misha Koshelev
Dear All: I just wanted to double check before I do anything with D3DXCreateTeapot. I have several options for implementing this: Option A One, the slightly harder option, involves the original dataset: http://www.sjbaker.org/teapot/teaset.tgz Option B Another, much simpler me

Re: Sending patches for bug #22918

2010-07-17 Thread Misha Koshelev
On Sat, 2010-07-17 at 15:39 +0200, Frédéric Delanoy wrote: > On Sat, Jul 17, 2010 at 14:43, Misha Koshelev wrote: > > On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote: > >> Misha Koshelev wrote: > > p.s. Do I remember correctly AJ does not commit on weekends? >

Re: Sending patches for bug #22918

2010-07-17 Thread Misha Koshelev
On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote: > Misha Koshelev wrote: > > Dear All: > > > > Congrats on 1.2! > > > > I have begun sending my patches from my repository: > > http://github.com/misha680/wine/commits/master > > > > >

Re: [PATCH 01/10] d3dx9: Add stub and basic test for D3DXCreateSphere.

2010-07-16 Thread Misha Koshelev
On Fri, Jul 16, 2010 at 5:37 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://test

Sending patches for bug #22918

2010-07-16 Thread Misha Koshelev
Dear All: Congrats on 1.2! I have begun sending my patches from my repository: http://github.com/misha680/wine/commits/master Specifically, I have sent the first 10 patches (of approx 70 currently). I look forward to your comments/commits ;) Also, if anyone knows how to make git format-patch o

Test questions: defining test structures as global variables and quick floating point reference

2010-07-15 Thread Misha Koshelev
Dear All: Thank you again for all your help. To remind you, I am working on fixing: http://bugs.winehq.org/show_bug.cgi?id=22918 And, as we are currently in code freeze, I have a GitHub repo here in which I am making relevant changes: http://github.com/misha680/wine/commits/master I am going ov

added some Git morsels

2010-07-14 Thread Misha Koshelev
Dear All: Hope you are all doing well. Per Dan's suggestions, and since I have been working with GitHub, I have added some morsels to the Wiki page: http://wiki.winehq.org/GitWine * Per Mike Kaplinskiy's great advice, removing trailing whitespace: http://wiki.winehq.org/GitWine * For git-rebase

Re: Having some trouble implementing D3DXComputeNormals... any hints/advice?

2010-07-12 Thread Misha Koshelev
On Mon, 2010-07-12 at 22:54 +0200, Henri Verbeet wrote: > On 12 July 2010 22:43, Misha Koshelev wrote: > > Thank you Henri for the explanation. In fact it seems that this flag is > > default on D3DXComputeTangentFrameEx: > > > >D3DXTANGENT_WEIGHT_BY_AREA &g

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Misha Koshelev
> On 10 July 2010 17:40, Misha Koshelev wrote: > On Sat, 2010-07-10 at 07:40 +010... > > > Ok that makes sense. > > > > What about in the case of something like this: > > > > /* > http://www.cygnus... > > > Is assert ok here or do I need to change it to some kind of skip > > statement as well? > > T...

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Misha Koshelev
programmer made an error. Thank you Misha On Jul 10, 2010 12:11 PM, "Reece Dunn" wrote: On 10 July 2010 17:40, Misha Koshelev wrote: > On Sat, 2010-07-10 at 07:40 +010... > Ok that makes sense. > > What about in the case of something like this: > > /* > http://www

Inserting commits fyi... I think this might do the trick

2010-07-10 Thread Misha Koshelev
Thank you all for your comments. I still seem to be losing commits. However I have found a reference that seems like it might do the trick and wanted to share with others. Specifically, the key is to mark edit in interactive rebase on the commit one desires to split. Next one does a git reset HEA

Re: sorry one more question: assert statements in tests

2010-07-10 Thread Misha Koshelev
On Sat, 2010-07-10 at 07:40 +0100, Reece Dunn wrote: > On 10 July 2010 03:40, Misha Koshelev wrote: > > I am implementing my tests as follows: > > > > * patch 1: general test for a D3DX function (D3DXCreateBox for example, > > testing specific vertices and indice

Re: git rebase to _insert_ commits?

2010-07-10 Thread Misha Koshelev
On Sat, 2010-07-10 at 05:33 +0200, David Hedberg wrote: > On Sat, Jul 10, 2010 at 2:54 AM, Misha Koshelev wrote: > > Dear All: > > > > I am still learning git and it seems that my solution does not quite > > work. > > > > Specifically, my idea was to

sorry one more question: assert statements in tests

2010-07-09 Thread Misha Koshelev
I am implementing my tests as follows: * patch 1: general test for a D3DX function (D3DXCreateBox for example, testing specific vertices and indices for _specific_ dimensions). * patch 2: separate into function that works with arbitrary dimensions for the box, etc. I restrict to the dimensions fro

Re: git rebase to _insert_ commits?

2010-07-09 Thread Misha Koshelev
On Fri, 2010-07-09 at 21:02 -0400, Mike Kaplinskiy wrote: > You can move commits around in an interactive rebase. Just create an > empty commit, move it into place with rebase and edit it. > > Sorry for top post, mobile gmail doesn't let you bottom post. > > > On J

Re: git rebase to _insert_ commits?

2010-07-09 Thread Misha Koshelev
On Fri, 2010-07-09 at 21:02 -0400, Mike Kaplinskiy wrote: > You can move commits around in an interactive rebase. Just create an > empty commit, move it into place with rebase and edit it. > > Sorry for top post, mobile gmail doesn't let you bottom post. > > > On J

git rebase to _insert_ commits?

2010-07-09 Thread Misha Koshelev
Dear All: I am still learning git and it seems that my solution does not quite work. Specifically, my idea was to use: git rebase -i upstream/master Mark the commit _after_ which I'd like to insert a commit with edit. Then, when I am at that commit, I do: git commit --amend -a save commit Th

please don't shoot from the hip ;)

2010-07-09 Thread Misha Koshelev
Hi Guys: I really appreciate all the responses to my work on this bug http://bugs.winehq.org/show_bug.cgi?id=22918 Especially the fact that you guys are looking at this code is very very important to me, as it will have to be eventually reviewed to be submitted to Wine. However, I am a little fr

Re: WINED3DUSAGE_MASK?

2010-07-09 Thread Misha Koshelev
On Fri, 2010-07-09 at 11:31 +0200, Stefan Dösinger wrote: > Am 09.07.2010 um 03:21 schrieb Misha Koshelev: > >wined3d: Add WINED3DUSAGE_OVERLAY. > This was added for overlay surfaces that only exist in ddraw. The mask is to > make sure d3d9 apps don't accidentally pass thi

WINED3DUSAGE_MASK?

2010-07-08 Thread Misha Koshelev
Dear All: Sorry to bother - I just ran into something quite curious in terms of a Wine-specific feature that is certainly not matched in Windows XP and was wondering what its purpose was... Also, should I use todo_wine to test for this, or is there a better way since this seems something that obv

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

2010-07-08 Thread Misha Koshelev
On Wed, Jul 7, 2010 at 10:41 PM, James McKenzie wrote: > Misha Koshelev wrote: >>> >>> Misha Koshelev wrote: >>> >>>> >>>> Ok per Dan's comments back to >>> >>>> >>> >>> Misha: >>>

fyi d3dx work

2010-07-07 Thread Misha Koshelev
I did end up going with a github repo as I've finally figured out git pretty well (thanks a lot to you guys!) It is here: http://github.com/misha680/wine/commits/master In any case, feel free to peruse if interested. Hopefully when 1.2 is done I can start submitting to wine. Henri especially has

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)

2010-07-07 Thread Misha Koshelev
> Misha Koshelev wrote: > > > >Ok per Dan's comments back to > > Misha: > > Alexandre rejects 'white space' changes, that is changes that fix > indentation, remove extraneous or trailing spaces and tabs unless there is > another change neede

bug or feature: libd3dx9.cross.a

2010-07-07 Thread Misha Koshelev
Dear All: I have run into another slight issue and, as this may affect others, was wondering whether or not I am (i) doing something wrong or (ii) this is something that should be corrected (in that case I am happy to submit a patch but need a bit of guidance as to where this could be fixed as I

one more git trick - how to add (try x) automatically?

2010-07-07 Thread Misha Koshelev
Any hints. Since I'll probably be trying more than once for patches, good to know. Thank you! Misha

Re: one more legal/protocol question

2010-07-06 Thread Misha Koshelev
On Tue, 2010-07-06 at 19:08 -0700, Juan Lang wrote: > > My question: > > Can I simply > > 1) look at the relevant DirectX 9 Microsoft .h files and add the > > constants (rewriting of course not copy paste) from there? > > I believe you can. > > > 2) do I have to do something more complicated? >

one more legal/protocol question

2010-07-06 Thread Misha Koshelev
Dear All: I may be mistaken, but it appears that the constants used for D3DX Mesh Options: http://msdn.microsoft.com/en-us/library/bb205746%28v=VS.85%29.aspx are not yet present in Wine. For example, in the main Wine source directory the command: find . -name \*.h -exec grep D3DXMESH_32BIT {} \

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
On Tue, Jul 6, 2010 at 2:04 PM, Misha Koshelev wrote: > On Tue, 2010-07-06 at 14:50 -0400, Mike Kaplinskiy wrote: >> On Tue, Jul 6, 2010 at 2:31 PM, Misha Koshelev wrote: >> > On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: >> >> Thank you so much for the i

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Misha Koshelev
On Wed, 2010-07-07 at 00:17 +0200, Matteo Bruni wrote: > 2010/7/6 Misha Koshelev : > > Oops good thing I did not yet figure out how to use a native d3dx9_36 then > > so no compromise of my ability to contribute. > > > > Just to clarify then... I may NOT use wine to mo

Re: ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Misha Koshelev
Oops good thing I did not yet figure out how to use a native d3dx9_36 then so no compromise of my ability to contribute. Just to clarify then... I may NOT use wine to monitor calls within a native DLL? Specifically, I may not determine what parameters one native function passes to another? Thank

ok sorry dumb question... running make test with native DLLs

2010-07-06 Thread Misha Koshelev
I am now trying to debug the exact parameters D3DXCreateBox uses in its call to D3DXCreateMesh to create its mesh. I would like to run make test with a native DLL. I have tried both: * using winecfg to set native overrides * WINEDLLOVERRIDES="d3dx9_36=n" make test but neither seems to do the tri

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
On Tue, 2010-07-06 at 14:50 -0400, Mike Kaplinskiy wrote: > On Tue, Jul 6, 2010 at 2:31 PM, Misha Koshelev wrote: > > On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: > >> Thank you so much for the info. I will probably just keep the Zip file for > >> now but if

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
On Tue, Jul 6, 2010 at 12:42 PM, Misha Koshelev wrote: > Thank you so much for the info. I will probably just keep the Zip file for > now but if the number of patches gets out of hand will try git again :-) > Thanks again > > Misha > > On Jul 6, 2010 12:18 PM, "Mike Ka

Re: Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
Thank you so much for the info. I will probably just keep the Zip file for now but if the number of patches gets out of hand will try git again :-) Thanks again Misha On Jul 6, 2010 12:18 PM, "Mike Kaplinskiy" wrote: On Tue, Jul 6, 2010 at 11:27 AM, Misha Koshelev wrote: > Fyi I

Update - no wine repo on github

2010-07-06 Thread Misha Koshelev
Fyi I am just going to keep my latest patches here: http://www.mkosh.com/wine-d3dx9.zip I have struggled for an hour trying to remove a remote commit on github, and that's an hour I'd rather spend implementing D3DX functions. Anyway sorry for the mailbox clutter :) Misha

Re: back from Russia... learning d3dx9

2010-07-06 Thread Misha Koshelev
On Tue, 2010-07-06 at 15:10 +0200, Matteo Bruni wrote: > 2010/7/6 Misha Koshelev : > > Thank you for the well wishes James and Dan. Will def keep the test bot in > > mind. > > Unfortunately no WineTestBot machine has any d3dx9_xx.dll installed > (or so it was last tim

Re: back from Russia... learning d3dx9

2010-07-05 Thread Misha Koshelev
soon once code freeze is done. Oh and happy fourth belatedly! Misha On Jul 5, 2010 6:53 PM, "James McKenzie" wrote: Misha Koshelev wrote: > > Hi All: > > Just wanted to let y'all know you seem to have great progress ... A bunch of us are. I hope it is soon. There ar

back from Russia... learning d3dx9

2010-07-05 Thread Misha Koshelev
Hi All: Just wanted to let y'all know you seem to have great progress towards wine 1.2. I am eagerly awaiting its release so that I can start submitting more patches. Meanwhile, I am learning background material for D3DX9. Along with the wonderful book Dan recommended: http://www.d3dcoder.net/d3

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-25 Thread Misha Koshelev
On Fri, 2010-06-25 at 18:59 +0200, Henri Verbeet wrote: > On 25 June 2010 18:20, Misha Koshelev wrote: > >> regard, although there are (very) minor issues like using %d for > >> unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 > >> over simply &q

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-25 Thread Misha Koshelev
> On 24 June 2010 05:18, Misha Koshelev wrote: > > Dan suggested tests ok during code freeze so blame Dan for my patches ;) > Certainly will. wine-devel is an open mailing list, and posting is > easy. You'll probably want to check with something like "git shortlog >

Re: [PATCH 2/7] d3dx9: Add IUnknown method calls to ID3DXMesh.

2010-06-25 Thread Misha Koshelev
> On 24 June 2010 05:18, Misha Koshelev wrote: > > +#if !defined(__cplusplus) || defined(CINTERFACE) > > +/*** IUnknown methods ***/ > > +#define ID3DXMesh_QueryInterface(p,a,b) > > (p)->lpVtbl->QueryInterface(p,a,b) > > +#define ID3DXMesh_AddRef(

[no subject]

2010-06-25 Thread Misha Koshelev
> On 24 June 2010 05:18, Misha Koshelev wrote: > > Dan suggested tests ok during code freeze so blame Dan for my patches ;) > Certainly will. wine-devel is an open mailing list, and posting is > easy. You'll probably want to check with something like "git shortlog >

Re: sorry guys... slow on uptake today :)

2010-06-25 Thread Misha Koshelev
On Fri, 2010-06-25 at 07:31 -0700, James Mckenzie wrote: > Misha Koshelev wrote: > > > >So I've been working on bug 13891, but got sidetracked by what I thought > >was a race condition as dlls/shell32/tests/shlexec.c was hanging. > > > >Spent several hour

sorry guys... slow on uptake today :)

2010-06-24 Thread Misha Koshelev
So I've been working on bug 13891, but got sidetracked by what I thought was a race condition as dlls/shell32/tests/shlexec.c was hanging. Spent several hours tracing it to line 464 in dlls/ntdll/directory.c if (stat( entry->mnt_dir, &st ) == -1) continue; (read from /etc/mtab) Turned o

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-24 Thread Misha Koshelev
On Thu, 2010-06-24 at 11:33 -0700, James Mckenzie wrote: > Henri Verbeet > > >On 24 June 2010 18:11, Misha Koshelev wrote: > >> Ok thank you. Since we are in code freeze and I'd like to help wine, > >> perhaps then I > >>will just go down the list of

  1   2   3   >