Marcus Meissner wrote:
-if (!(fin = fopen(input_file_name, "r"))) return 0;
if (stat(input_file_name, &st) < 0) return 0;
+if (!(fin = fopen(input_file_name, "r"))) return 0;
Wouldn't it be better to use fstat here to avoid a race condition?
Mike
Kanit Therdsteerasukdi wrote:
I'm a student at UCLA taking CS130: Software Engineering. For CS130, we
are writing conformance tests for Common Controls (comctl32). I will be
working on the Date and Time Picker. Attached is an initial test,
testing the getters and setters.
Looks like good w
Robert Shearman wrote:
Ref counts can be assumed to be between 0 and MAXLONG, so the fact
that LONG is signed isn't important.
NO. The DCOM spec says that STDOBJREF::cPublicRefs is unsigned,
therefore the ref counts can be assumed to be up to MAXULONG. Therefore,
this change is incorrect an
Scott Ritchie wrote:
The simplest thing to do is for someone to just track the code they
release and diff it against our own stuff, and note if anything new and
interesting (eg an implementation of a function) comes up. Then send in
a patch if it seems like it could help us too. But, is anyon
Damjan Jovanovic wrote:
diff -ur a/include/winbase.h b/include/winbase.h
--- a/include/winbase.h 2007-01-12 20:59:52.0 +0200
+++ b/include/winbase.h 2007-01-24 20:42:35.0 +0200
I would recommend you at least split the modifications to winbase into a
separate patch, as they ar
Martin Cracauer wrote:
The game "TacOps" (a standalone 2D wargame, not to be mixed up with
the Unreal mod "Tac Ops") uses home-grown scrollbars. They have
autorepeat, that means holding the mouse button on the "down" or "up"
icons will continue to scroll until you release the button. Without
Anatoly Lyutin wrote:
Changelog: Add test for CompareStringA for non latin symbols.
Hmm.
+ if (0) test_sorting_non_latin();
Adding a test that won't run...
+/* If you want to get the source code of the program generating a file,
+ * please write to me on [EMAIL PROTECTED]
+ * Automatic
Thomas Weidenmueller wrote:
BOOL WINAPI
-InitCommonControlsEx (LPINITCOMMONCONTROLSEX lpInitCtrls)
+InitCommonControlsEx (const INITCOMMONCONTROLSEX *picce)
The version of the Windows Platform SDK that I'm looking at agrees with
Wine.
There is also no reason to make a pointless change to
Dmitry Timoshkov wrote:
Does behaviour of MsiGetPropertyA and MsiGetPropertyW differ in that case?
I'd be interested to have a look at the test case.
I've put the test case up here:
http://mandoo.dyndns.org/msitest.zip
+TlsSetValue( tls_slot, (void*) 1 );
Shouldn't this be reset to 0
Keyur Pujara wrote:
I am contemplating to port a complex windows
application using winelib over Solaris/SPARC. In one
of the emails in wine-devel list, I saw that there may
be following issues in the process:
* byte endianness
* alignment issues
* pointer size
* must not use x86 assembly
This is the first time I've submitted a patch, so let me know if this
method of submission is incorrect. See description in the attachment.
It's best to put the description in the body of the mail, and write a
descriptive subject like "ole32: fix StgOpenStorage conformance test
failure" or s
Andrew Talbot wrote:
-if( n < 0 )
+if( (LONG)n < 0 )
Why not change the type of n to LONG rather than using a cast?
Mike
Stephen Torri wrote:
I am trying to create a custom Windows PE loader (binary & DLL) for the
purpose of security research. I am having a difficult time finding how
to allocate memory for a binary at the desired address in memory
(especially if its non-relocatable). I would like to see why I cann
Edward Savage wrote:
I'm prepared to write the WWN releases in Brian Vincent seeming absence
if it pleases the powers that be.
If this is alright I'd like some one to give an overview of what topics
should be covered and then for some one to review the first one or two
created. I've read th
Robert Shearman wrote:
+{
+char *format_name = HeapAlloc(GetProcessHeap(), 0, length);
+if (!format_name)
+return E_OUTOFMEMORY;
+GetClipboardFormatNameA(clipformat, format_name, length);
+hr = IStream_Write(stream, format_name, length, NULL);
+
Cloudor Pu wrote:
Now, how can I get X11 window id by HWND in my program? I saw a patch
GetX11WindowId at
http://www.mail-archive.com/wine-devel@winehq.com/msg05282.html
But this cannot be found in the latest wine. Can I get xwindow id by
HWND without patching wine?
Only top level (managed)
James Hawkins wrote:
Changelog:
* Remove redundant NULL checks before x_Release.
obj->Release() will read the vtable pointer from the object, and that
will crash if obj is NULL, so these checks are needed. The following
code will crash:
IUnknown *obj = NULL;
IUnknown_Release(obj);
You c
Nick Burns wrote:
The patches have been split in 2 one for the thunk and one for the winmm
driver.
Have these patches been rejected?
(I still dont know how to tell that -- other than checking wine-cvs)
"Rejected" is a strong word. Perhaps you could think of it as
"Alexandre hasn't been con
Anybody have time to help triage an install problem?
Sunbird (and FireFox 2) installs run in an endless loop for some people.
If you have time to try the install out and see if it works on your
system, then comment on bug 6613, it would help out.
http://bugs.winehq.org/show_bug.cgi?id=6613
Alexandre Julliard wrote:
My impression from reading MSDN is that Windows pops up a message box
too, but I don't have a way of confirming this. And I'm not convinced
that "make everything work and ignore security" is the right default,
we all know how well this worked for Windows.
Sure, don't
Alexandre Julliard wrote:
Peter Beutner <[EMAIL PROTECTED]> writes:
Besides i think it's a bad idea to blindly mark pages executable like this:
"hey, we successfully catched an attempted buffer overflow attack, thanks for
NX. But lets
ignore it and let the code run anyway ..." :p
Well, the
Lei Zhang wrote:
Add the IE6 registry key, so installers that check for the key will
stop complaining.
[EMAIL PROTECTED]:~/wine$ patch -p1 --dry-run < Add\ the\ IE6\ registry\ key.eml
patching file tools/wine.inf
patch: malformed patch at line 67:
Engine\Settings\SYSTEM\INIT,SHAREDMEMLO
Sam Dennis wrote:
@ cdecl vprintf(str long) MSVCRT_vprintf
-@ cdecl vsprintf(ptr str ptr) ntdll.vsprintf
+@ cdecl vsprintf(ptr str ptr) MSVCRT_vsprintf
Looks like your mailer munged the whitespace in the patch, which will
prevent it from applying cleanly.
Try using git format-patch --attac
Eric Pouech wrote:
well, the kill_thread in that case in only done when the waiting thread
also died while waiting (ie has been killed by some other way) (in
normal cases, the wait operation on the waiting side would just return
an error code)
the I'm not still conviced this path is actually
Eric Pouech wrote:
IIRC, the issue in this code is that you access in _SAFE macro the next
field in the current cursor *after* the current cursor has been freed
the issue is not that the next item has been freed while itering on the
current cursor
(this was at least the issue I had)
It looks
Eric Pouech wrote:
IMO this should be fixed by rewriting correctly the _SAFE version of the
list macros, which are to blame here.
I have this somewhere, I'll send it later on.
The only way to prevent the next pointer (or any other pointer in the
thread list) from being free'd is to grab it.
Dmitry Timoshkov wrote:
Well, I'd say that reporting the bugs on wine-devel shouldn't hurt,
besides presumably developers' audience here is much wider, and somebody
who have introduced a regression might not review bugs.winehq.org at all.
The point of reporting bugs in bugzilla is that we can
Mirek wrote:
Hi, there is big regression in latest CVS version,
Please report regressions and bugs to bugs.winehq.org.
Mike
Pavel Troller wrote:
It is usuyally generated from wine-pthread
gdb wine-pthread core.19668
Please open a bug and discuss this problem via bugzilla, rather than on
wine-devel.
Mike
L. Rahyen wrote:
fixme:seh:check_no_exec No-exec fault triggered at 0x401000, enabling
work-around
Are you using SeLinux or some other patches? If so, please try building
your kernel from the vanilla Linux kernel.org sources.
Mike
L. Rahyen wrote:
The system is gentoo linux (2.6.18-gentoo-r1)
I recently tried 2.6.18.1 kernel and wine stoped working. Then I downgraded
to 2.6.16.18 and wine working fine now.
I'm using a custom built 2.6.18.1 on Debian Unstable/AMD64 now, and Wine
works fine for me, so this is unlikel
Robert Shearman wrote:
In this case, just that the prototype is correct and so won't crash the
program in random ways when the function is called.
Well, you're welcome to write such a test case if you think it's
necessary. I think you'll prove nothing useful.
Mike
Robert Shearman wrote:
+NTSTATUS WINAPI RtlDllShutdownInProgress(void)
For undocumented functions like this, you should add a test case.
That's unreasonable. A stub isn't meant to work correctly, just stop an
application from crashing. What will a test case prove?
Mike
James Hawkins wrote:
+/* Crashes on Win2K
st = pAcquireCredentialsHandleA(NULL, unisp_name_a, 0, NULL,
NULL, NULL,
NULL, NULL, NULL);
ok(st == SEC_E_NO_CREDENTIALS, "Expected SEC_E_NO_CREDENTIALS,
got %08x\n",
st);
+ */
Please use #if 0/#endif to comment out
Francois Gouget wrote:
Including each header manually surely is not normal practice on Windows,
but the nice thing is that it lets us detect bugs in our header
dependencies. If we just include windows.h we will completely miss those
and thus reduces the value of the test.
These tests don't
Dan Kegel wrote:
The first three came today, and sadly, wine from git fails
to install one, and fails to run the other two:
Well, at least we're 2 for 3 with installers :)
Mike
---
Hi,
This code is mainly for debugging. I don't expect it to be applied, but
don't object if it is.
It exposes a number of memory leaks in richedit. For example, running
the richedit regression test shows leaks at:
line 248 file editor.c
line 1120 file editor.c
line 2230 file editor
David Anderson wrote:
An app (apparently Visual Basic) fails with
Run-time error '445'
Object doesn't support this action
Please report your bug to bugs.winehq.org, not wine-devel. You'll have
better luck getting help if your application is available for download.
Mike
Pierre d'Herbemont wrote:
dlls/winequartz.drv/Makefile.in |4 +-
dlls/winequartz.drv/event.c | 74
+++
dlls/winequartz.drv/quartzdrv.h |5 ++
dlls/winequartz.drv/quartzdrv_carbon.c | 46 +++
dlls/winequartz.
Matthew Kehrer wrote:
So what commands are needed to just update it?
I understand how to set it up from what you have said.
So, assuming you created a Git tree from Wine tarball as follows:
tar jxvf wine-0.9.23.tar.bz2 | sed s/^wine-0.9.23\\/// > list
cd wine-0.9.23
git init-db
git update-in
Matthew Kehrer wrote:
So what commands are needed to just update it?
I understand how to set it up from what you have said.
Well, the commands are easy enough, but they need to be done on a full
repository. I'll probably have a go at modifying gitweb.pl to return
the mailbox you need to upd
Sidney Fong wrote:
From 487243c1040f7ed17bd9241fc0f63f3f4774d76d Mon Sep 17 00:00:00 2001
From: FONG Sidney Hok Nang <[EMAIL PROTECTED]>
Date: Sun, 22 Oct 2006 15:36:38 +0800
Subject: Fix user/kernel times of GetProcessTimes()
Changes:
Fix the known bug[1] of GetProcessTimes() where it origina
Dmitry Timoshkov wrote:
This won't work as expected if hwnd is invalid and buffer contains
some '\0' terminated data. Probably a better aproach would be to call
GlobalGetAtomNameA with a buffer of size MAX_ATOM_LEN + 1 allocated
on the stack (MAX_ATOM_LEN is defined in dlls/kernel32/atom.c as 2
Matthew Kehrer wrote:
Is there a way I can convert a source tarball I download to a local GIT
repository?
Actually, I gave this some thought. It's possible, but complicated.
You can create your own git tree as follows:
tar jxvf wine-0.9.23.tar.bz2 | sed s/^wine-0.9.23\\/// > list
cd wine-
James Hawkins wrote:
static const WCHAR create_fmt[] = {'C','R','E','A','T','E','
','T','A','B','L','E',' ','`','%','s','`',' ','(',' ',0};
-size = sizeof(create_fmt) + lstrlenW(table) - 2;
+size = lstrlenW(create_fmt) + lstrlenW(table) - 1;
Since the string is const, and we
Matthew Kehrer wrote:
Is there a way I can convert a source tarball I download to a local GIT
repository?
Not really.
I have dial-up a home, but I know of a place where I can bring my flash
drive and use it to get the tarball as GIT does not have resume support.
Is this possible?
It a 20
Deun wrote:
Changelog by Denis Huguet ([EMAIL PROTECTED])
* 2006/10/17 :
Major diff between winemp3's layer3.c file and the one from
MPlayer-1.0pre7try2/mp3lib/layer3.c for fixing decoding
glitches found out when opening mp3 file with GoldWave 4.21
with wine-0.9.22 (same with 0.9.23)
Hi Deni
Thanks for sending the patch!
L. Rahyen wrote:
+UINT WINAPI GetRawInputDeviceList(PRAWINPUTDEVICELIST pRawInputDeviceList,
PUINT puiNumDevices, UINT cbSize)
+{
+pRawInputDeviceList = NULL;
That doesn't do what you think it does. You probably want:
memset( pRawInputDeviceList, 0, sizeo
Stephen Moehle wrote:
As suggested, I am also attaching the results my testing.
Good work!
The test should be integrated into the wine regression test suite, so
that they can be run automatically whenever code is checked into Wine.
Have a look at dlls/msvcrt/tests/printf.c for an example.
James Hawkins wrote:
+WCHAR user[MAX_PATH];
+
+size = MAX_PATH;
+type = REG_SZ;
+user[0] = '\0';
+res = RegQueryValueExW( hkey, szRegisteredUser, NULL, &type,
(LPBYTE)user, &size );
+MSI_SetPropertyW( package, szUSERNAME, user );
How about:
L
Yey! More msi fixes! :)
James Hawkins wrote:
+copy = MSI_CopyRecord( rec );
Why not just do a msiobj_addref( &ref->hdr ) rather than copying the
record?
+/* move SetProperty events to the front of the list */
+reprioritize_set_prop_events( &events );
How about just running
Vitaliy Margolen wrote:
dlls/winex11.drv/mouse.c | 43 +--
...
POINT cursor_pos;
+static CRITICAL_SECTION cursor_CritSection;
There's a reference to cursor_pos in dlls/winex11.drv/keyboard.c too,
and you're missing a critical section around it
James Hawkins wrote:
MS Platform SDK has atlbase.h as a public header in include/atl.
Shouldn't we follow suit? Right now atlbase.h is in dlls/atl.
Our atlbase.h is written in C, whereas Microsoft's is written in C++.
Given that the original atlbase.h includes alot of C++ code, and
reimple
Peter Lemenkov wrote:
The last wine version which at least compiles at my PowerPC fine is 0.9.17.
You could do a regression analysis with Git, described at the bottom of
the GitWine Wiki page, to find the patch that changed behaviour.
I have no clue how to debug this, so I would ask you:
Since we're trying to get "make test" working nicely on everybody's
machine, here's the failure of the day for me.
This is on Debian/unstable for AMD64, with libGL and libGLU provided by
ia32-libs 1.15.
Mike
make[2]: Entering directory `/home/mike/wine/dlls/d3d9/tests'
../../../tools/runt
Ge van Geldorp wrote:
Changelog:
Ge van Geldorp <[EMAIL PROTECTED]>
- Add 64-bit proxy/stub code for core COM interfaces
It's unlikely that this patch will be accepted. It's better to fix widl
to generate the 64bit code rather than add more midl generated code.
Mike
Stefan Dösinger wrote:
@@ -851,6 +853,13 @@ DllMain(HINSTANCE hInstDLL,
+/* Initialize the ddraw object list critical section unconditionally
+ * Even if the app doesn't use multithreaded ddraw objects it can still
+ * use multiple ddraw objects in multiple threads
+
James Hawkins wrote:
Is there anything wrong with this patch? It fixes bug 6379. msdn is
not specific about which order the events in the ControlEvent table
are executed, greatest to least or vice versa.
It might be better to store the results in a list instead of using
recursion. Though
Tim Schmidt wrote:
It sounds like a general framework for routing these kind of raw disk
i/o would be useful... probably configurable by app would be most
useful.
UML has a COW (copy-on-write) layer [1]. If we had something like this,
conceivable we could allow Wine to read raw disks (or t
Dan Kegel wrote:
Presumably more semi-intelligent futzing with the stubs will
get us by for a lot of apps, but I wonder: how soon are we
going to have to really implement side-by-side assemblies?
A good first step would be to write a simple test case that shows what
they do...
Mike
James Hawkins wrote:
@@ -1456,6 +1456,9 @@ static void msi_dialog_update_pathedit(
prop = msi_dialog_dup_property( dialog, control->property, indirect );
path = msi_dup_property( dialog->package, prop );
+if (!path)
+path = prop;
+
SetWindowTextW( control->hwnd, pa
Alex Villacís Lasso wrote:
Dreamweaver still can't find the DLL without my patch, even with the
"start" command, as demonstrated in the previous trace. Did you mean
that my patch *should* have placed the check in ShellExecute? Does
cmd.exe from Windows XP use CreateProcess or ShellExecute?
Alex Villacís Lasso wrote:
Changelog:
* Check under HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\App
Paths\\EXENAME.EXE for
additional directory locations to search for DLLs. Fixes Dreamweaver MX
6.0.
This change is incorrect. The App Pathes key is checked by
ShellExecute, not by
Marcus Meissner wrote:
We need to include string.h and also wine/port.h
to get strcasecmp on platforms where it is missing.
In Win32 code, shouldn't we be using lstrcmpi instead?
Mike
Sam Dennis wrote:
+if PKG_CHECK_MINVER(fontforge, 20060406); then
configure should check for features, not versions. This avoids problems
with patched older versions or newer versions with features removed.
To check for fontforge correctly, we need to check that it will generate
a ttf fil
Robert Lunnon wrote:
"Community Focused Process" means what it says, develop a process which is
centred on the community the project serves. This requires the project to
answer some introspective questions
1. Who "owns" Wine, does wine belong to A.) Alexandre, or B) the community
it serve
Ge van Geldorp wrote:
My objective is to improve Wine by maximizing the number of patches of
acceptable quality. In my opinion, this can be done by:
1) assuring no patches get lost
2) assuring an author gets informed about why his patch is not acceptable in
its current form so he can improve it
Detlef Riekenberg wrote:
When switching the Instructions for the Wine tree
from cvs to git, the Instructions for the
additional modules (docs, lostwages, ...) got lost.
They're still available at the old link:
http://www.winehq.org/site/cvs
It would be nice to move the remaining modules to G
Ge van Geldorp wrote:
It would make sure the author always receives some kind of feedback (either
from the bot, other developers or yourself) and would make sure patches
don't get lost (patches are automatically entered into the system and only
leave the system when the author withdraws them or
Accepted patches will appear in the wine-cvs mailing list.
Patches with obvious problems may receive a response on wine-devel.
Some patches may not receive any response. In this case, your patch
maybe considered 'Not Obviously Correct', and you can:
* check the patch over yourself, and thin
Since you know better, how about maintaining your own Wine tree and
showing us how it's done?
Self evidently thats what I have to do until some core functionality patches
find their way into WineHQ wine. It's not particularly hard, but it is time
consuming to manage merge conflicts.
It's v
The current process is crippling this project, limiting the developer base
and reducing community value. Without some healthy dissent it will never
change and get better. I am a friend of change, a true believer in the
process of continuous improvement. I believe one day, the WIne project w
Paul Vriens wrote:
The single-quotes should be needed as the SQL statement in the trace showed:
trace:msi:MSI_DatabaseOpenViewW L"SELECT `Message` FROM `Error` WHERE
`Error` = The installlation of QuickTime did not complete successfully.
iTunes requires QuickTime." 0x6669a498
Might be worth c
Robert Lunnon wrote:
Which you are entitled to, but my opinion happens to differ. Whether the wine
core source has all the patches, (Which it doesn't - many, but not all) isn't
relevant, it's the process that they go through that I believe could improve.
The way to get your changes in is no
Jeff L wrote:
How do you get a patch back that you have managed to remove completely
from your system with a
git reset HEAD^
git reset
git checkout patchname ?
git fetch does not seem to refresh the patch from the repository. I was
going fairly well with git then stuffed this up.
If the pa
Matt Finnicum wrote:
What I do is to follow along with things on the shortlog:
http://source.winehq.org/git/?p=wine.git;a=shortlog
Lets say you want to move your current branch to my recent patch
"riched20: Rewrite of scrolling and some redrawing code." - you'd
click the link "commit" to the ri
Daniel Skorka wrote:
+ res = connect(s, ptr->ai_addr, (int)ptr->ai_addrlen);
+ if(res)
Why not use InternetConnect? If the connection needs to be made
through a http:// proxy, connect() may not work, but InternetConnect
should handle that case.
Mike
Saulius Krasuckas wrote:
Thank you. Now that I downloaded mmbranch, saw its changelog, I would
like to reclaim disk space used by it. I deleted it with git branch -D,
but only ~100 kB were gained. Do you know of any way to get all the
space back? There should be ~40 additional MB freed.
Paul Vriens wrote:
I've sent in a patch that got some remarks by Juan Lang. The patch is
already applied to mmbranch.
Most patches sent to wine-patches that have (valid) comments will not be
applied by AJ.
Should I now resend to make sure it gets applied when AJ is back AND
sent a patch to fi
Paul Vriens wrote:
make[2]: Entering directory `/wine/wine-git/dlls/opengl32'
gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT
-fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement
-Wwrite-strings -Wpointer-arith -g -O2 -o wgl.o wgl.c
wgl.c
Julien wrote:
I was very interested in comparing the implementation status of reactos
and wine. So I coded a little python script to list all the api that are
implemented in reactos AND are only stub in wine. Attached to this mail
is the list of identified functions.
One may note that most of
Remove unnecessary glBlendColor in TextureFactor renderstate
commit e8325a47f01690e9d142b2535c8de6645376537d
Author: Mike McCormack <[EMAIL PROTECTED]>
Date: Fri Sep 1 17:22:44 2006 +0900
msi: Add a short test for transforms.
commit 479d486fa3dca078930bfa5efb0f14ec36b45f43
Author: Mike
Albert Lee wrote:
+TRACE("%p, %p, %p\n", sds, sc, ss);
+
+SCRIPT_DIGITSUBSTITUTE psds;
+
This causes a warning:
gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__
-D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+
-Wdeclaration-after-statement -Wwrite-stri
Hi All,
As Alexandre has gone on holidays for a week, I've made available a
temporary Git tree containing most patches sent to wine-patches.
You can pull my branch into your existing Git checkout as follows:
git fetch http://mandoo.dyndns.org/wine.git master:mmbranch
git rebase mmbranch
If y
Paul Vriens wrote:
configure |3 -
configure.ac|1
dlls/Makefile.in|1
dlls/wintrust/tests/Makefile.in | 13 +++
dlls/wintrust/tests/register.c | 176 +++
programs/winetest/Makefile
James Liggett wrote:
+if (!list_head(&tray.icons))
+{
+INITCOMMONCONTROLSEX init_tooltip;
+
+init_tooltip.dwSize = sizeof(INITCOMMONCONTROLSEX);
+init_tooltip.dwICC = ICC_TAB_CLASSES;
+
+InitCommonControlsEx(&init_tooltip);
Shouldn't yo
Jeff Latimer wrote:
have. However after that I end up with this:
[EMAIL PROTECTED] wing]$ git rebase --continue
You must edit all merge conflicts and then
mark them as resolved using git update-index
I also have the options of git rebase --abort and git rebase --skip
which I am not sure of
James Hawkins wrote:
+UINT msi_dialog_directorylist_up( msi_dialog *dialog )
+{
+msi_control *control;
+BOOL indirect;
+LPWSTR prop, path, ptr;
+
+control = msi_dialog_find_control_by_class( dialog, WC_LISTVIEWW );
+indirect = control->attributes & msidbControlAttributesIndi
James Hawkins wrote:
+indirect = msi_dup_property( dialog->package, control->property );
+prop = indirect;
+}
+
+val = msi_dup_property( dialog->package, prop );
+lstrcpynW( path, val, MAX_PATH );
+
+PathStripPathW( path );
+PathRemoveBackslashW( path );
Ca
[EMAIL PROTECTED] wrote:
After doing some digging it appears the problem is the current DIB
engine or lack thereof (the DIBEngine page on the Wine wiki and the
bugzilla bug it links to are very useful). From what I can tell this
has been a known shortcoming in Wine for at least 4.5 - 5 years,
James Hawkins wrote:
@@ -65,6 +65,7 @@ struct msi_control_tag
float progress_current;
float progress_max;
WCHAR name[1];
+DWORD attributes;
You shouldn't add members after name[1], as the string in name[] will
overwrite them.
+sz = 0x20;
+buf = msi_alloc( sz*siz
Jeff Latimer wrote:
Mike I suppose that the problem is that wrapping your mind around git
and working out how to handle patches, especially as it takes time to
get them accepted, revert them and manage trees etc is difficult. I
don't know about other but I have had a number of perplexing and
Jeff Latimer wrote:
If CVS goes, is there another way to see what patches have been applied
to the tree? The git does not seem to do that for me and cvs.winehq.org
is a fairly easy lookup.
If you have a local git tree, "git whatchanged" will give you the
complete commit history.
There's
Robert Shearman wrote:
I think we should leave the reference to the CVS tree page (but still
add a link to the Git tree). Some people find it easier to work with CVS
than Git.
I think Alexandre would prefer to receive patch submissions in Git
format, as they are easier to apply and waste le
Augusto Arcoverde da Rocha wrote:
I'm tring store some marks as comments inside of system register, but
when I start some wine process and it finish the comments have
disappeared from the register file. Is this the expected behaviour?
Yes.
As the registry is both read and written, and there'
Andrew Talbot wrote:
MSI{Get|Set}FeatureState(), MSI{Get|Set}ComponentState() and
MSI{Get|Set}Property() have appropriate const string arguments in the SDK.
Which version of the Windows SDK is that?
-UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPSTR szFeature,
+UINT WINAPI MsiGetFea
James Hawkins wrote:
Is there anything wrong with this patch?
This fixes bug 5768.
http://bugs.winehq.org/show_bug.cgi?id=5768
Changelog:
* The input buffer length is the number of characters excluding the
NULL terminator, so fix an off by one error.
msi_strcpy_to_awstring is used by many f
Dan Kegel wrote:
No fair, Mike, you should have given the link to the PR:
http://gcc.gnu.org/PR19430
:) If you know a gcc person that has time, nagging them would be great.
Many similar errors will get caught, as long as you turn on the
optimizer with -O (otherwise the compiler can't detect
Mike Hearn wrote:
And there are a few small style nits, for instance there's usually
no reason to change "void *foo" to "void *foo = NULL", you want it
to remain uninitialized because that way the compiler will warn if
it's ever used before being set to something: superior to blindly
using a NU
David D. Hagood wrote:
I've been posting my findings on this very matter to wine-users - look
for "cannot run under Fedora 6 tset 1".
Alexandre has committed a patch that looks like it should fix the
problem to the git tree.
Mike
1 - 100 of 703 matches
Mail list logo
