Re: socks & wine, patching wininet to use winsock

2010-12-17 Thread Mike Kaplinskiy
I was thinking about looking at wininet soon myself, but haven't had the time. I don't know what the right approach should be, but the least I can tell you is stop including all the linux headers: #ifdef HAVE_NETDB_H # include #endif #ifdef HAVE_NETINET_IN_H # include # include #endif #ifdef HA

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-18 Thread Mike Kaplinskiy
On Sun, Oct 17, 2010 at 5:51 PM, Erich Hoover wrote: > On Sat, Oct 16, 2010 at 1:41 PM, Mike Kaplinskiy > wrote: >> On Thu, Oct 14, 2010 at 10:08 PM, Erich Hoover wrote: >>> ... >>>     DWORD                               flags; >>>     unsig

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-16 Thread Mike Kaplinskiy
On Thu, Oct 14, 2010 at 10:08 PM, Erich Hoover wrote: > If you guys would mind looking over this revised patchset I would > greatly appreciate it, I believe I've appropriately included your > corrections.  Please note that mswsock.h and ws2ipdef.h will be > submitted as separate patches.  Thanks i

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-13 Thread Mike Kaplinskiy
On Wed, Oct 13, 2010 at 10:30 AM, Erich Hoover wrote: > > Is it acceptable to just add a parameter for WS2_recvfrom() or should > this function get renamed?  This function currently mirrors > WSARecvFrom exactly. > Feel free to change the name if you want, I don't have any problems with it (althou

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-12 Thread Mike Kaplinskiy
On Tue, Oct 12, 2010 at 8:01 PM, Erich Hoover wrote: > Real Name: >     Erich Hoover > Description: >     While searching for something else I discovered a bug relevant to the > interface-bound UDP broadcast patches I've been working on.  Apparently, > IP_PKTINFO does work on Windows when used wit

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)

2010-10-05 Thread Mike Kaplinskiy
There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-04 Thread Mike Kaplinskiy
On Mon, Oct 4, 2010 at 2:18 PM, Rudolf Mayerhofer wrote: >>I don't know much about kernel32/ntdll, but I'm pretty sure that you >>could get this to work through ntdll. NtQuerySystemInformation with >>SystemProcessorInformation/SystemLogicalProcessorInformation (see >>http://undocumented.ntinternal

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-03 Thread Mike Kaplinskiy
On Sun, Oct 3, 2010 at 10:25 AM, Rudolf Mayerhofer wrote: >>A rewrite of my previously sent patches in order to avoid changing >>SYSTEM_CPU_INFORMATION. > >>This patch supersedes my previously sent patches: >>[PATCH1/3] include/winternl: Add Logical Processor Information to >>SYSTEM_CPU_INFORMATIO

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)

2010-09-22 Thread Mike Kaplinskiy
On Wed, Sep 22, 2010 at 6:13 PM, James Mckenzie wrote: > > > > -Original Message- >>From: Ricardo Filipe >>Sent: Sep 22, 2010 1:18 PM >>To: wine-devel@winehq.org >>Subject: Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3) >> >&g

Re: RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)

2010-09-19 Thread Mike Kaplinskiy
On Sun, Sep 19, 2010 at 1:33 PM, Erich Hoover wrote: > On Sat, Sep 18, 2010 at 9:59 PM, Mike Kaplinskiy > wrote: >> There's enough #ifdef's to make this mostly unreadable. > Sorry about this, I was concerned that pushing these out so that > changes do not appear d

Re: RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)

2010-09-18 Thread Mike Kaplinskiy
Ah sorry, forgot to mention one more thing - fd's are different on the server side and the client side and between processes. So you're locking different semaphores everywhere effectively not locking anything. Mike. On Sat, Sep 18, 2010 at 11:59 PM, Mike Kaplinskiy wrote: > A few b

Re: RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)

2010-09-18 Thread Mike Kaplinskiy
A few broad comments: - There's enough #ifdef's to make this mostly unreadable. It's hard to think of the cases of no IP_PKTINFO availability, only compile time availability or full availability. Please just write a few wrapper functions for the #ifdef's that return sensible values if IP_PKTINFO i

Re: [2/2] ws2_32: Fail when select is called with an invalid fd.

2010-09-13 Thread Mike Kaplinskiy
On Sun, Sep 12, 2010 at 5:23 PM, Vincent Povirk wrote: > > > > > > > @@ -3193,6 +3193,10 @@ int WINAPI WS_select(int nfds, WS_fd_set *ws_readfds, > return SOCKET_ERROR; > } > > +for (i=0; i +if (pollfds[i].fd == -1) > +return SOCKET_ERROR; You're leaking poll

Re: ptrace, pokerstars and Ubuntu 10.10

2010-09-12 Thread Mike Kaplinskiy
On Sun, Sep 12, 2010 at 10:24 PM, Scott Ritchie wrote: > On 09/12/2010 05:57 PM, Mike Kaplinskiy wrote: >> CAP_NET_RAW should enable ping to work just fine I think. setuid seems >> a little too dangerous on the current wineserver, we don't do many >> checks and a few

Re: ptrace, pokerstars and Ubuntu 10.10

2010-09-12 Thread Mike Kaplinskiy
CAP_NET_RAW should enable ping to work just fine I think. setuid seems a little too dangerous on the current wineserver, we don't do many checks and a few bugs on our side will turn the os into windows, and not in a good way. Better stick to cap's for now while we don't need all the uid 0 features.

Re: [PATCH 1/5] server: move is_removeable to fd_ops

2010-08-23 Thread Mike Kaplinskiy
On Wed, Aug 4, 2010 at 1:29 AM, Mike Kaplinskiy wrote: > --- >  server/change.c     |    2 ++ >  server/device.c     |    1 + >  server/fd.c         |   18 -- >  server/file.c       |    1 + >  server/file.h       |    3 +++ >  server/mailslot.c   |    3 ++

Re: [2/2] ws2_32, WS2_sendto: Avoid error when sending zero byte buffer (try 2)

2010-08-14 Thread Mike Kaplinskiy
Several things: - Don't set errno. For good practice it's more or less read-only. - All the tests have to pass after each patch, so if your tests fail (which they probably should) without your patch, add todo_wine and then remove them in the followup patch (or just send the tests second). - The

Re: [PATCH 2/5] ws2_32/tests: test ConnectEx

2010-08-02 Thread Mike Kaplinskiy
On Mon, Aug 2, 2010 at 11:50 PM, Mike Kaplinskiy wrote: > --- >  dlls/ws2_32/tests/sock.c |  227 > ++ >  1 files changed, 227 insertions(+), 0 deletions(-) > Shoot, any chance you can just take #1 and take 2-5 from the first batch? Tha

Re: ws2_32, WS2_send: Avoid error if total bytes sent is 0

2010-07-26 Thread Mike Kaplinskiy
On Mon, Jul 26, 2010 at 3:05 PM, Wolfgang Schwotzer wrote: > This fixes bug #19397 > > > > I don't think that's the right place for the fix. You should probably put it in WS2_sendto. Also could you add some tests to verify that this is the behavior for all protocols, not just IrDA? Mike.

Re: [Resend] Add '_ONCE' variants of DPRINTF, FIXME, WARN.

2010-07-17 Thread Mike Kaplinskiy
On Sat, Jul 17, 2010 at 1:29 AM, Max TenEyck Woodbury wrote: > +#define WINE_FIXME_ONCE(args...) do { } while(0) > +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE I think you want WINE_FIXME_ONCE_ not WINE_FIXME_ONCE_ONCE_. > +#define WINE_FIXME_ONCE(args...) do { } while(0) > +#define WINE_FI

Re: ws2_32: socket.c: wrapped WSASendTo/WSARecvFrom with a different function name

2010-07-17 Thread Mike Kaplinskiy
On Sat, Jul 17, 2010 at 7:02 AM, Pigeon wrote: > > WSASendTo/WSARecvFrom, wrapped in a different function name, so that > internal calls from ws2_32 itself will not trigger programs like Garena, > which catches WSASendTo/WSARecvFrom calls. > > Reference: Wine Bug Id #16047 > > --- >  dlls/ws2_32/s

Re: git rebase to _insert_ commits?

2010-07-09 Thread Mike Kaplinskiy
You can move commits around in an interactive rebase. Just create an empty commit, move it into place with rebase and edit it. Sorry for top post, mobile gmail doesn't let you bottom post. On Jul 9, 2010 8:56 PM, "Misha Koshelev" wrote: Dear All: I am still learning git and it seems that my so

Re: Update - no wine repo on github

2010-07-06 Thread Mike Kaplinskiy
nks again >> >> Misha >> >> On Jul 6, 2010 12:18 PM, "Mike Kaplinskiy" >> wrote: >> >> On Tue, Jul 6, 2010 at 11:27 AM, Misha Koshelev wrote: >>> Fyi I am just going to... >> >> It shouldn't be too hard. Something lik

Re: Update - no wine repo on github

2010-07-06 Thread Mike Kaplinskiy
On Tue, Jul 6, 2010 at 11:27 AM, Misha Koshelev wrote: > Fyi I am just going to keep my latest patches here: > http://www.mkosh.com/wine-d3dx9.zip > > I have struggled for an hour trying to remove a remote commit on github, > and that's an hour I'd rather spend implementing D3DX functions. > > Any

Re: The __WINE__ macro does not identify the Wine platform

2010-06-17 Thread Mike Kaplinskiy
On Thu, Jun 17, 2010 at 4:56 PM, Alan W. Irwin wrote: > According to some old discussion > (http://www.mail-archive.com/wine-de...@winehq.com/msg15669.html) on > wine-devel it appears that __WINE__ was going to be the macro used to > identify the Wine platform, > > However, that doesn't appear to

Re: Speed/latency issues for development in a Wine environment

2010-06-17 Thread Mike Kaplinskiy
On Thu, Jun 17, 2010 at 4:35 PM, Alan W. Irwin wrote: > To introduce myself to this list, I am a complete Wine newbie with no > Windows experience at all, but I do have years of experience developing > software on Linux, and in the interests of testing that software on a free > Windows platform, I

Re: [PATCH 5/5] server: get rid of sock_try_event

2010-05-13 Thread Mike Kaplinskiy
On Thu, May 13, 2010 at 6:28 AM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> We *might* need to ignore POLLERR messages for UDP sockets, as the >> condition is actually temporary and sock_try_event was hiding this. > > It doesn't work here: > > .

Re: ws2_32: negate return value of SIOCATMARK (try 2)

2010-04-29 Thread Mike Kaplinskiy
2010/4/28 André Hentschel : > confirmed by Mike Kaplinskiy > > try 1 was on 4th November 2009 > > --- >  dlls/ws2_32/socket.c     |   16 ++-- >  dlls/ws2_32/tests/sock.c |    2 +- >  2 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/dlls

Re: Crash when executing custom action in msi

2010-04-18 Thread Mike Kaplinskiy
On Sun, Apr 18, 2010 at 3:58 PM, Octavian Voicu wrote: > Hello, > > I'm trying to get the Adobe Photoshop Elements 8.0 installer to work > and noticed the license screen doesn't show up when running the > installer using wine. A trace shows that a custom action > (CA_EULA_ExtractEulaFiles) generat

Re: [PATCH 4/8] server: send the proper status code in case of socket error

2010-04-18 Thread Mike Kaplinskiy
On Sun, Apr 18, 2010 at 4:00 AM, Greg Geldorp wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http:

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-09 Thread Mike Kaplinskiy
On Thu, Apr 8, 2010 at 8:29 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> This won't work for implementing half-closed sockets. If we have only >> the read half is closed, we will get POLLIN/0 recv indefinitely if we >> keep polling (not POLLHUP). If w

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-08 Thread Mike Kaplinskiy
On Thu, Apr 8, 2010 at 11:16 AM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> But I see your point that perhaps it doesn't belong in the main loop >> when one of the halves gets closed. I guess we can keep sock_try_event >> around but only use it when the

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-07 Thread Mike Kaplinskiy
On Tue, Apr 6, 2010 at 2:03 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Would allowing adding the fd to the poll loop after it has been >> removed be more sane? Otherwise we have to resort to ugly things like >> sock_try_event (which only half work). >

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-06 Thread Mike Kaplinskiy
On Tue, Apr 6, 2010 at 1:08 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Remove the fd from the poll list so we don't get POLLHUP/POLLERR >> messages when we ask for no events > > This is wrong, even when selecting for no events you want to rece

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 3:52 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Hope this makes the rationale a bit clearer. Although admittedly the >> patch does allow for some busy waiting since >> if (mask & FD_READ  || async_waiting( sock->r

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 12:17 PM, Paul Vriens wrote: > On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: >> >> --- >>  dlls/ws2_32/tests/Makefile.in |    2 +- >>  dlls/ws2_32/tests/sock.c      |  735 >> + >>  2 files c

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 2:50 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> POLLIN/POLLOUT are selected if we have pending asyncs (as they should >> be), but we shouldn't add these as pending events since the associated >> overlapped operations aren

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 2:28 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> --- >>  server/async.c |    8 >>  server/file.h  |    1 + >>  server/sock.c  |   26 +++--- >>  3 files changed, 20 insertions(+), 15 dele

Re: [PATCH 2/2] ws2_32/tests: test a WSARecv error condition

2010-03-23 Thread Mike Kaplinskiy
On Tue, Mar 23, 2010 at 3:56 PM, Paul Vriens wrote: > On 03/22/2010 07:56 PM, Mike Kaplinskiy wrote: >> >> + >> +    bret = GetOverlappedResult((HANDLE)dest,&ov,&bytesReturned, FALSE); >> +    todo_wine ok(!bret&&  GetLastError() == ERROR_NETNAME_DE

Re: [PATCH 1/2] ws2_32: use ntstatus in overlapped functions (try 3)

2010-01-24 Thread Mike Kaplinskiy
On Fri, Jan 22, 2010 at 6:46 PM, Mike Kaplinskiy wrote: > Also some style fixes. Sorry for the fuss over this :) > --- >  dlls/ws2_32/socket.c |   45 ++--- >  1 files changed, 34 insertions(+), 11 deletions(-) > Don't even look at thi

errno-ntstatus conversion

2010-01-23 Thread Mike Kaplinskiy
There are many places where we need to do a conversion between the unix errno and the windows ntstatus (and then sometimes to dos errors). Here are some that I found: http://source.winehq.org/source/server/file.c#L582 http://source.winehq.org/source/server/sock.c#L702 http://source.winehq.org/sour

Re: Usage of libxml2 for several modules

2010-01-16 Thread Mike Kaplinskiy
While we're on the subject of libxml2, there is a small problem with the way we use xmlAddChild. msxml doesn't automatically coalesce text nodes when two are next to each other in the tree and keeps them as two separate entities (you call normalize to coalesce them). libxml2 does this automatically

Re: Anti aliased fonts in wine - minimum font size

2009-12-03 Thread Mike Kaplinskiy
I think some time ago this was explained as a NOTABUG in freetype, which actually obeys the font's preferences and if the font supplies special images for smaller font sizes, it uses them WITHOUT aliasing them, which seems logical. Windows seems to lazily alias everything. If you can find a way to

Re: Try to find out why "Unity3d (3D application)" doesn't work with Wine.

2009-10-06 Thread Mike Kaplinskiy
On Tue, Oct 6, 2009 at 12:10 PM, Roderick Colenbrander wrote: > Esstentially what happens is that using the SendMessage in > internal_SetPixelFormat we call 'set_win_format' in window.c. I can't > say why it fails perhaps no parent window is up yet.. > > Roderick > > > On Tue, Oct 6, 2009 at 6:02

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

2009-09-30 Thread Mike Kaplinskiy
On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens wrote: > On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: >> >> --- >>  dlls/ws2_32/tests/sock.c |   46 >> +- >>  1 files chang

Re: cppcheck sept 18 redux

2009-09-22 Thread Mike Kaplinskiy
On Tue, Sep 22, 2009 at 10:48 AM, Luke Benstead wrote: > 2009/9/22 Ben Klein : >> 2009/9/23 Luke Benstead : >>> If it IS the case that this doesn't cause a crash and is perfectly >>> valid, can someone explain to me how/why this works? Or point me (no >>> pun intended) to the bit in the C spec tha

Re: cppcheck sept 18 redux

2009-09-22 Thread Mike Kaplinskiy
On Tue, Sep 22, 2009 at 3:06 AM, Ben Klein wrote: > 2009/9/22 Mike Kaplinskiy : >> On Tue, Sep 22, 2009 at 1:09 AM, Vitaliy Margolen >> wrote: >>>> [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible >>>> null pointer dereference: dmW

Re: cppcheck sept 18 redux

2009-09-21 Thread Mike Kaplinskiy
On Tue, Sep 22, 2009 at 1:09 AM, Vitaliy Margolen wrote: > Ben Klein wrote: >> The question remains, how exactly does >> FIELD_OFFSET work, and does it end up dereferencing ca[5]? > It does pointer arithmetic and does not dereference anything. "ca[5]" is the > same as "(ca + 5)" or on lower level

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 7:08 PM, Henri Verbeet wrote: > 2009/9/13 Ben Klein : >> 2009/9/13 Nicolas Le Cam : >>> Last one is also a false positive, it's just two pointers being >>> subtracted to retrieve an offset. >> >> That's not the reason why it's a false positive. Without context that >> line

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 11:24 AM, Mike Kaplinskiy wrote: > On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam wrote: >> 2009/9/12 chris ahrendt : >>> >>> Here is the run for Friday Sept. 11 with the tools and the tests >>> directory results removed. >>>

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam wrote: > 2009/9/12 chris ahrendt : >> >> Here is the run for Friday Sept. 11 with the tools and the tests >> directory results removed. >> >> >> [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd >> [/home/cahrendt/wine-git

Re: fixing ReadDirectoryChangesW()

2009-09-11 Thread Mike Kaplinskiy
On Fri, Sep 11, 2009 at 5:42 PM, Dan Kegel wrote: > Michael Pujos wrote: >> I'm willing to resubmit this patch with updated tests >> against current Wine, but before I procceed >> I need to be sure it won't be rejected simply because it changes the >> protocol. > > Server changes are tricky to ge

Re: Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER

2009-09-08 Thread Mike Kaplinskiy
On Tue, Sep 8, 2009 at 12:03 PM, Nicholas LaRoche wrote: > > I had a few issues applying your patches to the latest git revision, but  I > did find equivalent functionality in wine-hacks. This solved my problem > however the code in this tree doesn't support AcceptEx with TCP. > > http://repo.or.cz

Re: Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER

2009-09-07 Thread Mike Kaplinskiy
On Mon, Sep 7, 2009 at 11:08 AM, Nicholas LaRoche wrote: > Mike Kaplinskiy wrote: >> >> On Mon, Sep 7, 2009 at 2:45 AM, Nicholas LaRoche wrote: >>> >>> I ran into a bug last week regarding the lack of >>> SIO_GET_EXTENSION_FUNCTION_POINTER support in W

Re: Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER

2009-09-07 Thread Mike Kaplinskiy
On Mon, Sep 7, 2009 at 2:45 AM, Nicholas LaRoche wrote: > I ran into a bug last week regarding the lack of > SIO_GET_EXTENSION_FUNCTION_POINTER support in WSAIoctl. > > Are there any outstanding issues preventing it's implementation? > > Perhaps if anyone has worked in this area, are there any thin

Re: Asynchronus serial port

2009-09-02 Thread Mike Kaplinskiy
On Wed, Sep 2, 2009 at 7:31 PM, Fenixk19 wrote: > Hello! I've already post the > bug(http://bugs.winehq.org/show_bug.cgi?id=19713) on this subject, but i > need more help. So I've decided to write here. > There is a problem in wine. When I use asynchronous serial port read, > data never comes. Even

Re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation

2009-08-29 Thread Mike Kaplinskiy
On Sat, Aug 29, 2009 at 1:51 AM, shanmukha sainath addepalli wrote: > > Hi, > >    These are the series of patches for SwitchDesktop and > OpenInputDesktop API implementation in user32.dll > >    SwitchDesktop API when called switches to another desktop and makes > it active. > >    Fir

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Mike Kaplinskiy
On Fri, Aug 28, 2009 at 5:22 PM, Marcus Meissner wrote: > On Fri, Aug 28, 2009 at 02:16:40PM -0700, chris ahrendt wrote: >> Ok CPPCheck guys have repired the false positive but now get this: >> >> $ ./cppcheck -q -a ../wine/wine/dlls/wineoss.drv/mixer.c >> ../wine/wine/dlls/wineoss.drv/mixer.c:576:

Re: [PATCH 6/7] ws2_32: implement AcceptEx

2009-08-28 Thread Mike Kaplinskiy
On Fri, Aug 28, 2009 at 2:01 PM, Juan Lang wrote: > Hi Mike, I have one minor nit on this patch: > > +    if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read ); > Please don't check if (wsa->read) is NULL before calling HeapFree. > HeapFree already does the correct thing given NULL, and we had

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-27 Thread Mike Kaplinskiy
On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt wrote: > This is the result of running cppcheck 1.35 with the --all parm against > the august 27th Git tree: > > [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of > bounds > [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) A

Re: CPPCheck Run for Friday August 21

2009-08-21 Thread Mike Kaplinskiy
On Fri, Aug 21, 2009 at 9:21 PM, chris ahrendt wrote: > [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 > [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a > deallocated pointer: stream2 > [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak:

[PATCH 3/4] kernel32: implement CancelIoEx (try 2)

2009-08-13 Thread Mike Kaplinskiy
From 60e82c0890e7f435afcd200752226ed1fa4ee669 Mon Sep 17 00:00:00 2001 From: Mike Kaplinskiy Date: Sun, 9 Aug 2009 00:12:52 -0400 Subject: kernel32: implement CancelIoEx --- dlls/kernel32/file.c| 26 ++ dlls/kernel32/kernel32.spec |1 + include/winbase.h

Re: cppcheck run against 1.27

2009-08-08 Thread Mike Kaplinskiy
On Sat, Aug 8, 2009 at 4:56 AM, Marcus Meissner wrote: > On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: >> >> [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd > > I do not fully understand the code (keep fd open to have to lock > existing?), but it is in a fatal exit

Request for vista testing

2009-08-06 Thread Mike Kaplinskiy
Can someone test this on vista? It tests NtCancelIoFileEx. The goal is to find out the order of arguments. Thanks, Mike. diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 164c2da..174daa5 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -54,6 +54,7 @@ static

Re: ODBC Databases: Jet/Access success

2009-07-23 Thread Mike Kaplinskiy
On Thu, Jul 23, 2009 at 10:32 PM, Juan Lang wrote: > Hey Barry, > > this was a handy writeup.  Perhaps you could add it to the wiki? > Here's a page that you might add it to: > http://wiki.winehq.org/NativeOdbc > > The user guide should probably point to the wiki, but that's a > different topic.  T

Re: blocking/non-blocking socket question.

2009-07-23 Thread Mike Kaplinskiy
On Thu, Jul 23, 2009 at 10:28 PM, Juan Lang wrote: >> I think what Rein means is that the unix socket fd backing the windows >> socket handle is always non-blocking - and if he is, he may be >> correct: >> >> http://source.winehq.org/source/server/sock.c#L578 && >> http://source.winehq.org/source/s

Re: blocking/non-blocking socket question.

2009-07-23 Thread Mike Kaplinskiy
On Thu, Jul 23, 2009 at 1:50 PM, Juan Lang wrote: >> It is calling recv() on a socket that was previously: >> 1) set to blocking with a WS_ioctlsock() call with cmd WS_FIONBIO >> 2) AsyncSelect()'ed that should make the socket non-blocking. > (snip) >> while the second does not touch the unix fd. T

Re: ws2/tests: Test AcceptEx with a deferred socket

2009-07-20 Thread Mike Kaplinskiy
Paul, I don't like NT4 anymore. We're breaking up. Does the attached patch fix the latest failures (not counting the build warnings)? Mike. On Mon, Jul 20, 2009 at 7:05 AM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> Paul (and anyone who can test on x86_64): &

Re: msi: Fix some pointer conversion warnings on 64-bit(try2)

2009-07-19 Thread Mike Kaplinskiy
André Hentschel wrote: > didnt want to change both variables, now its fine > sry for the noise > --- > dlls/msi/join.c |5 +++-- > dlls/msi/msiquery.c |4 ++-- > dlls/msi/storages.c |2 +- > dlls/msi/streams.c |2 +- > 4 files changed, 7 insertions(+), 6 deletions(-) > >

Re: ws2/tests: Test AcceptEx with a deferred socket

2009-07-17 Thread Mike Kaplinskiy
Paul (and anyone who can test on x86_64): Can you confirm that the new patch gives no failures? Mike. On Fri, Jul 17, 2009 at 2:02 AM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> Paul, >> >> Does the attached fix test failures on at least NT4? The 4000 test &

Re: ws2/tests: Test AcceptEx with a deferred socket

2009-07-16 Thread Mike Kaplinskiy
eir kernel module is out. Mike. On Thu, Jul 16, 2009 at 3:40 AM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> This tests the following AcceptEx scenario: >>   WSAAccept->CF_DEFER->AcceptEx >> Windows seems to return the deferred socket with Acc

Re: Need help testing (acceptex)

2009-07-11 Thread Mike Kaplinskiy
000=40secs max) Mike. On Sat, Jul 11, 2009 at 5:47 PM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> Can someone try this test on win2000+? This tests the >> WSAAccept->Defer->AcceptEx scenario, and I've only verified th

Need help testing (acceptex)

2009-07-11 Thread Mike Kaplinskiy
Can someone try this test on win2000+? This tests the WSAAccept->Defer->AcceptEx scenario, and I've only verified the behavior on xp. Thanks, Mike diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index c90111d..f9856da 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/s

AcceptEx Patch Comments

2009-07-07 Thread Mike Kaplinskiy
I'm looking for some comments regarding my (winsock part by Scott) acceptex patch: http://bugs2.winehq.org/attachment.cgi?id=22193 . This is just preliminary and doesn't support receive (yet). The approach was done to fix the server-side issues AJ had with Scott's original patch, so server side co

Re: AcceptEx Proposal

2009-07-05 Thread Mike Kaplinskiy
On Sun, Jul 5, 2009 at 6:55 AM, Damjan Jovanovic wrote: > On Fri, Jul 3, 2009 at 5:49 AM, Mike > Kaplinskiy wrote: >> I have been thinking about the correct way to implement AcceptEx, and >> I was looking for comments about the approach. Note I know all of >> these cases

AcceptEx Proposal

2009-07-02 Thread Mike Kaplinskiy
I have been thinking about the correct way to implement AcceptEx, and I was looking for comments about the approach. Note I know all of these cases will require tests, I'm just listing them for problems someone might see. Wineserver changes: - add an async* to the socket structure to track this s

Re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer

2009-06-30 Thread Mike Kaplinskiy
On Tue, Jun 30, 2009 at 11:48 PM, Andrew Eikum wrote: > Attached to this email is a rough implementation of the main GDI+ > containers functions.  It performs correctly in a few simple tests I > ran on it, but it's not quite ready to send off to wine-patches.  I'd > like to get some feedback here,

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 8:33 PM, Ben Klein wrote: > 2009/6/15 Mike Kaplinskiy : >> On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger >> wrote: >>> *) If  we create a stub / thunk driver for each known windows display >>> driver, >>> we potentially have  

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger wrote: > *) If we create a stub / thunk driver for each known windows display driver, > we potentially have all those thunks around. E.g. an app might complain that > it finds BOTH nv4_disp.dll AND atiumdag.dll. > > *) Providing these vendor specif

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 5:20 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 3:13 PM, Mike > Kaplinskiy wrote: >> ... >> >> Then perhaps when this mechanism is in place, we can add a way to have >> 1 general "funnel" dll and symlink it on prefix creation

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 4:55 PM, Roderick Colenbrander wrote: > On Sun, Jun 14, 2009 at 10:52 PM, Roderick > Colenbrander wrote: >> On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: >>> On Sun, Jun 14, 2009 at 2:26 PM, Mike >>> Kaplinskiy wrote: >>>>

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
I don't know about stubbing drivers, but I remember that autodetection/registry wasn't accepted on the fallout 3 patch. I think AJ would prefer something like http://source.winehq.org/git/wine.git/?a=commit;h=f2e2e3e49947490368900ef06a92e1df1bc52820 but for driver dll strings. But take my comments

Re: DIB Engine : passing all tests

2009-05-28 Thread Mike Kaplinskiy
On Thu, May 28, 2009 at 6:58 PM, Jerome Leclanche wrote: > Hi Max, > > From what I understand, the problem is not your design. I don't want > to put words in anyone's mouth, but to me it seems you and AJ agree on > the final goal; Alexandre just doesn't want the "intermediary step" in > the master

Re: Bugzilla: I dont stay logged in

2009-05-25 Thread Mike Kaplinskiy
2009/5/25 André Hentschel : > Hi, > If i log in with both Checkboxes selected, i can do exactly one thing, and > then i am logged out again. > For example:    if i am on a bug and log in, i can write a comment and got > logged out. >                if i log in and select "add an attachment" i can f

Re: DXTn textures in D3DX9

2009-05-24 Thread Mike Kaplinskiy
I believe mesa looks for libtxc_dxtn @ http://homepage.hispeed.ch/~rscheidegger/dri_experimental/s3tc_index.html and then enables full s3tc support. The library itself is tiny and in (ugly) C, so that is already good news. But as stated on the website, you cannot use the code due to legality. Maybe

Re: can't find winedbg

2009-05-04 Thread Mike Kaplinskiy
On Mon, May 4, 2009 at 9:27 PM, Christopher Harvey wrote: > I just built wine out of git. > Ran this: > wine-git $ find . -name winedbg > ./programs/winedbg > > > notice there is no winedbg program. The output there is a folder only. > Where is the winedbg program within the git tree? > > > I'm p

Re: Severity levels

2009-05-03 Thread Mike Kaplinskiy
2009/5/3 James McKenzie : > Ken Sharp wrote: >> >> >> Nicklas Börjesson wrote: >> >>> I think that the users should have quite a say with regards to how >>> important a bug is, because for every user putting in the >>> (considerable for a user) effort of reporting a bug, there are dozens >>> that d

Re: Office 2007 MSI Crash - Null dereference @ MsiViewExecute

2009-05-03 Thread Mike Kaplinskiy
On Sun, May 3, 2009 at 10:36 PM, James Hawkins wrote: > On Sun, May 3, 2009 at 1:52 PM, Mike Kaplinskiy > wrote: >> On Thu, Apr 30, 2009 at 1:08 PM, James Hawkins wrote: >>> On Thu, Apr 30, 2009 at 4:03 AM, Austin English >>> wrote: >>>> On Tue

Re: Office 2007 MSI Crash - Null dereference @ MsiViewExecute

2009-05-03 Thread Mike Kaplinskiy
On Thu, Apr 30, 2009 at 1:08 PM, James Hawkins wrote: > On Thu, Apr 30, 2009 at 4:03 AM, Austin English > wrote: >> On Tue, Apr 28, 2009 at 9:27 PM, Mike Kaplinskiy >> wrote: >>> I was looking at the trace of the crash from bug 17600, and it looks like >

Re: Office 2007 MSI Crash - Null dereference @ MsiViewExecute

2009-04-30 Thread Mike Kaplinskiy
James Hawkins wrote: > On Thu, Apr 30, 2009 at 4:03 AM, Austin English > wrote: >> On Tue, Apr 28, 2009 at 9:27 PM, Mike Kaplinskiy >> wrote: >>> I was looking at the trace of the crash from bug 17600, and it looks >>> like a custom action is calling MsiVie

Office 2007 MSI Crash - Null dereference @ MsiViewExecute

2009-04-30 Thread Mike Kaplinskiy
I was looking at the trace of the crash from bug 17600, and it looks like a custom action is calling MsiViewExecute with a null hRec. I (sadly) don't know much about the wine MSI architecture, but the msiobj_lock on line 484 should fail since rec will never be fetched (null). I think the intent