Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

2013-09-11 Thread Michael Stefaniuc
On 09/11/2013 02:11 PM, Henri Verbeet wrote: On 11 September 2013 12:09, Jacek Caban wrote: +typedef enum D3D11_RESOURCE_MISC_FLAG +{ +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, +D3D11_RESOURCE_MISC_SHARED = 0x0002, +D3D11_RESOUR

Re: Sequences in a loop

2013-08-30 Thread Michael Stefaniuc
On 08/30/2013 02:33 PM, matyapiro31 wrote: > I found many wine sources use not a pointer,but a sequence . > for example: > krnl386.exe16/dma.c: > for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];i msdaps/usrmarshal.c: for(prop = 0; prop < > rgPropertySets[prop_set].cProperties; prop++) > I know in

Re: ntdll: Store all 'comClass' attributes (try3)

2013-08-28 Thread Michael Stefaniuc
Hello Nikolay, On 08/27/2013 12:16 PM, Nikolay Sivov wrote: > +static OLEMISC get_olemisc_value(const WCHAR *str, int len) > +{ > +int min, max; > + > +min = 0; > +max = sizeof(olemisc_values)/sizeof(struct olemisc_entry) - 1; > + > +while (min <= max) > +{ > +int n, c;

Re: Wiki is down

2013-08-23 Thread Michael Stefaniuc
On 08/23/2013 03:39 PM, Rosanne DiMesio wrote: > I'm getting an "Unable to connect" message from Firefox and "Connection > closed by remote server" from Opera. CC'ing Dimi as he might not read wine-devel so often. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 09:33 PM, Tae Wong wrote: > You have to manually update it by adding all authors from the GIT log. > > The attachment is here at first message. That one you did is not correct either: - I see some Spanish "double" last names sorted by the 2nd one instead of the first. - In Dutch th

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 05:40 PM, Tae Wong wrote: > In the GIT tree, the AUTHORS file is sorted on first names. Wrong. It is sorted by the text line. The first word on the line can be the first or lastname, depending what the author used. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 04:42 PM, Tae Wong wrote: > Julliard said that it should feel free to provide a script that sorts > by last name. > > You want to do this. Careful. It is a trap. He is fine with it if it is done *right*. Figuring out what the last name is is a hard problem. bye michael

Re: [website] Update git URL

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: > --- > templates/en/cvs.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/en/cvs.template b/templates/en/cvs.template > index 202cf60..300b9e4 100644 > --- a/templates/en/cvs.template > +++ b/templates/

Re: Another major milestone

2013-07-19 Thread Michael Stefaniuc
On 07/19/2013 01:40 PM, Marcus Meissner wrote: > On Thu, Jul 18, 2013 at 04:55:42PM -0500, Jeremy White wrote: >> Alright folks, I have to confess that the 1.6 release came and I didn't >> immediately get up and dance. >> >> In fact, a new Wine release was almost...boring. >> >> I think we have to

Fwd: Re: RFC: Three dots or Unicode ellipsis character

2013-07-03 Thread Michael Stefaniuc
Original Message Subject: Re: RFC: Three dots or Unicode ellipsis character Date: Wed, 03 Jul 2013 19:32:15 +0200 From: Michael Stefaniuc To: Francois Gouget On 07/03/2013 04:45 PM, Francois Gouget wrote: > > Wine uses three dots (...) rather than the Unicode el

Re: winex11.drv: When skipping unknown attribute also skip it's value.

2013-06-30 Thread Michael Stefaniuc
On 06/30/2013 11:29 PM, Ričardas Barkauskas wrote: > --- > dlls/winex11.drv/opengl.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > 0001-winex11.drv-When-skipping-unknown-attribute-also-skip-.txt > > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > in

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Michael Stefaniuc
On 06/26/2013 10:06 PM, Thomas Faber wrote: > On 2013-06-26 21:47, André Hentschel wrote: >> The whitespace changes are bad, please don't do that. > > Ok, I can take them out no problem. > Why's it bad though? I thought the rule was "fix it while you're > working on it anyway". Sure, fix the lines

Re: testbot and NT4

2013-06-03 Thread Michael Stefaniuc
On 06/03/2013 10:36 PM, André Hentschel wrote: > On 03.06.2013 22:22, Alexandre Julliard wrote: >> André Hentschel writes: >> >>> I haven't heard about NT4 been taking out of the requirement. I guess >>> the NT4 machines are offline due to the transition to the new testbot >>> (newtestbot.winehq.o

Re: wineconsole screen scenarios

2013-05-16 Thread Michael Stefaniuc
On 05/16/2013 03:34 PM, Hugh McMaster wrote: > On Thursday, 16 May 2013 > Rosanne DiMesio wrote: > >> On Thu, 16 May 2013 08:04:07 -0400 >> Hugh McMaster wrote: >>> >>> My concern is with scenario (3). Wine is designed to be used with an X >>> server, but wineconsole can be used in non-X-based e

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-26 Thread Michael Stefaniuc
On 04/26/2013 05:54 AM, Sam Edwards wrote: On 04/25/2013 12:28 PM, Alexandre Julliard wrote: It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so ../../../../wine/dlls/comctl32/tests/listview.c && touch listview.ok wine: Unhandled

Re: Clang static analyzer results / wine-1.5.28-66-g6899279

2013-04-19 Thread Michael Stefaniuc
On 04/19/2013 12:43 AM, Austin English wrote: With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179768 91177308-0d34-0410-b5e6-96231b3b80d8 clang version: git-svn-id:

wiki.winehq.org is down

2013-03-07 Thread Michael Stefaniuc
Hey Dimi, the wiki is down: is the wiki down? it pings but with high latency and while port 80 connects a GET / doesn't returns thanks bye michael

Re: ntdll: make NtDelayExecution a bit more efficient

2013-03-06 Thread Michael Stefaniuc
On 03/06/2013 07:10 PM, Graham wrote: > Alexandre wrote: >> That's what the existing code already does. > > Indeed. I don't know what I was thinking... > >>> 2. If you're about to block on select(), then I don't see any point in >>> preceding that with a call to sched_yield(). >> >> This was adde

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 2)

2013-03-01 Thread Michael Stefaniuc
Hello Joerg, On 03/01/2013 10:22 AM, joerg-cyril.hoe...@t-systems.com wrote: > The idea to replace X * numerator / denominator > by X / den * mul + remainder from euclidian division > came from > http://blog.airsource.co.uk/index.php/2010/03/15/quelle-heure-est-il/ > > M. Stefaniuc suggested an i

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use.

2013-02-27 Thread Michael Stefaniuc
Hello Joerg, On 02/27/2013 02:46 PM, joerg-cyril.hoe...@t-systems.com wrote: The idea to replace X * numerator / denominator by X / den * mul + remainder from euclidian division came from can you please use an inline function for that? http://blog.airsource.co.uk/index.php/2010/03/15/quelle-h

Re: iphlpapi: Let C look like C.

2013-02-07 Thread Michael Stefaniuc
Thanks Juan, On 02/07/2013 12:54 AM, Juan Lang wrote: > Hi Michael, this isn't actually a problem with your patch, just > something I spotted: > > On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc <mailto:mstef...@redhat.com>> wrote: > > On 02/06/201

Re: iphlpapi: Let C look like C.

2013-02-06 Thread Michael Stefaniuc
On 02/06/2013 11:16 PM, Austin English wrote: > On Feb 6, 2013 11:13 PM, "Michael Stefaniuc" <mailto:mstef...@redhat.de>> wrote: >> >> --- >> dlls/iphlpapi/ipstats.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >

Re: ws2_32: Use assignment instead of memcpy to copy structs.

2013-01-24 Thread Michael Stefaniuc
Forgot to add the credit for this patch series as I didn't wrote this coccinelle script: Found using the memcpy-assign.cocci script submitted for inclusion into the Linux kernel: https://systeme.lip6.fr/pipermail/cocci/2013-January/000121.html bye michael On 01/24/2013 02:21 PM, Mi

Re: [PATCH 1/3] include: Define FIELD_OFFSET to the standard offsetof macro

2012-12-11 Thread Michael Stefaniuc
On 12/11/2012 10:20 AM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >> On 12/10/2012 07:37 PM, Amine Khaldi wrote: >>> This prevents the undefined behavior (null pointer dereference) >>> diagnostics (clang with ubsan checks for example). >> This

Re: [PATCH 1/3] include: Define FIELD_OFFSET to the standard offsetof macro

2012-12-10 Thread Michael Stefaniuc
On 12/10/2012 07:37 PM, Amine Khaldi wrote: > This prevents the undefined behavior (null pointer dereference) > diagnostics (clang with ubsan checks for example). This is a bug in clang. There is no null pointer dereference. Afair gcc tried to pull this trick too but got educated about their error.

Re: [PATCH] amstream: Initialize correctly AM_MEDIA_TYPE struct.

2012-11-15 Thread Michael Stefaniuc
Hello Christian, On 11/15/2012 09:43 AM, Christian Costa wrote: > Fixes bug 32185. > --- > dlls/amstream/mediastreamfilter.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/amstream/mediastreamfilter.c > b/dlls/amstream/mediastreamfilter.c > index 9b2bd8e..d5388e5 100644 > --

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-11 Thread Michael Stefaniuc
On 11/11/2012 07:12 AM, Max TenEyck Woodbury wrote: > On 11/11/2012 01:01 AM, Nikolay Sivov wrote: >> On 11/11/2012 05:00, Max TenEyck Woodbury wrote: >>> I mentioned this a few days ago. It would have helped if you had >>> raised this point then. >>> >>> As it stands, it is simply a way to adding

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-11 Thread Michael Stefaniuc
On 11/11/2012 03:00 AM, Max TenEyck Woodbury wrote: > I mentioned this a few days ago. It would have helped if you had > raised this point then. I tried, but your email made no sense. You didn't even mention that you're talking about COM interfaces. > As it stands, it is simply a way to adding da

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-10 Thread Michael Stefaniuc
You can't do that as the COM standard specifies also the ABI. A COM interface is a pointer to a virtual table; it is *not* a struct. That's just an implementation detail in C. On 11/10/2012 08:48 PM, m...@mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury > > --- > tools/widl/header.c | 14

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-08 Thread Michael Stefaniuc
On 11/08/2012 03:44 PM, Christian Costa wrote: > > > 2012/11/8 Michael Stefaniuc <mailto:mstef...@redhat.com>> > > On 11/08/2012 01:13 PM, Christian Costa wrote: > > > > > > 2012/11/8 Henri Verbeet <mailto:hverb...@gmail.com>

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-08 Thread Michael Stefaniuc
On 11/08/2012 02:50 PM, Nikolay Sivov wrote: > On 11/8/2012 15:41, Michael Stefaniuc wrote: >> On 11/08/2012 01:13 PM, Christian Costa wrote: >>> >>> 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> >>> >>> On 8 November 2012 00:22, Mi

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-08 Thread Michael Stefaniuc
On 11/08/2012 01:13 PM, Christian Costa wrote: > > > 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> > > On 8 November 2012 00:22, Michael Stefaniuc <mailto:mstef...@redhat.com>> wrote: > > But using just the capitalized letters from the name

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-07 Thread Michael Stefaniuc
On 11/07/2012 06:40 PM, Christian Costa wrote: > 2012/11/7 Michael Stefaniuc <mailto:mstef...@redhat.com>> > On 11/07/2012 02:50 PM, Christian Costa wrote: > > I didn't write this code and I don't like the current name either > but a > > m

LPJUNK for COM Interfaces (Was: Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.)

2012-11-07 Thread Michael Stefaniuc
On 11/06/2012 11:05 PM, Christian Costa wrote: >> Sure, separate patch to remove the duplicate name is fine. Just start >> with that as it makes the subsequent COM cleanup patch shorter as it >> cleans up the function header (whitespace and LPJUNK). > That's what I try to do altough I don't clearly

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-07 Thread Michael Stefaniuc
On 11/07/2012 02:50 PM, Christian Costa wrote: > > > 2012/11/7 Nikolay Sivov mailto:bungleh...@gmail.com>> > > On 11/7/2012 01:05, Christian Costa wrote: > > Le 06/11/2012 22:38, Michael Stefaniuc a écrit : > > On 11/06/201

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Michael Stefaniuc
On 11/06/2012 08:51 PM, Christian Costa wrote: > Le 06/11/2012 20:26, Nikolay Sivov a écrit : >> On 11/6/2012 20:47, Christian Costa wrote: >> What I also meant is these names are redundant, something like >> directmusicloader_AddRef() is enough, of course you could use mixed >> casing in names if

Re: [PATCH 5/6] dsound: rework ugly mixer logic

2012-10-24 Thread Michael Stefaniuc
Hello Jörg, On 10/24/2012 12:36 PM, joerg-cyril.hoe...@t-systems.com wrote: > I'm not happy with Wine's DSound+WinMM->mmdevapi. That may be a good > move for MS, but it's a bad move for Wine. Wine's audio drivers don't what would you do instead? Go back to the old way and have dsound and winmm d

Re: [PATCH 1/2] user32: Remove redundant sizeof check.

2012-10-24 Thread Michael Stefaniuc
On 10/24/2012 11:04 AM, Ken Thomases wrote: > On Oct 24, 2012, at 3:24 AM, Michael Stefaniuc wrote: > >> @@ -1330,9 +1330,6 @@ static HICON CURSORICON_LoadFromFile( LPCWSTR filename, >> } >> >> dir = (const CURSORICONFILEDIR*) bits; >> -if ( filesi

Re: d3dx9_36: Add tests for D3DXSHRotateZ

2012-10-22 Thread Michael Stefaniuc
On 10/22/2012 11:21 AM, Henri Verbeet wrote: > On 22 October 2012 09:06, Rico Schüller wrote: >> On 19.10.2012 13:15, Nozomi Kodama wrote: >>> >>> This patch adds tests for the patch sent by Rico for D3DXSHRotateZ. >>> >>> Moreover, I changed const in CONST in the declaration of the function in >>

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-10 Thread Michael Stefaniuc
On 10/10/2012 10:42 AM, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > David Laight wrote: > >> Better to code as: >>status = wmm->dwStatus; >>if (...) > Incidentally, that's what I did tonight in patch 20/25 try 2. > >> but even then I think the compiler is allowed to perform

Re: dsound: Don't bother shrinking the secondary buffer list.

2012-09-27 Thread Michael Stefaniuc
Hello Jörg, as always it depends. On 09/27/2012 09:37 AM, joerg-cyril.hoe...@t-systems.com wrote: >> +#include > > your patch is already committed, yet I believe that the least that dsound > needs is new asserts. > > Asserts in dsound have been a PITA in Wine for the last decade. > > It's ok

Re: ole32: Add CoGetDefaultContext stub

2012-09-19 Thread Michael Stefaniuc
Hallo Alistair, > --- > dlls/ole32/compobj.c |9 + > dlls/ole32/ole32.spec |1 + > 2 files changed, 10 insertions(+) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index 0055d15..2ea1dc9 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4279,

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).

2012-09-18 Thread Michael Stefaniuc
Hello Charles, On 09/18/2012 07:51 AM, Charles Davis wrote: > From: Charles Davis > > Contrary to what a novice C programmer might expect, when you declare an > array parameter to a function, what you actually get is a pointer. > Therefore, using sizeof() on the parameter will return the size of

Re: ddraw: Don't print a fixme for the flags in DirectDrawEnumerateExA; they don't change the outcome

2012-09-12 Thread Michael Stefaniuc
After talking to Henri on irc, please ignore this patch. There are patches out there to enumerate more devices than the primary one and then the flags do play a role. On 09/12/2012 11:08 PM, Michael Stefaniuc wrote: > --- > dlls/ddraw/main.c |5 + > 1 files changed, 1 inserti

Re: Moving pages to/from wiki

2012-08-30 Thread Michael Stefaniuc
On 08/30/2012 06:05 PM, Jeremy Newman wrote: > On 08/29/2012 09:32 PM, Kyle Auble wrote: >> just checked http://cvs.winehq.org and sure enough, there is still a >> very outdated CVS repository there, but I can't find a template or a PHP >> applet for it, just the same links you found (most in WWN i

Re: [12/18] windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts.

2012-07-24 Thread Michael Stefaniuc
Hello Dmitry, On 07/24/2012 08:12 AM, Dmitry Timoshkov wrote: > --- > dlls/windowscodecs/jpegformat.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c > index 53d7ec4..2c77d4f 1006

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

2012-07-24 Thread Michael Stefaniuc
Hello Dmitry, On 07/24/2012 08:01 AM, Dmitry Timoshkov wrote: > The patches in this series do not depend on each other, numeration is just > for a convenience. Patches do basically the same job for different objects, > so I decided to not invent a new subject for every separate kind of object. > -

Re: quartz/tests: Add COM aggregation test for NullRenderer. (2nd try)

2012-07-01 Thread Michael Stefaniuc
On 07/02/2012 01:32 AM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/Job

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.

2012-06-30 Thread Michael Stefaniuc
On 07/01/2012 12:12 AM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/Job

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
On 06/28/2012 01:50 PM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >>> truncating from double to float while gcc keeps silence for instance. >> I never looked at that but I assume the same holds true as above. > > The following thread has some

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
On 06/28/2012 01:00 PM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >> afair the fix is to disable the int truncation warnings in MSVC. For >> whatever reason they seem to enable those bogus warnings. > > The warnings are not bogus, the PSDK compiler also emits

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
Dmitry, afair the fix is to disable the int truncation warnings in MSVC. For whatever reason they seem to enable those bogus warnings. bye michael On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote: > --- > include/basetsd.h | 16 > 1 file changed, 8 insertions(+), 8 deleti

Re: [PATCH 4/4] qedit: Support COM aggregation for SampleGrabber.

2012-06-26 Thread Michael Stefaniuc
On 06/27/2012 12:02 AM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? No qedit.dll on those two boxes. > Full results can be found

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.

2012-06-26 Thread Michael Stefaniuc
Argh! Please skip this patch, it is incomplete and just skips the rest of the tests on Wine. I'll resubmit it when I implement COM aggregation for MediaDet. Patch 4/4 can be still applied as it doesn't depends on this. bye michael On 06/26/2012 11:53 PM, Michael Stefa

Re: Wine automated testing update

2012-06-21 Thread Michael Stefaniuc
Francois, On 06/21/2012 04:21 PM, Francois Gouget wrote: > --- Network trouble > > I'm having trouble getting the network to work fine in the QEmu VMs. > > Eventually I discovered that if I bridged to eth0 then it's just the > communication between the host and the VM that does not work. >

Re: 'Expensive' expressions in loop limits (was: Implementation of D3DXSHScale)

2012-06-19 Thread Michael Stefaniuc
On 06/19/2012 10:47 AM, Dan Kegel wrote: > Nozomi wrote: > +for (i = 0; i < order * order; i++) > > I might have written > int n = order * order; > for (i=0; i < n; i++) > to avoid repeating the multiplication every time around the loop, > even though multiplication is cheap nowadays

Re: MSVCP60.dll

2012-06-15 Thread Michael Stefaniuc
Hello John! On 06/15/2012 06:22 AM, John Emmas wrote: > Firstly, I'm not a Linux user. I'm a Windows programmer but I have a > passing knowledge of Linux (and several friends who are Linux > programmers). I write a Windows application which gets launched as a > child process by a popular Linux D

Re: msvcrt: Fix the name of the Portuguese locale alias.

2012-06-14 Thread Michael Stefaniuc
Bruno, On 06/14/2012 11:25 AM, Piotr Caban wrote: > On 06/13/12 23:51, Bruno Jesus wrote: >> Just a side note. Although I'm not sure I think portuguese is "ptg", >> brazilian portuguese is "ptb". So the correct may be: >> >>> +"portuguese", "ptg", >> >> A Portugal user would be able to check t

Re: wined3d: Avoid sizeof on structs with variable length arrays.

2012-06-13 Thread Michael Stefaniuc
On 06/13/2012 12:56 PM, Henri Verbeet wrote: > On 13 June 2012 10:41, Michael Stefaniuc wrote: >> -object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); >> +object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, >> FIELD_OFFSET(struc

Re: A copyright question to wine developpers

2012-06-11 Thread Michael Stefaniuc
Hello! On 06/11/2012 10:54 AM, Christophe-Marie Duquesne wrote: > To my understanding, wine is a reimplementation of the MS system. As > far as I understand, you take MS public headers and reimplement their > functions. If that is how it works, then how do you deal with > copyright? The MS headers

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

2012-06-05 Thread Michael Stefaniuc
On 06/05/2012 08:53 AM, Max TenEyck Woodbury wrote: > The issue is access from linux native code to the .net > framework. That should require a specific decision on the > part of the system administrator to make it available. It is > that package that I believe is called 'mono'. I have taken > s

Re: quartz: COM cleanup for Parser_OutputPin

2012-05-18 Thread Michael Stefaniuc
Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: > diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c > index 5027e90..bac1b24 100644 > --- a/dlls/quartz/avisplit.c > +++ b/dlls/quartz/avisplit.c > @@ -288,7 +288,7 @@ static HRESULT AVISplitter_next_request(AVISplitterImpl > *Thi

Re: mstask: Actually run a test and fix the expected behaviour.

2012-05-16 Thread Michael Stefaniuc
On 05/16/2012 11:32 AM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/Job

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
On 05/14/2012 11:47 AM, Eric Pouech wrote: >>> while (*ptr) >>> if (isspaceW(*ptr)) ptr++; else break; >> I do not mind terse code but that kinda overdoes it. I would put the >> "else" on a separate line. >> > trafic on wine-devel is rather low those days > wh

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 6805c75..14fd01b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( > > /* skip

Re: Patch 85420

2012-04-17 Thread Michael Stefaniuc
On 04/17/2012 09:46 PM, Marcus Meissner wrote: > On Tue, Apr 17, 2012 at 09:10:45PM +0200, Christian Costa wrote: >> Patch http://source.winehq.org/patches/data/85420 is marked as >> pending. I've taken a look but I still don't understand what's >> wrong. >> Is there anything I've missed ? > > I s

Re: ddraw/tests: Compare the correct surface pointers.

2012-04-15 Thread Michael Stefaniuc
On 04/15/2012 10:04 PM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. Yupp, test is incorrect. Stefan is looking at it. bye michael > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please doub

Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog

2012-04-15 Thread Michael Stefaniuc
Hello Detlef, On 04/15/2012 10:08 PM, Detlef Riekenberg wrote: > Used by apps to adjust the dialog position > or remove the cancel button before vista > > -- > By by ... Detlef > --- > dlls/browseui/progressdlg.c | 69 > ++- > 1 files changed, 68 insert

Re: [PATCH 1/3] amstream: Add CLSID_AMAudioData implementation. (try 2)

2012-04-03 Thread Michael Stefaniuc
Hello Christian, On 04/03/2012 07:53 AM, Christian Costa wrote: > +/*** IUnknown methods ***/ > +static HRESULT WINAPI IAudioDataImpl_QueryInterface(IAudioData *iface, > REFIID riid, void **ppv) > +{ > +AMAudioDataImpl *This = impl_from_IAudioData(iface); > + > +TRACE("(%p/%p)->(%s,%p)\n"

Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.

2012-04-02 Thread Michael Stefaniuc
ed. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 G

Re: [PATCH 3/3] d3drm: Implement CreateMesh method and stubbed IDirect3DRMMesh interface.

2012-03-29 Thread Michael Stefaniuc
Hello Christian, On 03/29/2012 11:57 PM, Christian Costa wrote: > +HRESULT Direct3DRMMesh_create(REFIID riid, IUnknown** ppObj) > +{ > +IDirect3DRMMeshImpl* object; > + > +TRACE("(%p)\n", ppObj); > + > +object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(IDirect3DRMMeshImp

Re: 'Pending' patches state

2012-03-28 Thread Michael Stefaniuc
Alexandre, On 03/28/2012 10:17 AM, Alexandre Julliard wrote: > Dmitry Timoshkov writes: > >> It's very confusing, and absolutely not clear what is required from the >> patch submitter, especially since *there is no any feedback on the patch*. >> 'Rejected' at least requies some sort of feedback,

Re: d3d10core: Standardize COM aggregation for d3d10_device.

2012-03-26 Thread Michael Stefaniuc
Now that Alexandre is back and Jacek didn't want to beat me to it it is time to finish my reply... On 03/22/2012 01:06 AM, Henri Verbeet wrote: > On 22 March 2012 00:50, Michael Stefaniuc wrote: >> -static HRESULT STDMETHODCALLTYPE d3d10_device_inner_QueryInterface(IUnknown >

Re: mscoree: Print the debug string and not the pointer to it.

2012-03-23 Thread Michael Stefaniuc
On 03/23/2012 07:50 PM, Lauri Kenttä wrote: On 2012-03-22 00:36, Michael Stefaniuc wrote: HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR pVersion, DWORD cchBuffer, DWORD *dwlength) { - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), cchBuffer, dwlength

Re: Updating GSoC proposal

2012-03-20 Thread Michael Stefaniuc
Hello Alex, On 03/20/2012 05:17 PM, HolyCause wrote: > On 3/20/12 07:22, Maarten Lankhorst wrote: >> Agreed, would like to add cmd parser to that list too. >> >> ~Maarten > Why is this? Does cmd sound like a bad project? > > FWIW I was planning on improving cmd as my GSoC project, and I've talked

Re: Networking+wine

2012-03-19 Thread Michael Stefaniuc
On 03/19/2012 01:40 PM, prateek papriwal wrote: > http://wiki.winehq.org/FAQ#head-f566a12c806a1eacaeefb7cb6419a513a773c571 as > mentioned wine does not provide sandboxing at all but there can be some > wine users would like to prevent Windows apps from accessing unix system > so there is need for

Re: use assert etc. in Wine dlls? What is better?

2012-03-13 Thread Michael Stefaniuc
Hello Joerg, On 03/13/2012 03:05 PM, joerg-cyril.hoe...@t-systems.com wrote: > Maarten's wine-pulse contains several instances of assert() > I've been thinking about adding a bit of protection against > inconcsistencies within mmdevapi code too. > > There are two variants that could be applicable

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Michael Stefaniuc
On 03/13/2012 12:42 AM, Christian Costa wrote: > Le 12/03/2012 20:32, Christian Costa a écrit : >> Le 12/03/2012 21:02, Nikolay Sivov a écrit : >>> On 3/12/2012 21:52, Christian Costa wrote: They are displayed as a single space in a text editor but visible with an hex editor. >>> I guess

Re: Got Application cross-compiled with msvc11 for ARM running

2012-03-08 Thread Michael Stefaniuc
On 03/08/2012 05:54 PM, André Hentschel wrote: > Am 08.03.2012 17:52, schrieb Michael Stefaniuc: >> On 03/08/2012 05:40 PM, André Hentschel wrote: >>> Hi, >>> I cross-compiled a simple Application with the preview of MSVC 11 to ARM. >>> After some minor change

Re: Got Application cross-compiled with msvc11 for ARM running

2012-03-08 Thread Michael Stefaniuc
On 03/08/2012 05:40 PM, André Hentschel wrote: > Hi, > I cross-compiled a simple Application with the preview of MSVC 11 to ARM. > After some minor changes to Wine i was able to run it on my Pandaboard using > the native msvcr110.dll. > One thing i noticed in the cross-compile environment is that

Re: winemenubuilder: Nothing useful is done on Mac OS X so just exit.

2012-03-01 Thread Michael Stefaniuc
Hello Francois, On 03/01/2012 03:07 AM, Francois Gouget wrote: > --- > > A real Mac OS X implementation would be nice but barring that it seems > better to do nothing than to create .desktop files and directories that > make no sense on Mac OS X. > > programs/winemenubuilder/winemenubuilder.c

Re: [PATCH 1/2] winmm: Avoid using SuspendThread, it can hang Wine.

2012-02-09 Thread Michael Stefaniuc
joerg-cyril.hoe...@t-systems.com wrote: > Michael Stefaniuc wrote: >> See that as an opportunity to clean up the whitespace issues in those 120 >> lines ;) > Hmm, what was the latest word on reformatting, if any? > Until now I've been careful to preserve the surrounding

Re: [PATCH 1/2] winmm: Avoid using SuspendThread, it can hang Wine.

2012-02-09 Thread Michael Stefaniuc
joerg-cyril.hoe...@t-systems.com wrote: > Alexandre Julliard wrote: >> Please stop abusing goto, write a proper loop instead. > No problem. The idea was to minimize the patch and show what really changed. > Adding a while loop will indent all 120 lines of code in between { }. See that as an opportu

Re: winecfg: Center main window on the screen.

2012-02-08 Thread Michael Stefaniuc
Vitaliy Margolen wrote: > Please don't! I want my window manager decide based on how I configured > it where to position new windows. And not every program open in the > middle of the screen just because it things it's the most important > thing on my screen. Uh? At the moment it always opens in th

Re: po: Remove untranslated English strings from the Romanian translation

2012-02-07 Thread Michael Stefaniuc
Francois Gouget wrote: > On Tue, 7 Feb 2012, Michael Stefaniuc wrote: > [...] >>> #: regedit.rc:282 >>> msgid "Hexadecimal" >>> -msgstr "Hexadecimal" >>> +msgstr "" >>> >>> #: regedit.rc:283 >

Re: po: Remove untranslated English strings from the Romanian translation

2012-02-07 Thread Michael Stefaniuc
Hello Frédéric, the patch is wrong. Frédéric Delanoy wrote: > --- > po/ro.po |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/po/ro.po b/po/ro.po > index a0912c2..c9375c4 100644 > --- a/po/ro.po > +++ b/po/ro.po > @@ -11803,11 +11803,11 @@ msgstr "Bază" > >

Re: comctl32: Remove an obsolete resource attribute.

2012-02-07 Thread Michael Stefaniuc
Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=16849 >

Re: [PATCH] winealsa: snd_card_get_name uses strdup (Valgrind).

2012-02-01 Thread Michael Stefaniuc
o noticed now that Jörg Höhle already deemed this strdup solution > ugly in his previous try. Luckily Michael Stefaniuc sent a finer patch > #83376. Still not good enough. But at least we forced Alexandre to fix it himself ;) bye michael

Re: snd_card_get_name uses strdup (Valgrind).

2012-02-01 Thread Michael Stefaniuc
c038a07f5da476a3a0e2ad870 Mon Sep 17 00:00:00 2001 From: Michael Stefaniuc Date: Wed, 1 Feb 2012 14:45:25 +0100 Subject: winealsa.drv: Clean up the sound card name retrieval code. Fixes a memleak found by Valgrind. --- dlls/winealsa.drv/mmdevdrv.c | 28 1 files cha

Re: mmdevapi: Correctly convert UINT32 to INT64

2012-01-30 Thread Michael Stefaniuc
Hello Joerg, On 01/30/2012 09:46 AM, joerg-cyril.hoe...@t-systems.com wrote: thank you very much for finding a bug in my code. I'll have to meditate signed/unsigned conversions for the next months. Perhaps it's my lack of familiarity with the MS-Windows API that had me not find a signed equiva

Re: comdlg32: Remove the font sample characters string.

2012-01-18 Thread Michael Stefaniuc
Frédéric Delanoy wrote: > 2012/1/18 Francois Gouget : >> On Wed, 18 Jan 2012, Frédéric Delanoy wrote: >> >>> On Wed, Jan 18, 2012 at 10:12, Francois Gouget wrote: The sample text does not depend on the dialog language but on the scripts supported by the font. As such translating it in t

Re: [PATCH 2/3] dsound: Merge IKsPropertySet into the secondary buffer object.

2012-01-17 Thread Michael Stefaniuc
On 01/17/2012 05:44 PM, Andrew Eikum wrote: > On Tue, Jan 17, 2012 at 01:53:10AM +0100, Michael Stefaniuc wrote: >> @@ -901,10 +895,11 @@ HRESULT IDirectSoundBufferImpl_Create( >> TRACE("Created buffer at %p\n", dsb); >> >> dsb->ref = 0;

Re: msvcp90: start rfind from given position

2012-01-13 Thread Michael Stefaniuc
On 01/13/2012 11:42 PM, Daniel Lehman wrote: >> >> === WVISTAADM (32 bit string) === >> Failure running script in VM: The specified guest user must be logged >> in interactively to perform this operation > > Do I need to resend in this case? I already ran it on TestBot before > submitting the pa

Re: [PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

2012-01-12 Thread Michael Stefaniuc
Hello Joerg, and addendum inline Michael Stefaniuc wrote: > joerg-cyril.hoe...@t-systems.com wrote: >> Michael Stefaniuc wrote: >>> static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer >> +if (pUnk) { >> +WARN(&quo

Re: [PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

2012-01-12 Thread Michael Stefaniuc
joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > Michael Stefaniuc wrote: >> static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer > +if (pUnk) { > +WARN("invalid parameter: pUnk != NULL\n"); > +/* *lplpDSCaptureBuffer

Re: [6/6] d3drm: Implement GetParent

2012-01-09 Thread Michael Stefaniuc
On 01/09/2012 09:42 PM, André Hentschel wrote: > Am 08.01.2012 20:02, schrieb Nikolay Sivov: >> On 1/8/2012 20:47, André Hentschel wrote: >>> --- >>> dlls/d3drm/frame.c | 11 +++ >>> dlls/d3drm/tests/d3drm.c | 16 >>> 2 files changed, 15 insertions(+), 12 dele

Re: Antw.: Remove obsolete and unused cmdlgtst.

2011-12-08 Thread Michael Stefaniuc
On 12/08/2011 01:16 PM, Dmitry Timoshkov wrote: "André Hentschel" wrote: Yes, i just recently modified it to test a bug, please don't remove it You can always get through git when needed it. That or we split it out into a separate git tree. But we can keep it if it is still useful. My only

Re: dinput: Stub IDirectInputJoyConfig8 interface.

2011-11-24 Thread Michael Stefaniuc
On 11/24/2011 08:46 PM, Vitaliy Margolen wrote: > On 11/24/2011 12:27 PM, Michael Stefaniuc wrote: >> Hello Vitaliy, >> >> On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: >>> --- >>> dlls/dinput/dinput_main.c|7 ++ >>> dlls/dinput/dinput

Re: dinput: Stub IDirectInputJoyConfig8 interface.

2011-11-24 Thread Michael Stefaniuc
Hello Vitaliy, On 11/24/2011 06:28 PM, Vitaliy Margolen wrote: > --- > dlls/dinput/dinput_main.c|7 ++ > dlls/dinput/dinput_private.h |2 + > dlls/dinput/joystick.c | 195 + > include/dinputd.h| 243 > +++

Re: qedit/tests: Add SampleGrabber COM aggregation test.

2011-11-21 Thread Michael Stefaniuc
Marvin wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=15558 >

  1   2   3   4   5   6   7   8   >