Is there anything wrong with my patches? The first one is marked as "Pending".
Am Dienstag, 26. März 2013, 18:46:23 schrieb Ludger Sprenker:
> Try3:
> - Removed last named value initialization
> - Do not check initial value of properties, if the
> precondition/initia
On Wed, 06 Feb 2013 13:51:32 +0100, Hans Leidekker wrote:
> +handle = CreateFileW(filename, GENERIC_READ, 0, NULL,
> OPEN_EXISTING, 0, NULL);
> +if (handle == INVALID_HANDLE_VALUE) return
> HRESULT_FROM_WIN32(GetLastError());
Hello Hans,
I think, you are hiding a fixme for the default col
Looks as if the testbot mixed an older patch-set with the new one. Is there a
way to prevent this?
Am Montag, 4. Februar 2013, 20:46:31 schrieb Marvin:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recogni
Am Sonntag, 20. Januar 2013, 12:53:56 schrieb Dmitry Timoshkov:
> Ludger Sprenker wrote:
> > +read_hr = IPropertyBag2_Read(pIEncoderOptions, 2, pb, NULL, v,
> > hr); +if (SUCCEEDED(hr))
>
> Looks like a typo.
Yes, it is typo. I am checking SUCCEEDED(read_hr
