Re: Try to implement my first stub function - AbortPrinter() - (try 4)

Hello Maarten, On Fri, Apr 15, 2011 at 12:05 PM, Maarten Lankhorst wrote: > Hello, > > Op 14-04-11 10:37, Loďc Maury schreef: > > Hello, >> >> From what was said from the last comments, I have modified the code and >> I have added the test patch. >> >> What do you think ? >> > You're doing all

Try to implement my first stub function - AbortPrinter() - (try 4)

Hello, From what was said from the last comments, I have modified the code and I have added the test patch. What do you think ? Thank you Loïc --- dlls/winspool.drv/tests/info.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/dlls/wins

Re: Try to implement my first stub function - AbortPrinter() - (try 3)

Hello Andrew, Hi Loïc, On 04/08/2011 07:54 AM, Loïc Maury wrote: I try always to implement my first stub function - AbortPrinter. It's looking good. Before you submit this, you should add some tests. Take a look in . Demonstrate that AbortPrinter() on Windows behaves the same way as

Try to implement my first stub function - AbortPrinter() - (try 3)

Hello, I try always to implement my first stub function - AbortPrinter. The last time, I send into Wine patch mailling list, but the patch was not correct. Now I think the format for the patch is correct (no whitespace, etc…). More over, I have modified the value if(!job->portname) by if(!po

winspool.drv : Implement AbortPrinter() function

--- dlls/winspool.drv/info.c | 95 +- 1 files changed, 93 insertions(+), 2 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index e4a464a..f16914a 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

Hello Mr.Eikum, On 09/02/11 16:30, Andrew Eikum wrote: On 02/09/2011 09:09 AM, Loïc Maury wrote: The indentation looks fine to me now. You've got an extra newline after the "if(printer->doc)" block and before the "else." The formatting on the TRACE statement is s

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

Hello Mr.Le Cam On Tue, Feb 8, 2011 at 10:07 PM, Nicolas Le Cam wrote: > > > 2011/2/8 Loïc Maury > > >> Hello Mr.Timoshkov, >> >> Thank you for your reply. >> >>> Loīc Maury wrote: >>> >>> >>> After the various commen

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

Hello Mr.Eikum, Thank you for your reply. On 08/02/11 18:13, Andrew Eikum wrote: On 02/08/2011 10:48 AM, Loïc Maury wrote: First of all set your tab size to 8, and ask your editor to not use tabs at all. I have modified my editor, but I don't know if it 's correct now ? The i

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

Hello Mr.Timoshkov, Thank you for your reply. Loïc Maury wrote: After the various comments, I have modified the patch. First of all set your tab size to 8, and ask your editor to not use tabs at all. I have modified my editor, but I don't know if it 's correct now ? +

Try to Implement my first Stub function - AbortPrinter() - (try 2).

Hello, After the various comments, I have modified the patch. What do you think ? Thank You Loïc --- dlls/winspool.drv/info.c | 97 +- 1 files changed, 95 insertions(+), 2 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/in

Re: Try to Implement my first Stub function - AbortPrinter().

Hello Mr.Sivov and Wine community, On 03/02/11 12:02, Nikolay Sivov wrote: On 2/3/2011 13:51, Loïc Maury wrote: Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document

Try to Implement my first Stub function - AbortPrinter().

Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document spool file for a printer, created by StartDocPrinter(), who indicate that a document was spooled. I saw that the API pr

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

On Tue, Jan 25, 2011 at 12:29 AM, Ken Thomases wrote: > Loïc, > > Your mailer seems to have mangled your patch with line wrapping. There are > some suggestions on Wine's SubmittingPatches wiki page for avoiding this. > Primarily, you should attach the patch to your email. If you already did >

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 4)

--- dlls/ntdll/cdrom.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..6a6d8e0 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd)

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

--- dlls/ntdll/cdrom.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..6a6d8e0 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -1121,6 +1121,10 @@ static NTSTATUS CDROM_Verify(int dev, int fd) r

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 2)

Hello, I have add comment in the code for the patch. Thank you Loïc --- dlls/ntdll/cdrom.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c index 59f85a0..d65850d 100644 --- a/dlls/ntdll/cdrom.c +++ b/dlls/ntdll/cdrom.c @@ -112

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

On Thu, Dec 30, 2010 at 11:20 AM, maury loïc wrote: > Hello, > > it's my first patch, and it implement the CDROM_Verify() > to work on Mac Os. > > merci > > Loïc > > --- > dlls/ntdll/cdrom.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/ntdll/cdrom.c b/dlls/