Hi Juan,
> The results you sent aren't very useful without more investigation.
Indeed.
I have started doing that on msi (which is the first place where I
spotted such a construct, but as the list shows, it's far from being the
only one), and sent a patch this morning.
However, I have neither the t
Fixed stupid mistake pointed by James Hawkins.
2007-12-09 Lionel Debroux <[EMAIL PROTECTED]>
* dlls/msi/database.c:
msi: fix memory leaks (found by Smatch).
>From 1a98023c007750708a14f5fa231c78649e36e44e Mon Sep 17 00:00:00 2001
From: Lionel Debroux <[EMAIL PROTECTED]>
Date: Sun,
Removed a level of indentation, following feedback of James Hawkins.
2007-12-09 Lionel Debroux <[EMAIL PROTECTED]>
* dlls/msi/dialog.c:
msi: fix missing alloc check.
>From 10299ab9e8ece57c6cd10bded0ecde2c4b06c548 Mon Sep 17 00:00:00 2001
From: Lionel Debroux <[EMAIL PROTECTED]>
D
"msi_dialog_list_box" in dlls/msi/dialog.c gets flagged by Michael
Stefaniuc's unfree-wine.pl script.
* As far as I can see, "info", allocated line 2203, is not used before
the return that leaks it (line 2214), neither in a direct nor an
indirect (macro) way. But maybe the "fail-fast" behaviour is
Hi,
Both AppDB and Bugzilla currently complain about too many connections to
the server:
(AppDB)
Warning: mysql_connect() [function.mysql-connect]: Too many connections
in /home/winehq/opt/appdb/include/query.php on line 82
Warning: mysql_select_db(): supplied argument is not a valid MySQL-Link
Lionel_Debroux wrote:
> EnumRfc1766_create leaks some heap memory in two error paths. Found in
> Michael Stefaniuc's list of Wine potential bugs detected by Smatch.
>
> 2007-09-24 Lionel Debroux <[EMAIL PROTECTED]>
>* dlls/mlang/mlang.c:
>mlang: fi
> > tools/fnt2fon is flagged in the janitorial page "IgnoredReturnValues".
> > This page is outdated, but its content is still valid for fnt2fon,
> > which ignores a number of return values.
> I don't think that's worth fixing, the warnings are essentially
> useless, it just makes the code uglier.
